November 2025 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master
by osmith 14 Nov '25

14 Nov '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email ) Change subject: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File nplab-m3ua-test/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/41430/comment/8fc37645_62c… : PS1, Line 12: cp runtest-junitxml.py /usr/local/bin/ not sure if only this one file is needed. but if that is the case, you could also directly do this: ``` wget https://gitea.osmocom.org/nplab/m3ua-testtool/raw/branch/osmocom/master/run… -O /usr/local/bin/runtest-junitxml.py ``` just an optimization, doesn't need to block this patch -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I78b2a27b355f11ba64476216bc7ef76713e8f61e Gerrit-Change-Number: 41430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 12:45:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in docker-playground[master]: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master
by pespin 14 Nov '25

14 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email ) Change subject: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master ...................................................................... nplab-m3ua-test: Parametrize git branch and change it to osmocom/master I just pushed a new "osmocom/master" branch to our fork pointing to laforge/python3. Change-Id: I78b2a27b355f11ba64476216bc7ef76713e8f61e --- M make/Makefile M nplab-m3ua-test/Dockerfile 2 files changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/30/41430/1 diff --git a/make/Makefile b/make/Makefile index b320ba9..1fba3d6 100644 --- a/make/Makefile +++ b/make/Makefile @@ -19,6 +19,7 @@ NAME?=$(shell basename $(CURDIR)) ASTERISK_BRANCH?=sysmocom/20.7.0 LIBOSMOCORE_BRANCH?=master +M3UA_TESTTOOL_BRANCH?=osmocom/master OSMO_TTCN3_BRANCH?=master OSMO_BB_BRANCH?=master OSMO_BSC_BRANCH?=master @@ -106,6 +107,7 @@ --build-arg OSMOCOM_REPO_TESTSUITE_MIRROR=$(OSMOCOM_REPO_TESTSUITE_MIRROR) \ --build-arg ASTERISK_BRANCH=$(ASTERISK_BRANCH) \ --build-arg LIBOSMOCORE_BRANCH=$(LIBOSMOCORE_BRANCH) \ + --build-arg M3UA_TESTTOOL_BRANCH=$(M3UA_TESTTOOL_BRANCH) \ --build-arg OSMO_BB_BRANCH=$(OSMO_BB_BRANCH) \ --build-arg OSMO_BSC_BRANCH=$(OSMO_BSC_BRANCH) \ --build-arg OSMO_BTS_BRANCH=$(OSMO_BTS_BRANCH) \ diff --git a/nplab-m3ua-test/Dockerfile b/nplab-m3ua-test/Dockerfile index e5cc00f..d0418b4 100644 --- a/nplab-m3ua-test/Dockerfile +++ b/nplab-m3ua-test/Dockerfile @@ -1,11 +1,14 @@ ARG USER=osmocom-build FROM $USER/sigtran-tests +ARG M3UA_TESTTOOL_BRANCH="osmocom/master" + RUN cd /tmp && git clone https://gitea.osmocom.org/nplab/m3ua-testtool -ADD https://gitea.osmocom.org/api/v1/repos/nplab/m3ua-testtool/git/refs/heads/l… /tmp/commit +ADD https://gitea.osmocom.org/api/v1/repos/nplab/m3ua-testtool/git/refs/heads/$… /tmp/commit RUN cd /tmp/m3ua-testtool && \ - git fetch && \ - git checkout -f laforge/python3 && \ + git fetch && git checkout $M3UA_TESTTOOL_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$M3UA_TESTTOOL_BRANCH || exit 1); \ + git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ cp runtest-junitxml.py /usr/local/bin/ COPY dotguile /root/.guile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I78b2a27b355f11ba64476216bc7ef76713e8f61e Gerrit-Change-Number: 41430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: nplab-m3ua-test: Configure Network Indicator as International
by pespin 14 Nov '25

14 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41431?usp=email ) Change subject: nplab-m3ua-test: Configure Network Indicator as International ...................................................................... nplab-m3ua-test: Configure Network Indicator as International That's what we are using at the osmo-stp configuration. Until now it didn't matter since libosmo-sigtran didn't validate NI matching configuration on received messages, but since 1af56bf8cf266dd708b623e75d6d175a58f3dd47 it does. Change-Id: Iae825ebc588524c7a3761c80392940733f3887a6 --- M nplab-m3ua-test/m3ua-param-testtool.scm 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/31/41431/1 diff --git a/nplab-m3ua-test/m3ua-param-testtool.scm b/nplab-m3ua-test/m3ua-param-testtool.scm index 10ca653..c919195 100644 --- a/nplab-m3ua-test/m3ua-param-testtool.scm +++ b/nplab-m3ua-test/m3ua-param-testtool.scm @@ -66,7 +66,7 @@ (define ss7-message (list 11 34 45 67 67 89)) (define ss7-si 0) -(define iut-ni 1) +(define iut-ni 0) (define iut-mp 0) (define iut-sls 0) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41431?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iae825ebc588524c7a3761c80392940733f3887a6 Gerrit-Change-Number: 41431 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: handover_decision: Check for connection prerequisites
by matanp 14 Nov '25

14 Nov '25

matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email ) Change subject: handover_decision: Check for connection prerequisites ...................................................................... handover_decision: Check for connection prerequisites Before this fix, a handover could be started while subscriber doesn't have a connection or while an initial assignment is stiil going. In some cases, it would cause the assert in handover_request to fail. Change-Id: I37314bdadd306ea96963d020b7c5372323e4640d --- M src/osmo-bsc/handover_decision.c M tests/handover/handover_test.c M tests/handover/handover_tests.ok A tests/handover/test_ho_1_rxqual_before_connection.ho_vty 4 files changed, 78 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/handover_decision.c b/src/osmo-bsc/handover_decision.c index 2fb466c..2cb12a3 100644 --- a/src/osmo-bsc/handover_decision.c +++ b/src/osmo-bsc/handover_decision.c @@ -234,6 +234,20 @@ if (mr->num_cell > 0 && mr->num_cell < 7) process_meas_neigh(mr); + /* check for ongoing handover/assignment */ + if (!mr->lchan->conn) { + LOGPHOLCHAN(mr->lchan, LOGL_ERROR, "Skipping, No subscriber connection???\n"); + return; + } + if (mr->lchan->conn->assignment.new_lchan) { + LOGPHOLCHAN(mr->lchan, LOGL_INFO, "Skipping, Initial Assignment is still ongoing\n"); + return; + } + if (mr->lchan->conn->ho.fi) { + LOGPHOLCHAN(mr->lchan, LOGL_INFO, "Skipping, Handover still ongoing\n"); + return; + } + av_rxlev = get_meas_rep_avg(mr->lchan, TDMA_MEAS_FIELD_RXLEV, TDMA_MEAS_DIR_DL, TDMA_MEAS_SET_AUTO, ho_get_hodec1_rxlev_avg_win(bts->ho)); diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index e4c7873..7740f0b 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -437,7 +437,7 @@ osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_A_CONN_CFM, NULL); } -struct gsm_lchan *lchan_act(struct gsm_lchan *lchan, int full_rate, const char *codec) +struct gsm_lchan *lchan_act_without_conn(struct gsm_lchan *lchan, int full_rate, const char *codec) { /* serious hack into osmo_fsm */ lchan->fi->state = LCHAN_ST_ESTABLISHED; @@ -455,7 +455,6 @@ LOG_LCHAN(lchan, LOGL_DEBUG, "activated by handover_test.c\n"); - create_conn(lchan); if (!strcasecmp(codec, "FR") && full_rate) lchan->current_ch_mode_rate.chan_mode = GSM48_CMODE_SPEECH_V1; else if (!strcasecmp(codec, "HR") && !full_rate) @@ -470,6 +469,15 @@ exit(EXIT_FAILURE); } + chan_counts_ts_update(lchan->ts); + + return lchan; +} + +struct gsm_lchan *lchan_act(struct gsm_lchan *lchan, int full_rate, const char *codec) +{ + lchan_act_without_conn(lchan, full_rate, codec); + create_conn(lchan); lchan->conn->codec_list = (struct gsm0808_speech_codec_list){ .codec = { { .fi=true, .type=GSM0808_SCT_FR1, }, @@ -480,9 +488,6 @@ }, .len = 5, }; - - chan_counts_ts_update(lchan->ts); - return lchan; } @@ -500,6 +505,20 @@ return lchan_act(lchan, full_rate, codec); } +struct gsm_lchan *create_lchan_without_conn(struct gsm_bts *bts, int full_rate, const char *codec) +{ + struct gsm_lchan *lchan; + + lchan = lchan_select_by_type(bts, (full_rate) ? GSM_LCHAN_TCH_F : GSM_LCHAN_TCH_H, + SELECT_FOR_HANDOVER, NULL); + if (!lchan) { + fprintf(stderr, "No resource for lchan\n"); + exit(EXIT_FAILURE); + } + + return lchan_act_without_conn(lchan, full_rate, codec); +} + static void lchan_release_ack(struct gsm_lchan *lchan) { if (!lchan->fi || lchan->fi->state != LCHAN_ST_WAIT_BEFORE_RF_RELEASE) @@ -975,6 +994,30 @@ return CMD_SUCCESS; } +DEFUN(create_empty_lchan, create_empty_lchan_cmd, + "create-empty-lchan bts <0-999> (TCH/F|TCH/H) (AMR|HR|EFR)", + "Create channel using the next free matching lchan on a given BTS, simulate not yet connected MS\n" + "BTS index to create on\n" + "lchan type to select\n" + "codec\n") +{ + const char *bts_nr_str = argv[0]; + const char *tch_type = argv[1]; + const char *codec = argv[2]; + struct gsm_lchan *lchan; + VTY_ECHO(); + fprintf(stderr, "- Creating mobile at BTS %s on " + "%s with %s codec\n", bts_nr_str, tch_type, codec); + lchan = create_lchan_without_conn(bts_by_num_str(bts_nr_str), + !strcmp(tch_type, "TCH/F"), codec); + if (!lchan) { + fprintf(stderr, "Failed to create lchan!\n"); + return CMD_WARNING; + } + fprintf(stderr, " * New channel is at %s\n", gsm_lchan_name(lchan)); + return CMD_SUCCESS; +} + struct meas_rep_data { int argc; const char **argv; @@ -1527,6 +1570,7 @@ install_element(CONFIG_NODE, &create_n_bts_cmd); install_element(CONFIG_NODE, &create_bts_cmd); install_element(CONFIG_NODE, &create_ms_cmd); + install_element(CONFIG_NODE, &create_empty_lchan_cmd); install_element(CONFIG_NODE, &meas_rep_cmd); install_element(CONFIG_NODE, &meas_rep_repeat_cmd); install_element(CONFIG_NODE, &meas_rep_repeat_bspower_cmd); diff --git a/tests/handover/handover_tests.ok b/tests/handover/handover_tests.ok index 0424181..d3bf030 100644 --- a/tests/handover/handover_tests.ok +++ b/tests/handover/handover_tests.ok @@ -33,6 +33,7 @@ pass test_dyn_ts_favor_half_used_tch_h_as_target.ho_vty pass test_dyn_ts_favor_moving_half_used_tch_h.ho_vty pass test_dyn_ts_favor_static_ts_as_target.ho_vty +pass test_ho_1_rxqual_before_connection.ho_vty pass test_ho_to_better_cell.ho_vty pass test_ho_to_better_cell_2.ho_vty pass test_hysteresis.ho_vty diff --git a/tests/handover/test_ho_1_rxqual_before_connection.ho_vty b/tests/handover/test_ho_1_rxqual_before_connection.ho_vty new file mode 100644 index 0000000..6dd2737 --- /dev/null +++ b/tests/handover/test_ho_1_rxqual_before_connection.ho_vty @@ -0,0 +1,14 @@ +# Do not try to handover (algorithm 1) if connection is not yet created. + +create-n-bts 1 + +network + bts 0 + handover algorithm 1 + neighbor-list mode manual-si5 + neighbor-list add arfcn 100 + si5 neighbor-list add arfcn 100 + +create-empty-lchan bts 0 TCH/F AMR +meas-rep repeat 3 lchan 0 0 1 0 rxlev 0 rxqual 6 ta 0 neighbors 30 +expect-ts-use trx 0 0 states * TCH/F - - - - - - -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37314bdadd306ea96963d020b7c5372323e4640d Gerrit-Change-Number: 41415 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: handover_decision: Check for connection prerequisites
by pespin 14 Nov '25

14 Nov '25

Attention is currently required from: jolly, laforge, matanp, neels, osmith. pespin has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email ) Change subject: handover_decision: Check for connection prerequisites ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37314bdadd306ea96963d020b7c5372323e4640d Gerrit-Change-Number: 41415 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Fri, 14 Nov 2025 10:53:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: mtp: Implement already defined osmo_mtp_prim_name()
by pespin 14 Nov '25

14 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41416?usp=email ) Change subject: mtp: Implement already defined osmo_mtp_prim_name() ...................................................................... mtp: Implement already defined osmo_mtp_prim_name() Implement osmo_mtp_prim_name(), which was defined in a header file but didn't exist so far. Create a mtp_sap.c file as a counterpart of mtp_sap.h header, and move there all primitive/SAP related code, to make it easier to spot where the inter-layer communication happens. This way we also have the same disposition as with sccp_sap/sccp_user. This is a preparation commit, follow-up commits will use the osmo_mtp_prim_name() API and clean up and move more APIs to mtp_sap.c. Change-Id: Ifa21c26ceaa079435a2d157f99813e06cfc12e71 --- M include/osmocom/sigtran/mtp_sap.h M src/Makefile.am A src/mtp_sap.c 3 files changed, 66 insertions(+), 1 deletion(-) Approvals: daniel: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/sigtran/mtp_sap.h b/include/osmocom/sigtran/mtp_sap.h index f13d6f1..590e0ab 100644 --- a/include/osmocom/sigtran/mtp_sap.h +++ b/include/osmocom/sigtran/mtp_sap.h @@ -30,6 +30,11 @@ OSMO_MTP_PRIM_RESUME, OSMO_MTP_PRIM_STATUS, }; +extern const struct value_string osmo_mtp_prim_type_names[]; +static inline const char *osmo_mtp_prim_type_name(enum osmo_mtp_prim_type val) +{ + return get_value_string(osmo_mtp_prim_type_names, val); +} /* ITU Q.704 14.2 Service information octet. See enum mtp_si_ni00 in mtp.h. */ #define MTP_SIO(service, net_ind) ((((net_ind) & 0x3) << 6) | ((service) & 0xF)) @@ -66,4 +71,4 @@ #define msgb_mtp_prim(msg) ((struct osmo_mtp_prim *)(msg)->l1h) -char *osmo_mtp_prim_name(struct osmo_prim_hdr *oph); +char *osmo_mtp_prim_name(const struct osmo_prim_hdr *oph); diff --git a/src/Makefile.am b/src/Makefile.am index 62c7e9d..de3d02e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -46,6 +46,7 @@ libosmo_sigtran_la_SOURCES = \ ipa.c \ m3ua.c \ + mtp_sap.c \ sccp2sua.c \ sccp_connection.c \ sccp_helpers.c \ diff --git a/src/mtp_sap.c b/src/mtp_sap.c new file mode 100644 index 0000000..b6b6eeb --- /dev/null +++ b/src/mtp_sap.c @@ -0,0 +1,59 @@ +/* (C) 2025 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <errno.h> + +#include <osmocom/core/linuxlist.h> +#include <osmocom/core/logging.h> +#include <osmocom/core/talloc.h> +#include <osmocom/core/prim.h> +#include <osmocom/sigtran/osmo_ss7.h> +#include <osmocom/sigtran/mtp_sap.h> + +const struct value_string osmo_mtp_prim_type_names[] = { + { OSMO_MTP_PRIM_TRANSFER, "MTP-TRANSFER" }, + { OSMO_MTP_PRIM_PAUSE, "MTP-PAUSE" }, + { OSMO_MTP_PRIM_RESUME, "MTP-RESUME" }, + { OSMO_MTP_PRIM_STATUS, "MTP-STATUS" }, + { 0, NULL } +}; + +static char prim_name_buf[128]; + +static int mtp_prim_hdr_name_buf(char *buf, size_t buflen, const struct osmo_prim_hdr *oph) +{ + struct osmo_strbuf sb = { .buf = buf, .len = buflen }; + + if (!oph) { + OSMO_STRBUF_PRINTF(sb, "null"); + return sb.chars_needed; + } + + OSMO_STRBUF_PRINTF(sb, "%s.%s", + osmo_mtp_prim_type_name(oph->primitive), + osmo_prim_operation_name(oph->operation)); + return sb.chars_needed; +} + +char *osmo_mtp_prim_name(const struct osmo_prim_hdr *oph) +{ + mtp_prim_hdr_name_buf(prim_name_buf, sizeof(prim_name_buf), oph); + return prim_name_buf; +} -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ifa21c26ceaa079435a2d157f99813e06cfc12e71 Gerrit-Change-Number: 41416 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: mtp: Improve mtp_sap/ss7_user APIs
by pespin 14 Nov '25

14 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email ) Change subject: mtp: Improve mtp_sap/ss7_user APIs ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22 Gerrit-Change-Number: 41411 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 10:46:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bsc[master]: handover_decision: Check for connection prerequisites
by fixeria 14 Nov '25

14 Nov '25

Attention is currently required from: jolly, laforge, matanp, neels, osmith. fixeria has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email ) Change subject: handover_decision: Check for connection prerequisites ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > May I merge it? Just wait for somebody giving CR+2, after that yes, feel free to merge. I would still want @nhofmeyr@sysmocom.de, our handover voodoo, to take a look. But unfortunately he's not very active in code review nowadays... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37314bdadd306ea96963d020b7c5372323e4640d Gerrit-Change-Number: 41415 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Fri, 14 Nov 2025 10:45:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: matanp <matan1008(a)gmail.com>

1 0

[M] Change in osmo-bsc[master]: handover_decision: Check for connection prerequisites
by matanp 14 Nov '25

14 Nov '25

Attention is currently required from: fixeria, jolly, laforge, neels, osmith. matanp has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email ) Change subject: handover_decision: Check for connection prerequisites ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Thank you! Marking as resolved. May I merge it? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37314bdadd306ea96963d020b7c5372323e4640d Gerrit-Change-Number: 41415 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 10:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: matanp <matan1008(a)gmail.com>

1 0

[M] Change in osmo-bsc[master]: handover_decision: Check for connection prerequisites
by fixeria 14 Nov '25

14 Nov '25

Attention is currently required from: jolly, laforge, matanp, neels, osmith. fixeria has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email ) Change subject: handover_decision: Check for connection prerequisites ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Added one, could you please review it? Thank you! Marking as resolved. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37314bdadd306ea96963d020b7c5372323e4640d Gerrit-Change-Number: 41415 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Fri, 14 Nov 2025 10:06:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: matanp <matan1008(a)gmail.com>

1 0

2025

2024

2023

2022

gerrit-log November 2025