osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41471?usp=email )
Change subject: GSUP: PDP Context ID: start at 1
......................................................................
GSUP: PDP Context ID: start at 1
In OsmoHLR, PDP Contexts can have IDs <1-10>. 0 is used internally to
mark a profile slot as disabled:
https://gitea.osmocom.org/cellular-infrastructure/osmo-hlr/src/commit/d4b45…
HLR Test TC_gsup_ul_subscriber_data in osmo-ttcn3-hacks also makes this
assumption:
https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/commit/85276b94c474bb6…
However the new GSUP implementation in PyHSS started its IDs at 0. I've
suggested to start it at 1 here:
https://github.com/nickvsnetworking/pyhss/pull/277/files/4b6da7447438778068…
Change-Id: I9c39002cb7f7dd81ae0f1f0f9d80df1aaf399f48
---
M common/chapters/gsup.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc
index 824ac90..33d35da 100644
--- a/common/chapters/gsup.adoc
+++ b/common/chapters/gsup.adoc
@@ -1276,7 +1276,7 @@
==== PDP Context ID
The PDP type context ID IE consists of a single integer byte wrapped in
-a TLV.
+a TLV. Values for PDP Context ID start at 1 (0 is reserved).
[packetdiag]
----
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41471?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9c39002cb7f7dd81ae0f1f0f9d80df1aaf399f48
Gerrit-Change-Number: 41471
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, neels, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email )
Change subject: Validate session remote CP F-SEID and use it to transmit session requests
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-upf/up_endpoint.c:
https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/6763ef27_20f08b66?usp… :
PS1, Line 189: return OSMO_PFCP_CAUSE_MANDATORY_IE_INCORRECT;
having no error on `local_addr->u.sa.sa_family == AF_INET6 && !f_seid->ip_addr.v6_present` seems unexpected, is this correct?
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31
Gerrit-Change-Number: 41482
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Nov 2025 12:43:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, fixeria, laforge, osmith.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by daniel, Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified-1 by Jenkins Builder
Change subject: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind
......................................................................
sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind
This is needed ie. in SCCPLite, where MGCP and CTRL messages need to be
sent/received over the same IPA multiplex TCP conn as the SCCPLite
(SCCP/IPA) one towards a given MSC.
Prior to this, osmo-bsc-sccplite was doing lots of manual
libosmo-sigtran APIs to obtain a route, an AS, and ASP, sending over an
ASP, etc. Similary, the rx_unknown callback was added to libosmo-sigtran
to hook into the ASP level. Tons of stuff which should really be done
properly inside libosmo-sigtran and provided over the existing public
SAPs, as this patch proposes.
With the proposed approach, an SCCPLite client (eg. osmo-bsc), besides
setting up an sccp_user to handle SCCP, also sets an ss7_user (MTP SAP)
with the newly introduced new Service Indicator (SI) MTP_SI_NI11_OSMO_IPA
to be able to manage the IPA[MGCP/CTRL] traffic towards a given MTP peer
(SCCPLite client, ie. MSC).
Related: SYS#6880
Depends: libosmo-sigtran.git Change-Id I9fedb26ccd3434fc7f272feb3c45cf4bdb80c7ae
Change-Id: I567ed206eab1add21836bfd937f3790d3d7a00d7
---
M TODO-RELEASE
M include/osmocom/bsc/bsc_msc_data.h
M include/osmocom/bsc/osmo_bsc_sigtran.h
M src/osmo-bsc/bsc_ctrl.c
M src/osmo-bsc/osmo_bsc_mgcp.c
M src/osmo-bsc/osmo_bsc_sigtran.c
6 files changed, 158 insertions(+), 116 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/00/41400/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I567ed206eab1add21836bfd937f3790d3d7a00d7
Gerrit-Change-Number: 41400
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email )
Change subject: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind
......................................................................
Patch Set 5:
(2 comments)
File src/osmo-bsc/osmo_bsc_sigtran.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/41400/comment/9294ebb5_1696ab98?usp… :
PS4, Line 466: }
> Maybe set `rc` to `-ENODEV` here? Currently you're returning `0`.
Done
File src/osmo-bsc/osmo_bsc_sigtran.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/41400/comment/4f858cd4_9acd5027?usp… :
PS5, Line 799: i
> Just to be sure: is this check no longer needed?
For sure it's not needed, because this is some layers below the SAPs used by osmo-bsc.
It's like checking you received a TCP packet from an ethernet interface.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I567ed206eab1add21836bfd937f3790d3d7a00d7
Gerrit-Change-Number: 41400
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Nov 2025 12:32:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41410?usp=email )
Change subject: mtp: Support MTP-TRANSFER.req/ind of raw IPA messages
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Reminder that this needs review, specially regarding architecture of the new osmocom specific SI to transmit IPA frames over IPA ASPs.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I9fedb26ccd3434fc7f272feb3c45cf4bdb80c7ae
Gerrit-Change-Number: 41410
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Nov 2025 12:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, laforge, lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email )
Change subject: bssgp: Fix non-uniqe rate_ctr ids
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'll merge this in a few hours if no further feedback is provided against it.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I782e11a75a8adc10292238fde46bf9c3975d970d
Gerrit-Change-Number: 41456
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 21 Nov 2025 12:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41472?usp=email )
Change subject: hlr/testenv_pyhss: run redis
......................................................................
hlr/testenv_pyhss: run redis
With https://github.com/nickvsnetworking/pyhss/pull/277 redis is used
for communication between the API and GSUP services, so add it here too
just like in hss/testenv_pyhss.cfg.
Change-Id: Ia4b5799836d9bff72831141e09fed5295130ee6b
---
A hlr/pyhss/redis.conf
M hlr/testenv_pyhss.cfg
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/hlr/pyhss/redis.conf b/hlr/pyhss/redis.conf
new file mode 100644
index 0000000..85ee91d
--- /dev/null
+++ b/hlr/pyhss/redis.conf
@@ -0,0 +1,2 @@
+bind 127.0.0.1
+protected-mode yes
diff --git a/hlr/testenv_pyhss.cfg b/hlr/testenv_pyhss.cfg
index 9e9d430..7a70872 100644
--- a/hlr/testenv_pyhss.cfg
+++ b/hlr/testenv_pyhss.cfg
@@ -4,6 +4,12 @@
config=HLR_Tests.cfg
copy=pyhss/HLR_Tests.cfg
+[redis]
+program=redis-server ./redis.conf
+make=no
+package=no
+copy=pyhss/redis.conf
+
[pyhss_gsup]
program=./run_in_venv.sh pyhss_gsup
setup=wait_for_port.py -p 4222
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41472?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia4b5799836d9bff72831141e09fed5295130ee6b
Gerrit-Change-Number: 41472
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>