January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: osmo-pcap-master: depend on libosmo-netif

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/39381?usp=email ) Change subject: osmo-pcap-master: depend on libosmo-netif ...................................................................... osmo-pcap-master: depend on libosmo-netif Fix the TTCN3-centos7-pcap-client-test jenkins job by adding the now missing dependency on libosmo-netif. Related: osmo-pcap I3562185f98685ea5a412273212e6dfbe55b360e2 Change-Id: Idc3cd011bc019c094d9b8b534dbd86056b76476c --- M osmo-pcap-master/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/osmo-pcap-master/Dockerfile b/osmo-pcap-master/Dockerfile index e595bc1..280b9a1 100644 --- a/osmo-pcap-master/Dockerfile +++ b/osmo-pcap-master/Dockerfile @@ -9,6 +9,7 @@ apt-get update && \ apt-get install -y --no-install-recommends \ libosmocore-dev \ + libosmo-netif-dev \ libzmq3-dev \ && \ apt-get clean \ @@ -20,6 +21,7 @@ "pkgconfig(libosmogb)" \ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ + "pkgconfig(libosmo-netif)" \ "pkgconfig(libzmq)" \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Idc3cd011bc019c094d9b8b534dbd86056b76476c Gerrit-Change-Number: 39381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in osmo-dev[master]: all.deps: osmo-pcap now depends on libosmo-netif

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/39380?usp=email ) Change subject: all.deps: osmo-pcap now depends on libosmo-netif ...................................................................... all.deps: osmo-pcap now depends on libosmo-netif Related: osmo-pcap I3562185f98685ea5a412273212e6dfbe55b360e2 Change-Id: If7980c7a3f486341a6e288bdb940347bf9ee2bfd --- M all.deps 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/all.deps b/all.deps index cf3811e..dac171e 100644 --- a/all.deps +++ b/all.deps @@ -23,7 +23,7 @@ osmo-pcu libosmocore libosmo-gprs asn1c libasn1c osmo-gbproxy libosmocore -osmo-pcap libosmocore +osmo-pcap libosmocore libosmo-netif osmo-bsc-nat libosmo-sigtran osmo-mgw libosmo-pfcp libosmocore libgtpnl -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: If7980c7a3f486341a6e288bdb940347bf9ee2bfd Gerrit-Change-Number: 39380 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in osmo-dev[master]: all.deps: osmo-pcap now depends on libosmo-netif

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39380?usp=email ) Change subject: all.deps: osmo-pcap now depends on libosmo-netif ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: If7980c7a3f486341a6e288bdb940347bf9ee2bfd Gerrit-Change-Number: 39380 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Jan 2025 09:14:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in docker-playground[master]: osmo-pcap-master: depend on libosmo-netif

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/39381?usp=email ) Change subject: osmo-pcap-master: depend on libosmo-netif ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Idc3cd011bc019c094d9b8b534dbd86056b76476c Gerrit-Change-Number: 39381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Jan 2025 09:14:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-dev[master]: all.deps: osmo-pcap now depends on libosmo-netif

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39380?usp=email ) Change subject: all.deps: osmo-pcap now depends on libosmo-netif ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I can't do +2 gerrit doesn't allow it. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: If7980c7a3f486341a6e288bdb940347bf9ee2bfd Gerrit-Change-Number: 39380 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Jan 2025 09:14:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-bts[master]: coverity: ensure lchan->si->* bitmask sizes

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-bts/+/39376?usp=email ) Change subject: coverity: ensure lchan->si->* bitmask sizes ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Agree with fixeria, this should be in a .c file because iirc it's declaring a static array on older versions of gcc, good catch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39376?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieb5d35e720e8d77336f6f912d039bab7f3b95c55 Gerrit-Change-Number: 39376 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Jan 2025 09:13:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-bts[master]: coverity: ensure lchan->si->* bitmask sizes

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-bts/+/39376?usp=email ) Change subject: coverity: ensure lchan->si->* bitmask sizes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmo-bts/lchan.h: https://gerrit.osmocom.org/c/osmo-bts/+/39376/comment/dfa049d9_46c0656e?usp… : PS1, Line 388: osmo_static_assert Not sure if it's a good idea to put static asserts to a header file, because this way we end up checking this assert in every `*.c` file that includes this header. Not a big deal given that it's checked at compile time, but still does not feel right. Maybe put it to `src/common/lchan.c` instead? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39376?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieb5d35e720e8d77336f6f912d039bab7f3b95c55 Gerrit-Change-Number: 39376 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Jan 2025 07:53:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-dev[master]: all.deps: osmo-pcap now depends on libosmo-netif

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39380?usp=email ) Change subject: all.deps: osmo-pcap now depends on libosmo-netif ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: If7980c7a3f486341a6e288bdb940347bf9ee2bfd Gerrit-Change-Number: 39380 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Jan 2025 07:53:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-ci[master]: ansible/setup-jenkins-slave: add mingw job deps

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39375?usp=email ) Change subject: ansible/setup-jenkins-slave: add mingw job deps ...................................................................... ansible/setup-jenkins-slave: add mingw job deps Support running the legacy job Osmocom-OBS_MinGW_weekly_publish by installing its dependencies directly in the LXC. This is a workaround until we modernize the job, see the related issue. Related: OS#6706 Change-Id: I49ccf5957dda8459a94c48fe5426b16edc7cb3e2 --- M ansible/setup-jenkins-slave.yml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ansible/setup-jenkins-slave.yml b/ansible/setup-jenkins-slave.yml index 2ed3bc7..f2e0bcd 100644 --- a/ansible/setup-jenkins-slave.yml +++ b/ansible/setup-jenkins-slave.yml @@ -11,11 +11,14 @@ - ca-certificates - etckeeper - ncdu + - osc # OS#6706 + - rpm2cpio # OS#6706 - rsync - screen - tmux - tree - vim + - zip # OS#6706 cache_valid_time: 3600 update_cache: yes roles: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I49ccf5957dda8459a94c48fe5426b16edc7cb3e2 Gerrit-Change-Number: 39375 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in docker-playground[master]: osmo-pcap-master: depend on libosmo-netif

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/39381?usp=email ) Change subject: osmo-pcap-master: depend on libosmo-netif ...................................................................... osmo-pcap-master: depend on libosmo-netif Fix the TTCN3-centos7-pcap-client-test jenkins job by adding the now missing dependency on libosmo-netif. Related: osmo-pcap I3562185f98685ea5a412273212e6dfbe55b360e2 Change-Id: Idc3cd011bc019c094d9b8b534dbd86056b76476c --- M osmo-pcap-master/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/39381/1 diff --git a/osmo-pcap-master/Dockerfile b/osmo-pcap-master/Dockerfile index e595bc1..280b9a1 100644 --- a/osmo-pcap-master/Dockerfile +++ b/osmo-pcap-master/Dockerfile @@ -9,6 +9,7 @@ apt-get update && \ apt-get install -y --no-install-recommends \ libosmocore-dev \ + libosmo-netif-dev \ libzmq3-dev \ && \ apt-get clean \ @@ -20,6 +21,7 @@ "pkgconfig(libosmogb)" \ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ + "pkgconfig(libosmo-netif)" \ "pkgconfig(libzmq)" \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Idc3cd011bc019c094d9b8b534dbd86056b76476c Gerrit-Change-Number: 39381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025