Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-bts/+/39376?usp=email ) Change subject: coverity: ensure lchan->si->* bitmask sizes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmo-bts/lchan.h: https://gerrit.osmocom.org/c/osmo-bts/+/39376/comment/dfa049d9_46c0656e?usp=... : PS1, Line 388: osmo_static_assert Not sure if it's a good idea to put static asserts to a header file, because this way we end up checking this assert in every `*.c` file that includes this header. Not a big deal given that it's checked at compile time, but still does not feel right. Maybe put it to `src/common/lchan.c` instead? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39376?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieb5d35e720e8d77336f6f912d039bab7f3b95c55 Gerrit-Change-Number: 39376 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Tue, 21 Jan 2025 07:53:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes