Attention is currently required from: neels.
Patch set 1:Code-Review +1
1 comment:
File include/osmo-bts/lchan.h:
Patch Set #1, Line 388: osmo_static_assert
Not sure if it's a good idea to put static asserts to a header file, because this way we end up checking this assert in every `*.c` file that includes this header. Not a big deal given that it's checked at compile time, but still does not feel right. Maybe put it to `src/common/lchan.c` instead?
To view, visit change 39376. To unsubscribe, or for help writing mail filters, visit settings.