January 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: osmo_io: Support writing to files with mode OSMO_IO_FD_MODE_READ_WRITE

by pespin

Attention is currently required from: daniel, jolly, laforge, osmith, pespin. Hello Jenkins Builder, daniel, jolly, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/39363?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: osmo_io: Support writing to files with mode OSMO_IO_FD_MODE_READ_WRITE ...................................................................... osmo_io: Support writing to files with mode OSMO_IO_FD_MODE_READ_WRITE Trying to use IORING_OP_SENDMSG on local files fails with "Socket operation on non-socket" errors. Use io_uring vectorized (readv, writev) since those are available since kernel v5.1, while non-vectorized ones (read, write) were only added later in kernel v5.10. Change-Id: Iefcbc7d09f429f4ecc611227cb5ef796f50c0539 --- M src/core/osmo_io_poll.c M src/core/osmo_io_uring.c M tests/osmo_io/osmo_io_test.c M tests/osmo_io/osmo_io_test.ok 4 files changed, 138 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/39363/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iefcbc7d09f429f4ecc611227cb5ef796f50c0539 Gerrit-Change-Number: 39363 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/docker-cleanup: add "docker system prune"

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39374?usp=email ) Change subject: scripts/docker-cleanup: add "docker system prune" ...................................................................... scripts/docker-cleanup: add "docker system prune" On build4 this freed up another 8.223GB when I just ran it: $ docker system prune WARNING! This will remove: - all stopped containers - all networks not used by at least one container - all dangling images - all dangling build cache Are you sure you want to continue? [y/N] Change-Id: I98aa5324eaf7cf319625d85bc80d431b89ee50a7 --- M scripts/docker-cleanup.sh 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/docker-cleanup.sh b/scripts/docker-cleanup.sh index 982ccea..f1ed6f2 100755 --- a/scripts/docker-cleanup.sh +++ b/scripts/docker-cleanup.sh @@ -44,3 +44,6 @@ # remove docker buildkit cache docker builder prune --all --filter "until=24h" -f + +# remove dangling images +docker system prune -f -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I98aa5324eaf7cf319625d85bc80d431b89ee50a7 Gerrit-Change-Number: 39374 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/docker-cleanup: add "docker system prune"

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39374?usp=email ) Change subject: scripts/docker-cleanup: add "docker system prune" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I98aa5324eaf7cf319625d85bc80d431b89ee50a7 Gerrit-Change-Number: 39374 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jan 2025 13:13:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs: manually trigger "git gc" for linux.git

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39373?usp=email ) Change subject: jobs: manually trigger "git gc" for linux.git ...................................................................... jobs: manually trigger "git gc" for linux.git We already use shallow clones for linux.git, and git runs a garbage collector automatically to ensure no longer needed artifacts are removed. But this did not work anymore on build4 for build-kernel-net-next, and it increased up to 8.4 GiB: 8,4 GiB /build-kernel-net-next After running "git gc" again: 3,3 GiB /build-kernel-net-next The reason was that "git gc" did not exit successfully once and wrote a log file, then refused to run again. Run "git gc --auto" explicitly in foreground to let abort in such a case, so it does not go unnoticed in the future. Change-Id: Ic81ae5a1edb0dbe119e06cc3b49ea69ef81b2a5f --- M jobs/build-kernels-testenv.yml M jobs/gerrit-verifications-dahdi.yml M jobs/master-builds-dahdi.yml 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/build-kernels-testenv.yml b/jobs/build-kernels-testenv.yml index d916093..47a9dd9 100644 --- a/jobs/build-kernels-testenv.yml +++ b/jobs/build-kernels-testenv.yml @@ -43,6 +43,9 @@ default: 'master' builders: - shell: |- + git config gc.autoDetach false + git gc --auto + IMAGE="osmocom-build/debian-bookworm-osmo-ttcn3-testenv" podman pull "registry.osmocom.org/$IMAGE" diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index 2cf9e95..de11b25 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -80,6 +80,9 @@ builders: - shell: | + git -C linux config gc.autoDetach false + git -C linux gc --auto + rm -rf dahdi-linux git init dahdi-linux cd dahdi-linux diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index 8f6d070..f72076f 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -56,6 +56,9 @@ builders: - shell: | + git -C linux config gc.autoDetach false + git -C linux gc --auto + rm -rf dahdi-linux git clone \ --depth=1 \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic81ae5a1edb0dbe119e06cc3b49ea69ef81b2a5f Gerrit-Change-Number: 39373 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/docker-cleanup: add "docker system prune"

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39374?usp=email ) Change subject: scripts/docker-cleanup: add "docker system prune" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I98aa5324eaf7cf319625d85bc80d431b89ee50a7 Gerrit-Change-Number: 39374 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jan 2025 13:07:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/docker-cleanup: add "docker system prune"

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39374?usp=email ) Change subject: scripts/docker-cleanup: add "docker system prune" ...................................................................... scripts/docker-cleanup: add "docker system prune" On build4 this freed up another 8.223GB when I just ran it: $ docker system prune WARNING! This will remove: - all stopped containers - all networks not used by at least one container - all dangling images - all dangling build cache Are you sure you want to continue? [y/N] Change-Id: I98aa5324eaf7cf319625d85bc80d431b89ee50a7 --- M scripts/docker-cleanup.sh 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/74/39374/1 diff --git a/scripts/docker-cleanup.sh b/scripts/docker-cleanup.sh index 982ccea..f1ed6f2 100755 --- a/scripts/docker-cleanup.sh +++ b/scripts/docker-cleanup.sh @@ -44,3 +44,6 @@ # remove docker buildkit cache docker builder prune --all --filter "until=24h" -f + +# remove dangling images +docker system prune -f -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I98aa5324eaf7cf319625d85bc80d431b89ee50a7 Gerrit-Change-Number: 39374 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs: manually trigger "git gc" for linux.git

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39373?usp=email ) Change subject: jobs: manually trigger "git gc" for linux.git ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic81ae5a1edb0dbe119e06cc3b49ea69ef81b2a5f Gerrit-Change-Number: 39373 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jan 2025 13:04:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[S] Change in libosmo-netif[master]: add osmo_stream_cli_set_name_f()

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email ) Change subject: add osmo_stream_cli_set_name_f() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > ack -> separate patch Is it already in Gerrit? CR+2 if so. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jan 2025 13:03:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: hnbgw_rx_hnb_register_req(): guard against asn.1 parsing errors

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39362?usp=email ) Change subject: hnbgw_rx_hnb_register_req(): guard against asn.1 parsing errors ...................................................................... Patch Set 2: (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/39362/comment/afb5d012_843b807f?u… : PS2, Line 494: make sure that actual values ended up in the asn1 octet strings Are these fields marked as `MANDATORY` in the respective ASN.1 definition? If so, then I would expect `hnbap_decode_hnbregisterrequesties()` to fail (return negative) if at least one `MANDATORY` field/IE is somehow missing. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I555f11cadc23ea231821bd48f7cd62953b022e9e Gerrit-Change-Number: 39362 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jan 2025 13:00:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months

1
0
0 0

[XS] Change in osmo-trx[master]: comma_delimited_to_vector() optimization CID#465430

by fixeria

Attention is currently required from: Hoernchen, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email ) Change subject: comma_delimited_to_vector() optimization CID#465430 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/39359/comment/15761bdc_2aa9559d?usp… : PS1, Line 9: (I The patch looks good. Moving is "cheaper" than copying. See https://lemire.me/blog/2023/01/30/move-or-copy-your-strings-possible-perfor…, for instance. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I30e57c6a9df39552bc4f8c18d27bc421f5c60f49 Gerrit-Change-Number: 39359 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jan 2025 12:57:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025