lists.osmocom.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
List overview
Download
gerrit-log
May 2024
----- 2025 -----
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
gerrit-log@lists.osmocom.org
1 participants
1530 discussions
Start a n
N
ew thread
[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Server field
by pespin
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email
) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: SIP_Templates: Allow passing Server field ...................................................................... SIP_Templates: Allow passing Server field This field is used by an IMS core. Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc --- M library/SIP_Templates.ttcn 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index e6e8b53..65f9d22 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -218,6 +218,16 @@ optionsTags := optionsTags } +// [20.35 RFC2616 14.38] +template (value) Server ts_Server(template (value) ServerVal_List serverBody := {}) := { + fieldName := SERVER_E, + serverBody := serverBody +} +template (present) Server tr_Server(template (present) ServerVal_List serverBody := ?) := { + fieldName := SERVER_E, + serverBody := serverBody +} + // [20.37] template (value) Supported ts_Supported(template (value) OptionTag_List optionsTags := {}) := { fieldName := SUPPORTED_E, @@ -536,6 +546,7 @@ template (omit) Require require := omit, template (omit) Security_client security_client := omit, template (omit) Security_server security_server := omit, + template (omit) Server server := omit, template (omit) Supported supported := omit, template (omit) UserAgent userAgent := ts_UserAgent({ "osmo-ttcn3-hacks/0.23" }), template (omit) WwwAuthenticate wwwAuthenticate := omit @@ -562,6 +573,7 @@ require := require, security_client := security_client, security_server := security_server, + server := server, supported := supported, toField := { fieldName := TO_E, @@ -587,6 +599,7 @@ template Require require := *, template Security_client security_client := *, template Security_server security_server := *, + template Server server := *, template Supported supported := *, template UserAgent userAgent := *, template WwwAuthenticate wwwAuthenticate := * @@ -612,6 +625,7 @@ require := require, security_client := security_client, security_server := security_server, + server := server, supported := supported, toField := { fieldName := TO_E, -- To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc Gerrit-Change-Number: 36797 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 year, 1 month
1
0
0
0
[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Always set Content-Length
by pespin
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email
) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: SIP_Templates: Always set Content-Length ...................................................................... SIP_Templates: Always set Content-Length According to RFC3261 7.4.2, 7.5, 20.14 Content-Length SHOULD be set over any transport, and MUST be set over TCP. Hence, make sure we set it in all cases. This allows Asterisk being able to decode SIP messages sent to it over a TCP connection, since it uses the Content-Length field to look up for message boundaries over the TCP stream. Change-Id: I26e444fe466b4742d74ef5a6e371ce8488a5afcf --- M library/SIP_Templates.ttcn 1 file changed, 68 insertions(+), 17 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 65f9d22..e2be94b 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -201,6 +201,16 @@ } +// [20.14] +template (value) ContentLength ts_ContentLength(template (value) integer len := 0) := { + fieldName := CONTENT_LENGTH_E, + len := len +} +template (present) ContentLength tr_ContentLength(template (present) integer len := ?) := { + fieldName := CONTENT_LENGTH_E, + len := len +} + // [20.19] template (value) Expires ts_Expires(template (value) DeltaSec deltaSec := "7200") := { fieldName := EXPIRES_E, @@ -419,6 +429,16 @@ return ct; } +private function f_ContentLength(template (omit) charstring body) +return template (value) ContentLength { + /* rfc3261 20.14: "If no body is present in a message, then the + * Content-Length header field value MUST be set to zero." */ + if (istemplatekind(body, "omit")) { + return ts_ContentLength(0); + } + return ts_ContentLength(lengthof(body)); +} + template (value) ContentType ts_CT_SDP := { fieldName := CONTENT_TYPE_E, mediaType := "application/sdp" @@ -539,6 +559,7 @@ template (value) charstring method, template (value) integer seq_nr, template (value) Via via, + template (omit) ContentLength content_length := ts_ContentLength(0), template (omit) ContentType content_type := omit, template (omit)Authorization authorization := omit, template (omit) Allow allow := ts_Allow(c_SIP_defaultMethods), @@ -558,6 +579,7 @@ callid := call_id }, contact := contact, + contentLength := content_length, contentType := content_type, cSeq := { fieldName := CSEQ_E, @@ -592,8 +614,9 @@ template Contact contact, template (present) Via via := tr_Via_from(?), template charstring method, - template ContentType content_type := *, template integer seq_nr := ?, + template ContentLength content_length := *, + template ContentType content_type := *, template Allow allow := *, template Expires expires := *, template Require require := *, @@ -610,6 +633,7 @@ callid := call_id }, contact := contact, + contentLength := content_length, contentType := content_type, cSeq := { fieldName := CSEQ_E, @@ -655,7 +679,8 @@ requestLine := ts_SIP_ReqLine(REGISTER_E, sip_url_host_port), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, contact, "REGISTER", seq_nr, via, - f_ContentTypeOrOmit(ts_CT_SDP, body), + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body), authorization := authorization, expires := expires, require := require, @@ -679,7 +704,7 @@ template charstring body := *) := { requestLine := tr_SIP_ReqLine(REGISTER_E, sip_url_host_port), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, contact, - via, "REGISTER", *, seq_nr, + via, "REGISTER", seq_nr, expires := expires, require := require, security_client := security_client, @@ -700,7 +725,8 @@ msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, contact, "INVITE", seq_nr, via, - f_ContentTypeOrOmit(ts_CT_SDP, body)), + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -714,7 +740,7 @@ template charstring body) := { requestLine := tr_SIP_ReqLine(INVITE_E, uri), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, ?, - via, "INVITE", *, seq_nr), + via, "INVITE", seq_nr), messageBody := body, payload := omit } @@ -728,7 +754,9 @@ template (omit) charstring body) := { requestLine := ts_SIP_ReqLine(BYE_E, to_addr.addr.nameAddr.addrSpec), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, "BYE", seq_nr, - via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -743,7 +771,7 @@ template charstring body := *) := { requestLine := tr_SIP_ReqLine(BYE_E, uri), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, omit, - via, "BYE", *, seq_nr), + via, "BYE", seq_nr), messageBody := body, payload := omit } @@ -761,7 +789,8 @@ ts_Contact_SipAddr(from_addr), "ACK", seq_nr, via, - f_ContentTypeOrOmit(ts_CT_SDP, body)), + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -776,7 +805,7 @@ requestLine := tr_SIP_ReqLine(ACK_E, uri), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, *, via, - "ACK", *, seq_nr), + "ACK", seq_nr), messageBody := body, payload := omit } @@ -792,7 +821,7 @@ requestLine := tr_SIP_ReqLine(CANCEL_E, uri), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, *, via, - "CANCEL", *, seq_nr), + "CANCEL", seq_nr), messageBody := body, payload := omit } @@ -809,7 +838,9 @@ template (omit) charstring body := omit) := { statusLine := ts_SIP_StatusLine(status_code, reason), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, method, seq_nr, - via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -825,7 +856,9 @@ template (omit) charstring body := omit) := { statusLine := ts_SIP_StatusLine(100, "Trying"), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, method, seq_nr, - via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -841,7 +874,9 @@ template (omit) charstring body := omit) := { statusLine := ts_SIP_StatusLine(180, "Ringing"), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, method, seq_nr, - via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -860,7 +895,7 @@ statusLine := tr_SIP_StatusLine(status_code, reason), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, contact, via, - method, *, seq_nr), + method, seq_nr), messageBody := body, payload := omit } @@ -882,7 +917,7 @@ statusLine := tr_SIP_StatusLine(status_code, reason), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, contact, via, - method, *, seq_nr, + method, seq_nr, wwwAuthenticate := wwwAuthenticate), messageBody := body, payload := omit @@ -903,7 +938,7 @@ statusLine := tr_SIP_StatusLine(status_code, reason), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, omit, via, - method, *, seq_nr), + method, seq_nr), messageBody := body, payload := omit } @@ -923,7 +958,7 @@ statusLine := tr_SIP_StatusLine(status_code, reason), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, *, via, - method, *, seq_nr), + method, seq_nr), messageBody := body, payload := omit } -- To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26e444fe466b4742d74ef5a6e371ce8488a5afcf Gerrit-Change-Number: 36814 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 year, 1 month
1
0
0
0
[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing UserAgent field
by pespin
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36796?usp=email
) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: SIP_Templates: Allow passing UserAgent field ...................................................................... SIP_Templates: Allow passing UserAgent field This way it can be set to omit, since this field is not set by an IMS core. Change-Id: Ib1e3e66b8fe46ad2626b07193dfcaa594f26352e --- M library/SIP_Templates.ttcn 1 file changed, 26 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index e1c9ec6..e6e8b53 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -228,6 +228,16 @@ optionsTags := optionsTags } +// [20.41 RFC2616 14.43] +template (value) UserAgent ts_UserAgent(template (value) ServerVal_List userAgentBody := {}) := { + fieldName := USER_AGENT_E, + userAgentBody := userAgentBody +} +template (present) UserAgent tr_UserAgent(template (present) ServerVal_List userAgentBody := ?) := { + fieldName := USER_AGENT_E, + userAgentBody := userAgentBody +} + template (value) SipAddr ts_SipAddr(template (value) HostPort host_port, template (omit) UserInfo user_info := omit, @@ -527,6 +537,7 @@ template (omit) Security_client security_client := omit, template (omit) Security_server security_server := omit, template (omit) Supported supported := omit, + template (omit) UserAgent userAgent := ts_UserAgent({ "osmo-ttcn3-hacks/0.23" }), template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { allow := allow, @@ -557,12 +568,7 @@ addressField := to_addr.addr, toParams := to_addr.params }, - userAgent := { - fieldName := USER_AGENT_E, - userAgentBody := { - "osmo-ttcn3-hacks/0.23" - } - }, + userAgent := userAgent, via := via, wwwAuthenticate := wwwAuthenticate } @@ -582,6 +588,7 @@ template Security_client security_client := *, template Security_server security_server := *, template Supported supported := *, + template UserAgent userAgent := *, template WwwAuthenticate wwwAuthenticate := * ) modifies t_SIP_msgHeader_any := { allow := allow, @@ -611,7 +618,7 @@ addressField := to_addr.addr, toParams := to_addr.params }, - userAgent := *, + userAgent := userAgent, via := via, wwwAuthenticate := wwwAuthenticate } -- To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36796?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib1e3e66b8fe46ad2626b07193dfcaa594f26352e Gerrit-Change-Number: 36796 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 year, 1 month
1
0
0
0
[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing 'Allow' field
by pespin
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email
) Change subject: SIP_Templates: Allow passing 'Allow' field ...................................................................... SIP_Templates: Allow passing 'Allow' field Change-Id: I10dd36d8c0ef8dbcbb58016c9684d877a0455b03 --- M library/SIP_Templates.ttcn 1 file changed, 23 insertions(+), 22 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index d35813e..1eeccb9 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -66,6 +66,16 @@ } } +// [20.5] +template (present) Allow tr_Allow(template Method_List methods := *) := { + fieldName := ALLOW_E, + methods := methods +} +template (value) Allow ts_Allow(template (omit) Method_List methods := omit) := { + fieldName := ALLOW_E, + methods := methods +} + template (value) Credentials ts_Credentials_DigestResponse(template (value) CommaParam_List digestResponse) := { digestResponse := digestResponse } @@ -511,7 +521,7 @@ template (value) Via via, template (omit) ContentType content_type := omit, template (omit)Authorization authorization := omit, - template (value) Method_List allow_methods := c_SIP_defaultMethods, + template (omit) Allow allow := ts_Allow(c_SIP_defaultMethods), template (omit) Expires expires := omit, template (omit) Require require := omit, template (omit) Security_client security_client := omit, @@ -519,10 +529,7 @@ template (omit) Supported supported := omit, template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { - allow := { - fieldName := ALLOW_E, - methods := allow_methods - }, + allow := allow, authorization := authorization, callId := { fieldName := CALL_ID_E, @@ -560,21 +567,6 @@ wwwAuthenticate := wwwAuthenticate } -function tr_AllowMethods(template Method_List allow_methods) return template Allow { - if (istemplatekind(allow_methods, "omit")) { - return omit; - } else if (istemplatekind(allow_methods, "*")) { - return *; - } else if (istemplatekind(allow_methods, "?")) { - return ?; - } - var template (present) Allow ret := { - fieldName := ALLOW_E, - methods := allow_methods - } - return ret -} - template (present) MessageHeader tr_SIP_msgh_std(template CallidString call_id, template SipAddr from_addr, @@ -584,7 +576,7 @@ template charstring method, template ContentType content_type := *, template integer seq_nr := ?, - template Method_List allow_methods := *, + template Allow allow := *, template Expires expires := *, template Require require := *, template Security_client security_client := *, @@ -592,7 +584,7 @@ template Supported supported := *, template WwwAuthenticate wwwAuthenticate := * ) modifies t_SIP_msgHeader_any := { - allow := tr_AllowMethods(allow_methods), + allow := allow, callId := { fieldName := CALL_ID_E, callid := call_id -- To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10dd36d8c0ef8dbcbb58016c9684d877a0455b03 Gerrit-Change-Number: 36793 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 year, 1 month
1
0
0
0
[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Add ts_SIP_Response_Trying
by pespin
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36794?usp=email
) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: SIP_Templates: Add ts_SIP_Response_Trying ...................................................................... SIP_Templates: Add ts_SIP_Response_Trying Similar to ts_SIP_Response_Ringing. We also have the counterpart tr_* for both Trying and Ringing. This is needed in a follow-up patch. Change-Id: I05d8be9ce8860c610c509670392e14f1096fdddb --- M library/SIP_Templates.ttcn 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 1eeccb9..e1c9ec6 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -792,7 +792,22 @@ messageBody := body, payload := omit } - +/* 100 Trying */ +template (value) PDU_SIP_Response +ts_SIP_Response_Trying( + template (value) CallidString call_id, + template (value) SipAddr from_addr, + template (value) SipAddr to_addr, + Via via, + integer seq_nr, + charstring method := "INVITE", + template (omit) charstring body := omit) := { + statusLine := ts_SIP_StatusLine(100, "Trying"), + msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, method, seq_nr, + via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + messageBody := body, + payload := omit +} /* 180 Ringing */ template (value) PDU_SIP_Response ts_SIP_Response_Ringing( -- To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36794?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I05d8be9ce8860c610c509670392e14f1096fdddb Gerrit-Change-Number: 36794 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 year, 1 month
1
0
0
0
[S] Change in libosmocore[master]: core: fix LOGPIO(): add missing space after 'iofd(...)'
by fixeria
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/36829?usp=email
) Change subject: core: fix LOGPIO(): add missing space after 'iofd(...)' ...................................................................... core: fix LOGPIO(): add missing space after 'iofd(...)' Without a space the logging looks like this: iofd(virt-rnc0-0)Cancelling read Change-Id: I84d305ce6cfc69352a64cb9e42229f88f09893c0 --- M include/osmocom/core/osmo_io.h 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h index 6f4dfa8..fa1f9c3 100644 --- a/include/osmocom/core/osmo_io.h +++ b/include/osmocom/core/osmo_io.h @@ -55,7 +55,7 @@ * \param[in] args arguments to the format string */ #define LOGPIO(iofd, level, fmt, args...) \ - LOGP(DLIO, level, "iofd(%s)" fmt, iofd->name, ## args) + LOGP(DLIO, level, "iofd(%s) " fmt, iofd->name, ## args) struct osmo_io_fd; -- To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/36829?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84d305ce6cfc69352a64cb9e42229f88f09893c0 Gerrit-Change-Number: 36829 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 year, 1 month
1
0
0
0
[S] Change in osmo-mgw[master]: doc: example configs: fix deprecation warnings
by pespin
Attention is currently required from: osmith. pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/36785?usp=email
) Change subject: doc: example configs: fix deprecation warnings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/36785?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I62a4fd119de48039c3c450d5323d8f9b7de8120f Gerrit-Change-Number: 36785 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:56:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 year, 1 month
1
0
0
0
[M] Change in osmo-trx[master]: contrib/systemd: run as osmocom user
by pespin
Attention is currently required from: msuraev, osmith. pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/30131?usp=email
) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/30131?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3e0e5978992dac0a0c76c6f0e859576aa3eb72eb Gerrit-Change-Number: 30131 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:56:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 year, 1 month
1
0
0
0
[S] Change in libosmocore[master]: core: fix LOGPIO(): add missing space after 'iofd(...)'
by pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/36829?usp=email
) Change subject: core: fix LOGPIO(): add missing space after 'iofd(...)' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/36829?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84d305ce6cfc69352a64cb9e42229f88f09893c0 Gerrit-Change-Number: 36829 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:55:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 year, 1 month
1
0
0
0
[L] Change in osmo-ttcn3-hacks[master]: asterisk: Initial IMS registration
by osmith
Attention is currently required from: jolly, laforge, pespin. osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759?usp=email
) Change subject: asterisk: Initial IMS registration ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb3b19ccd82cad25948106b2c72aa424d7f79cd8 Gerrit-Change-Number: 36759 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:54:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 year, 1 month
1
0
0
0
← Newer
1
...
71
72
73
74
75
76
77
...
153
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
Results per page:
10
25
50
100
200