May 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmo-iuh[master]: ranap_common: Implement support for missing procedures

by tnt

Attention is currently required from: daniel, neels, pespin, tnt. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email ) Change subject: ranap_common: Implement support for missing procedures ...................................................................... Patch Set 2: Code-Review+1 (4 comments) Patchset: PS1: > I don't really understand what this is about TBH, just doing a quick read of the code for "unexpecte […] Done Patchset: PS2: Looks logical to me. File src/ranap_common_ran.c: https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/69e96e8c_19bd53ac PS1, Line 196: static int ran_ranap_rx_unsuccessful_msg_co(RANAP_SuccessfulOutcome_t *imsg, ranap_message *message) > ran_ranap_rx_unsuccessful_msg_co takes a RANAP_SuccessfulOutcome_t as param and not some RANAP_Unsuc […] Done https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/300fccd4_2fecee0b PS1, Line 247: rc = ran_ranap_rx_unsuccessful_msg_co(&pdu->choice.successfulOutcome, message); > Not pdu->choice. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6 Gerrit-Change-Number: 36787 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 15:15:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-remsim[master]: user_ifdhandler: Fix segfault on startup

by Joey Berkovitz

Attention is currently required from: laforge. Joey Berkovitz has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email ) Change subject: user_ifdhandler: Fix segfault on startup ...................................................................... Patch Set 3: (1 comment) File src/client/user_ifdhandler.c: https://gerrit.osmocom.org/c/osmo-remsim/+/36835/comment/08424d65_bc6da8f0 PS1, Line 374: ensure_osmo_ctx > ensure_osmo_ctx() basically calls osmo_ctx_init() which is called just two lines below. […] confirmed - moving osmo_select_init below the successful osmo_ctx_init fixes the issue -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923 Gerrit-Change-Number: 36835 Gerrit-PatchSet: 3 Gerrit-Owner: Joey Berkovitz <joey(a)berkovitz.us> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 May 2024 15:13:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-remsim[master]: user_ifdhandler: Fix segfault on startup

by Joey Berkovitz

Attention is currently required from: Joey Berkovitz. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: user_ifdhandler: Fix segfault on startup ...................................................................... user_ifdhandler: Fix segfault on startup Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923 --- M src/client/user_ifdhandler.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/35/36835/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923 Gerrit-Change-Number: 36835 Gerrit-PatchSet: 3 Gerrit-Owner: Joey Berkovitz <joey(a)berkovitz.us> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Joey Berkovitz <joey(a)berkovitz.us> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[L] Change in osmo-iuh[master]: ranap_common: Implement support for missing procedures

by laforge

Attention is currently required from: daniel, neels, pespin, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email ) Change subject: ranap_common: Implement support for missing procedures ...................................................................... Patch Set 2: (3 comments) Patchset: PS1: > I don't really understand what this is about TBH, just doing a quick read of the code for "unexpecte […] thanks, it was a simple copy+paste mistake. File src/ranap_common_ran.c: https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/9f6380a6_a8ca699e PS1, Line 196: static int ran_ranap_rx_unsuccessful_msg_co(RANAP_SuccessfulOutcome_t *imsg, ranap_message *message) > ran_ranap_rx_unsuccessful_msg_co takes a RANAP_SuccessfulOutcome_t as param and not some RANAP_Unsuc […] Done https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/80125f9e_14235a47 PS1, Line 247: rc = ran_ranap_rx_unsuccessful_msg_co(&pdu->choice.successfulOutcome, message); > Not pdu->choice. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6 Gerrit-Change-Number: 36787 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 15:10:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[L] Change in osmo-iuh[master]: ranap_common: Implement support for missing procedures

by laforge

Attention is currently required from: daniel, laforge, neels, pespin. Hello Jenkins Builder, daniel, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: ranap_common: Implement support for missing procedures ...................................................................... ranap_common: Implement support for missing procedures Both the RAN and the CN side of ranap_common were missing support for decoding requests and/or responses for a number of RANAP procedures. This patch adds all of them a of TS 25.413 Release 12 except those related to MBMS or SRVCC. Related: SYS#6885 Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6 --- M src/ranap_common_cn.c M src/ranap_common_ran.c 2 files changed, 284 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/87/36787/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6 Gerrit-Change-Number: 36787 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[L] Change in osmo-iuh[master]: ranap_common: Implement support for missing procedures

by tnt

Attention is currently required from: daniel, laforge, neels. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email ) Change subject: ranap_common: Implement support for missing procedures ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: I don't really understand what this is about TBH, just doing a quick read of the code for "unexpected" things and this seemed a bit weird to me, feel free to ignore if this is how it should be ... File src/ranap_common_ran.c: https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/050f4484_42ff9ca5 PS1, Line 196: static int ran_ranap_rx_unsuccessful_msg_co(RANAP_SuccessfulOutcome_t *imsg, ranap_message *message) ran_ranap_rx_unsuccessful_msg_co takes a RANAP_SuccessfulOutcome_t as param and not some RANAP_UnsuccessfulOutcome_t https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/38ab628c_4d80622b PS1, Line 247: rc = ran_ranap_rx_unsuccessful_msg_co(&pdu->choice.successfulOutcome, message); Not pdu->choice.unsuccessfulOutcome ? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6 Gerrit-Change-Number: 36787 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 15:04:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates...

by laforge

Attention is currently required from: dexter, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email ) Change subject: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates.ttcn ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a5ededbd958c87537f84155092b6a6cd715865a Gerrit-Change-Number: 36832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 14:56:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates...

by laforge

Attention is currently required from: dexter, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email ) Change subject: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates.ttcn ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: adding @pmaier@sysmocom.de as I know he also has been using PIPEasp recently in his eIM/IPAd tests -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a5ededbd958c87537f84155092b6a6cd715865a Gerrit-Change-Number: 36832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 14:55:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-remsim[master]: user_ifdhandler: Fix segfault on startup

by laforge

Attention is currently required from: Joey Berkovitz. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email ) Change subject: user_ifdhandler: Fix segfault on startup ...................................................................... Patch Set 1: (1 comment) File src/client/user_ifdhandler.c: https://gerrit.osmocom.org/c/osmo-remsim/+/36835/comment/c6824d93_206eb05a PS1, Line 374: ensure_osmo_ctx ensure_osmo_ctx() basically calls osmo_ctx_init() which is called just two lines below. Might it be that the existing code just needs to be re-ordered? Did you try the following: * not adding ensure_osmo_ctx * moving osmo_select_init below osmo_ctx_init Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923 Gerrit-Change-Number: 36835 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Berkovitz <joey(a)berkovitz.us> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Joey Berkovitz <joey(a)berkovitz.us> Gerrit-Comment-Date: Wed, 15 May 2024 14:55:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-remsim[master]: user_ifdhandler: Fix segfault on startup

by Joey Berkovitz

Joey Berkovitz has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email ) Change subject: user_ifdhandler: Fix segfault on startup ...................................................................... user_ifdhandler: Fix segfault on startup Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923 --- M src/client/user_ifdhandler.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/35/36835/1 diff --git a/src/client/user_ifdhandler.c b/src/client/user_ifdhandler.c index c6a9392..b9ddfb9 100644 --- a/src/client/user_ifdhandler.c +++ b/src/client/user_ifdhandler.c @@ -371,6 +371,7 @@ if (gethostname(hostname, sizeof(hostname)) < 0) OSMO_STRLCPY_ARRAY(hostname, "unknown"); + ensure_osmo_ctx(); osmo_select_init(); rc = osmo_ctx_init("client"); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923 Gerrit-Change-Number: 36835 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Berkovitz <joey(a)berkovitz.us> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024