May 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: gtp/gtp.c: move gtp_create_context_resp down

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36789?usp=email ) Change subject: gtp/gtp.c: move gtp_create_context_resp down ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I34efe7592013a8423f4f280758272d81f24b65fa Gerrit-Change-Number: 36789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 May 2024 08:35:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp/gsn_internal.h: new file

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36067?usp=email ) Change subject: gtp/gsn_internal.h: new file ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I999462e39411fc4ec7e50bd0212e870006fbc4f1 Gerrit-Change-Number: 36067 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 16 May 2024 08:35:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email ) Change subject: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates.ttcn ...................................................................... remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates.ttcn This way code can be used and extended for other testsuites. Change-Id: I4a5ededbd958c87537f84155092b6a6cd715865a --- A library/PIPEasp_Templates.ttcn M remsim/RemsimClient_Tests.ttcn M remsim/gen_links.sh 3 files changed, 41 insertions(+), 22 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/library/PIPEasp_Templates.ttcn b/library/PIPEasp_Templates.ttcn new file mode 100644 index 0000000..af4e434 --- /dev/null +++ b/library/PIPEasp_Templates.ttcn @@ -0,0 +1,27 @@ +module PIPEasp_Templates { + +import from PIPEasp_PortType all; +import from PIPEasp_Types all; + +template (value) ASP_PExecuteBackground ts_ExecBg(charstring cmd) := { + command := cmd +} + +template (present) ASP_PStdout tr_Stdout(template (present) charstring line) := { + stdout := line +} + +template (present) ASP_PStderr tr_Stderr(template (present) charstring line) := { + stderr := line +} + +template (value) ASP_PStdin ts_Stdin(template (value) charstring line) := { + stdin :=line +} + +/* Ignore output from stderr: */ +altstep as_ignore_stderr(PIPEasp_PT pt) { +[] pt.receive(tr_Stderr(?)) { repeat; } +} + +} diff --git a/remsim/RemsimClient_Tests.ttcn b/remsim/RemsimClient_Tests.ttcn index 219573c..d747eef 100644 --- a/remsim/RemsimClient_Tests.ttcn +++ b/remsim/RemsimClient_Tests.ttcn @@ -20,6 +20,7 @@ /* the PIPEasp port allows us to interact with osmo-remsim-client-shell via stdin/stdout */ import from PIPEasp_PortType all; import from PIPEasp_Types all; +import from PIPEasp_Templates all; import from RSPRO all; import from RSPRO_Types all; @@ -196,34 +197,13 @@ * Tests interacting with local remsim-bankd-client via PIPE port ***********************************************************************/ -template (value) ASP_PExecuteBackground ts_ExecBg(charstring cmd) := { - command := cmd -} - -template (present) ASP_PStdout tr_Stdout(template (present) charstring line) := { - stdout := line -} - -template (present) ASP_PStderr tr_Stderr(template (present) charstring line) := { - stderr := line -} - -template (value) ASP_PStdin ts_Stdin(template (value) charstring line) := { - stdin :=line -} - -/* osmo-remsim-client logs to stderr, so we need to ignore that log output */ -private altstep as_ignore_stderr() runs on client_test_CT { -[] PIPE.receive(tr_Stderr(?)) { repeat; } -} - /* start a local osmo-remsim-client as sub-process and attach it to PIPE port */ private function f_init_client_pipe(ClientSlot cs) runs on client_test_CT { var charstring cmdline := mp_client_shell_cmd & " -i 127.0.0.1"; map(self:PIPE, system:PIPE); PIPE.send(ts_ExecBg(cmdline & " -c " & int2str(cs.clientId) & " -n " & int2str(cs.slotNr))); - activate(as_ignore_stderr()); + activate(as_ignore_stderr(PIPE)); } /* pretty-print an octet string as series of ASCII encoded hex bytes with spaces */ diff --git a/remsim/gen_links.sh b/remsim/gen_links.sh index b25375b..615c550 100755 --- a/remsim/gen_links.sh +++ b/remsim/gen_links.sh @@ -39,6 +39,7 @@ DIR=../library FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_VTY_Functions.ttcn Osmocom_Types.ttcn " +FILES+="PIPEasp_Templates.ttcn " FILES+="IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp IPA_CodecPort.ttcn " #RSL_Types.ttcn RSL_Emulation.ttcn " FILES+="Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn " FILES+="Native_Functions.ttcn Native_FunctionDefs.cc " -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a5ededbd958c87537f84155092b6a6cd715865a Gerrit-Change-Number: 36832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in docker-playground[master]: ttcn3-asterisk: Configure asterisk for initial SIP register on IMS side

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36831?usp=email ) Change subject: ttcn3-asterisk: Configure asterisk for initial SIP register on IMS side ...................................................................... ttcn3-asterisk: Configure asterisk for initial SIP register on IMS side This set of pjsip config requires work done by jolly in our fork of asterisk adding IMS features. Depends: osmo-ttcn3-hacks.git Change-Id Idb3b19ccd82cad25948106b2c72aa424d7f79cd8 Change-Id: I66d128192146ad600203ea2a41b8bf019311d603 --- M ttcn3-asterisk-ims-ue-test/Asterisk_Tests.cfg M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 2 files changed, 67 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/ttcn3-asterisk-ims-ue-test/Asterisk_Tests.cfg b/ttcn3-asterisk-ims-ue-test/Asterisk_Tests.cfg index c9011d5..40bc86e 100644 --- a/ttcn3-asterisk-ims-ue-test/Asterisk_Tests.cfg +++ b/ttcn3-asterisk-ims-ue-test/Asterisk_Tests.cfg @@ -20,6 +20,9 @@ Asterisk_Tests.mp_remote_sip_host := "172.18.11.10" Asterisk_Tests.mp_local_sip_port := 5061 Asterisk_Tests.mp_remote_sip_port := 5094 +Asterisk_Tests.mp_local_ims_host := "172.18.11.103" +Asterisk_Tests.mp_local_ims_port := 5060 +Asterisk_Tests.mp_ims_imsi := "238010000090828" Asterisk_Tests.mp_ami_remote_host := "172.18.11.10" [MAIN_CONTROLLER] diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index 57cab41..07f68ba 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -1,4 +1,6 @@ - +;############ +; LOCAL SIP +;############ [transport-udp] type=transport protocol=udp @@ -68,3 +70,51 @@ [0504](aor_phone_template) +;############ +; VoLTE +;############ +[transport-tcp] +type=transport +protocol=tcp +bind=172.18.11.10:5060 +ims_port_c=5555 +ims_port_s=5060 + +[volte_ims] +type=registration +transport=transport-tcp +outbound_auth=volte_ims +server_uri=sip:172.18.11.103 +client_uri=sip:238010000090828@172.18.11.103 +retry_interval=30 +fatal_retry_interval=30 +expiration=600000 +ims_aka=yes +contact_user=volte_ims +endpoint=volte_ims +line=yes + +[volte_ims] +type=endpoint +context=volte_ims +disallow=all +allow=vevs +outbound_auth=volte_ims +aors=volte_ims +rewrite_contact=yes +from_user=238010000090828 +from_domain=172.18.11.103 + +[volte_ims] +type=auth +auth_type=ims_aka +username=238010000090828(a)172.18.11.103 +usim_ami=no +usim_opc=775A1F887D2AD66F9719C2C79F847B50 +usim_k=D534E07854B75E475C667A856AA31F9C +usim_sqn=000000011000 + +[volte_ims] +type=aor +contact=sip:238010000090828@172.18.11.103 +max_contacts=1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I66d128192146ad600203ea2a41b8bf019311d603 Gerrit-Change-Number: 36831 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email ) Change subject: ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker ...................................................................... ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker In docker, the /data dir is mapped to $VOL_BASE_DIR, which is created by docker-playground.git jenkins-common.sh, hence as the user running jenkins.sh in the host system. As a result, when the dir is mapped to /data, inside the container it will have the UID:GID of the outter user, not the one inside docker. Before this patch, if a ttcn3 container was started in jenkins.sh with --cap-add=NET_ADMIN, then osmo-ttcn3-hacks.git/ttcn3-tcpdump-start.sh would select dumpcap instead of tcpdump, to attempt to record a pcap file to /data/$testcase.pcap. Due to some unknown way of dropping privileges done by dumpcap though, it was unable to open the /data/$testcase.pcap due to /data being owned to another user (tcpdump doesn't have this problem). This patch fixes the above scenario by making sure /data is chowned to the user running stuff inside docker. This is already kinda expected since there's a fix_perms() script in jenkins-common.sh reverting files created during the test so that they can be accessible by outter user once everything is finished. Change-Id: I1229a91cdbb1aa73fd94f1bf7e26f34086f06b25 --- M common/ttcn3-docker-run.sh 1 file changed, 32 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/common/ttcn3-docker-run.sh b/common/ttcn3-docker-run.sh index c8c871e..60339c4 100755 --- a/common/ttcn3-docker-run.sh +++ b/common/ttcn3-docker-run.sh @@ -31,6 +31,9 @@ done fi +# Make sure /data is owned to the user running inside docker. +# jenkins-commons.sh fix_perms() will fix back the permissions once done. +chown -R "$(id -u):$(id -g)" /data cd /data # Use TEST_NAME to only run one test instead of all. Set it like this: -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1229a91cdbb1aa73fd94f1bf7e26f34086f06b25 Gerrit-Change-Number: 36836 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: libgtp: move includes to osmocom/include/gtp

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36066?usp=email ) Change subject: libgtp: move includes to osmocom/include/gtp ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File gtp/Makefile.am: https://gerrit.osmocom.org/c/osmo-ggsn/+/36066/comment/3a2418e7_12fa6628 PS2, Line 22: lookupa.h I assume you keep this one intentionally? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: If7e01c61168819bf7120667344e40c857da5490b Gerrit-Change-Number: 36066 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 16 May 2024 08:32:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email ) Change subject: ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1229a91cdbb1aa73fd94f1bf7e26f34086f06b25 Gerrit-Change-Number: 36836 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 16 May 2024 08:30:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: contrib/systemd: run as osmocom user

by osmith

Attention is currently required from: lynxis lazus, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29412?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 16: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29412?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I915f2fc12d0bd905d24636aacb2760a6b72a55e3 Gerrit-Change-Number: 29412 Gerrit-PatchSet: 16 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 16 May 2024 08:20:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: doc: set state-dir to /var/lib/osmocom/osmo-ggsn

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36841?usp=email ) Change subject: doc: set state-dir to /var/lib/osmocom/osmo-ggsn ...................................................................... doc: set state-dir to /var/lib/osmocom/osmo-ggsn Prepare to run osmo-ggsn as user with the systemd service. As with other Osmocom service files, we will set StateDirectory= and WorkingDirectory= options. This results in osmo-ggsn only being able to write to /var/lib/osmocom, therefore let's change the state-dir from /tmp to /var/lib/osmocom/osmo-ggsn to avoid: gsn.c:411 fopen(path=/tmp/gsn_restart, mode=w) failed: Error = Permission denied Having the state in /var/lib/osmocom also makes more sense, because then it doesn't get deleted on reboot. Change-Id: I5b51529b4f8bd2462e54f58a1ce2e2d7c76ff46a --- M doc/examples/osmo-ggsn-kernel-gtp.cfg M doc/examples/osmo-ggsn.cfg M doc/manuals/chapters/configuration.adoc 3 files changed, 24 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/41/36841/1 diff --git a/doc/examples/osmo-ggsn-kernel-gtp.cfg b/doc/examples/osmo-ggsn-kernel-gtp.cfg index 28eb207..12da4f8 100644 --- a/doc/examples/osmo-ggsn-kernel-gtp.cfg +++ b/doc/examples/osmo-ggsn-kernel-gtp.cfg @@ -36,7 +36,7 @@ no login ! ggsn ggsn0 - gtp state-dir /tmp + gtp state-dir /var/lib/osmocom/osmo-ggsn gtp bind-ip 127.0.0.2 apn internet gtpu-mode kernel-gtp diff --git a/doc/examples/osmo-ggsn.cfg b/doc/examples/osmo-ggsn.cfg index 02523e9..76fa257 100644 --- a/doc/examples/osmo-ggsn.cfg +++ b/doc/examples/osmo-ggsn.cfg @@ -36,7 +36,7 @@ no login ! ggsn ggsn0 - gtp state-dir /tmp + gtp state-dir /var/lib/osmocom/osmo-ggsn gtp bind-ip 127.0.0.2 apn internet gtpu-mode tun diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index 5314d10..f0889d3 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -16,7 +16,7 @@ .Example: Single GGSN configuration section ---- ggsn ggsn0 - gtp state-dir /tmp + gtp state-dir /var/lib/osmocom/osmo-ggsn gtp bind-ip 127.0.0.6 apn internet gtpu-mode tun @@ -58,7 +58,7 @@ for every GGSN instance: ---- -OsmoGGSN(config-ggsn)# gtp state-dir /var/lib/ggsn/ggsn0 <1> +OsmoGGSN(config-ggsn)# gtp state-dir /var/lib/osmocom/osmo-ggsn <1> OsmoGGSN(config-ggsn)# gtp bind-ip 127.0.0.6 <2> ---- <1> Store the GSN restart state in the specified directory -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5b51529b4f8bd2462e54f58a1ce2e2d7c76ff46a Gerrit-Change-Number: 36841 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: ggsn/ggsn_vty: create state-dir

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36840?usp=email ) Change subject: ggsn/ggsn_vty: create state-dir ...................................................................... ggsn/ggsn_vty: create state-dir Prepare to change the state-dir in the default config in a follow-up commit. Create the directory if it does not exist. Change-Id: I91349fb284336a9de6af41475f1b824eb0e021b0 --- M ggsn/ggsn_vty.c 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/40/36840/1 diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c index 7414b6a..7d4202b 100644 --- a/ggsn/ggsn_vty.c +++ b/ggsn/ggsn_vty.c @@ -22,6 +22,8 @@ #include <inttypes.h> #include <netinet/in.h> #include <arpa/inet.h> +#include <sys/stat.h> +#include <sys/types.h> #include <osmocom/core/talloc.h> #include <osmocom/core/utils.h> @@ -223,6 +225,11 @@ { struct ggsn_ctx *ggsn = (struct ggsn_ctx *) vty->index; + if (mkdir(argv[0], 0755) == -1 && errno != EEXIST) { + vty_out(vty, "%% Failed to create state-dir: %s%s", argv[0], VTY_NEWLINE); + return CMD_WARNING; + } + osmo_talloc_replace_string(ggsn, &ggsn->cfg.state_dir, argv[0]); return CMD_SUCCESS; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I91349fb284336a9de6af41475f1b824eb0e021b0 Gerrit-Change-Number: 36840 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024