May 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ggsn[master]: gtp: move conversion functions up

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email ) Change subject: gtp: move conversion functions up ...................................................................... gtp: move conversion functions up Move the conversion functions above the first user, so we can make in_addr2gsna static in a follow-up commit and remove the extra declaration. Change-Id: I51e6a7c1161320fc54b0e8197ae57e4327976eb1 --- M gtp/gtp.c 1 file changed, 47 insertions(+), 34 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/gtp/gtp.c b/gtp/gtp.c index 9442b33..482875d 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -823,6 +823,40 @@ } /* *********************************************************** + * Conversion functions + *************************************************************/ + +/* *********************************************************** + * IP address conversion functions + * There exist several types of address representations: + * - eua: End User Address. (29.060, 7.7.27, message type 128) + * Used for signalling address to mobile station. Supports IPv4 + * IPv6 x.25 etc. etc. + * - gsna: GSN Address. (29.060, 7.7.32, message type 133): IP address + * of GSN. If length is 4 it is IPv4. If length is 16 it is IPv6. + * - in_addr: IPv4 address struct. + * - sockaddr_in: Socket API representation of IP address and + * port number. + *************************************************************/ + +int gsna2in_addr(struct in_addr *dst, struct ul16_t *gsna) +{ + memset(dst, 0, sizeof(struct in_addr)); + if (gsna->l != 4) + return EOF; /* Return if not IPv4 */ + memcpy(dst, gsna->v, gsna->l); + return 0; +} + +int in_addr2gsna(struct ul16_t *gsna, struct in_addr *src) +{ + memset(gsna, 0, sizeof(struct ul16_t)); + gsna->l = 4; + memcpy(gsna->v, src, gsna->l); + return 0; +} + +/* *********************************************************** * Session management messages * Messages: create, update and delete PDP context * @@ -3052,40 +3086,6 @@ return 0; } -/* *********************************************************** - * Conversion functions - *************************************************************/ - -/* *********************************************************** - * IP address conversion functions - * There exist several types of address representations: - * - eua: End User Address. (29.060, 7.7.27, message type 128) - * Used for signalling address to mobile station. Supports IPv4 - * IPv6 x.25 etc. etc. - * - gsna: GSN Address. (29.060, 7.7.32, message type 133): IP address - * of GSN. If length is 4 it is IPv4. If length is 16 it is IPv6. - * - in_addr: IPv4 address struct. - * - sockaddr_in: Socket API representation of IP address and - * port number. - *************************************************************/ - -int gsna2in_addr(struct in_addr *dst, struct ul16_t *gsna) -{ - memset(dst, 0, sizeof(struct in_addr)); - if (gsna->l != 4) - return EOF; /* Return if not IPv4 */ - memcpy(dst, gsna->v, gsna->l); - return 0; -} - -int in_addr2gsna(struct ul16_t *gsna, struct in_addr *src) -{ - memset(gsna, 0, sizeof(struct ul16_t)); - gsna->l = 4; - memcpy(gsna->v, src, gsna->l); - return 0; -} - /* TS 29.060 has yet again a different encoding for IMSIs than * what we have in other places, so we cannot use the gsm48 * decoding functions. Also, libgtp uses an uint64_t in -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I51e6a7c1161320fc54b0e8197ae57e4327976eb1 Gerrit-Change-Number: 36791 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp/gtp_internal.h: new file

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email ) Change subject: gtp/gtp_internal.h: new file ...................................................................... gtp/gtp_internal.h: new file While at it, move internal functions of gtp.h to a separate file too. Make all functions that are only used inside gtp.c static. The following APIs are unexpectedly public: * imsi_gtp2str gets used by pdp.h * gsna2in_addr, gtp_echo_req gets used by osmo-sgsn Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7 --- M ggsn/ggsn.c M ggsn/ggsn_vty.c M ggsn/sgsn.c M gtp/Makefile.am M gtp/gtp.c A gtp/gtp_internal.h M include/osmocom/gtp/gtp.h M sgsnemu/sgsnemu.c 8 files changed, 54 insertions(+), 77 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index 2e9010e..8d1524c 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -58,6 +58,7 @@ #include "../lib/icmpv6.h" #include "pco.h" #include "ggsn.h" +#include "../gtp/gtp_internal.h" static int ggsn_tun_fd_cb(struct osmo_fd *fd, unsigned int what); static int cb_tun_ind(struct tun_t *tun, void *pack, unsigned len); diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c index a661869..f70daf1 100644 --- a/ggsn/ggsn_vty.c +++ b/ggsn/ggsn_vty.c @@ -42,6 +42,7 @@ #include "ggsn.h" #include "sgsn.h" +#include "../gtp/gtp_internal.h" #define PREFIX_STR "Prefix (Network/Netmask)\n" #define IFCONFIG_STR "GGSN-based interface configuration\n" diff --git a/ggsn/sgsn.c b/ggsn/sgsn.c index 15548ef..b324fd7 100644 --- a/ggsn/sgsn.c +++ b/ggsn/sgsn.c @@ -1,6 +1,6 @@ #include "sgsn.h" #include "ggsn.h" - +#include "../gtp/gtp_internal.h" static bool sgsn_peer_attempt_free(struct sgsn_peer *sgsn) { diff --git a/gtp/Makefile.am b/gtp/Makefile.am index 11426a4..a140cee 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -18,6 +18,7 @@ gsn.c \ gsn_internal.h \ gtp.c \ + gtp_internal.h \ gtpie.c \ lookupa.c \ lookupa.h \ diff --git a/gtp/gtp.c b/gtp/gtp.c index 482875d..245927b 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -61,6 +61,7 @@ #include "queue.h" #include "gsn_internal.h" +#include "gtp_internal.h" /* Error reporting functions */ @@ -640,8 +641,8 @@ } /* Send off an echo reply */ -int gtp_echo_resp(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, int fd, void *pack, unsigned len) +static int gtp_echo_resp(struct gsn_t *gsn, int version, + struct sockaddr_in *peer, int fd, void *pack, unsigned len) { union gtp_packet packet; unsigned int length = get_default_gtp(version, GTP_ECHO_RSP, &packet); @@ -652,8 +653,8 @@ } /* Handle a received echo request */ -int gtp_echo_ind(struct gsn_t *gsn, int version, struct sockaddr_in *peer, - int fd, void *pack, unsigned len) +static int gtp_echo_ind(struct gsn_t *gsn, int version, struct sockaddr_in *peer, + int fd, void *pack, unsigned len) { /* Check if it was a duplicate request */ @@ -665,8 +666,8 @@ } /* Handle a received echo reply */ -int gtp_echo_conf(struct gsn_t *gsn, int version, struct sockaddr_in *peer, - void *pack, unsigned len) +static int gtp_echo_conf(struct gsn_t *gsn, int version, struct sockaddr_in *peer, + void *pack, unsigned len) { union gtpie_member *ie[GTPIE_SIZE]; unsigned char recovery; @@ -718,8 +719,8 @@ * only listen to the GTP0 port, and therefore will never receive * anything else than GTP0 */ -int gtp_unsup_req(struct gsn_t *gsn, int version, struct sockaddr_in *peer, - int fd, void *pack, unsigned len) +static int gtp_unsup_req(struct gsn_t *gsn, int version, struct sockaddr_in *peer, + int fd, void *pack, unsigned len) { union gtp_packet packet; @@ -729,8 +730,8 @@ } /* Handle a Version Not Supported message */ -int gtp_unsup_ind(struct gsn_t *gsn, struct sockaddr_in *peer, - void *pack, unsigned len) +static int gtp_unsup_ind(struct gsn_t *gsn, struct sockaddr_in *peer, + void *pack, unsigned len) { if (gsn->cb_unsup_ind) @@ -848,7 +849,7 @@ return 0; } -int in_addr2gsna(struct ul16_t *gsna, struct in_addr *src) +static int in_addr2gsna(struct ul16_t *gsna, struct in_addr *src) { memset(gsna, 0, sizeof(struct ul16_t)); gsna->l = 4; @@ -1025,8 +1026,8 @@ } /* Send Create PDP Context Response */ -int gtp_create_pdp_resp(struct gsn_t *gsn, int version, struct pdp_t *pdp, - uint8_t cause) +static int gtp_create_pdp_resp(struct gsn_t *gsn, int version, struct pdp_t *pdp, + uint8_t cause) { union gtp_packet packet; unsigned int length = @@ -1101,9 +1102,9 @@ } /* Handle Create PDP Context Request */ -int gtp_create_pdp_ind(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, int fd, - void *pack, unsigned len) +static int gtp_create_pdp_ind(struct gsn_t *gsn, int version, + struct sockaddr_in *peer, int fd, + void *pack, unsigned len) { struct pdp_t *pdp, *pdp_old; struct pdp_t pdp_buf; @@ -1426,8 +1427,8 @@ } /* Handle Create PDP Context Response */ -int gtp_create_pdp_conf(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, void *pack, unsigned len) +static int gtp_create_pdp_conf(struct gsn_t *gsn, int version, + struct sockaddr_in *peer, void *pack, unsigned len) { struct pdp_t *pdp; union gtpie_member *ie[GTPIE_SIZE]; @@ -2193,11 +2194,11 @@ } /* Send Delete PDP Context Response */ -int gtp_delete_pdp_resp(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, int fd, - void *pack, unsigned len, - struct pdp_t *pdp, struct pdp_t *linked_pdp, - uint8_t cause, int teardown) +static int gtp_delete_pdp_resp(struct gsn_t *gsn, int version, + struct sockaddr_in *peer, int fd, + void *pack, unsigned len, + struct pdp_t *pdp, struct pdp_t *linked_pdp, + uint8_t cause, int teardown) { union gtp_packet packet; unsigned int length = @@ -2238,9 +2239,9 @@ } /* Handle Delete PDP Context Request */ -int gtp_delete_pdp_ind(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, int fd, - void *pack, unsigned len) +static int gtp_delete_pdp_ind(struct gsn_t *gsn, int version, + struct sockaddr_in *peer, int fd, + void *pack, unsigned len) { struct pdp_t *pdp = NULL; struct pdp_t *linked_pdp = NULL; @@ -2337,8 +2338,8 @@ } /* Handle Delete PDP Context Response */ -int gtp_delete_pdp_conf(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, void *pack, unsigned len) +static int gtp_delete_pdp_conf(struct gsn_t *gsn, int version, + struct sockaddr_in *peer, void *pack, unsigned len) { union gtpie_member *ie[GTPIE_SIZE]; uint8_t cause; diff --git a/gtp/gtp_internal.h b/gtp/gtp_internal.h new file mode 100644 index 0000000..c8f22dc --- /dev/null +++ b/gtp/gtp_internal.h @@ -0,0 +1,3 @@ +#pragma once + +uint64_t gtp_imsi_str2gtp(const char *str); diff --git a/include/osmocom/gtp/gtp.h b/include/osmocom/gtp/gtp.h index 7e6bb55..e3c66c9 100644 --- a/include/osmocom/gtp/gtp.h +++ b/include/osmocom/gtp/gtp.h @@ -265,59 +265,12 @@ extern int gtp_decaps0(struct gsn_t *gsn); extern int gtp_decaps1c(struct gsn_t *gsn); extern int gtp_decaps1u(struct gsn_t *gsn); -/* Internal functions (not part of the API) */ extern int gtp_echo_req(struct gsn_t *gsn, int version, void *cbp, struct in_addr *inetaddrs); -extern int gtp_echo_resp(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, int fd, - void *pack, unsigned len); -extern int gtp_echo_ind(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, int fd, - void *pack, unsigned len); -extern int gtp_echo_conf(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, void *pack, unsigned len); - -extern int gtp_unsup_req(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, - int fd, void *pack, unsigned len); -extern int gtp_unsup_ind(struct gsn_t *gsn, struct sockaddr_in *peer, - void *pack, unsigned len); - -extern int gtp_create_pdp_resp(struct gsn_t *gsn, int version, - struct pdp_t *pdp, uint8_t cause); - -extern int gtp_create_pdp_ind(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, int fd, - void *pack, unsigned len); - -extern int gtp_create_pdp_conf(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, - void *pack, unsigned len); - -extern int gtp_update_pdp_req(struct gsn_t *gsn, int version, void *cbp, - struct in_addr *inetaddr, struct pdp_t *pdp); - -extern int gtp_delete_pdp_req(struct gsn_t *gsn, int version, void *cbp, - struct pdp_t *pdp); - -extern int gtp_delete_pdp_resp(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, int fd, - void *pack, unsigned len, - struct pdp_t *pdp, struct pdp_t *linked_pdp, - uint8_t cause, int teardown); - -extern int gtp_delete_pdp_ind(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, int fd, - void *pack, unsigned len); - -extern int gtp_delete_pdp_conf(struct gsn_t *gsn, int version, - struct sockaddr_in *peer, - void *pack, unsigned len); extern int gsna2in_addr(struct in_addr *dst, struct ul16_t *gsna); -extern int in_addr2gsna(struct ul16_t *gsna, struct in_addr *src); + extern const char *imsi_gtp2str(const uint64_t *imsi); -extern uint64_t gtp_imsi_str2gtp(const char *str); #endif /* !_GTP_H */ diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c index de7af4a..152b05b 100644 --- a/sgsnemu/sgsnemu.c +++ b/sgsnemu/sgsnemu.c @@ -62,6 +62,7 @@ #include "../lib/syserr.h" #include "../lib/netns.h" #include "../lib/icmpv6.h" +#include "../gtp/gtp_internal.h" #include "cmdline.h" #define IPADDRLEN 256 /* Character length of addresses */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7 Gerrit-Change-Number: 36068 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp/gsn_internal.h: new file

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36067?usp=email ) Change subject: gtp/gsn_internal.h: new file ...................................................................... gtp/gsn_internal.h: new file Change-Id: I999462e39411fc4ec7e50bd0212e870006fbc4f1 --- M gtp/Makefile.am M gtp/gsn.c A gtp/gsn_internal.h M gtp/gtp.c M include/osmocom/gtp/gsn.h 5 files changed, 15 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/gtp/Makefile.am b/gtp/Makefile.am index f0c7555..11426a4 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -16,6 +16,7 @@ libgtp_la_SOURCES = \ gsn.c \ + gsn_internal.h \ gtp.c \ gtpie.c \ lookupa.c \ diff --git a/gtp/gsn.c b/gtp/gsn.c index e326f80..c23fb2a 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -62,6 +62,7 @@ #include <osmocom/gtp/gtpie.h> #include "queue.h" +#include "gsn_internal.h" /* Error reporting functions */ diff --git a/gtp/gsn_internal.h b/gtp/gsn_internal.h new file mode 100644 index 0000000..deb60c3 --- /dev/null +++ b/gtp/gsn_internal.h @@ -0,0 +1,3 @@ +#pragma once + +void gtp_queue_timer_start(struct gsn_t *gsn); diff --git a/gtp/gtp.c b/gtp/gtp.c index 8921802..bdf7e7d 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -60,6 +60,7 @@ #include <osmocom/gtp/gtpie.h> #include "queue.h" +#include "gsn_internal.h" /* Error reporting functions */ diff --git a/include/osmocom/gtp/gsn.h b/include/osmocom/gtp/gsn.h index 8e47ce3..936db9b 100644 --- a/include/osmocom/gtp/gsn.h +++ b/include/osmocom/gtp/gsn.h @@ -175,7 +175,4 @@ extern int gtp_retrans(struct gsn_t *gsn) OSMO_DEPRECATED("This API is a no-op, libgtp already does the job internally"); extern int gtp_retranstimeout(struct gsn_t *gsn, struct timeval *timeout) OSMO_DEPRECATED("This API is a no-op and will return a 1 day timeout"); -/* Internal APIs: */ -void gtp_queue_timer_start(struct gsn_t *gsn); - #endif /* !_GSN_H */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I999462e39411fc4ec7e50bd0212e870006fbc4f1 Gerrit-Change-Number: 36067 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp/gtp.c: move gtp_create_context_resp down

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36789?usp=email ) Change subject: gtp/gtp.c: move gtp_create_context_resp down ...................................................................... gtp/gtp.c: move gtp_create_context_resp down Move gtp_create_context_resp below gtp_create_pdp_resp, which it calls. In a follow-up commit, we can make gtp_create_pdp_resp static and remove the additional declaration. Change-Id: I34efe7592013a8423f4f280758272d81f24b65fa --- M gtp/gtp.c 1 file changed, 26 insertions(+), 13 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/gtp/gtp.c b/gtp/gtp.c index bdf7e7d..2d18fab 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -990,19 +990,6 @@ return 0; } -/* API: Application response to context indication */ -int gtp_create_context_resp(struct gsn_t *gsn, struct pdp_t *pdp, int cause) -{ - - /* Now send off a reply to the peer */ - gtp_create_pdp_resp(gsn, pdp->version, pdp, cause); - - if (!gtp_cause_successful(cause)) - gtp_freepdp(gsn, pdp); - - return 0; -} - /* Send Create PDP Context Response */ int gtp_create_pdp_resp(struct gsn_t *gsn, int version, struct pdp_t *pdp, uint8_t cause) @@ -1066,6 +1053,19 @@ pdp->fd, pdp->seq, pdp->tid); } +/* API: Application response to context indication */ +int gtp_create_context_resp(struct gsn_t *gsn, struct pdp_t *pdp, int cause) +{ + + /* Now send off a reply to the peer */ + gtp_create_pdp_resp(gsn, pdp->version, pdp, cause); + + if (!gtp_cause_successful(cause)) + gtp_freepdp(gsn, pdp); + + return 0; +} + /* Handle Create PDP Context Request */ int gtp_create_pdp_ind(struct gsn_t *gsn, int version, struct sockaddr_in *peer, int fd, -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I34efe7592013a8423f4f280758272d81f24b65fa Gerrit-Change-Number: 36789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: libgtp: move includes to osmocom/include/gtp

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36066?usp=email ) Change subject: libgtp: move includes to osmocom/include/gtp ...................................................................... libgtp: move includes to osmocom/include/gtp Move all includes from /usr/include/….h to /usr/include/osmocom/gtp/….h to be more consistent with other Osmocom projects, and to not "pollute" the top include directory if we add more header files. Also the new directory structure makes more obvious, which headers are public and which ones aren't. Adjust libgtp.pc.in so both #include <gtp.h> (legacy) and #include <osmocom/gtp/gtp.h> can be used. Related: OS#6373 Change-Id: If7e01c61168819bf7120667344e40c857da5490b --- M Makefile.am M configure.ac M ggsn/Makefile.am M ggsn/ggsn.c M ggsn/ggsn.h M ggsn/ggsn_vty.c M ggsn/pco.h M ggsn/sgsn.h M gtp/Makefile.am M gtp/gsn.c M gtp/gtp.c M gtp/gtpie.c M gtp/pdp.c M gtp/queue.c M gtp/queue.h A include/Makefile.am A include/osmocom/Makefile.am A include/osmocom/gtp/Makefile.am R include/osmocom/gtp/gsn.h R include/osmocom/gtp/gtp.h R include/osmocom/gtp/gtpie.h R include/osmocom/gtp/pdp.h M lib/Makefile.am M lib/gtp-kernel.c M lib/icmpv6.c M lib/icmpv6.h M lib/in46_addr.c M lib/in46_addr.h M lib/ippool.h M lib/util.c M libgtp.pc.in M sgsnemu/Makefile.am M sgsnemu/sgsnemu.c M tests/gtp/gtpie_test.c 34 files changed, 91 insertions(+), 40 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/Makefile.am b/Makefile.am index 4d59c53..ccd1e31 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,5 +1,6 @@ ## Process this file with automake to produce Makefile.in SUBDIRS = \ + include \ lib \ gtp \ ggsn \ diff --git a/configure.ac b/configure.ac index b73c5db..07b8b81 100644 --- a/configure.ac +++ b/configure.ac @@ -265,6 +265,9 @@ tests/Makefile tests/lib/Makefile tests/gtp/Makefile + include/Makefile + include/osmocom/Makefile + include/osmocom/gtp/Makefile libgtp.pc]) AC_OUTPUT diff --git a/ggsn/Makefile.am b/ggsn/Makefile.am index 0c6f334..ad6b2b2 100644 --- a/ggsn/Makefile.am +++ b/ggsn/Makefile.am @@ -7,6 +7,7 @@ -fno-builtin \ -Wall \ -DSBINDIR='"$(sbindir)"' \ + -I$(top_srcdir)/include \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index 0603773..2e9010e 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -46,14 +46,15 @@ #include <osmocom/ctrl/control_if.h> #include <osmocom/gsm/apn.h> +#include <osmocom/gtp/pdp.h> +#include <osmocom/gtp/gtp.h> + #include "../lib/tun.h" #include "../lib/ippool.h" #include "../lib/syserr.h" #include "../lib/in46_addr.h" #include "../lib/gtp-kernel.h" #include "../lib/util.h" -#include "../gtp/pdp.h" -#include "../gtp/gtp.h" #include "../lib/icmpv6.h" #include "pco.h" #include "ggsn.h" diff --git a/ggsn/ggsn.h b/ggsn/ggsn.h index 1abbc9a..7a3204f 100644 --- a/ggsn/ggsn.h +++ b/ggsn/ggsn.h @@ -8,12 +8,12 @@ #include <osmocom/core/timer.h> #include <osmocom/core/tdef.h> #include <osmocom/ctrl/control_if.h> +#include <osmocom/gtp/gtp.h> #include "../lib/tun.h" #include "../lib/ippool.h" #include "../lib/syserr.h" #include "../lib/in46_addr.h" -#include "../gtp/gtp.h" #include "sgsn.h" diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c index 7414b6a..a661869 100644 --- a/ggsn/ggsn_vty.c +++ b/ggsn/ggsn_vty.c @@ -35,8 +35,8 @@ #include <osmocom/vty/misc.h> #include <osmocom/vty/tdef_vty.h> -#include "../gtp/gtp.h" -#include "../gtp/pdp.h" +#include <osmocom/gtp/gtp.h> +#include <osmocom/gtp/pdp.h> #include "../lib/util.h" diff --git a/ggsn/pco.h b/ggsn/pco.h index 2f95d09..bedfa8a 100644 --- a/ggsn/pco.h +++ b/ggsn/pco.h @@ -2,7 +2,7 @@ #include <stdint.h> -#include "../gtp/pdp.h" +#include <osmocom/gtp/pdp.h> /* 3GPP TS 24.008 10.5.6.3 */ enum pco_protocols { diff --git a/ggsn/sgsn.h b/ggsn/sgsn.h index d2c3c0c..3bc94e3 100644 --- a/ggsn/sgsn.h +++ b/ggsn/sgsn.h @@ -8,7 +8,7 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/timer.h> -#include "../gtp/pdp.h" +#include <osmocom/gtp/pdp.h> struct ggsn_ctx; struct pdp_priv_t; diff --git a/gtp/Makefile.am b/gtp/Makefile.am index 666befe..f0c7555 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -6,26 +6,21 @@ lib_LTLIBRARIES = libgtp.la -include_HEADERS = gtp.h gsn.h pdp.h gtpie.h - AM_CFLAGS = \ -fno-builtin \ -Wall \ -DSBINDIR='"$(sbindir)"' \ + -I$(top_srcdir)/include \ $(LIBOSMOCORE_CFLAGS) \ $(NULL) libgtp_la_SOURCES = \ gsn.c \ - gsn.h \ gtp.c \ - gtp.h \ gtpie.c \ - gtpie.h \ lookupa.c \ lookupa.h \ pdp.c \ - pdp.h \ queue.c \ queue.h \ $(NULL) diff --git a/gtp/gsn.c b/gtp/gsn.c index e66dc99..e326f80 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -57,9 +57,10 @@ /* #include <stdint.h> ISO C99 types */ -#include "pdp.h" -#include "gtp.h" -#include "gtpie.h" +#include <osmocom/gtp/pdp.h> +#include <osmocom/gtp/gtp.h> +#include <osmocom/gtp/gtpie.h> + #include "queue.h" /* Error reporting functions */ diff --git a/gtp/gtp.c b/gtp/gtp.c index 43e56b5..8921802 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -55,9 +55,10 @@ /* #include <stdint.h> ISO C99 types */ -#include "pdp.h" -#include "gtp.h" -#include "gtpie.h" +#include <osmocom/gtp/pdp.h> +#include <osmocom/gtp/gtp.h> +#include <osmocom/gtp/gtpie.h> + #include "queue.h" /* Error reporting functions */ diff --git a/gtp/gtpie.c b/gtp/gtpie.c index e413d11..3212a8a 100644 --- a/gtp/gtpie.c +++ b/gtp/gtpie.c @@ -37,7 +37,7 @@ #include <netinet/in.h> #include <string.h> -#include "gtpie.h" +#include <osmocom/gtp/gtpie.h> /*! Encode a TLV type Information Element. * \param[inout] p Pointer to output packet to which IE is appended diff --git a/gtp/pdp.c b/gtp/pdp.c index 2be2dd3..9626ce8 100644 --- a/gtp/pdp.c +++ b/gtp/pdp.c @@ -28,8 +28,10 @@ #include <netinet/in.h> #include <string.h> #include <inttypes.h> -#include "pdp.h" -#include "gtp.h" + +#include <osmocom/gtp/pdp.h> +#include <osmocom/gtp/gtp.h> + #include "lookupa.h" #include "queue.h" diff --git a/gtp/queue.c b/gtp/queue.c index 4c25913..157c226 100644 --- a/gtp/queue.c +++ b/gtp/queue.c @@ -27,8 +27,10 @@ #include <sys/time.h> #include <netinet/in.h> #include <string.h> -#include "pdp.h" -#include "gtp.h" + +#include <osmocom/gtp/pdp.h> +#include <osmocom/gtp/gtp.h> + #include "queue.h" /*! \brief dump a queue_t to stdout */ diff --git a/gtp/queue.h b/gtp/queue.h index 9f62482..7fde079 100644 --- a/gtp/queue.h +++ b/gtp/queue.h @@ -19,7 +19,7 @@ #include <osmocom/core/linuxlist.h> -#include "gtp.h" +#include <osmocom/gtp/gtp.h> #define QUEUE_DEBUG 0 /* Print debug information */ diff --git a/include/Makefile.am b/include/Makefile.am new file mode 100644 index 0000000..9d963a0 --- /dev/null +++ b/include/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + osmocom \ + $(NULL) diff --git a/include/osmocom/Makefile.am b/include/osmocom/Makefile.am new file mode 100644 index 0000000..2a96bba --- /dev/null +++ b/include/osmocom/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + gtp \ + $(NULL) diff --git a/include/osmocom/gtp/Makefile.am b/include/osmocom/gtp/Makefile.am new file mode 100644 index 0000000..db696e5 --- /dev/null +++ b/include/osmocom/gtp/Makefile.am @@ -0,0 +1,8 @@ +libgtp_HEADERS = \ + gsn.h \ + gtp.h \ + gtpie.h \ + pdp.h \ + $(NULL) + +libgtpdir = $(includedir)/osmocom/gtp diff --git a/gtp/gsn.h b/include/osmocom/gtp/gsn.h similarity index 100% rename from gtp/gsn.h rename to include/osmocom/gtp/gsn.h diff --git a/gtp/gtp.h b/include/osmocom/gtp/gtp.h similarity index 100% rename from gtp/gtp.h rename to include/osmocom/gtp/gtp.h diff --git a/gtp/gtpie.h b/include/osmocom/gtp/gtpie.h similarity index 100% rename from gtp/gtpie.h rename to include/osmocom/gtp/gtpie.h diff --git a/gtp/pdp.h b/include/osmocom/gtp/pdp.h similarity index 100% rename from gtp/pdp.h rename to include/osmocom/gtp/pdp.h diff --git a/lib/Makefile.am b/lib/Makefile.am index bef8962..1fdc93f 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -19,6 +19,7 @@ -fno-builtin \ -Wall \ -DSBINDIR='"$(sbindir)"' \ + -I$(top_srcdir)/include \ $(LIBOSMOCORE_CFLAGS) \ $(NULL) diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c index 6a14d78..4c8c3ac 100644 --- a/lib/gtp-kernel.c +++ b/lib/gtp-kernel.c @@ -23,12 +23,13 @@ #include <time.h> +#include <osmocom/gtp/pdp.h> +#include <osmocom/gtp/gtp.h> + #include "../lib/tun.h" #include "../lib/syserr.h" #include "../lib/util.h" #include "../lib/ippool.h" -#include "../gtp/pdp.h" -#include "../gtp/gtp.h" #include "gtp-kernel.h" diff --git a/lib/icmpv6.c b/lib/icmpv6.c index ac1474d..b6994cd 100644 --- a/lib/icmpv6.c +++ b/lib/icmpv6.c @@ -21,10 +21,11 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/utils.h> -#include "checksum.h" -#include "../gtp/gtp.h" -#include "../gtp/pdp.h" +#include <osmocom/gtp/gtp.h> +#include <osmocom/gtp/pdp.h> + +#include "checksum.h" #include "ippool.h" #include "syserr.h" #include "icmpv6.h" diff --git a/lib/icmpv6.h b/lib/icmpv6.h index ee5ef29..5bed5c6 100644 --- a/lib/icmpv6.h +++ b/lib/icmpv6.h @@ -5,8 +5,8 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/endian.h> -#include "../gtp/gtp.h" -#include "../gtp/pdp.h" +#include <osmocom/gtp/gtp.h> +#include <osmocom/gtp/pdp.h> #define ICMPv6_OPT_TYPE_PREFIX_INFO 0x03 diff --git a/lib/in46_addr.c b/lib/in46_addr.c index 648fe7e..c5157be 100644 --- a/lib/in46_addr.c +++ b/lib/in46_addr.c @@ -10,7 +10,7 @@ */ #include "../lib/in46_addr.h" -#include "../gtp/pdp.h" +#include <osmocom/gtp/pdp.h> #include <osmocom/core/utils.h> diff --git a/lib/in46_addr.h b/lib/in46_addr.h index 5589f94..89e1e22 100644 --- a/lib/in46_addr.h +++ b/lib/in46_addr.h @@ -2,7 +2,7 @@ #include <stdint.h> #include <netinet/in.h> -#include "../gtp/pdp.h" +#include <osmocom/gtp/pdp.h> /* a simple wrapper around an in6_addr to also contain the length of the address, * thereby implicitly indicating the address family of the address */ diff --git a/lib/ippool.h b/lib/ippool.h index efb274b..406938e 100644 --- a/lib/ippool.h +++ b/lib/ippool.h @@ -13,7 +13,7 @@ #define _IPPOOL_H #include "../lib/in46_addr.h" -#include "../gtp/gtp.h" +#include <osmocom/gtp/gtp.h> /* Assuming that the address space is fragmented we need a hash table in order to return the addresses. diff --git a/lib/util.c b/lib/util.c index 6bb0d85..f29884a 100644 --- a/lib/util.c +++ b/lib/util.c @@ -9,7 +9,7 @@ * */ -#include "../gtp/pdp.h" +#include <osmocom/gtp/pdp.h> #include "ippool.h" #include "in46_addr.h" diff --git a/libgtp.pc.in b/libgtp.pc.in index e6048e9..b6b0652 100644 --- a/libgtp.pc.in +++ b/libgtp.pc.in @@ -7,5 +7,8 @@ Description: C Utility Library Version: @VERSION@ Libs: -L${libdir} -lgtp -Cflags: -I${includedir}/ +# Add two include paths to support: +# * #include <osmocom/gtp/gtp.h> (like other Osmocom headers) +# * #include <gtp.h> (legacy compat) +Cflags: -I${includedir}/osmocom/gtp/ -I${includedir}/ diff --git a/sgsnemu/Makefile.am b/sgsnemu/Makefile.am index 7e7fdbb..5d88c7f 100644 --- a/sgsnemu/Makefile.am +++ b/sgsnemu/Makefile.am @@ -7,6 +7,7 @@ -fno-builtin \ -Wall \ -DSBINDIR='"$(sbindir)"' \ + -I$(top_srcdir)/include \ $(LIBOSMOCORE_CFLAGS) \ $(NULL) diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c index 7893f4f..de7af4a 100644 --- a/sgsnemu/sgsnemu.c +++ b/sgsnemu/sgsnemu.c @@ -54,13 +54,14 @@ #endif // HAVE_IN6_ADDR_GEN_MODE_NONE #endif +#include <osmocom/gtp/pdp.h> +#include <osmocom/gtp/gtp.h> + #include "../lib/tun.h" #include "../lib/ippool.h" #include "../lib/syserr.h" #include "../lib/netns.h" #include "../lib/icmpv6.h" -#include "../gtp/pdp.h" -#include "../gtp/gtp.h" #include "cmdline.h" #define IPADDRLEN 256 /* Character length of addresses */ diff --git a/tests/gtp/gtpie_test.c b/tests/gtp/gtpie_test.c index ed1f26e..46c0a98 100644 --- a/tests/gtp/gtpie_test.c +++ b/tests/gtp/gtpie_test.c @@ -10,8 +10,9 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/bits.h> +#include <osmocom/gtp/gtpie.h> + #include "../../lib/syserr.h" -#include "../../gtp/gtpie.h" static const uint8_t in[] = { 1,2,3,4,5,6 }; static uint8_t buf[256]; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: If7e01c61168819bf7120667344e40c857da5490b Gerrit-Change-Number: 36066 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: remove unused conversion functions

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email ) Change subject: gtp: remove unused conversion functions ...................................................................... gtp: remove unused conversion functions Remove ipv42eua and eua2ipv4, which are in the "internal functions" section of gtp.h, but are not used anywhere in the code anymore. This is in preparation of moving the internal functions that are used in multiple .c files into a separate header file, and to make the other internal functions static. (Compiler complains about unused static functions.) Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 --- M TODO-RELEASE M gtp/gtp.c M include/osmocom/gtp/gtp.h 3 files changed, 17 insertions(+), 23 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index 22cfd1d..73c4fbe 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,4 +8,5 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libgtp REMOVE remove GTP cause defines of reserved values +libgtp REMOVE ABI change (removed API: ipv42eua, eua2ipv4) libgtpnl > 1.2.5 gtp_tunnel_set_family() diff --git a/gtp/gtp.c b/gtp/gtp.c index 2d18fab..9442b33 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -3069,27 +3069,6 @@ * port number. *************************************************************/ -int ipv42eua(struct ul66_t *eua, struct in_addr *src) -{ - eua->v[0] = PDP_EUA_ORG_IETF; - eua->v[1] = PDP_EUA_TYPE_v4; - if (src) { - eua->l = 6; - memcpy(&eua->v[2], src, 4); - } else { - eua->l = 2; - } - return 0; -} - -int eua2ipv4(struct in_addr *dst, struct ul66_t *eua) -{ - if ((eua->l != 6) || (eua->v[0] != PDP_EUA_ORG_IETF) || (eua->v[1] != PDP_EUA_TYPE_v4)) - return -1; /* Not IPv4 address */ - memcpy(dst, &eua->v[2], 4); - return 0; -} - int gsna2in_addr(struct in_addr *dst, struct ul16_t *gsna) { memset(dst, 0, sizeof(struct in_addr)); diff --git a/include/osmocom/gtp/gtp.h b/include/osmocom/gtp/gtp.h index 7465cf1..7e6bb55 100644 --- a/include/osmocom/gtp/gtp.h +++ b/include/osmocom/gtp/gtp.h @@ -315,8 +315,6 @@ struct sockaddr_in *peer, void *pack, unsigned len); -extern int ipv42eua(struct ul66_t *eua, struct in_addr *src); -extern int eua2ipv4(struct in_addr *dst, struct ul66_t *eua); extern int gsna2in_addr(struct in_addr *dst, struct ul16_t *gsna); extern int in_addr2gsna(struct ul16_t *gsna, struct in_addr *src); extern const char *imsi_gtp2str(const uint64_t *imsi); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 Gerrit-Change-Number: 36790 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp/gtp_internal.h: new file

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email ) Change subject: gtp/gtp_internal.h: new file ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7 Gerrit-Change-Number: 36068 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 16 May 2024 08:38:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp: move conversion functions up

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email ) Change subject: gtp: move conversion functions up ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I51e6a7c1161320fc54b0e8197ae57e4327976eb1 Gerrit-Change-Number: 36791 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 May 2024 08:37:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: libgtp: move includes to osmocom/include/gtp

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36066?usp=email ) Change subject: libgtp: move includes to osmocom/include/gtp ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File gtp/Makefile.am: https://gerrit.osmocom.org/c/osmo-ggsn/+/36066/comment/6fefeef4_56649066 PS2, Line 22: lookupa.h yes, because it did not get installed to /usr/include before. See the deleted line in this file: > include_HEADERS = gtp.h gsn.h pdp.h gtpie.h -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: If7e01c61168819bf7120667344e40c857da5490b Gerrit-Change-Number: 36066 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 May 2024 08:37:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: remove unused conversion functions

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email ) Change subject: gtp: remove unused conversion functions ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 Gerrit-Change-Number: 36790 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 May 2024 08:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024