March 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-hnbgw[master]: HNBAP: Make sure to respond with correct "reject"

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36478?usp=email ) Change subject: HNBAP: Make sure to respond with correct "reject" ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I300db368a3d1d2fb5967f69f2ed4ac90ecf85e75 Gerrit-Change-Number: 36478 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Mar 2024 21:17:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-iuh[master]: hnbap_common: Make error message more verbose (which type failed)

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36480?usp=email ) Change subject: hnbap_common: Make error message more verbose (which type failed) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36480?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3d263a2a50afbe1a2a99e52b16e983e0aae22edf Gerrit-Change-Number: 36480 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Mar 2024 21:17:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: fix MGCP_Test.TC_one_crcx_loopback_rtp_implicit expectations

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36466?usp=email ) Change subject: fix MGCP_Test.TC_one_crcx_loopback_rtp_implicit expectations ...................................................................... fix MGCP_Test.TC_one_crcx_loopback_rtp_implicit expectations osmo-mgw should not respond to unknown peers. The test expected the wrong thing, because of an old hack for 3G voice. Fix that. Related: OS#6424 Change-Id: Ibe2ee59d1ed2c25ffef7e8534c172ac190b4983d --- M mgw/MGCP_Test.ttcn 1 file changed, 29 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 3161079..7090b34 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1931,11 +1931,22 @@ stats := f_rtpem_stats_get(RTPEM[0]); - if (stats.num_pkts_tx != stats.num_pkts_rx) { - setverdict(fail); - } - if (stats.bytes_payload_tx != stats.bytes_payload_rx) { - setverdict(fail); + if (one_phase) { + /* osmo-mgw knows both local and remote RTP address. Expect all packets to be reflected. */ + if (stats.num_pkts_tx != stats.num_pkts_rx) { + setverdict(fail); + } + if (stats.bytes_payload_tx != stats.bytes_payload_rx) { + setverdict(fail); + } + } else { + /* osmo-mgw knows only the local RTP address. Expect no packets to be reflected. */ + if (stats.num_pkts_rx > 0) { + setverdict(fail, "stats.num_pkts_rx=", stats.num_pkts_rx, ": osmo-mgw should not send RTP packets to an arbitrary peer"); + } + if (stats.bytes_payload_rx > 0) { + setverdict(fail); + } } f_rtpem_stats_err_check(stats); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe2ee59d1ed2c25ffef7e8534c172ac190b4983d Gerrit-Change-Number: 36466 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: fix MGCP_Test.TC_one_crcx_loopback_rtp_implicit expectations

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36466?usp=email ) Change subject: fix MGCP_Test.TC_one_crcx_loopback_rtp_implicit expectations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe2ee59d1ed2c25ffef7e8534c172ac190b4983d Gerrit-Change-Number: 36466 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 21:16:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej() ...................................................................... HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej() Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/81/36481/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b Gerrit-Change-Number: 36481 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Rename f_hnbap_register to f_hnbap_hnb_register

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36482?usp=email ) Change subject: hnbgw: Rename f_hnbap_register to f_hnbap_hnb_register ...................................................................... hnbgw: Rename f_hnbap_register to f_hnbap_hnb_register There's HNB and UE registration; let's make clear which it is. Change-Id: I171f0385389c5f50dc7ad28525deef396fff5fbf --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 20 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/36482/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 89b243b..cd8ac7a 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -560,7 +560,7 @@ /* helper function to start all of the simulated hNodeBs */ function f_start_hnbs() runs on test_CT { for (var integer i:= 0; i < g_num_hnbs; i := i+1) { - f_hnbap_register(i, i); + f_hnbap_hnb_register(i, i); } } @@ -887,7 +887,7 @@ ***********************************************************************/ -function f_hnbap_register(integer hnb_idx := 0, integer cell_id := 0, boolean expect_reject := false) runs on test_CT +function f_hnbap_hnb_register(integer hnb_idx := 0, integer cell_id := 0, boolean expect_reject := false) runs on test_CT { timer T := 2.0; @@ -926,7 +926,7 @@ testcase TC_hnb_register() runs on test_CT { g_num_hnbs := 1; f_init(start_hnb := false); - f_hnbap_register(0); + f_hnbap_hnb_register(0); f_shutdown_helper(); } @@ -935,8 +935,8 @@ testcase TC_hnb_register_duplicate() runs on test_CT { g_num_hnbs := 2; f_init(start_hnb := false); - f_hnbap_register(0); - f_hnbap_register(1, 0, expect_reject := true); + f_hnbap_hnb_register(0); + f_hnbap_hnb_register(1, 0, expect_reject := true); f_verify_talloc_count(HNBGWVTY, {"struct hnb_context"}, expect_count := 1); f_shutdown_helper(); } @@ -947,8 +947,8 @@ testcase TC_hnb_register_duplicate_reuse_sctp_assoc() runs on test_CT { g_num_hnbs := 1; f_init(start_hnb := false); - f_hnbap_register(0); - f_hnbap_register(0); + f_hnbap_hnb_register(0); + f_hnbap_hnb_register(0); f_verify_talloc_count(HNBGWVTY, {"struct hnb_context"}, expect_count := 1); f_shutdown_helper(); } @@ -958,9 +958,9 @@ testcase TC_hnb_reregister_reuse_sctp_assoc() runs on test_CT { g_num_hnbs := 1; f_init(start_hnb := false); - f_hnbap_register(0); + f_hnbap_hnb_register(0); HNBAP[0].send(ts_HNBAP_HNBDe_Register(ts_HnbapCause(unspecified))); - f_hnbap_register(0); + f_hnbap_hnb_register(0); f_verify_talloc_count(HNBGWVTY, {"struct hnb_context"}, expect_count := 1); f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I171f0385389c5f50dc7ad28525deef396fff5fbf Gerrit-Change-Number: 36482 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce tests about UE registration

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36484?usp=email ) Change subject: hnbgw: Introduce tests about UE registration ...................................................................... hnbgw: Introduce tests about UE registration We didn't have any test coverage for HNBAP UE registration so far. Let's start with two basic tests: * normal / successful case * abnormal case: UE Register without prior HNB Register Change-Id: Ice2743d376ab8041646259fa25117d6fd0e8c2fd --- M hnbgw/HNBGW_Tests.ttcn M library/hnbap/HNBAP_Templates.ttcn 2 files changed, 232 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/84/36484/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 91677b1..09079db 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -33,6 +33,7 @@ import from TELNETasp_PortType all; import from HNBAP_Templates all; +import from HNBAP_IEs all; import from HNBAP_PDU_Descriptions all; import from RUA_IEs all; @@ -923,6 +924,38 @@ } } +function f_hnbap_ue_register(integer hnb_idx := 0, template (present) UE_Identity ue_id, boolean expect_reject := false) runs on test_CT +{ + timer T := 2.0; + + HNBAP[hnb_idx].send(ts_HNBAP_UERegisterRequest(ue_id)); + + T.start; + alt { + [] HNBAP[hnb_idx].receive(tr_HNBAP_UERegisterAccept(ue_id)) { + if (expect_reject) { + setverdict(fail, "Rx UE Register Accept while expecting reject"); + } else { + setverdict(pass); + } + } + [] HNBAP[hnb_idx].receive(tr_HNBAP_UERegisterReject(ue_id, ?)) { + if (expect_reject) { + setverdict(pass); + } else { + setverdict(fail, "Rx UE Register Reject while expecting accept"); + } + } + [] HNBAP[hnb_idx].receive(IUHEM_Event:?) { + repeat; + } + [] T.timeout { + setverdict(fail, "Timeout waiting for UE Register response"); + } + } +} + + testcase TC_hnb_register() runs on test_CT { g_num_hnbs := 1; f_init(start_hnb := false); @@ -965,6 +998,24 @@ f_shutdown_helper(); } +/* regular UE registration */ +testcase TC_ue_register() runs on test_CT { + var UE_Identity ue_id := { iMSI := imsi_hex2oct(f_gen_imsi(1)) }; + g_num_hnbs := 1; + f_init(start_hnb := true); + f_hnbap_ue_register(0, ue_id); + f_shutdown_helper(); +} + +/* UE registration from unregistered HNB */ +testcase TC_ue_register_before_hnb_register() runs on test_CT { + var UE_Identity ue_id := { iMSI := imsi_hex2oct(f_gen_imsi(1)) }; + g_num_hnbs := 1; + f_init(start_hnb := false); + f_hnbap_ue_register(0, ue_id, expect_reject := true); + f_shutdown_helper(); +} + /*********************************************************************** * RUA / RANAP Testing ***********************************************************************/ diff --git a/library/hnbap/HNBAP_Templates.ttcn b/library/hnbap/HNBAP_Templates.ttcn index 2576d17..7a86e0c 100644 --- a/library/hnbap/HNBAP_Templates.ttcn +++ b/library/hnbap/HNBAP_Templates.ttcn @@ -232,6 +232,172 @@ } } +/* 9.1.6 UE REGISTER REQUEST */ +template (present) HNBAP_PDU +tr_HNBAP_UERegisterRequest(template (present) UE_Identity ue_id) := { + initiatingMessage := { + procedureCode := id_UERegister, + criticality := reject, + value_ := { + uERegisterRequest := { + protocolIEs := { + { + id := HNBAP_Constants.id_UE_Identity, + criticality := reject, + value_ := { UE_Identity := ue_id } + }, { + id := HNBAP_Constants.id_Registration_Cause, + criticality := ignore, + value_ := { Registration_Cause := normal } + }, { + id := HNBAP_Constants.id_UE_Capabilities, + criticality := ignore, + value_ := { + UE_Capabilities := { + access_stratum_release_indicator := ?, + csg_capability := ? + } + } + } + }, + protocolExtensions := * /* TODO: CriticalityDiagnostics, BackoffTimer */ + } + } + } +} + +template (value) HNBAP_PDU +ts_HNBAP_UERegisterRequest(template (value) UE_Identity ue_id) := { + initiatingMessage := { + procedureCode := id_UERegister, + criticality := reject, + value_ := { + uERegisterRequest := { + protocolIEs := { + { + id := HNBAP_Constants.id_UE_Identity, + criticality := reject, + value_ := { UE_Identity := ue_id } + }, { + id := HNBAP_Constants.id_Registration_Cause, + criticality := ignore, + value_ := { Registration_Cause := normal } + }, { + id := HNBAP_Constants.id_UE_Capabilities, + criticality := ignore, + value_ := { + UE_Capabilities := { + access_stratum_release_indicator := rel_8_and_beyond, + csg_capability := not_csg_capable, + iE_Extensions := omit + } + } + } + }, + protocolExtensions := omit /* TODO: CriticalityDiagnostics, BackoffTimer */ + } + } + } +} + +/* 9.1.7 UE REGISTER ACCEPT */ +template (present) HNBAP_PDU +tr_HNBAP_UERegisterAccept(template (present) UE_Identity ue_id) := { + successfulOutcome := { + procedureCode := id_UERegister, + criticality := reject, + value_ := { + uERegisterAccept := { + protocolIEs := { + { + id := HNBAP_Constants.id_UE_Identity, + criticality := reject, + value_ := { UE_Identity := ue_id } + }, { + id := HNBAP_Constants.id_Context_ID, + criticality := reject, + value_ := { Context_ID := ? } + }, * + }, + protocolExtensions := * /* TODO: CriticalityDiagnostics, BackoffTimer */ + } + } + } +} + +template (value) HNBAP_PDU +ts_HNBAP_UERegisterAccept(template (value) UE_Identity ue_id, + template (value) BIT24 context_id) := { + successfulOutcome := { + procedureCode := id_UERegister, + criticality := reject, + value_ := { + uERegisterAccept := { + protocolIEs := { + { + id := HNBAP_Constants.id_UE_Identity, + criticality := reject, + value_ := { UE_Identity := ue_id } + }, { + id := HNBAP_Constants.id_Context_ID, + criticality := reject, + value_ := { Context_ID := context_id } + } + }, + protocolExtensions := omit /* TODO: CriticalityDiagnostics, BackoffTimer */ + } + } + } +} + +/* 9.1.8 UE REGISTER REJECT */ +template (present) HNBAP_PDU +tr_HNBAP_UERegisterReject(template (present) UE_Identity ue_id, template (present) Cause cause := ?) := { + unsuccessfulOutcome := { + procedureCode := id_UERegister, + criticality := reject, + value_ := { + uERegisterReject := { + protocolIEs := { + { + id := HNBAP_Constants.id_UE_Identity, + criticality := reject, + value_ := { UE_Identity := ue_id } + }, { + id := HNBAP_Constants.id_Cause, + criticality := ignore, + value_ := { Cause := cause } + }, * + }, + protocolExtensions := * /* TODO: CriticalityDiagnostics, BackoffTimer */ + } + } + } +} +template (value) HNBAP_PDU +ts_HNBAP_UERegisterReject(template (value) UE_Identity ue_id, template (value) Cause cause) := { + unsuccessfulOutcome := { + procedureCode := id_UERegister, + criticality := reject, + value_ := { + uERegisterReject := { + protocolIEs := { + { + id := HNBAP_Constants.id_UE_Identity, + criticality := reject, + value_ := { UE_Identity := ue_id } + }, { + id := HNBAP_Constants.id_Cause, + criticality := ignore, + value_ := { Cause := cause } + } + }, + protocolExtensions := omit /* TODO: CriticalityDiagnostics, BackoffTimer */ + } + } + } +} + /* 9.1.9 HNB DE-REGISTER */ template (value) HNBAP_PDU ts_HNBAP_HNBDe_Register(template (value) Cause cause) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice2743d376ab8041646259fa25117d6fd0e8c2fd Gerrit-Change-Number: 36484 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Qualify RAC/LAI/SAI to RANAP_IEs module

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36483?usp=email ) Change subject: hnbgw: Qualify RAC/LAI/SAI to RANAP_IEs module ...................................................................... hnbgw: Qualify RAC/LAI/SAI to RANAP_IEs module This is in preparation of importing HNBAP_IEs which introduces types of the same name. Change-Id: I2fb7ca8dfc2011c727633e795a9d16856825379d --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/36483/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index cd8ac7a..91677b1 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -800,12 +800,12 @@ private function f_build_initial_ue_with_nas(TestHdlrParams pars, octetstring nas) return RANAP_PDU { - var LAI lai := { + var RANAP_IEs.LAI lai := { pLMNidentity := hex2oct(pars.hnb.lai.mcc_mnc), lAC := int2oct(pars.hnb.lai.lac, 2), iE_Extensions := omit }; - var SAI sai := { + var RANAP_IEs.SAI sai := { pLMNidentity := lai.pLMNidentity, lAC := lai.lAC, sAC := int2oct(pars.hnb.sac, 2), @@ -818,7 +818,7 @@ } var template RANAP_PDU ret; if (pars.ps_domain) { - var RAC rac := '00'O; + var RANAP_IEs.RAC rac := '00'O; ret := ts_RANAP_initialUE_PS(lai, rac, sai, nas, sigc_id, grnc_id); } else { ret := ts_RANAP_initialUE_CS(lai, sai, nas, sigc_id, grnc_id); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2fb7ca8dfc2011c727633e795a9d16856825379d Gerrit-Change-Number: 36483 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email ) Change subject: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej() ...................................................................... Patch Set 2: (2 comments) File src/osmo-hnbgw/hnbgw_hnbap.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15469): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481/comment/8c93ee17_7cd64d0d PS2, Line 279: (const char *)ue_id->choice.iMSI.buf, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15469): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481/comment/02102c28_9757617a PS2, Line 279: (const char *)ue_id->choice.iMSI.buf, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b Gerrit-Change-Number: 36481 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 27 Mar 2024 20:49:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()

by laforge

laforge has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email ) Change subject: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej() ...................................................................... HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej() Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/81/36481/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b Gerrit-Change-Number: 36481 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024