Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39028?usp=email )
Change subject: debian/control: libosmo-abis-dev: add missing dep
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39028?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ib7012ffce6ab853396a55d65ae4e48c7409276a4
Gerrit-Change-Number: 39028
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Dec 2024 15:51:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................
Patch Set 2:
(1 comment)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/06fbcfea_47a6… :
PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
> The problem with this is that when you want to run a single test, eg by putting it in PCU_Tests_SNS. […]
But if you want to use it by another test you can set those.
I don't see/understand you point here.
It works and IMHO: make it more clear that those are test input which are more important than other variables
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Dec 2024 15:02:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/39025?usp=email )
Change subject: rebar.lock: update gtplib commit
......................................................................
rebar.lock: update gtplib commit
Let the commit point at the tree that was just rebased, so building
with a newer erlang version on debian unstable is fixed.
Fix for:
[ 619s] ===> Compiling _checkouts/gtplib/src/gtp_packet.erl failed
[ 619s] gtp_packet.erl:252:1: syntax error before: 'maybe'
Related: OS#6661
Change-Id: I44bd92b9d9ca90fe396d85f67a064cba08b3f6c3
---
M rebar.lock
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
lynxis lazus: Looks good to me, approved
diff --git a/rebar.lock b/rebar.lock
index ab13202..cd1bc6e 100644
--- a/rebar.lock
+++ b/rebar.lock
@@ -23,7 +23,7 @@
0},
{<<"gtplib">>,
{git,"https://github.com/osmocom/gtplib",
- {ref,"526a7e5d6ba4e76aaae87c31421f26a71dd79d33"}},
+ {ref,"08781f86f340aeaa4708166bfbeccf754217023e"}},
0},
{<<"lager">>,
{git,"https://github.com/erlang-lager/lager",
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/39025?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I44bd92b9d9ca90fe396d85f67a064cba08b3f6c3
Gerrit-Change-Number: 39025
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/gapk/+/39027?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: debian/control: libosmogapk-dev: add missing dep
......................................................................
debian/control: libosmogapk-dev: add missing dep
libosmogapk.pc.in requires libosmocore and libosmocodec.
Change-Id: I652db0c06164619df0d54055d10f0a5f2b9d7e4e
---
M debian/control
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/27/39027/2
--
To view, visit https://gerrit.osmocom.org/c/gapk/+/39027?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Change-Id: I652db0c06164619df0d54055d10f0a5f2b9d7e4e
Gerrit-Change-Number: 39027
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith.
lynxis lazus has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/39025?usp=email )
Change subject: rebar.lock: update gtplib commit
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
It would be great to use release on our erlang modules so we don't have to depend on the .lock files so much.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/39025?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I44bd92b9d9ca90fe396d85f67a064cba08b3f6c3
Gerrit-Change-Number: 39025
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Dec 2024 14:58:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge, pespin.
lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email )
Change subject: Remove rspro_client.c which is not used anyway
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I3bacae853101a79804553175ebd4482acb188597
Gerrit-Change-Number: 39021
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Dec 2024 14:57:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes