Attention is currently required from: fixeria, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................
Patch Set 2:
(1 comment)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/cf48e1df_1f9f… :
PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
> For me it makes it more clear that those are test input. […]
The problem with this is that when you want to run a single test, eg by putting it in PCU_Tests_SNS.ttcn, you cannot pass parameters this way.
We are not doing this anywhere for such reasons, and I think we shouldn't start now unless this has been properly validated.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 04 Dec 2024 14:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................
PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
After removing a NS-VC via SNS-DEL, the NS-VC shouldn't receive
any further NS PDUs.
Related: OS#6611
Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
---
M pcu/PCU_Tests_SNS.ttcn
1 file changed, 22 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/39011/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................
Patch Set 1:
(2 comments)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/74fdb855_9490… :
PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
> What's the point of adding testcase parameters? […]
For me it makes it more clear that those are test input.
I think you can even set those when starting the test.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/dae6c6d5_c00d… :
PS1, Line 347: setverdict(fail, "Received unexpected NS-ALIVE ACK");
> As the name suggests, `ax_rx_fail_on_any_ns()` already does `setverdict(fail, ... […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Dec 2024 14:47:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>