Attention is currently required from: fixeria, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................
Patch Set 2:
(1 comment)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/4389a2fc_1529… :
PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
> You have to recompile anyways if you want to change it. […]
So if you have in TC_ctrl:
execute( TC_sns_del(tout := 10.0) );
execute( TC_sns_del(tout := 25.0) );
How do they show in the junit xml file? they show with the same name? how do you differentaite them when seeing them in jenkins analytics?
See all the kind of things I'm bringing up which you didn't actually accounted for?
Having different names for same test with different parameters allows for that, instead of passing parameters to it that way.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 04 Dec 2024 17:06:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................
Patch Set 2:
(1 comment)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/3183d6c3_ef5e… :
PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
> But you cannot run such a test from the . […]
You have to recompile anyways if you want to change it.
There isn't even a coding style for ttcn3 in osmocom AFAIK.
This is a style discussion. It would work the same if those are variables within the testcase. There aren't any downsides in function.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Dec 2024 17:02:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: Makefile:am: Improve formatting and order of CFLAGS and LIBS
......................................................................
Makefile:am: Improve formatting and order of CFLAGS and LIBS
Place osmocom libraries in proper dependency order.
Change-Id: Ia766a09103d2216258a83cc98899e6cae4b0351d
---
M src/Makefile.am
M src/bankd/Makefile.am
M src/client/Makefile.am
M src/server/Makefile.am
4 files changed, 74 insertions(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/20/39020/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ia766a09103d2216258a83cc98899e6cae4b0351d
Gerrit-Change-Number: 39020
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................
Patch Set 2:
(1 comment)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/e882b4ca_1554… :
PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
> Yes, same here. I don't get your point, what is wrong here. […]
But you cannot run such a test from the .cfg file, that's my point and the reason why we didn't use this syntax so far.
Hence why we have a *function* implementing the test with params, and then we have a *testcase* calling the function with specific params inside it, so you can run from .cfg file it without recompiling.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 04 Dec 2024 16:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email )
Change subject: Makefile:am: Improve formatting and order of CFLAGS and LIBS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Let me have a deeper look, maybe I did it the wrong way.
It seems in general the linker searches from left to right, and notes unresolved symbols as it goes.
So libs should be placed so that the library that needs symbols must be first, then the library that resolves the symbol.
This is actually more important for static libraries than shared libraries, see:
https://praveenv253.github.io/logs/2014/03/15/log-message-1.htmlhttps://stackoverflow.com/questions/45135/why-does-the-order-in-which-libra…
Some distros like debian and ubuntu started passing -Wl,--as-needed by default, which then require the object files to be passed before the libraries.
According to https://wiki.gentoo.org/wiki/Project:Quality_Assurance/As-needed "Importance of linking order" this is not much of a problem with autoamke since we properly use LDADD instead of LDFLAGS.
See also:
https://wiki.ubuntu.com/OneiricOcelot/ReleaseNotes#GCC_4.6_Toolchainhttps://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--as-neededhttps://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
So I think the problem is actually those places where we pass .o objects in LDADD. There, we need to put the .o files first, and then the libraries in the order mentioned above.
I think it's good to always follow the same order always everywhere to avoid potential problems though.
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ia766a09103d2216258a83cc98899e6cae4b0351d
Gerrit-Change-Number: 39020
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 04 Dec 2024 16:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................
Patch Set 2:
(1 comment)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/cf3ece32_c986… :
PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
> > But if you want to use it by another test you can set those. […]
Yes, same here. I don't get your point, what is wrong here.
So far I get, you would done it different.
I like to have arguments to a test case,
which I find useful and could be converted into a function later if necessary.
The language allows such things.
Further it also allows the following:
```
execute( TC_sns_add_nack() );
- execute( TC_sns_del() );
+ execute( TC_sns_del(tout := 25.0) );
execute( TC_sns_chg_weight() );
```
It feels completely bike shred here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Dec 2024 16:22:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................
Patch Set 2:
(1 comment)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/5da27363_86c4… :
PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
> But if you want to use it by another test you can set those.
Not sure what you mean here. This is a test itself, not a function...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 04 Dec 2024 15:55:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/gapk/+/39027?usp=email )
Change subject: debian/control: libosmogapk-dev: add missing dep
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/gapk/+/39027?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Change-Id: I652db0c06164619df0d54055d10f0a5f2b9d7e4e
Gerrit-Change-Number: 39027
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Dec 2024 15:53:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email )
Change subject: Remove rspro_client.c which is not used anyway
......................................................................
Remove rspro_client.c which is not used anyway
rspro_client.c was already removed ~6 years ago in
511c51313d4b1994eaa5faebcf01e8e24fb8b5a5, so those APIs where not really
implemented and hence used. Remove the header.
Related: OS#5896
Change-Id: I3bacae853101a79804553175ebd4482acb188597
---
M debian/libosmo-rspro-dev.install
M include/osmocom/rspro/Makefile.am
D include/osmocom/rspro/rspro_client.h
3 files changed, 0 insertions(+), 65 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
lynxis lazus: Looks good to me, approved
diff --git a/debian/libosmo-rspro-dev.install b/debian/libosmo-rspro-dev.install
index 5abeb9c..56c5908 100644
--- a/debian/libosmo-rspro-dev.install
+++ b/debian/libosmo-rspro-dev.install
@@ -1,4 +1,3 @@
-usr/include/osmocom/rspro
usr/lib/*/libosmo-rspro*.a
usr/lib/*/libosmo-rspro*.so
usr/lib/*/libosmo-rspro*.la
diff --git a/include/osmocom/rspro/Makefile.am b/include/osmocom/rspro/Makefile.am
index 7549ffb..1943af1 100644
--- a/include/osmocom/rspro/Makefile.am
+++ b/include/osmocom/rspro/Makefile.am
@@ -72,8 +72,3 @@
noinst_HEADERS+=per_decoder.h
noinst_HEADERS+=per_encoder.h
noinst_HEADERS+=per_opentype.h
-
-rspro_HEADERS = \
- rspro_client.h
-
-rsprodir = $(includedir)/osmocom/rspro
diff --git a/include/osmocom/rspro/rspro_client.h b/include/osmocom/rspro/rspro_client.h
deleted file mode 100644
index 76f3da6..0000000
--- a/include/osmocom/rspro/rspro_client.h
+++ /dev/null
@@ -1,59 +0,0 @@
-/* Remote SIM Protocol client */
-
-/* (C) 2018 by Harald Welte <laforge(a)gnumonks.org>
- * All Rights Reserved
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <http://www.gnu.org/licenses/>.
- *
- */
-#pragma once
-
-#include <osmocom/core/timer.h>
-
-/* a loss of RSPRO is considered quite serious, let's try to recover as quickly as
- * possible. Even one new connection attempt per second should be quite acceptable until the link is
- * re-established */
-#define OSMO_RSPRO_CLIENT_RECONNECT_INTERVAL 1
-#define OSMO_RSPRO_CLIENT_PING_INTERVAL 20
-
-struct msgb;
-struct ipa_client_conn;
-struct osmo_rspro_client;
-
-/* Expects message in msg->l2h */
-typedef int (*osmo_rspro_client_read_cb_t)(struct osmo_rspro_client *rsproc, struct msgb *msg);
-
-struct osmo_rspro_client {
- const char *unit_name;
-
- struct ipa_client_conn *link;
- osmo_rspro_client_read_cb_t read_cb;
- void *data;
-
- struct osmo_timer_list ping_timer;
- struct osmo_timer_list connect_timer;
- int is_connected;
- int got_ipa_pong;
-};
-
-struct osmo_rspro_client *osmo_rspro_client_create(void *talloc_ctx,
- const char *unit_name,
- const char *ip_addr,
- unsigned int tcp_port,
- osmo_rspro_client_read_cb_t read_cb);
-
-void osmo_rspro_client_destroy(struct osmo_rspro_client *rsproc);
-int osmo_rspro_client_send(struct osmo_rspro_client *rsproc, struct msgb *msg);
-struct msgb *osmo_rspro_client_msgb_alloc(void);
-
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I3bacae853101a79804553175ebd4482acb188597
Gerrit-Change-Number: 39021
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>