Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34552?usp=email )
Change subject: RTP_Emulation: Log the different failure verdicts before stopping
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
the commit log seems to be a bit different from the patch?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34552?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I177b2f4e56ac89fcab20ba6235bf968ac1873046
Gerrit-Change-Number: 34552
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Sep 2023 14:25:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein, daniel, pespin.
Hello Jenkins Builder, daniel, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: osmo_io: Clean up code
......................................................................
osmo_io: Clean up code
- Remove osmo_io_init() from header, since it has no function definition
- Add osmo_iofd_init() to header
Change-Id: I77f7ae2b211507f420d87c484ec75ee054fceb63
---
M include/osmocom/core/osmo_io.h
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/34524/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I77f7ae2b211507f420d87c484ec75ee054fceb63
Gerrit-Change-Number: 34524
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: daniel, laforge, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34338?usp=email )
Change subject: stream_srv: Fix connection error handling
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
This patch didn't really introduce the (possible) issues I'm addressing here, but I think it would be better if we fixed them while we're at it
File src/stream_srv.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/01098932_6b4c22fa
PS2, Line 489: if (OSMO_UNLIKELY(res <= 0)) {
Why do we not call `osmo_stream_srv_clear_tx_queue()` here, if the connection is dead anyways?
https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/a563c839_25e5d060
PS2, Line 496: if (osmo_iofd_txqueue_len(iofd) == 0)
Can it not happen that messages can't be sent out, so that this condition never holds true? In that case, the connection won't be closed as announced (I think this is a problem without this change, as well).
Also, `osmo_stream_srv_clear_tx_queue()` isn't called anywhere except in `osmo-hnbgw.git:src/osmo-hnbgw/hnbgw.c` on connection restart (or something among those lines) as far as I can tell, so if messages can't be sent out and `OSMO_STREAM_SRV_F_FLUSH_DESTROY` is set, then it looks like we will have some sort of endless loop here.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34338?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I84eea2717f3762830f3f5b115e6fc8545eaa4fd5
Gerrit-Change-Number: 34338
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: arehbein <arehbein(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Sep 2023 14:08:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment