July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-mgw[master]: ASCI: Add new mode for voice group/broadcast call
by jolly 04 Jul '23

04 Jul '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33546 ) Change subject: ASCI: Add new mode for voice group/broadcast call ...................................................................... ASCI: Add new mode for voice group/broadcast call The new mode "confecho" is similar to "sendrecv", except that it also echoes back RTP towards the sender. This is required for voice group or broadcast calls. Talker and listeners use the same timeslot, so that audio must be echoed from the talker to the listeners. It is different from "loopback", because a loopback only echoes back RTP towards the sender, but does not forward audio through the endpoint to the other connections. Also it does not forward RTP from senders of other connections. Because there is no transcoding within the endpoint, only one connection in the mode "confecho" shall receive RTP from the sender. The flags to send and receive RTP are removed from the mode "loopback", because a connection in loopback mode does not send to, nor receive from the endpoint. I just echoes RTP without any forwarding. Change-Id: I0639c663e119d85bef1010c7aa45e2f133a9daf0 --- M include/osmocom/mgcp/mgcp_common.h M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp/mgcp_msg.c M src/libosmo-mgcp/mgcp_protocol.c M tests/mgcp/mgcp_test.c 5 files changed, 36 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/46/33546/1 diff --git a/include/osmocom/mgcp/mgcp_common.h b/include/osmocom/mgcp/mgcp_common.h index 07d8d37..6f0775d 100644 --- a/include/osmocom/mgcp/mgcp_common.h +++ b/include/osmocom/mgcp/mgcp_common.h @@ -46,7 +46,8 @@ MGCP_CONN_RECV_ONLY = 1, MGCP_CONN_SEND_ONLY = 2, MGCP_CONN_RECV_SEND = MGCP_CONN_RECV_ONLY | MGCP_CONN_SEND_ONLY, - MGCP_CONN_LOOPBACK = 4 | MGCP_CONN_RECV_SEND, + MGCP_CONN_LOOPBACK = 4, + MGCP_CONN_CONFECHO = MGCP_CONN_LOOPBACK | MGCP_CONN_RECV_SEND, }; #define MGCP_X_OSMO_IGN_HEADER "X-Osmo-IGN:" diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 78652a1..5df4560 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -1548,6 +1548,7 @@ { MGCP_CONN_RECV_SEND, "sendrecv" }, { MGCP_CONN_SEND_ONLY, "sendonly" }, { MGCP_CONN_RECV_ONLY, "recvonly" }, + { MGCP_CONN_CONFECHO, "confecho" }, { MGCP_CONN_LOOPBACK, "loopback" }, { 0, NULL } }; diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index 26a44c6..a46ffc2 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -75,7 +75,7 @@ } /*! Parse connection mode. - * \param[in] mode as string (recvonly, sendrecv, sendonly or loopback) + * \param[in] mode as string (recvonly, sendrecv, sendonly confecho or loopback) * \param[in] endp pointer to endpoint (only used for log output) * \param[out] associated connection to be modified accordingly * \returns 0 on success, -1 on error */ @@ -100,6 +100,8 @@ conn->mode = MGCP_CONN_RECV_SEND; else if (strcasecmp(mode, "sendonly") == 0) conn->mode = MGCP_CONN_SEND_ONLY; + else if (strcasecmp(mode, "confecho") == 0) + conn->mode = MGCP_CONN_CONFECHO; else if (strcasecmp(mode, "loopback") == 0) conn->mode = MGCP_CONN_LOOPBACK; else { diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 978af42..6223ffa 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1088,7 +1088,7 @@ /* check connection mode setting */ if (conn->conn->mode != MGCP_CONN_LOOPBACK - && conn->conn->mode != MGCP_CONN_RECV_ONLY + && (conn->conn->mode & MGCP_CONN_SEND_ONLY) && osmo_sockaddr_port(&conn->end.addr.u.sa) == 0) { LOGPCONN(_conn, DLMGCP, LOGL_ERROR, "CRCX: selected connection mode type requires an opposite end!\n"); @@ -1296,7 +1296,7 @@ /* check connection mode setting */ if (conn->conn->mode != MGCP_CONN_LOOPBACK - && conn->conn->mode != MGCP_CONN_RECV_ONLY + && (conn->conn->mode & MGCP_CONN_SEND_ONLY) && !mgcp_rtp_end_remote_addr_available(&conn->end)) { LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, "MDCX: selected connection mode type requires an opposite end!\n"); diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index e37bb57..1caa879 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -712,9 +712,8 @@ /* Check that NONE disables all output */ OSMO_ASSERT((MGCP_CONN_NONE & MGCP_CONN_RECV_SEND) == 0); - /* Check that LOOPBACK enables all output */ - OSMO_ASSERT((MGCP_CONN_LOOPBACK & MGCP_CONN_RECV_SEND) == - MGCP_CONN_RECV_SEND); + /* Check that LOOPBACK disables all output */ + OSMO_ASSERT((MGCP_CONN_LOOPBACK & MGCP_CONN_RECV_SEND) == 0); } /* Extract a connection ID from a response and return in conn_id; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0639c663e119d85bef1010c7aa45e2f133a9daf0 Gerrit-Change-Number: 33546 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-mgw[master]: ASCI: Support conference briding with 1..n connections
by jolly 04 Jul '23

04 Jul '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33548 ) Change subject: ASCI: Support conference briding with 1..n connections ...................................................................... ASCI: Support conference briding with 1..n connections An RTP bridge may have 1 or many endpoints. Each endpoint may receive, send or echo audio back. Because transcoding is not supported, it must be assumed that only connection receives RTP in a conference with more than 2 connections. A connection that receives RTP into the endpont will have "send" pointer set to (one of) the other connection that shall send out RTP. All connection that send RTP have "send_next" pointer set to the next or first connection that sends RTP. They are linked in a ring. Regular bridge with two connections: Each connection forwards audio towards the other connection and only towards the other connection. The "send_next" pointers are set to NULL or pointing to the other endpoint. connection A connection B ("sendrecv") ("sendrecv") conn->send ---------------------------> <------------------------------------- conn->send conn->send_next ----------------------> <------------------------------------- conn->send_next Conference bridge with three connections: Each connection forwards audio to itself and also towards all other connection. connection A connection B connection C ("confecho") ("confecho") ("confecho"); conn->send --\ conn->send --\ conn->send --\ <-----------/ <-----------/ <-----------/ conn->send_next --> conn->send_next --> <------------------------------------- conn->send_next The same conference bridge but without echo: Each connection forwards auto to all other connection but not to itself. connection A connection B connection C ("confecho") ("confecho") ("confecho"); conn->send -------> conn->send -------> <------------------------------------- conn->send conn->send_next --> conn->send_next --> <------------------------------------- conn->send_next Change-Id: Ic99a55ab5a3a6170e940403fadd52697e99f2f3a --- M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_trunk.c 5 files changed, 190 insertions(+), 60 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/48/33548/1 diff --git a/include/osmocom/mgcp/mgcp_trunk.h b/include/osmocom/mgcp/mgcp_trunk.h index e608161..7dff2b5 100644 --- a/include/osmocom/mgcp/mgcp_trunk.h +++ b/include/osmocom/mgcp/mgcp_trunk.h @@ -79,6 +79,8 @@ struct mgcp_trunk *mgcp_trunk_by_name(const struct mgcp_config *cfg, const char *epname); int e1_trunk_nr_from_epname(unsigned int *trunk_nr, const char *epname); struct mgcp_trunk *mgcp_trunk_by_line_num(const struct mgcp_config *cfg, unsigned int num); +int mgcp_trunk_connect(struct mgcp_endpoint *endp, struct mgcp_conn *exclude_conn); +void mgcp_trunk_endp_update(struct mgcp_endpoint *endp); /* The virtual trunk is always created on trunk id 0 for historical reasons, * use this define constant as ID when allocating a virtual trunk. Other diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index 20088b7..4114cf9 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -629,7 +629,7 @@ /* Allocate resources */ switch (endp->trunk->trunk_type) { case MGCP_TRUNK_VIRTUAL: - /* No updating initaliziation required for virtual endpoints. */ + mgcp_trunk_endp_update(endp); break; case MGCP_TRUNK_E1: mgcp_e1_endp_update(endp); diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 8850670..a03f697 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1292,6 +1292,7 @@ struct mgcp_conn *conn_dst; struct osmo_sockaddr *from_addr = mc->from_addr; char ipbuf[INET6_ADDRSTRLEN]; + int rc = 0; /*! NOTE: This callback function implements the endpoint specific * dispatch behaviour of an rtp bridge/proxy endpoint. It is assumed @@ -1323,36 +1324,25 @@ return mgcp_conn_rtp_dispatch_rtp(conn_src, msg); } - /* Find a destination connection. */ - /* NOTE: This code path runs every time an RTP packet is received. The - * function mgcp_find_dst_conn() we use to determine the detination - * connection will iterate the connection list inside the endpoint. - * Since list iterations are quite costly, we will figure out the - * destination only once and use the optional private data pointer of - * the connection to cache the destination connection pointer. */ - if (!conn->send) { - conn_dst = mgcp_find_dst_conn(conn); - conn->send = conn_dst; - } else { - conn_dst = conn->send; + /* Dispatch RTP packet to destination RTP connection(s). + * Only if reception is enabled and there is at least one destination, + * conn->send is set to that destination. TRP is forwarded to that + * destination. If there are multiple destinations (conference), + * conn->send_next points to the next destination. The loop is executed + * until data is sent to all destinations. If conn->send points to the + * receiving conn (this conn), data is also echoed back to the sender. + * + * The loop terminates if there is no other destination (conn_dst == NULL) + * or if it reaches the originating connection (conn_dst == conn) + * or if it reaches the destination where it started (conn_dst == conn->send). + */ + if ((conn_dst = conn->send)) { + do { + rc = mgcp_conn_rtp_dispatch_rtp(&conn_dst->u.rtp, msg); + conn_dst = conn_dst->send_next; + } while (conn_dst && conn_dst != conn && conn_dst != conn->send); } - - /* There is no destination conn, stop here */ - if (!conn_dst) { - LOGPCONN(conn, DRTP, LOGL_DEBUG, - "no connection to forward an incoming RTP packet to\n"); - return -1; - } - - /* The destination conn is not an RTP connection */ - if (conn_dst->type != MGCP_CONN_TYPE_RTP) { - LOGPCONN(conn, DRTP, LOGL_ERROR, - "unable to find suitable destination conn\n"); - return -1; - } - - /* Dispatch RTP packet to destination RTP connection */ - return mgcp_conn_rtp_dispatch_rtp(&conn_dst->u.rtp, msg); + return rc; } /*! dispatch incoming RTP packet to E1 subslot, handle RTCP packets locally. @@ -1397,18 +1387,8 @@ * \param[in] conn Connection that is about to be removed (ignored). */ void mgcp_cleanup_rtp_bridge_cb(struct mgcp_endpoint *endp, struct mgcp_conn *conn) { - struct mgcp_conn *conn_cleanup; - - /* In mgcp_dispatch_rtp_bridge_cb() we use conn->priv to cache the - * pointer to the destination connection, so that we do not have - * to go through the list every time an RTP packet arrives. To prevent - * a use-after-free situation we invalidate this information for all - * connections present when one connection is removed from the - * endpoint. */ - llist_for_each_entry(conn_cleanup, &endp->conns, entry) { - if (conn_cleanup->send == conn) - conn_cleanup->send = NULL; - } + /* Restructure connections with this connection excluded. */ + mgcp_trunk_connect(endp, conn); } /*! cleanup an endpoint when a connection on an E1 endpoint is removed. diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 6223ffa..c4149ab 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -966,24 +966,6 @@ return create_err_response(endp, endp, 517, "CRCX", pdata->trans); } - /* Check if we are able to accept the creation of another connection */ - if (llist_count(&endp->conns) >= endp->type->max_conns) { - LOGPENDP(endp, DLMGCP, LOGL_ERROR, - "CRCX: endpoint full, max. %i connections allowed!\n", - endp->type->max_conns); - if (trunk->force_realloc) { - /* There is no more room for a connection, make some - * room by blindly tossing the oldest of the two two - * connections */ - mgcp_conn_free_oldest(endp); - } else { - /* There is no more room for a connection, leave - * everything as it is and return with an error */ - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_LIMIT_EXCEEDED)); - return create_err_response(endp, endp, 540, "CRCX", pdata->trans); - } - } - /* Check if this endpoint already serves a call, if so, check if the * callids match up so that we are sure that this is our call */ if (endp->callid && mgcp_verify_call_id(endp, callid)) { diff --git a/src/libosmo-mgcp/mgcp_trunk.c b/src/libosmo-mgcp/mgcp_trunk.c index 69750f8..da685e1 100644 --- a/src/libosmo-mgcp/mgcp_trunk.c +++ b/src/libosmo-mgcp/mgcp_trunk.c @@ -24,6 +24,7 @@ #include <osmocom/mgcp/mgcp.h> #include <osmocom/mgcp/mgcp_protocol.h> #include <osmocom/mgcp/mgcp_endp.h> +#include <osmocom/mgcp/mgcp_conn.h> #include <osmocom/mgcp/mgcp_trunk.h> #include <osmocom/mgcp/mgcp_e1.h> #include <osmocom/abis/e1_input.h> @@ -306,3 +307,115 @@ return NULL; } + +/* Interconnect payload of connections depending on their mode. + * Optionally exclude a connection that shall be removed from the endpoint. + * + * A connection that receives RTP into the endpont will have "send" pointer + * set to (one of) the other connection that shall send out RTP. + * + * All connection that send RTP have "send_next" pointer set to the next + * or first connection that sends RTP. They are linked in a ring. + * + * Regular bridge with two connections: Each connection forwards audio + * towards the other connection and only towards the other connection. + * The "send_next" pointers are pointing to the other endpoint. + + * connection A connection B + * ("sendrecv") ("sendrecv") + * conn->send ---------------------------> + * <------------------------------------- conn->send + * conn->send_next ----------------------> + * <------------------------------------- conn->send_next + * + * Conference bridge with three connections: Each connection forwards + * audio to itself and also towards all other connection. + * + * connection A connection B connection C + * ("confecho") ("confecho") ("confecho"); + * conn->send --\ conn->send --\ conn->send --\ + * <-----------/ <-----------/ <-----------/ + * conn->send_next --> + * conn->send_next --> + * <------------------------------------- conn->send_next + * + * The same conference bridge but without echo: Each connection forwards + * auto to all other connection but not to itself. + * + * connection A connection B connection C + * ("confecho") ("confecho") ("confecho"); + * conn->send -------> conn->send -------> + * <------------------------------------- conn->send + * conn->send_next --> + * conn->send_next --> + * <------------------------------------- conn->send_next + * + */ +int mgcp_trunk_connect(struct mgcp_endpoint *endp, struct mgcp_conn *exclude_conn) +{ + struct mgcp_conn *conn = NULL, *first_conn = NULL, *previous_conn, *send_conn; + + /* Link all _sending_ connection in a circular linked list, if there is + * more than one sending endpoint. */ + llist_for_each_entry(conn, &endp->conns, entry) { + if (conn == exclude_conn) + continue; + if (conn->type != MGCP_CONN_TYPE_RTP) + continue; + if (!(conn->mode & MGCP_CONN_SEND_ONLY)) + continue; + if (!first_conn) + first_conn = conn; + else + previous_conn->send_next = conn; + previous_conn = conn; + } + if (first_conn && previous_conn != first_conn) + previous_conn->send_next = first_conn; + + /* Link all _receiving_ connections to a sending connection, if any. + * If the receiving connection also gets looped back what it receives, it is linked to itsef, so that the + * payload is also forwarded to itself. */ + llist_for_each_entry(conn, &endp->conns, entry) { + if (conn == exclude_conn) + continue; + if (conn->type != MGCP_CONN_TYPE_RTP) + continue; + if (!(conn->mode & MGCP_CONN_RECV_ONLY)) + continue; + /* If we are also sending to ourself, our connection is the first sending endpoint. */ + if ((conn->mode & MGCP_CONN_LOOPBACK) && (conn->mode & MGCP_CONN_SEND_ONLY)) + conn->send = conn; + /* If we are not sending to ourself, select the next sending connection in the circular list. */ + else if (conn->send_next) + conn->send = conn->send_next; + /* I case we are not in the ciruclar list, search for the first node in that list. */ + else { + llist_for_each_entry(send_conn, &endp->conns, entry) { + if ((send_conn->mode & MGCP_CONN_SEND_ONLY)) + conn->send = send_conn; + } + } + } + + /* Debug the result. */ + LOGP(DLMGCP, LOGL_DEBUG, "Endpoint %s has the following interconnections:\n", endp->name); + llist_for_each_entry(conn, &endp->conns, entry) { + LOGP(DLMGCP, LOGL_DEBUG, " -> Connection ID %s %s incoming payload.\n", conn->id, + (conn->mode & MGCP_CONN_RECV_ONLY) ? "receives" : "ignores"); + send_conn = conn->send; + while (send_conn) { + LOGP(DLMGCP, LOGL_DEBUG, " Payload is forwarded to ID %s\n", send_conn->id); + send_conn = send_conn->send_next; + if (send_conn == conn || send_conn == conn->send) + break; + } + } + + return 0; +} + +void mgcp_trunk_endp_update(struct mgcp_endpoint *endp) +{ + mgcp_trunk_connect(endp, NULL); +} -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic99a55ab5a3a6170e940403fadd52697e99f2f3a Gerrit-Change-Number: 33548 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: prepare cn pool: add multiple MSCs and SGSNs
by pespin 04 Jul '23

04 Jul '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33480 ) Change subject: hnbgw: prepare cn pool: add multiple MSCs and SGSNs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia29565cabc072de9aa46565b57232e1eda65874f Gerrit-Change-Number: 33480 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jul 2023 10:58:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: stream (cosmetic): Fix osmo_panic log fmts
by laforge 04 Jul '23

04 Jul '23

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33206 ) Change subject: stream (cosmetic): Fix osmo_panic log fmts ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jul 2023 10:42:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: stream (cosmetic): Fix osmo_panic log fmts
by laforge 04 Jul '23

04 Jul '23

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33206 ) Change subject: stream (cosmetic): Fix osmo_panic log fmts ...................................................................... Patch Set 6: (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/7ba191aa_2f81a7c3 PS6, Line 615: cli->state); there's also the __func__ or __FUNCTION__ macro that could be used here. This makes the compiler insert the function name. So something like osmo_panic("%s called with unexpected state %d\n", __func__, cli->state); This way it will work even if the code is refactored, functions are renamed etc. in the future. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jul 2023 10:42:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: PCU_Tests: test NACC procedure with UTRAN and E-UTRAN cell
by laforge 04 Jul '23

04 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540 ) Change subject: PCU_Tests: test NACC procedure with UTRAN and E-UTRAN cell ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idae86a458fd44ac81bab183ed1865b1c1bdbfd66 Gerrit-Change-Number: 33540 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jul 2023 10:41:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify that PacketCellChangeContine contains an ARFCN and ...
by laforge 04 Jul '23

04 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33539 ) Change subject: PCU_Tests: verify that PacketCellChangeContine contains an ARFCN and BSIC ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b8f3312088e3d2bc4b90702485e7c6a8d39f954 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jul 2023 10:40:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: nacc_fsm: Add support for NACC with UTRAN and E-UTRAN cells
by laforge 04 Jul '23

04 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33538 ) Change subject: nacc_fsm: Add support for NACC with UTRAN and E-UTRAN cells ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I96280f0ec5955ed3cb17641bf4118496c929bdac Gerrit-Change-Number: 33538 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jul 2023 10:40:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: Increase PCUIF wqueue size
by laforge 04 Jul '23

04 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33545 ) Change subject: Increase PCUIF wqueue size ...................................................................... Increase PCUIF wqueue size The default of 10 messages introduced recently is too small, specially when using osmo-bts-trx, where clock drifting and CPU scheduling can cause skewing and hence generation of 2-3 FNs (* up to 8 TS) at once, hence filling the PCUIF queue with more than 10 messages in a given moment. Fixes: c938a95e255262f38aae9d4242cc86a87c46d172 Change-Id: I7ababfc6cdf20196889fb542a8040128b3c118b5 --- M include/osmo-bts/bts.h 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified arehbein: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmo-bts/bts.h b/include/osmo-bts/bts.h index dcd8459..296aa0d 100644 --- a/include/osmo-bts/bts.h +++ b/include/osmo-bts/bts.h @@ -137,7 +137,7 @@ char *addr; }; -#define BTS_PCU_SOCK_WQUEUE_LEN_DEFAULT 10 +#define BTS_PCU_SOCK_WQUEUE_LEN_DEFAULT 100 /* One BTS */ struct gsm_bts { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7ababfc6cdf20196889fb542a8040128b3c118b5 Gerrit-Change-Number: 33545 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: Increase PCUIF wqueue size
by laforge 04 Jul '23

04 Jul '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33545 ) Change subject: Increase PCUIF wqueue size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7ababfc6cdf20196889fb542a8040128b3c118b5 Gerrit-Change-Number: 33545 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jul 2023 10:37:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0