July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add mscpool paging tests
by neels 04 Jul '23

04 Jul '23

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33488 to look at the new patch set (#2). Change subject: hnbgw: add mscpool paging tests ...................................................................... hnbgw: add mscpool paging tests Change-Id: If4bbd5c970108b01e8556fa7744ff627db75fb13 --- M hnbgw/HNBGW_Tests.ttcn M library/RAN_Emulation.ttcnpp M library/ranap/RANAP_Templates.ttcn 3 files changed, 172 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/88/33488/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4bbd5c970108b01e8556fa7744ff627db75fb13 Gerrit-Change-Number: 33488 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: f_verify_talloc_count: mtc.stop
by neels 04 Jul '23

04 Jul '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33475 ) Change subject: f_verify_talloc_count: mtc.stop ...................................................................... Patch Set 2: (1 comment) File library/Osmocom_VTY_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33475/comment/2b2e6782_e2f9… PS1, Line 290: setverdict(fail, "talloc count mismatch"); > Misc_Helpers. […] thx! -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id2b29beecf1c0652fb8d75e031e5c0dc9aa27975 Gerrit-Change-Number: 33475 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jul 2023 02:40:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: prepare cn pool: add multiple MSCs and SGSNs
by neels 04 Jul '23

04 Jul '23

Attention is currently required from: neels. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33480 to look at the new patch set (#2). Change subject: hnbgw: prepare cn pool: add multiple MSCs and SGSNs ...................................................................... hnbgw: prepare cn pool: add multiple MSCs and SGSNs Change-Id: Ia29565cabc072de9aa46565b57232e1eda65874f --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/gen_links.sh 2 files changed, 139 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/33480/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia29565cabc072de9aa46565b57232e1eda65874f Gerrit-Change-Number: 33480 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: f_verify_talloc_count: mtc.stop
by neels 04 Jul '23

04 Jul '23

Attention is currently required from: neels. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33475 to look at the new patch set (#2). Change subject: f_verify_talloc_count: mtc.stop ...................................................................... f_verify_talloc_count: mtc.stop If the talloc count matching failed, immediately stop the failed test. It is currently used by BSC_Tests.ttcn, and will soon also be used by HNBGW_Tests.ttcn. These tests were used to uncover memory leaks, and can now remain to guard against new leaks being introduced. Change-Id: Id2b29beecf1c0652fb8d75e031e5c0dc9aa27975 --- M library/Osmocom_VTY_Functions.ttcn 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/33475/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id2b29beecf1c0652fb8d75e031e5c0dc9aa27975 Gerrit-Change-Number: 33475 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: drop dead code from MSC_UnitdataCallback
by neels 04 Jul '23

04 Jul '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33473 ) Change subject: hnbgw: drop dead code from MSC_UnitdataCallback ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Also on RANAP, the HNBGW_Tests.ttcn so far conveniently ignored RANAP RESET handling. Apologies, that is inaccurate, actually the point is that RAN_Emulation handles RESET and hence the UnitdataCallback never had Unitdata messages left to handle. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33473 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7b9022e991b63b945c7ec6e5c9f7c4eb5da4d7e Gerrit-Change-Number: 33473 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jul 2023 02:29:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: drop dead code from MSC_UnitdataCallback
by neels 04 Jul '23

04 Jul '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33473 ) Change subject: hnbgw: drop dead code from MSC_UnitdataCallback ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: OK, I remember now. a) not used: osmo-hnbgw has only recently started sending RANAP UnitData by its own initiative. Until very recently, osmo-hnbgw has only responded to receiving a RESET, with an ACK. It has never sent a RESET message to the peer, here titan. Also on RANAP, the HNBGW_Tests.ttcn so far conveniently ignored RANAP RESET handling. In short, this UnitDataCallback so far never happened. b) makes no sense: The UnitDataCallback happens when osmo-hnbgw sends a RANAP UnitData to titan: so currently, in response to receiving any UnitData message, the code responds with a RESET. That is not logical at all. (What would make sense: when receiving a RESET, respond with RESET ACK. But: Proper handling of RANAP RESET in ttcn actually happens in RAN_Emulation.ttcnpp) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33473 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7b9022e991b63b945c7ec6e5c9f7c4eb5da4d7e Gerrit-Change-Number: 33473 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jul 2023 02:24:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: drop dead code from MSC_UnitdataCallback
by neels 04 Jul '23

04 Jul '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33473 ) Change subject: hnbgw: drop dead code from MSC_UnitdataCallback ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: i was sure the return value was not used, but clearly i was wrong... checking now what's up with this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33473 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7b9022e991b63b945c7ec6e5c9f7c4eb5da4d7e Gerrit-Change-Number: 33473 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jul 2023 00:51:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ctrl: Add rach max delay
by matanp 03 Jul '23

03 Jul '23

matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33541 ) Change subject: ctrl: Add rach max delay ...................................................................... ctrl: Add rach max delay Change-Id: I113211cc7e7ef20fac7e9d30e156522406ad62f7 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 98b79c6..77daa75 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -249,6 +249,7 @@ CTRL_CMD_DEFINE_RANGE(bts_lac, "location-area-code", struct gsm_bts, location_area_code, 0, 65535); CTRL_CMD_DEFINE_RANGE(bts_ci, "cell-identity", struct gsm_bts, cell_identity, 0, 65535); CTRL_CMD_DEFINE_RANGE(bts_bsic, "bsic", struct gsm_bts, bsic, 0, 63); +CTRL_CMD_DEFINE_RANGE(bts_rach_max_delay, "rach-max-delay", struct gsm_bts, rach_max_delay, 1, 127); static int set_bts_apply_config(struct ctrl_cmd *cmd, void *data) { @@ -1047,6 +1048,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_lac); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_ci); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_bsic); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rach_max_delay); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_apply_config); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_power_ctrl_defs); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I113211cc7e7ef20fac7e9d30e156522406ad62f7 Gerrit-Change-Number: 33541 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: ctrl: Add rach max delay
by fixeria 03 Jul '23

03 Jul '23

Attention is currently required from: matanp. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33541 ) Change subject: ctrl: Add rach max delay ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I113211cc7e7ef20fac7e9d30e156522406ad62f7 Gerrit-Change-Number: 33541 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 19:15:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: fix record PCUIF_pch_dt
by fixeria 03 Jul '23

03 Jul '23

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 ) Change subject: PCUIF_Types: fix record PCUIF_pch_dt ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I011eb2496b1422c49736b227dfa1e2a2d6096d67 Gerrit-Change-Number: 33417 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Jul 2023 19:05:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0