Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33553 )
Change subject: WIP: defer going to pkt_idle_timer after freeing TBF
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Posting some of my thoughts from IRC/#osmocom:
```
22:01 < fixeria> are you sure (GSM_TDMA_FN_DURATION_uS*6) /* > 4.615 * 4 */ would be enough?
22:02 < fixeria> there is a lead time before the scheduler is actually starting to Tx the block of 4 bursts
22:03 < fixeria> https://people.osmocom.org/fixeria/pdch.txt -- 10 * 0.577 ms = 5.77 ms
22:04 < fixeria> so GSM_TDMA_FN_DURATION_uS*6 is already cutting it close
```
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33553
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I563ad2ee6aacd65314e998626dc27adc29221a7d
Gerrit-Change-Number: 33553
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Jul 2023 15:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith, neels.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33557 )
Change subject: HNBGW_Tests: use realistic codec name and payload type in MGCP
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Change I08b91c849d810fe3cdb72c0f6f2a558b7377deab adds a check to osmo-mgcp-client that checks the codec description. This means we need to use a valid codec description in the HNBGW testsuite now. (which is an improvement)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib53ff7a878087b497e6ff27f786c9ab1297f3d5f
Gerrit-Change-Number: 33557
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Jul 2023 15:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33557 )
Change subject: HNBGW_Tests: use realistic codec name and payload type in MGCP
......................................................................
HNBGW_Tests: use realistic codec name and payload type in MGCP
When we respond to the MGCP requests from OsmoHNBGW, we use codec name
"FOO" and payload type 23 in the SDP part of the response. This is
obviously an invalid codec and osmo-mgcp-client will not tolerate this
anymore. Let's use a more realistic payload type and codec name, like
112 and "VND.3GPP.IUFP"
Change-Id: Ib53ff7a878087b497e6ff27f786c9ab1297f3d5f
---
M hnbgw/HNBGW_Tests.ttcn
1 file changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/33557/1
diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index e5f227e..f0b5cfe 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -165,8 +165,8 @@
mgw_rtp_port := 20000,
mgcp_connection_id := '22222'H
},
- rtp_payload_type := 23,
- rtp_sdp_format := "FOO",
+ rtp_payload_type := 112,
+ rtp_sdp_format := "VND.3GPP.IUFP",
hnb_rtp_ip := "127.1.1.1",
hnb_rtp_port := 10001,
cn_rtp_ip := "127.1.3.1",
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib53ff7a878087b497e6ff27f786c9ab1297f3d5f
Gerrit-Change-Number: 33557
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33551 )
Change subject: rlcmac: Rework tbf destructor to signal free() to its gre object
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33551
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I72959e27f2f62c84218d740cfb9e396d70562929
Gerrit-Change-Number: 33551
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Jul 2023 14:51:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33511 )
Change subject: ASCI: Add call control for VGCS/VBS
......................................................................
Patch Set 9:
(1 comment)
This change is ready for review.
File src/libmsc/vgcs_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/dd4fedf2_4a3c69bc
PS8, Line 1175: .name =
> Please remove the _fsm suffix from the name of [all] the FSMs. This is redundant. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b
Gerrit-Change-Number: 33511
Gerrit-PatchSet: 9
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 04 Jul 2023 14:03:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment