July 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsm0502.h: Document spec number
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33752 ) Change subject: gsm0502.h: Document spec number ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/gsm0502.h: https://gerrit.osmocom.org/c/libosmocore/+/33752/comment/2e0ee369_6e7ec43e PS1, Line 1: /*! \defgroup gsm0502 GSM 05.02 / 3GPP TS 45.002 A what's this "A"? I'm only aware of TS 45.002 without any suffix? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a3fdde39a4f3927516b9c160c04144764800fda Gerrit-Change-Number: 33752 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:12:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libasn1c[master]: INTEGER: ignore warning for all GCC versions
by laforge 16 Jul '23

16 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libasn1c/+/33739 ) Change subject: INTEGER: ignore warning for all GCC versions ...................................................................... INTEGER: ignore warning for all GCC versions The warning appears again with GCC 12 in Debian 12, causing the build to fail with --enable-werror. GCC 11 did not complain about it. As there are numerous bug reports about this in GCC's bug tracker, just disable it for all GCC versions. Related: adaa1c62e13a9ee8e7b978e6e9f67624f1ea7307 Related: OS#6057 Change-Id: I48d9d423df47f23a0ef3ea727a40b53d70aec48b --- M src/INTEGER.c 1 file changed, 16 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/INTEGER.c b/src/INTEGER.c index 0da24ad..1e62b2c 100644 --- a/src/INTEGER.c +++ b/src/INTEGER.c @@ -1336,16 +1336,12 @@ } break; } -#if __GNUC__ == 10 #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Warray-bounds" -#endif /* Copy the integer body */ for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) *bp++ = *p; -#if __GNUC__ == 10 #pragma GCC diagnostic pop -#endif if(st->buf) FREEMEM(st->buf); st->buf = buf; @@ -1398,16 +1394,12 @@ } break; } -#if __GNUC__ == 10 #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Warray-bounds" -#endif /* Copy the integer body */ for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) *bp++ = *p; -#if __GNUC__ == 10 #pragma GCC diagnostic pop -#endif if(st->buf) FREEMEM(st->buf); st->buf = buf; -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/33739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I48d9d423df47f23a0ef3ea727a40b53d70aec48b Gerrit-Change-Number: 33739 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libasn1c[master]: INTEGER: ignore warning for all GCC versions
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/33739 ) Change subject: INTEGER: ignore warning for all GCC versions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/33739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I48d9d423df47f23a0ef3ea727a40b53d70aec48b Gerrit-Change-Number: 33739 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:11:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: src/rspro: fix misleading indentations
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33733 ) Change subject: src/rspro: fix misleading indentations ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: this is code generated by asn1c, we shouldn't manually re-format generated code. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icc2e8da7232a93b04ac8f23800380ca9317bd60f Gerrit-Change-Number: 33733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:11:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-mme-test-ogs
by laforge 16 Jul '23

16 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33688 ) Change subject: jobs/ttcn3: add ttcn3-mme-test-ogs ...................................................................... jobs/ttcn3: add ttcn3-mme-test-ogs Related: OS#5760 Related: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-mme-test-ogs Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 --- M jobs/ttcn3-testsuites.yml 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved; Verified diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 0503a54..14e1d6f 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -121,6 +121,11 @@ description: | Test open5gs-smfd + open5gs-upfd PGW main. email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com + - ttcn3-mme-test-ogs: + timer: 15 14 * * * + description: | + Test open5gs-mme + email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com # debian latest stable - nplab-m3ua-test-latest: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 Gerrit-Change-Number: 33688 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-mme-test-ogs
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: osmith, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33688 ) Change subject: jobs/ttcn3: add ttcn3-mme-test-ogs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 Gerrit-Change-Number: 33688 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:10:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ci[master]: jobs: master/gerrit: use debian bookworm (12)
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33744 ) Change subject: jobs: master/gerrit: use debian bookworm (12) ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/33744/comment/bac2ba37_e62b8c2f PS1, Line 22: will still notice if a build breaks on an older debian release. but only quite late once it has already merged and starts to break the package feeds for the general public, right? https://gerrit.osmocom.org/c/osmo-ci/+/33744/comment/fab46324_cda4d034 PS1, Line 26: deb-build verification test I guess it makes sense to try to add a build on the "oldest currently supported distro verison"? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I079e55a1325083714c8d39f922b2563e843fc0bc Gerrit-Change-Number: 33744 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:10:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-mme-test-ogs
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: osmith, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33688 ) Change subject: jobs/ttcn3: add ttcn3-mme-test-ogs ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 Gerrit-Change-Number: 33688 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:08:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: Document tx_pch empty IMSI scenario
by laforge 16 Jul '23

16 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33756 ) Change subject: pcu_l1_if: Document tx_pch empty IMSI scenario ...................................................................... pcu_l1_if: Document tx_pch empty IMSI scenario Related: OS#6097 Change-Id: I327ca0e0f53be2d9b2a0705fe4de600229bdc5f9 --- M src/pcu_l1_if.cpp 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index a256962..f42a3d4 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -275,6 +275,16 @@ else memset(data, '0', IMSI_DIGITS_FOR_PAGING); + /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX + * mode (TS 44.060 5.5.1.5) and hence it is listening on all CCCH blocks + * (TS 45.002 6.5.3, 6.5.6). + * Hence, pgroup 000 is taken "randomly" to send it over it. This of + * course not optimal since it can actually be sent on any CCCH blocks, + * so we are delaying the ImmAss for no good reason. But anyway, + * pcu_l1if_tx_pch() is deprecated and pcu_l1if_tx_pch_dt() should be + * used instead, which doesn't suffer from this problem. + */ + /* block provided by upper layer comes without first byte (plen), prepend it manually: */ OSMO_ASSERT(sizeof(data) >= IMSI_DIGITS_FOR_PAGING + 1 + block->data_len); data[IMSI_DIGITS_FOR_PAGING] = (plen << 2) | 0x01; @@ -297,6 +307,10 @@ pch_dt.tlli = tlli; if (imsi) OSMO_STRLCPY_ARRAY(pch_dt.imsi, imsi); + /* OS#6097: if strlen(pch_dt.imsi) == 0: We assume the MS is in non-DRX + * mode (TS 44.060 5.5.1.5) and hence it is listening on all CCCH blocks + * (TS 45.002 6.5.3, 6.5.6). + */ pch_dt.data[0] = (plen << 2) | 0x01; bitvec_pack(block, pch_dt.data + 1); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I327ca0e0f53be2d9b2a0705fe4de600229bdc5f9 Gerrit-Change-Number: 33756 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: Document tx_pch empty IMSI scenario
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33756 ) Change subject: pcu_l1_if: Document tx_pch empty IMSI scenario ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I327ca0e0f53be2d9b2a0705fe4de600229bdc5f9 Gerrit-Change-Number: 33756 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:07:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0