July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-e1-recorder[master]: configure.ac: migrate from python2 to python3
by pespin 14 Jul '23

14 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33759 ) Change subject: configure.ac: migrate from python2 to python3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ib293c60cf66000b3e2520f7a02f39c4baa1c5ce9 Gerrit-Change-Number: 33759 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 18:00:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1-recorder[master]: configure.ac: migrate from python2 to python3
by fixeria 14 Jul '23

14 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33759 ) Change subject: configure.ac: migrate from python2 to python3 ...................................................................... configure.ac: migrate from python2 to python3 Fortunatelly we don't have any python2 specific code, so just bump. Change-Id: Ib293c60cf66000b3e2520f7a02f39c4baa1c5ce9 --- M configure.ac M osmoappdesc.py 2 files changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-recorder refs/changes/59/33759/1 diff --git a/configure.ac b/configure.ac index 568584d..3effcde 100644 --- a/configure.ac +++ b/configure.ac @@ -110,9 +110,9 @@ [Include the VTY/CTRL tests in make check [default=no]]), [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) if test "x$enable_ext_tests" = "xyes" ; then - AC_CHECK_PROG(PYTHON2_AVAIL,python2,yes) - if test "x$PYTHON2_AVAIL" != "xyes" ; then - AC_MSG_ERROR([Please install python2 to run the VTY/CTRL tests.]) + AC_CHECK_PROG(PYTHON3_AVAIL,python3,yes) + if test "x$PYTHON3_AVAIL" != "xyes" ; then + AC_MSG_ERROR([Please install python3 to run the VTY/CTRL tests.]) fi AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmotestvty.py,yes) if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then diff --git a/osmoappdesc.py b/osmoappdesc.py index 485a83b..56df5bc 100644 --- a/osmoappdesc.py +++ b/osmoappdesc.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 app_configs = { "osmo-e1-recorder": ["doc/examples/osmo-e1-recorder.cfg"] -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ib293c60cf66000b3e2520f7a02f39c4baa1c5ce9 Gerrit-Change-Number: 33759 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-smlc[master]: configure.ac: migrate from python2 to python3
by fixeria 14 Jul '23

14 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/33758 ) Change subject: configure.ac: migrate from python2 to python3 ...................................................................... configure.ac: migrate from python2 to python3 Fortunatelly we don't have any python2 specific code, so just bump. Change-Id: Iaab94a1e896b78dc8699256e326edc165b0ed922 Related: OS#5950 --- M configure.ac 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/58/33758/1 diff --git a/configure.ac b/configure.ac index 65ebd59..484d689 100644 --- a/configure.ac +++ b/configure.ac @@ -117,9 +117,9 @@ [Include the VTY/CTRL tests in make check [default=no]]), [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) if test "x$enable_ext_tests" = "xyes" ; then - AC_CHECK_PROG(PYTHON2_AVAIL,python2,yes) - if test "x$PYTHON2_AVAIL" != "xyes" ; then - AC_MSG_ERROR([Please install python2 to run the VTY/CTRL tests.]) + AC_CHECK_PROG(PYTHON3_AVAIL,python3,yes) + if test "x$PYTHON3_AVAIL" != "xyes" ; then + AC_MSG_ERROR([Please install python3 to run the VTY/CTRL tests.]) fi AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmotestvty.py,yes) if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/33758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Iaab94a1e896b78dc8699256e326edc165b0ed922 Gerrit-Change-Number: 33758 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: oc2g: Fix multiple definitions of arrays
by pespin 14 Jul '23

14 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33757 ) Change subject: oc2g: Fix multiple definitions of arrays ...................................................................... oc2g: Fix multiple definitions of arrays These errors started appearing lately when upgrading builders to debian12, with a newer gcc version. Change-Id: I0046a6f4fb3979710b4cd5222de599d9aaac227b --- M src/osmo-bts-oc2g/oc2gbts.h 1 file changed, 22 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/57/33757/1 diff --git a/src/osmo-bts-oc2g/oc2gbts.h b/src/osmo-bts-oc2g/oc2gbts.h index 24deae7..ea17b2d 100644 --- a/src/osmo-bts-oc2g/oc2gbts.h +++ b/src/osmo-bts-oc2g/oc2gbts.h @@ -23,24 +23,24 @@ }; enum l1prim_type oc2gbts_get_l1prim_type(GsmL1_PrimId_t id); -const struct value_string oc2gbts_l1prim_names[GsmL1_PrimId_NUM+1]; +extern const struct value_string oc2gbts_l1prim_names[GsmL1_PrimId_NUM+1]; GsmL1_PrimId_t oc2gbts_get_l1prim_conf(GsmL1_PrimId_t id); enum l1prim_type oc2gbts_get_sysprim_type(Oc2g_PrimId_t id); -const struct value_string oc2gbts_sysprim_names[Oc2g_PrimId_NUM+1]; +extern const struct value_string oc2gbts_sysprim_names[Oc2g_PrimId_NUM+1]; Oc2g_PrimId_t oc2gbts_get_sysprim_conf(Oc2g_PrimId_t id); -const struct value_string oc2gbts_l1sapi_names[GsmL1_Sapi_NUM+1]; -const struct value_string oc2gbts_l1status_names[GSML1_STATUS_NUM+1]; +extern const struct value_string oc2gbts_l1sapi_names[GsmL1_Sapi_NUM+1]; +extern const struct value_string oc2gbts_l1status_names[GSML1_STATUS_NUM+1]; -const struct value_string oc2gbts_tracef_names[29]; -const struct value_string oc2gbts_tracef_docs[29]; +extern const struct value_string oc2gbts_tracef_names[29]; +extern const struct value_string oc2gbts_tracef_docs[29]; -const struct value_string oc2gbts_tch_pl_names[15]; +extern const struct value_string oc2gbts_tch_pl_names[15]; -const struct value_string oc2gbts_clksrc_names[10]; +extern const struct value_string oc2gbts_clksrc_names[10]; -const struct value_string oc2gbts_dir_names[6]; +extern const struct value_string oc2gbts_dir_names[6]; enum pdch_cs { PDCH_CS_1, @@ -59,6 +59,6 @@ _NUM_PDCH_CS }; -const uint8_t pdch_msu_size[_NUM_PDCH_CS]; +extern const uint8_t pdch_msu_size[_NUM_PDCH_CS]; #endif /* LC15BTS_H */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0046a6f4fb3979710b4cd5222de599d9aaac227b Gerrit-Change-Number: 33757 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-mme-test-ogs
by fixeria 14 Jul '23

14 Jul '23

Attention is currently required from: osmith, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33688 ) Change subject: jobs/ttcn3: add ttcn3-mme-test-ogs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 Gerrit-Change-Number: 33688 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 17:40:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: Document tx_pch empty IMSI scenario
by pespin 14 Jul '23

14 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33756 ) Change subject: pcu_l1_if: Document tx_pch empty IMSI scenario ...................................................................... pcu_l1_if: Document tx_pch empty IMSI scenario Related: OS#6097 Change-Id: I327ca0e0f53be2d9b2a0705fe4de600229bdc5f9 --- M src/pcu_l1_if.cpp 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/56/33756/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index a256962..f42a3d4 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -275,6 +275,16 @@ else memset(data, '0', IMSI_DIGITS_FOR_PAGING); + /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX + * mode (TS 44.060 5.5.1.5) and hence it is listening on all CCCH blocks + * (TS 45.002 6.5.3, 6.5.6). + * Hence, pgroup 000 is taken "randomly" to send it over it. This of + * course not optimal since it can actually be sent on any CCCH blocks, + * so we are delaying the ImmAss for no good reason. But anyway, + * pcu_l1if_tx_pch() is deprecated and pcu_l1if_tx_pch_dt() should be + * used instead, which doesn't suffer from this problem. + */ + /* block provided by upper layer comes without first byte (plen), prepend it manually: */ OSMO_ASSERT(sizeof(data) >= IMSI_DIGITS_FOR_PAGING + 1 + block->data_len); data[IMSI_DIGITS_FOR_PAGING] = (plen << 2) | 0x01; @@ -297,6 +307,10 @@ pch_dt.tlli = tlli; if (imsi) OSMO_STRLCPY_ARRAY(pch_dt.imsi, imsi); + /* OS#6097: if strlen(pch_dt.imsi) == 0: We assume the MS is in non-DRX + * mode (TS 44.060 5.5.1.5) and hence it is listening on all CCCH blocks + * (TS 45.002 6.5.3, 6.5.6). + */ pch_dt.data[0] = (plen << 2) | 0x01; bitvec_pack(block, pch_dt.data + 1); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I327ca0e0f53be2d9b2a0705fe4de600229bdc5f9 Gerrit-Change-Number: 33756 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: SI13: Set DRX_TIMER_MAX value actually transmitted
by fixeria 14 Jul '23

14 Jul '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33754 ) Change subject: SI13: Set DRX_TIMER_MAX value actually transmitted ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf01a50b258e197ba5e3173492513349ddffdb38 Gerrit-Change-Number: 33754 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 17:07:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than pos...
by pespin 14 Jul '23

14 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33755 ) Change subject: cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than possible range ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not actually sure whether that NOTE means the value should be >=4 or actually <=4 .... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c8699bb5357a74805c25e8d02e982b25b47555d Gerrit-Change-Number: 33755 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 17:03:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than pos...
by pespin 14 Jul '23

14 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33755 ) Change subject: cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than possible range ...................................................................... cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than possible range Related: OS#6097 Change-Id: I5c8699bb5357a74805c25e8d02e982b25b47555d --- M src/osmo-bsc/system_information.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/55/33755/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 9ed77f9..461f86a 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1244,6 +1244,8 @@ .nmo = GPRS_NMO_II, .t3168 = 2000, .t3192 = 1500, + /* 3GPP TS 45.002 6.5.6: + * "On BCCH, the operator should limit DRX_TIMER_MAX [...] to 4 seconds" */ .drx_timer_max = 4, .bs_cv_max = 15, .ctrl_ack_type_use_block = bts->gprs.ctrl_ack_type_use_block, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c8699bb5357a74805c25e8d02e982b25b47555d Gerrit-Change-Number: 33755 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: SI13: Set DRX_TIMER_MAX value actually transmitted
by pespin 14 Jul '23

14 Jul '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33754 to look at the new patch set (#3). Change subject: SI13: Set DRX_TIMER_MAX value actually transmitted ...................................................................... SI13: Set DRX_TIMER_MAX value actually transmitted The set of values in seconds which can be expressed in the 3-bit field DRX_TIMER_MAX (0s, 1s, 2s, 4s,...64s) don't include the "3s" that where being specified. Instead, libosmocore's encode_drx_timer() was taking both upper boundary "4s" and encoding it "0b011". Hence, better write the value actually being transmitted to MS, to avoid users/readers confusion. More related info can be found on TS 44.060 Table 12.24.2 and TS 45.002 6.5.6. Related: OS#6097 Change-Id: Ibf01a50b258e197ba5e3173492513349ddffdb38 --- M src/osmo-bsc/system_information.c 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/33754/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf01a50b258e197ba5e3173492513349ddffdb38 Gerrit-Change-Number: 33754 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0