July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: gmm: Update DRX params during rx RAU REQ
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: fixeria, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/33753 ) Change subject: gmm: Update DRX params during rx RAU REQ ...................................................................... Patch Set 1: (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/33753/comment/0be65c6a_3c7a2b0a PS1, Line 1770: TLVP_PRESENT > Don't we need to check the length before copying `sizeof(mmctx->drx_parms)` bytes? TLVP_PRES_LEN could possibly be used. Or the code in libosmocore that defines minimumg length for each IE, as well as permitted/required IEs and which would then be called once before passing any messages further down into various handling functions which then can all rely on the guarantees provided by the shared/common validation. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/33753 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1dd7f8f161280dd017c337eacc3aa2be4ccd65ea Gerrit-Change-Number: 33753 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:07:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: SI13: Set DRX_TIMER_MAX value actually transmitted
by laforge 16 Jul '23

16 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33754 ) Change subject: SI13: Set DRX_TIMER_MAX value actually transmitted ...................................................................... SI13: Set DRX_TIMER_MAX value actually transmitted The set of values in seconds which can be expressed in the 3-bit field DRX_TIMER_MAX (0s, 1s, 2s, 4s,...64s) don't include the "3s" that where being specified. Instead, libosmocore's encode_drx_timer() was taking both upper boundary "4s" and encoding it "0b011". Hence, better write the value actually being transmitted to MS, to avoid users/readers confusion. More related info can be found on TS 44.060 Table 12.24.2 and TS 45.002 6.5.6. Related: OS#6097 Change-Id: Ibf01a50b258e197ba5e3173492513349ddffdb38 --- M src/osmo-bsc/system_information.c 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 35fce68..9ed77f9 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1244,7 +1244,7 @@ .nmo = GPRS_NMO_II, .t3168 = 2000, .t3192 = 1500, - .drx_timer_max = 3, + .drx_timer_max = 4, .bs_cv_max = 15, .ctrl_ack_type_use_block = bts->gprs.ctrl_ack_type_use_block, .ext_info_present = true, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf01a50b258e197ba5e3173492513349ddffdb38 Gerrit-Change-Number: 33754 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than pos...
by laforge 16 Jul '23

16 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33755 ) Change subject: cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than possible range ...................................................................... cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than possible range Related: OS#6097 Change-Id: I5c8699bb5357a74805c25e8d02e982b25b47555d --- M src/osmo-bsc/system_information.c 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 9ed77f9..461f86a 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1244,6 +1244,8 @@ .nmo = GPRS_NMO_II, .t3168 = 2000, .t3192 = 1500, + /* 3GPP TS 45.002 6.5.6: + * "On BCCH, the operator should limit DRX_TIMER_MAX [...] to 4 seconds" */ .drx_timer_max = 4, .bs_cv_max = 15, .ctrl_ack_type_use_block = bts->gprs.ctrl_ack_type_use_block, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c8699bb5357a74805c25e8d02e982b25b47555d Gerrit-Change-Number: 33755 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than pos...
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33755 ) Change subject: cosmetic: Document DRX_TIMER_MAX upper limit on BCCH smaller than possible range ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c8699bb5357a74805c25e8d02e982b25b47555d Gerrit-Change-Number: 33755 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:06:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: SI13: Set DRX_TIMER_MAX value actually transmitted
by laforge 16 Jul '23

16 Jul '23

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33754 ) Change subject: SI13: Set DRX_TIMER_MAX value actually transmitted ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf01a50b258e197ba5e3173492513349ddffdb38 Gerrit-Change-Number: 33754 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:05:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: change 'Received bad data' back to LOGL_DEBUG
by fixeria 15 Jul '23

15 Jul '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33760 ) Change subject: osmo-bts-trx: change 'Received bad data' back to LOGL_DEBUG ...................................................................... osmo-bts-trx: change 'Received bad data' back to LOGL_DEBUG In f2c902c2 I accidentally bumped the logging level for PDCH decoding errors to LOGL_NOTICE, making osmo-bts-trx spam the logging with hundreds of 'Received bad data' messsages. Revert this. Change-Id: Idb963f1a779dfa172825f6d481740cb0c4165485 Fixes: f2c902c2 "osmo-bts-trx: unify and enrich 'Received bad data' logging" --- M src/osmo-bts-trx/sched_lchan_pdtch.c 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/sched_lchan_pdtch.c b/src/osmo-bts-trx/sched_lchan_pdtch.c index 1720537..9f7c314 100644 --- a/src/osmo-bts-trx/sched_lchan_pdtch.c +++ b/src/osmo-bts-trx/sched_lchan_pdtch.c @@ -122,7 +122,7 @@ if (rc > 0) { presence_info = PRES_INFO_BOTH; } else { - LOGL1SB(DL1P, LOGL_NOTICE, l1ts, bi, + LOGL1SB(DL1P, LOGL_DEBUG, l1ts, bi, BAD_DATA_MSG_FMT "\n", BAD_DATA_MSG_ARGS); rc = 0; presence_info = PRES_INFO_INVALID; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idb963f1a779dfa172825f6d481740cb0c4165485 Gerrit-Change-Number: 33760 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: change 'Received bad data' back to LOGL_DEBUG
by pespin 15 Jul '23

15 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33760 ) Change subject: osmo-bts-trx: change 'Received bad data' back to LOGL_DEBUG ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idb963f1a779dfa172825f6d481740cb0c4165485 Gerrit-Change-Number: 33760 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jul 2023 00:15:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: change 'Received bad data' back to LOGL_DEBUG
by fixeria 14 Jul '23

14 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33760 ) Change subject: osmo-bts-trx: change 'Received bad data' back to LOGL_DEBUG ...................................................................... osmo-bts-trx: change 'Received bad data' back to LOGL_DEBUG In f2c902c2 I accidentally bumped the logging level for PDCH decoding errors to LOGL_NOTICE, making osmo-bts-trx spam the logging with hundreds of 'Received bad data' messsages. Revert this. Change-Id: Idb963f1a779dfa172825f6d481740cb0c4165485 Fixes: f2c902c2 "osmo-bts-trx: unify and enrich 'Received bad data' logging" --- M src/osmo-bts-trx/sched_lchan_pdtch.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/60/33760/1 diff --git a/src/osmo-bts-trx/sched_lchan_pdtch.c b/src/osmo-bts-trx/sched_lchan_pdtch.c index 1720537..9f7c314 100644 --- a/src/osmo-bts-trx/sched_lchan_pdtch.c +++ b/src/osmo-bts-trx/sched_lchan_pdtch.c @@ -122,7 +122,7 @@ if (rc > 0) { presence_info = PRES_INFO_BOTH; } else { - LOGL1SB(DL1P, LOGL_NOTICE, l1ts, bi, + LOGL1SB(DL1P, LOGL_DEBUG, l1ts, bi, BAD_DATA_MSG_FMT "\n", BAD_DATA_MSG_ARGS); rc = 0; presence_info = PRES_INFO_INVALID; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idb963f1a779dfa172825f6d481740cb0c4165485 Gerrit-Change-Number: 33760 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-smlc[master]: configure.ac: migrate from python2 to python3
by fixeria 14 Jul '23

14 Jul '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/33758 ) Change subject: configure.ac: migrate from python2 to python3 ...................................................................... configure.ac: migrate from python2 to python3 Fortunatelly we don't have any python2 specific code, so just bump. Change-Id: Iaab94a1e896b78dc8699256e326edc165b0ed922 Related: OS#5950 --- M configure.ac 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 65ebd59..484d689 100644 --- a/configure.ac +++ b/configure.ac @@ -117,9 +117,9 @@ [Include the VTY/CTRL tests in make check [default=no]]), [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) if test "x$enable_ext_tests" = "xyes" ; then - AC_CHECK_PROG(PYTHON2_AVAIL,python2,yes) - if test "x$PYTHON2_AVAIL" != "xyes" ; then - AC_MSG_ERROR([Please install python2 to run the VTY/CTRL tests.]) + AC_CHECK_PROG(PYTHON3_AVAIL,python3,yes) + if test "x$PYTHON3_AVAIL" != "xyes" ; then + AC_MSG_ERROR([Please install python3 to run the VTY/CTRL tests.]) fi AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmotestvty.py,yes) if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/33758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Iaab94a1e896b78dc8699256e326edc165b0ed922 Gerrit-Change-Number: 33758 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-e1-recorder[master]: configure.ac: migrate from python2 to python3
by fixeria 14 Jul '23

14 Jul '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33759 ) Change subject: configure.ac: migrate from python2 to python3 ...................................................................... configure.ac: migrate from python2 to python3 Fortunatelly we don't have any python2 specific code, so just bump. Change-Id: Ib293c60cf66000b3e2520f7a02f39c4baa1c5ce9 --- M configure.ac M osmoappdesc.py 2 files changed, 15 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 568584d..3effcde 100644 --- a/configure.ac +++ b/configure.ac @@ -110,9 +110,9 @@ [Include the VTY/CTRL tests in make check [default=no]]), [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) if test "x$enable_ext_tests" = "xyes" ; then - AC_CHECK_PROG(PYTHON2_AVAIL,python2,yes) - if test "x$PYTHON2_AVAIL" != "xyes" ; then - AC_MSG_ERROR([Please install python2 to run the VTY/CTRL tests.]) + AC_CHECK_PROG(PYTHON3_AVAIL,python3,yes) + if test "x$PYTHON3_AVAIL" != "xyes" ; then + AC_MSG_ERROR([Please install python3 to run the VTY/CTRL tests.]) fi AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmotestvty.py,yes) if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then diff --git a/osmoappdesc.py b/osmoappdesc.py index 485a83b..56df5bc 100644 --- a/osmoappdesc.py +++ b/osmoappdesc.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 app_configs = { "osmo-e1-recorder": ["doc/examples/osmo-e1-recorder.cfg"] -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ib293c60cf66000b3e2520f7a02f39c4baa1c5ce9 Gerrit-Change-Number: 33759 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0