June 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-msc[master]: Add initial CSD support with external MNCC
by pespin 20 Jun '23

20 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33369 ) Change subject: Add initial CSD support with external MNCC ...................................................................... Patch Set 2: (1 comment) File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/df3fc331_3f2e5cde PS1, Line 113: struct csd_filter csd; > This does not work, because for CSD codecs.ms gets set to CSD in trans_cc_filter_set_ms_from_bc: […] Then, if csd is actually extra filtering inside the general codecs filtering (as seems to suggest you last comment where CSD stuff is set in "&trans->cc.codecs.ms"), it may make sense to move this "csd" field inside the "codecs" struct? I'm not saying it should be done that way, just raising concerns. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ide8b8321e0401dcbe35da2ec9cee0abca821d99a Gerrit-Change-Number: 33369 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 11:31:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block
by pespin 20 Jun '23

20 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 ) Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... pcu: TC_t3193: Fix test to properly trigger tx of last DL data block Since osmo-pcu.git 95ec50c9e4821ed1bdd15e9e30da1278ec1280c1, OsmoPCU doesn't allow receiving a FINAL_ACK in FLOW state. This test was not written properly and was taking advantage of that permissive logic in osmo-pcu to trigger the target use case. Fix it to have the PCU send the last DL data block (FBI=1) so that it can send a PKT DL ACK/NACK with FinalAck=1 to terminate the DL TBF. Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f --- M pcu/PCU_Tests.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 9388f8f..343af34 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1875,6 +1875,12 @@ /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + /* Disable "idle DL TBF alive" timer, to make the test easier and avoid + * having to keep receiving dummy LLC blocks for a while until the last + * block with FBI=1 is set. This way the first and only DL block is already + * the FBI one. */ + f_vty_config2(PCUVTY, {"pcu"}, "timer X2031 0"); + /* Establish BSSGP connection to the PCU */ f_bssgp_establish(); f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); @@ -1886,6 +1892,10 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + if (dl_block.data.mac_hdr.hdr_ext.fbi == false) { + setverdict(fail, "Expected DL data block with FBI=1 but got FBI=0"); + f_shutdown(__BFILE__, __LINE__); + } /* ACK the DL block */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block
by pespin 20 Jun '23

20 Jun '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 ) Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 11:28:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block
by osmith 20 Jun '23

20 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 ) Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 11:28:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: Add initial CSD support with external MNCC
by osmith 20 Jun '23

20 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33369 ) Change subject: Add initial CSD support with external MNCC ...................................................................... Patch Set 1: (3 comments) File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/b1d2276a_e4f1698d PS1, Line 113: struct csd_filter csd; > union between codecs and csd makes sense? This does not work, because for CSD codecs.ms gets set to CSD in trans_cc_filter_set_ms_from_bc: ``` sdp_audio_codecs_set_csd(&trans->cc.codecs.ms); ``` File src/libmsc/csd_filter.c: https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/9a50ae9d_f9afcf2c PS1, Line 53: csd_bs_list_add_bs(list, bs_geran[i]); > I see no benefit and several drawbacks in they way you are doing this, instead of calling the functi […] Done https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/650505b8_4645893e PS1, Line 70: csd_bs_list_add_bs(list, bs_utran[i]); > same Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ide8b8321e0401dcbe35da2ec9cee0abca821d99a Gerrit-Change-Number: 33369 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 11:27:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: Add initial CSD support with external MNCC
by osmith 20 Jun '23

20 Jun '23

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33369 to look at the new patch set (#2). Change subject: Add initial CSD support with external MNCC ...................................................................... Add initial CSD support with external MNCC Implement and use CSD bearer service logic (with similar audio codec code): * csd_filter (codec_filter) * csd_bs (sdp_audio_codec) * csd_bs_list (sdp_audio_codecs) Related: OS#4394 Change-Id: Ide8b8321e0401dcbe35da2ec9cee0abca821d99a --- M include/osmocom/msc/Makefile.am A include/osmocom/msc/csd_bs.h A include/osmocom/msc/csd_filter.h M include/osmocom/msc/sdp_msg.h M include/osmocom/msc/transaction.h M src/libmsc/Makefile.am A src/libmsc/csd_bs.c A src/libmsc/csd_filter.c M src/libmsc/gsm_04_08_cc.c M src/libmsc/msc_a.c M src/libmsc/sdp_msg.c M src/libmsc/transaction_cc.c 12 files changed, 926 insertions(+), 58 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/69/33369/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ide8b8321e0401dcbe35da2ec9cee0abca821d99a Gerrit-Change-Number: 33369 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-pcu[master]: Differentiate between T3192 and T3193
by pespin 20 Jun '23

20 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33374 ) Change subject: Differentiate between T3192 and T3193 ...................................................................... Differentiate between T3192 and T3193 T3192 on the MS side (boadcasted by the network on SI13) is used for the MS to stay monitoring the PDCH of a DL TBF after sending PKT DL ACK/NACK for the last DL data block (FinalAck=1). T3193 is the counterpart in the network, defined as >T3192, which is used to make sure the TFI is no longer used by the MS and hence can be reused/re-assigned again. Hence, we want to differentiate between those 2 timers, since the first one gives us information on how late can we still tx PktDlAss on PACCH on that DL TBF, while the later only provides info on when to free the DL TBF in order to reuse the TFI. Change-Id: I7421342461bf159d945651037e6fe690f88c6fae --- M src/gprs_ms.c M src/pdch.cpp M src/tbf_dl_fsm.c M src/tbf_fsm.h M tests/tbf/TbfTest.err 5 files changed, 111 insertions(+), 23 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 0b062c1..dda2f29 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -1368,20 +1368,31 @@ dl_tbf = ms_dl_tbf(ms); if (dl_tbf) { - if (tbf_state(dl_tbf_as_tbf_const(dl_tbf)) == TBF_ST_WAIT_RELEASE) { - LOGPTBFDL(dl_tbf, LOGL_DEBUG, "in WAIT RELEASE state (T3193), so reuse TBF\n"); + switch (tbf_state(dl_tbf_as_tbf_const(dl_tbf))) { + case TBF_ST_WAIT_RELEASE: + LOGPTBFDL(dl_tbf, LOGL_DEBUG, "in WAIT RELEASE state (T3192), so reuse TBF\n"); rc = ms_new_dl_tbf_assigned_on_pacch(ms, dl_tbf_as_tbf(dl_tbf)); + return rc; + case TBF_ST_WAIT_REUSE_TFI: + /* According to DL TBF state it should be back to CCCH, let's check UL TBF to have more information. */ + break; + case TBF_ST_RELEASING: + /* Something went wrong (T3195), delay for later. */ + default: + /* DL TBF in working status (do nothing)*/ + return 0; } - } else { - /* Check if we can create a DL TBF to start sending the enqueued - * data. Otherwise it will be triggered later when it is reachable - * again. */ - if (ms_is_reachable_for_dl_ass(ms)) { - if (ms_ul_tbf(ms)) - rc = ms_new_dl_tbf_assigned_on_pacch(ms, ul_tbf_as_tbf(ms_ul_tbf(ms))); - else - rc = ms_new_dl_tbf_assigned_on_pch(ms); - } + + } + + /* Check if we can create a DL TBF to start sending the enqueued + * data. Otherwise it will be triggered later when it is reachable + * again. */ + if (ms_is_reachable_for_dl_ass(ms)) { + if (ms_ul_tbf(ms)) + rc = ms_new_dl_tbf_assigned_on_pacch(ms, ul_tbf_as_tbf(ms_ul_tbf(ms))); + else + rc = ms_new_dl_tbf_assigned_on_pch(ms); } return rc; } diff --git a/src/pdch.cpp b/src/pdch.cpp index 8a2ad96..7dfd3c2 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -429,8 +429,9 @@ "TBF is gone TLLI=0x%08x\n", tlli); return; } - if (tbf->state_is(TBF_ST_WAIT_RELEASE) && - tbf->direction == new_tbf->direction) + if ((tbf->state_is(TBF_ST_WAIT_RELEASE) || + tbf->state_is(TBF_ST_WAIT_REUSE_TFI)) && + tbf->direction == new_tbf->direction) tbf_free(tbf); osmo_fsm_inst_dispatch(new_tbf->state_fi, TBF_EV_ASSIGN_ACK_PACCH, NULL); diff --git a/src/tbf_dl_fsm.c b/src/tbf_dl_fsm.c index ebcd8b8..ba7fc5a 100644 --- a/src/tbf_dl_fsm.c +++ b/src/tbf_dl_fsm.c @@ -34,7 +34,8 @@ [TBF_ST_ASSIGN] = {}, [TBF_ST_FLOW] = {}, [TBF_ST_FINISHED] = {}, - [TBF_ST_WAIT_RELEASE] = { .T = 3193 }, + [TBF_ST_WAIT_RELEASE] = { .T = 3192 }, + [TBF_ST_WAIT_REUSE_TFI] = { /* .T = 3193 set manually onenter subtracting T3192 */ }, [TBF_ST_RELEASING] = { .T = 3195 }, }; @@ -243,8 +244,9 @@ break; case TBF_EV_FINAL_ACK_RECVD: /* We received Final Ack (DL ACK/NACK) from MS. move to - * WAIT_RELEASE, we wait there for release or re-use the TBF in - * case we receive more DL data to tx */ + * WAIT_RELEASE, where MS stays monitoring PDCH over T3192 span, + * where we can use this DL TBF to assign a new one in case we + * receive more DL data to Tx */ tbf_dl_fsm_state_chg(fi, TBF_ST_WAIT_RELEASE); break; case TBF_EV_MAX_N3105: @@ -259,6 +261,14 @@ { struct tbf_dl_fsm_ctx *ctx = (struct tbf_dl_fsm_ctx *)fi->priv; + /* T3192 is running on the MS and has also been armed by this FSM now. + * During that time, it is possible to reach the MS over PACCH to assign + * new DL TBF. + * Upon T3192 expiration, FSM will transition to TBF_ST_WAIT_REUSE_TFI + * for some more time (T3193 - T3192) until internally freeing the TBF + * object, at which time the resources can be reused. + */ + mod_ass_type(ctx, GPRS_RLCMAC_FLAG_CCCH, false); } @@ -266,10 +276,41 @@ { switch (event) { case TBF_EV_FINAL_ACK_RECVD: - /* ignore, duplicate ACK, we already know about since we are in WAIT_RELEASE */ + /* ignore, duplicate ACK, we already know about since we left ST_FINISHED */ break; - case TBF_EV_MAX_N3105: - tbf_dl_fsm_state_chg(fi, TBF_ST_RELEASING); + default: + OSMO_ASSERT(0); + } +} + +static void st_wait_reuse_tfi_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct tbf_dl_fsm_ctx *ctx = (struct tbf_dl_fsm_ctx *)fi->priv; + struct GprsMs *ms = tbf_ms(ctx->tbf); + unsigned long t3192, t3193, res; + + /* T3192 has expired, so the MS is not listening on that PACCH anymore. + * Still, wait until remaining of T3193 expiration (>T3192) to internally + * free the TBF, at which point the TFI and other allocated resources + * will be freed and can then be reused. + */ + + t3192 = osmo_tdef_get(ms->bts->T_defs_bts, 3192, OSMO_TDEF_MS, -1); + t3193 = osmo_tdef_get(ms->bts->T_defs_bts, 3193, OSMO_TDEF_MS, -1); + /* As per spec T3193 shall be greater than T3192, but let's be safe against wrong configs: */ + res = (t3193 >= t3192) ? (t3193 - t3192) : 0; + fi->T = 3193; + LOGPTBF(ctx->tbf, LOGL_DEBUG, "Waiting %lu sec. %lu microsec (T3193 - T3192) [REUSE TFI]\n", + res / 1000, (res % 1000) * 1000); + osmo_timer_schedule(&fi->timer, res / 1000, (res % 1000) * 1000); +} + +static void st_wait_reuse_tfi(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + /* Simply wait for T3193 timeout, it will tbf_free() */ + switch (event) { + case TBF_EV_FINAL_ACK_RECVD: + /* ignore, duplicate ACK, we already know about since we left ST_FINISHED */ break; default: OSMO_ASSERT(0); @@ -334,6 +375,9 @@ case -2002: handle_timeout_X2002(fi); break; + case 3192: + tbf_dl_fsm_state_chg(fi, TBF_ST_WAIT_REUSE_TFI); + break; case -2001: LOGPTBFDL(ctx->dl_tbf, LOGL_NOTICE, "releasing due to PACCH assignment timeout.\n"); /* fall-through */ @@ -401,11 +445,21 @@ X(TBF_EV_FINAL_ACK_RECVD) | X(TBF_EV_MAX_N3105), .out_state_mask = + X(TBF_ST_WAIT_REUSE_TFI) | X(TBF_ST_RELEASING), .name = "WAIT_RELEASE", .action = st_wait_release, .onenter = st_wait_release_on_enter, }, + [TBF_ST_WAIT_REUSE_TFI] = { + .in_event_mask = + X(TBF_EV_FINAL_ACK_RECVD), + .out_state_mask = + X(TBF_ST_RELEASING), + .name = "WAIT_REUSE_TFI", + .action = st_wait_reuse_tfi, + .onenter = st_wait_reuse_tfi_on_enter, + }, [TBF_ST_RELEASING] = { .in_event_mask = X(TBF_EV_DL_ACKNACK_MISS), diff --git a/src/tbf_fsm.h b/src/tbf_fsm.h index 999b3c0..fd6ffa6 100644 --- a/src/tbf_fsm.h +++ b/src/tbf_fsm.h @@ -52,7 +52,8 @@ TBF_ST_ASSIGN, /* wait for downlink assignment */ TBF_ST_FLOW, /* RLC/MAC flow, resource needed */ TBF_ST_FINISHED, /* flow finished, wait for release */ - TBF_ST_WAIT_RELEASE,/* DL TBF: wait for release or restart */ + TBF_ST_WAIT_RELEASE, /* DL TBF: wait for release or restart */ + TBF_ST_WAIT_REUSE_TFI, /* DL TBF: wait to reuse TFI after last PKT ACK/NACK */ TBF_ST_RELEASING, /* releasing, wait to free TFI/USF */ }; diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index a78e204..83bf6db 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -295,7 +295,7 @@ DL_TBF(DL:TFI-0-0-0:G){FINISHED}: state_chg to WAIT_RELEASE TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:1, PACCH:0] MS(TLLI-0xffeeddcc:TA-0:MSCLS-45-0:DL) appending 200 bytes to DL LLC queue -TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} in WAIT RELEASE state (T3193), so reuse TBF +TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} in WAIT RELEASE state (T3192), so reuse TBF [DL] algo A <multi> (suggested TRX: 0): Alloc start - Skipping TS 0, because not enabled - Skipping TS 1, because not enabled @@ -573,7 +573,7 @@ DL_TBF(DL:TFI-0-0-0:G){FINISHED}: state_chg to WAIT_RELEASE TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:1, PACCH:0] MS(TLLI-0xffeeddcc:TA-0:MSCLS-45-0:DL) appending 200 bytes to DL LLC queue -TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} in WAIT RELEASE state (T3193), so reuse TBF +TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} in WAIT RELEASE state (T3192), so reuse TBF [DL] algo A <multi> (suggested TRX: 0): Alloc start - Skipping TS 0, because not enabled - Skipping TS 1, because not enabled -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7421342461bf159d945651037e6fe690f88c6fae Gerrit-Change-Number: 33374 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block
by pespin 20 Jun '23

20 Jun '23

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 to look at the new patch set (#3). Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... pcu: TC_t3193: Fix test to properly trigger tx of last DL data block Since osmo-pcu.git 95ec50c9e4821ed1bdd15e9e30da1278ec1280c1, OsmoPCU doesn't allow receiving a FINAL_ACK in FLOW state. This test was not written properly and was taking advantage of that permissive logic in osmo-pcu to trigger the target use case. Fix it to have the PCU send the last DL data block (FBI=1) so that it can send a PKT DL ACK/NACK with FinalAck=1 to terminate the DL TBF. Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f --- M pcu/PCU_Tests.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/33375/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-pcu[master]: Differentiate between T3192 and T3193
by fixeria 20 Jun '23

20 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33374 ) Change subject: Differentiate between T3192 and T3193 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7421342461bf159d945651037e6fe690f88c6fae Gerrit-Change-Number: 33374 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 11:21:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block
by fixeria 20 Jun '23

20 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 ) Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/b9b2f13b_9e6f… PS2, Line 10: receive receiving https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/24e9ea9d_0286… PS2, Line 14: terminat ethe terminate the -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 11:11:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0