June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_mgwpool_keepalive_down_not_used
by fixeria 20 Jun '23

20 Jun '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33376 ) Change subject: BSC_Tests: fix TC_mgwpool_keepalive_down_not_used ...................................................................... BSC_Tests: fix TC_mgwpool_keepalive_down_not_used Current osmo-bsc master does not support the MGW keepalive yet, so f_vty_mgw_cfg_keepalive() fails. This leaves osmo-bsc in unclean state and makes all LCLS testcases fail. The problem is that before calling it we also call f_vty_mgw_enable() and f_vty_mgw_block(), but not calling their counterparts. Rearrange the testcase to call f_vty_mgw_cfg_keepalive() first, so that we fail early before calling f_vty_mgw_{enable,block}(). Change-Id: I6a94c441fe80a92c237c3c4a5481f2dac3376e35 Fixes: bd59842b6 "bsc: Introduce test TC_mgwpool_keepalive" --- M bsc/BSC_Tests.ttcn 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index ba0858c..a9cfa03 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -12307,9 +12307,9 @@ f_init(1, true, nr_mgw := 2); f_sleep(1.0); + f_vty_mgw_cfg_keepalive(0, req_intval := 1, req_endp := "null", rx_timeout := 3); f_vty_mgw_enable(1); f_vty_mgw_block(1, false); - f_vty_mgw_cfg_keepalive(0, req_intval := 1, req_endp := "null", rx_timeout := 3); vc_conn1 := f_start_handler_create(pars1); vc_conn2 := f_start_handler_create(pars2); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a94c441fe80a92c237c3c4a5481f2dac3376e35 Gerrit-Change-Number: 33376 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_mgwpool_keepalive_down_not_used
by pespin 20 Jun '23

20 Jun '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33376 ) Change subject: BSC_Tests: fix TC_mgwpool_keepalive_down_not_used ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a94c441fe80a92c237c3c4a5481f2dac3376e35 Gerrit-Change-Number: 33376 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:51:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_mgwpool_keepalive_down_not_used
by fixeria 20 Jun '23

20 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33376 ) Change subject: BSC_Tests: fix TC_mgwpool_keepalive_down_not_used ...................................................................... BSC_Tests: fix TC_mgwpool_keepalive_down_not_used Current osmo-bsc master does not support the MGW keepalive yet, so f_vty_mgw_cfg_keepalive() fails. This leaves osmo-bsc in unclean state and makes all LCLS testcases fail. The problem is that before calling it we also call f_vty_mgw_enable() and f_vty_mgw_block(), but not calling their counterparts. Rearrange the testcase to call f_vty_mgw_cfg_keepalive() first, so that we fail early before calling f_vty_mgw_{enable,block}(). Change-Id: I6a94c441fe80a92c237c3c4a5481f2dac3376e35 Fixes: bd59842b6 "bsc: Introduce test TC_mgwpool_keepalive" --- M bsc/BSC_Tests.ttcn 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/33376/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index ba0858c..a9cfa03 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -12307,9 +12307,9 @@ f_init(1, true, nr_mgw := 2); f_sleep(1.0); + f_vty_mgw_cfg_keepalive(0, req_intval := 1, req_endp := "null", rx_timeout := 3); f_vty_mgw_enable(1); f_vty_mgw_block(1, false); - f_vty_mgw_cfg_keepalive(0, req_intval := 1, req_endp := "null", rx_timeout := 3); vc_conn1 := f_start_handler_create(pars1); vc_conn2 := f_start_handler_create(pars2); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a94c441fe80a92c237c3c4a5481f2dac3376e35 Gerrit-Change-Number: 33376 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block
by osmith 20 Jun '23

20 Jun '23

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 ) Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/4eb513ce_3775… PS1, Line 1878: est > test Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/5704dc9a_87a3… PS1, Line 1880: alrady > already Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/518c799d_70bb… PS1, Line 1882: f_vty_config2(PCUVTY, {"pcu"}, "timer X2031 0"); > Yes, osmo-pcu is called with the respawn.sh. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block
by pespin 20 Jun '23

20 Jun '23

Attention is currently required from: osmith, fixeria. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 to look at the new patch set (#2). Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... pcu: TC_t3193: Fix test to properly trigger tx of last DL data block Since osmo-pcu.git 95ec50c9e4821ed1bdd15e9e30da1278ec1280c1, OsmoPCU doesn't allow receive a FINAL_ACK in FLOW state. This test was not written properly and was taking advantage of that permissive logic in osmo-pcu to trigger the target use case. Fix it to have the PCU send the last DL data block (FBI=1) so that it can send a PKT DL ACK/NACK with FinalAck=1 to terminat ethe DL TBF. Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f --- M pcu/PCU_Tests.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/33375/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block
by pespin 20 Jun '23

20 Jun '23

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 ) Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... Patch Set 1: (1 comment) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/1cf4f067_ba46… PS1, Line 1882: f_vty_config2(PCUVTY, {"pcu"}, "timer X2031 0"); > does the timer get reset again at the beginning of tests? (probably, but just to be sure) Yes, osmo-pcu is called with the respawn.sh. The process is restarted when the PCUIF socket is closed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:24:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block
by osmith 20 Jun '23

20 Jun '23

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 ) Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/531e4be3_9f9b… PS1, Line 1878: est test https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/280b2175_4b84… PS1, Line 1880: alrady already https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/94ada739_a0cd… PS1, Line 1882: f_vty_config2(PCUVTY, {"pcu"}, "timer X2031 0"); does the timer get reset again at the beginning of tests? (probably, but just to be sure) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:22:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: transaction: move cc.codecs.remote -> cc.remote
by pespin 20 Jun '23

20 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33365 ) Change subject: transaction: move cc.codecs.remote -> cc.remote ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > With audio codecs, the whole codec_filter (see include/osmocom/msc/codec_filter. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5d2e078db3b3437cb6feae40d8955912d7a297e4 Gerrit-Change-Number: 33365 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:20:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: Differentiate between T3192 and T3193
by osmith 20 Jun '23

20 Jun '23

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33374 ) Change subject: Differentiate between T3192 and T3193 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7421342461bf159d945651037e6fe690f88c6fae Gerrit-Change-Number: 33374 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:17:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: transaction: move cc.codecs.remote -> cc.remote
by osmith 20 Jun '23

20 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33365 ) Change subject: transaction: move cc.codecs.remote -> cc.remote ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Opening the debate here after looking at the whole patchset (I have no opinion but I think it's wort […] With audio codecs, the whole codec_filter (see include/osmocom/msc/codec_filter.h) code is based on "struct sdp_audio_codecs" which seems unsuitable for CSD: ``` struct sdp_audio_codec { /* Payload type number, like 3 for GSM-FR. */ unsigned int payload_type; /* Like "GSM", "AMR", "EFR", ... */ char subtype_name[16]; unsigned int rate; char fmtp[64]; }; ``` In CSD, SDP is the same for all bearer services (payload type 120, rate 8000, name CLEARMODE). For CSD we need to be able to have similar filter logic but based on bearer services (see struct csd_bs_map in src/libmsc/csd_bs.c in the last patch of this patchset). Therefore I implemented this bearer services logic separately. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5d2e078db3b3437cb6feae40d8955912d7a297e4 Gerrit-Change-Number: 33365 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:16:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0