pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 ) Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... pcu: TC_t3193: Fix test to properly trigger tx of last DL data block Since osmo-pcu.git 95ec50c9e4821ed1bdd15e9e30da1278ec1280c1, OsmoPCU doesn't allow receiving a FINAL_ACK in FLOW state. This test was not written properly and was taking advantage of that permissive logic in osmo-pcu to trigger the target use case. Fix it to have the PCU send the last DL data block (FBI=1) so that it can send a PKT DL ACK/NACK with FinalAck=1 to terminate the DL TBF. Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f --- M pcu/PCU_Tests.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 9388f8f..343af34 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1875,6 +1875,12 @@ /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + /* Disable "idle DL TBF alive" timer, to make the test easier and avoid + * having to keep receiving dummy LLC blocks for a while until the last + * block with FBI=1 is set. This way the first and only DL block is already + * the FBI one. */ + f_vty_config2(PCUVTY, {"pcu"}, "timer X2031 0"); + /* Establish BSSGP connection to the PCU */ f_bssgp_establish(); f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); @@ -1886,6 +1892,10 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + if (dl_block.data.mac_hdr.hdr_ext.fbi == false) { + setverdict(fail, "Expected DL data block with FBI=1 but got FBI=0"); + f_shutdown(__BFILE__, __LINE__); + } /* ACK the DL block */ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged