June 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx()
by fixeria 23 Jun '23

23 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33411 ) Change subject: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx() ...................................................................... coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx() According to 3GPP TS 45.003, section 3.9.2, the convolutional coding is *not* employed in the case of SID_FIRST. This is why we're using sid_first_dummy[] in this function. The conv[] array is not initialized in the case of AFS_SID_FIRST and passing it to tch_amr_reassemble() is highly likely a copy-paste bug. Pass the sid_first_dummy[] instead. Change-Id: Ic8bfc34ce9d14821fe4e82932325f0c517d443a1 Fixes: CID#272949 "Uninitialized scalar variable" --- M src/coding/gsm0503_coding.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/33411/1 diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 80286f7..286981e 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -2262,7 +2262,7 @@ tch_amr_sid_update_append(sid_first_dummy, 0, (codec_mode_req) ? codec[*ft] : codec[id > 0 ? id : 0]); - tch_amr_reassemble(tch_data, conv, 39); + tch_amr_reassemble(tch_data, sid_first_dummy, 39); len = 5; goto out; case AFS_SID_UPDATE: /* TODO: parse CMI _and_ CMC/CMR (16 + 16 bit) */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic8bfc34ce9d14821fe4e82932325f0c517d443a1 Gerrit-Change-Number: 33411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: Fix various uninitialized value errors
by pespin 23 Jun '23

23 Jun '23

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors ...................................................................... Patch Set 1: Code-Review-1 (5 comments) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/fc61231a_3dbc778f PS1, Line 2197: ubit_t d[244], p[6], conv[250] = {}; This definetly needs an explanation in commit description and possibly its own commit. File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/d659e1c3_e0fe40ec PS1, Line 490: struct osmo_nri_range add_range = {}; I don't really see a problem with not initializing it, unless osmo_nri_parse_range() requires the first param to be 0 initialized. Possibly something to be clarified. In any case, this requires explanation in commit description and its own commit. https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/d9bdd82d_92569161 PS1, Line 496: if (added_range) imho this should be moved after the if in line 499. https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/27ea52c8_18be4aca PS1, Line 526: struct osmo_nri_range del_range = {}; same as add_range above. File tests/codec/codec_ecu_fr_test.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/3c51d659_b8d92561 PS1, Line 126: osmo_ecu_fr_reset(&state, frame); why is zero-initializing state above required when calling this function? does osmo_ecu_fr_reset() require it? is it left uninitialized if osmo_ecu_fr_reset() fails? Further expalanation needed + own commit. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f Gerrit-Change-Number: 33400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 09:51:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Fix various uninitialized value errors
by fixeria 23 Jun '23

23 Jun '23

Attention is currently required from: osmith, fixeria, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/027f7cb1_42c52499 PS1, Line 2197: conv[250] = {}; I don't think we should be doing zero-init unconditionally here. This is a hot code path, and stuff like that should be avoided when possible. Let me take a look at CID#272949. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f Gerrit-Change-Number: 33400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 09:47:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: smpp_handle_bind_tx: initialize tlv
by osmith 23 Jun '23

23 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33395 ) Change subject: smpp_handle_bind_tx: initialize tlv ...................................................................... smpp_handle_bind_tx: initialize tlv Fixes: CID#272977 Change-Id: I22da1aa95bf19a9bb1d8e0875f3b68356d801c70 --- M src/libsmpputil/smpp_smsc.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/libsmpputil/smpp_smsc.c b/src/libsmpputil/smpp_smsc.c index d54b3c1..314dc60 100644 --- a/src/libsmpputil/smpp_smsc.c +++ b/src/libsmpputil/smpp_smsc.c @@ -467,7 +467,7 @@ { struct bind_transmitter_t bind; struct bind_transmitter_resp_t bind_r; - struct tlv_t tlv; + struct tlv_t tlv = {}; int rc; SMPP34_UNPACK(rc, BIND_TRANSMITTER, &bind, msgb_data(msg), -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I22da1aa95bf19a9bb1d8e0875f3b68356d801c70 Gerrit-Change-Number: 33395 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: smpp_msc: submit_to_sms: check ud_len > sms_msg_len
by osmith 23 Jun '23

23 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33397 ) Change subject: smpp_msc: submit_to_sms: check ud_len > sms_msg_len ...................................................................... smpp_msc: submit_to_sms: check ud_len > sms_msg_len Fixes: CID#240727 Change-Id: Ie01ac84816f6ac3ba5631a643d486fb0dfb05eb2 --- M src/libsmpputil/smpp_msc.c 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/libsmpputil/smpp_msc.c b/src/libsmpputil/smpp_msc.c index 87cab00..fed5858 100644 --- a/src/libsmpputil/smpp_msc.c +++ b/src/libsmpputil/smpp_msc.c @@ -245,6 +245,12 @@ sms->data_coding_scheme = GSM338_DCS_1111_7BIT; if (sms->ud_hdr_ind) { ud_len = *sms_msg + 1; + if (ud_len > sms_msg_len) { + sms_free(sms); + LOGP(DLSMS, LOGL_ERROR, "invalid ud_len=%u > sms_msg_len=%u\n", ud_len, + sms_msg_len); + return ESME_RINVPARLEN; + } printf("copying %u bytes user data...\n", ud_len); memcpy(sms->user_data, sms_msg, OSMO_MIN(ud_len, sizeof(sms->user_data))); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie01ac84816f6ac3ba5631a643d486fb0dfb05eb2 Gerrit-Change-Number: 33397 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: sdp_msg_test: fix dereference after null check
by osmith 23 Jun '23

23 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33396 ) Change subject: sdp_msg_test: fix dereference after null check ...................................................................... sdp_msg_test: fix dereference after null check Fixes: CID#274690 Change-Id: Ic59252e4f1d4daf5f86c6b73ec951e02109df9bc --- M tests/sdp_msg/sdp_msg_test.c 1 file changed, 17 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/tests/sdp_msg/sdp_msg_test.c b/tests/sdp_msg/sdp_msg_test.c index ebe8328..4798ae0 100644 --- a/tests/sdp_msg/sdp_msg_test.c +++ b/tests/sdp_msg/sdp_msg_test.c @@ -526,6 +526,8 @@ struct sdp_msg sdp = {}; struct sdp_audio_codec *codec; char buf[1024]; + const char *expect_sdp; + printf("\n[%d]\n", i); rc = sdp_msg_from_sdp_str(&sdp, t->sdp); if (rc) { @@ -542,14 +544,15 @@ printf("SDP: %s\n", sdp_audio_codecs_to_str(&sdp.audio_codecs)); sdp_msg_to_sdp_str_buf(buf, sizeof(buf), &sdp); - if (strcmp(buf, t->expect_sdp ? : t->sdp)) { + expect_sdp = t->expect_sdp ? : t->sdp; + if (strcmp(buf, expect_sdp)) { int j; ok = false; printf("ERROR:\n"); dump_sdp(buf, "selection result: "); - dump_sdp(t->expect_sdp, "expect result: "); - for (j = 0; t->expect_sdp[j]; j++) { - if (t->expect_sdp[j] != buf[j]) { + dump_sdp(expect_sdp, "expect result: "); + for (j = 0; expect_sdp[j]; j++) { + if (expect_sdp[j] != buf[j]) { printf("ERROR at position %d, at:\n", j); dump_sdp(buf + j, " mismatch: "); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59252e4f1d4daf5f86c6b73ec951e02109df9bc Gerrit-Change-Number: 33396 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: msc_ho_send_handover_request: fix check_after_deref
by osmith 23 Jun '23

23 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33398 ) Change subject: msc_ho_send_handover_request: fix check_after_deref ...................................................................... msc_ho_send_handover_request: fix check_after_deref Fixes: CID#211073 Change-Id: I9389cc9c4af987c11652c6fe9a0ff4289a7781c9 --- M src/libmsc/msc_ho.c 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c index 2a5891a..ce3f100 100644 --- a/src/libmsc/msc_ho.c +++ b/src/libmsc/msc_ho.c @@ -401,8 +401,6 @@ /* Don't send AoIP Transport Layer Address for inter-MSC Handover */ .rtp_ran_local = (msc_a->ho.new_cell.type == MSC_NEIGHBOR_TYPE_LOCAL_RAN_PEER) ? call_leg_local_ip(msc_a->cc.call_leg, RTP_TO_RAN) : NULL, - .call_id_present = true, - .call_id = cc_trans->callref, }, }; @@ -422,6 +420,8 @@ return; } ran_enc_msg.handover_request.geran.channel_type = &channel_type; + ran_enc_msg.handover_request.call_id_present = true; + ran_enc_msg.handover_request.call_id = cc_trans->callref; sdp_audio_codecs_to_speech_codec_list(&scl, &cc_trans->cc.local.audio_codecs); if (!scl.len) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9389cc9c4af987c11652c6fe9a0ff4289a7781c9 Gerrit-Change-Number: 33398 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: msc_ho_send_handover_request: fix check_after_deref
by fixeria 23 Jun '23

23 Jun '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33398 ) Change subject: msc_ho_send_handover_request: fix check_after_deref ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9389cc9c4af987c11652c6fe9a0ff4289a7781c9 Gerrit-Change-Number: 33398 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 09:41:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: smpp_msc: submit_to_sms: check ud_len > sms_msg_len
by fixeria 23 Jun '23

23 Jun '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33397 ) Change subject: smpp_msc: submit_to_sms: check ud_len > sms_msg_len ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie01ac84816f6ac3ba5631a643d486fb0dfb05eb2 Gerrit-Change-Number: 33397 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 09:40:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in pysim[master]: test - please ignore
by dexter 23 Jun '23

23 Jun '23

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/33410 ) Change subject: test - please ignore ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7bd49c91b2de2fc8aae732e35082992de1697bbf Gerrit-Change-Number: 33410 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 0