Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors ...................................................................... Patch Set 1: Code-Review-1 (5 comments) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/fc61231a_3dbc778f PS1, Line 2197: ubit_t d[244], p[6], conv[250] = {}; This definetly needs an explanation in commit description and possibly its own commit. File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/d659e1c3_e0fe40ec PS1, Line 490: struct osmo_nri_range add_range = {}; I don't really see a problem with not initializing it, unless osmo_nri_parse_range() requires the first param to be 0 initialized. Possibly something to be clarified. In any case, this requires explanation in commit description and its own commit. https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/d9bdd82d_92569161 PS1, Line 496: if (added_range) imho this should be moved after the if in line 499. https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/27ea52c8_18be4aca PS1, Line 526: struct osmo_nri_range del_range = {}; same as add_range above. File tests/codec/codec_ecu_fr_test.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/3c51d659_b8d92561 PS1, Line 126: osmo_ecu_fr_reset(&state, frame); why is zero-initializing state above required when calling this function? does osmo_ecu_fr_reset() require it? is it left uninitialized if osmo_ecu_fr_reset() fails? Further expalanation needed + own commit. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f Gerrit-Change-Number: 33400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 09:51:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment