Attention is currently required from: osmith, fixeria.

Patch set 1:Code-Review -1

View Change

5 comments:

• File src/coding/gsm0503_coding.c:

  • Patch Set #1, Line 2197: ubit_t d[244], p[6], conv[250] = {};

    This definetly needs an explanation in commit description and possibly its own commit.

• File src/gsm/gsm23236.c:

  • Patch Set #1, Line 490: struct osmo_nri_range add_range = {};

    I don't really see a problem with not initializing it, unless osmo_nri_parse_range() requires the first param to be 0 initialized. Possibly something to be clarified.
    In any case, this requires explanation in commit description and its own commit.

  • Patch Set #1, Line 496: if (added_range)

    imho this should be moved after the if in line 499.

  • Patch Set #1, Line 526: struct osmo_nri_range del_range = {};

    same as add_range above.

• File tests/codec/codec_ecu_fr_test.c:

  • Patch Set #1, Line 126: osmo_ecu_fr_reset(&state, frame);

    why is zero-initializing state above required when calling this function? does osmo_ecu_fr_reset() require it? is it left uninitialized if osmo_ecu_fr_reset() fails?

    Further expalanation needed + own commit.

To view, visit change 33400. To unsubscribe, or for help writing mail filters, visit settings.