June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: sdp_msg_test: fix dereference after null check
by fixeria 23 Jun '23

23 Jun '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33396 ) Change subject: sdp_msg_test: fix dereference after null check ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59252e4f1d4daf5f86c6b73ec951e02109df9bc Gerrit-Change-Number: 33396 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 09:36:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in pysim[master]: test - please ignore
by dexter 23 Jun '23

23 Jun '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33410 ) Change subject: test - please ignore ...................................................................... test - please ignore Change-Id: I7bd49c91b2de2fc8aae732e35082992de1697bbf --- A testme 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/10/33410/1 diff --git a/testme b/testme new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/testme -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7bd49c91b2de2fc8aae732e35082992de1697bbf Gerrit-Change-Number: 33410 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: smpp_handle_bind_tx: initialize tlv
by fixeria 23 Jun '23

23 Jun '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33395 ) Change subject: smpp_handle_bind_tx: initialize tlv ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I22da1aa95bf19a9bb1d8e0875f3b68356d801c70 Gerrit-Change-Number: 33395 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 09:34:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-python-tests[master]: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on...
by fixeria 23 Jun '23

23 Jun '23

Attention is currently required from: arehbein, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 ) Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files ...................................................................... Patch Set 5: Code-Review-1 (1 comment) File scripts/osmotestconfig.py: https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980/comment/57a50… PS5, Line 80: ign = shutil.ignore_patterns('*.cfg', '*tmp_dummy_sock') > So that would boil down to adding a new parameter to `osmotestconfig. […] I also don't like the proposed approach, agreeing with @pespin that putting project specific filenames here is not a good idea. Given that socket files are somehow special, maybe we can somehow exclude all special file types (socket files, named pipes) here? -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664 Gerrit-Change-Number: 30980 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 09:18:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: lapdm: cosmetic: simplify lapdm_phsap_up(), use OSMO_PRIM[_HDR]
by fixeria 23 Jun '23

23 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33409 ) Change subject: lapdm: cosmetic: simplify lapdm_phsap_up(), use OSMO_PRIM[_HDR] ...................................................................... lapdm: cosmetic: simplify lapdm_phsap_up(), use OSMO_PRIM[_HDR] Change-Id: I87dedca0a38f290ae56649373dc9172433b8e4b1 Related: OS#3626 --- M src/gsm/lapdm.c 1 file changed, 23 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/33409/1 diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index e8d9e78..4a82c4d 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -909,56 +909,33 @@ if (oph->sap != SAP_GSM_PH) { LOGP(DLLAPD, LOGL_ERROR, "primitive for unknown SAP %u\n", oph->sap); - rc = -ENODEV; - goto free; + msgb_free(oph->msg); + return -ENODEV; } - switch (oph->primitive) { - case PRIM_PH_DATA: - if (oph->operation != PRIM_OP_INDICATION) { - LOGP(DLLAPD, LOGL_ERROR, "PH_DATA is not INDICATION %u\n", - oph->operation); - rc = -ENODEV; - goto free; - } + switch (OSMO_PRIM_HDR(oph)) { + case OSMO_PRIM(PRIM_PH_DATA, PRIM_OP_INDICATION): rc = l2_ph_data_ind(oph->msg, le, pp->u.data.chan_nr, pp->u.data.link_id); break; - case PRIM_PH_RTS: - if (oph->operation != PRIM_OP_INDICATION) { - LOGP(DLLAPD, LOGL_ERROR, "PH_RTS is not INDICATION %u\n", - oph->operation); - rc = -ENODEV; - goto free; - } + case OSMO_PRIM(PRIM_PH_RTS, PRIM_OP_INDICATION): rc = l2_ph_data_conf(oph->msg, le); break; - case PRIM_PH_RACH: - switch (oph->operation) { - case PRIM_OP_INDICATION: - rc = l2_ph_rach_ind(le, pp->u.rach_ind.ra, pp->u.rach_ind.fn, - pp->u.rach_ind.acc_delay); - break; - case PRIM_OP_CONFIRM: - rc = l2_ph_chan_conf(oph->msg, le, pp->u.rach_ind.fn); - break; - default: - rc = -EIO; - goto free; - } + case OSMO_PRIM(PRIM_PH_RACH, PRIM_OP_INDICATION): + rc = l2_ph_rach_ind(le, pp->u.rach_ind.ra, pp->u.rach_ind.fn, + pp->u.rach_ind.acc_delay); + break; + case OSMO_PRIM(PRIM_PH_RACH, PRIM_OP_CONFIRM): + rc = l2_ph_chan_conf(oph->msg, le, pp->u.rach_ind.fn); break; default: LOGP(DLLAPD, LOGL_ERROR, "Unknown primitive %u\n", oph->primitive); - rc = -EINVAL; - goto free; + msgb_free(oph->msg); + return -EINVAL; } return rc; - -free: - msgb_free(oph->msg); - return rc; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I87dedca0a38f290ae56649373dc9172433b8e4b1 Gerrit-Change-Number: 33409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pySim-shell: Unregister profile commands during equip
by iw0 23 Jun '23

23 Jun '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/33424 to look at the new patch set (#2). Change subject: pySim-shell: Unregister profile commands during equip ...................................................................... pySim-shell: Unregister profile commands during equip This avoids error messages about re-registering 'AddlShellCommands' commandsets during 'equip()' in the bulk_script command. Change-Id: I893bb5ae95f5c6e4c2be2d133754e427bc92a33d --- M pySim-shell.py 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/33424/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I893bb5ae95f5c6e4c2be2d133754e427bc92a33d Gerrit-Change-Number: 33424 Gerrit-PatchSet: 2 Gerrit-Owner: iw0 <osmocom(a)heychris.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: pySim-shell: Unregister profile commands during equip
by iw0 23 Jun '23

23 Jun '23

iw0 has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33424 ) Change subject: pySim-shell: Unregister profile commands during equip ...................................................................... pySim-shell: Unregister profile commands during equip Change-Id: I893bb5ae95f5c6e4c2be2d133754e427bc92a33d --- M pySim-shell.py 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/33424/1 diff --git a/pySim-shell.py b/pySim-shell.py index f6cd75d..400e70d 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -204,6 +204,10 @@ if self.rs: lchan = self.rs.lchan[0] lchan.unregister_cmds(self) + if self.rs.profile: + for cmd_set in self.rs.profile.shell_cmdsets: + self.unregister_command_set(cmd_set) + for cmds in [Iso7816Commands, Ts102222Commands, PySimCommands]: cmd_set = self.find_commandsets(cmds) if cmd_set: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I893bb5ae95f5c6e4c2be2d133754e427bc92a33d Gerrit-Change-Number: 33424 Gerrit-PatchSet: 1 Gerrit-Owner: iw0 <osmocom(a)heychris.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios
by falconia 23 Jun '23

23 Jun '23

Attention is currently required from: neels. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29973 ) Change subject: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Cool, I never considered / tried Call Waiting before. […] @neels - thank you for taking the time to review my silly trivial patch! Please note that this patch is only a band-aid and NOT a proper solution - the band-aid allowed call waiting to work in the basic tests I did back then, but it comes nowhere close to a correct handling of all scenarios and corner cases. The only reason I submitted this patch to Gerrit all those months ago was upon urging from @fixeria, who told me something along the lines of "better to have a partial fix in the code than none at all". Regarding logs and ladder diagrams - point taken and noted. I will retest the patch and capture those logs when I find some time to switch my attention back to OsmoMSC, which I haven't touched in all these months. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibb62cb3c154b99769b2dfe708f73c20e8b632f5d Gerrit-Change-Number: 29973 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 07:50:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: use f_shutdown_helper() everywhere
by neels 23 Jun '23

23 Jun '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33407 ) Change subject: hnbgw: use f_shutdown_helper() everywhere ...................................................................... hnbgw: use f_shutdown_helper() everywhere I hope that this helps with sporadic test failures because of RANAP RESET happening during test shutdown. Change-Id: Ie2088bc8786742a1dffb0132f4b162fb2649fb9b --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 42 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 698c1a2..c3dbecd 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -820,6 +820,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_initial_ue), t_pars(1)); vc_conn.done; + + f_shutdown_helper(); } testcase TC_ranap_ps_initial_ue() runs on test_CT { var ConnHdlr vc_conn; @@ -830,6 +832,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_initial_ue), t_pars(2, true)); vc_conn.done; + + f_shutdown_helper(); } private function f_vty_set_sccp_max_optional_data(TELNETasp_PT pt, integer val := -1) @@ -860,6 +864,8 @@ /* reset */ f_vty_set_sccp_max_optional_data(HNBGWVTY); + + f_shutdown_helper(); } testcase TC_ranap_ps_initial_ue_empty_cr() runs on test_CT { var ConnHdlr vc_conn; @@ -875,6 +881,8 @@ /* reset */ f_vty_set_sccp_max_optional_data(HNBGWVTY); + + f_shutdown_helper(); } type record Testdata_CR_Limit { @@ -927,6 +935,8 @@ /* reset */ f_vty_set_sccp_max_optional_data(HNBGWVTY); + + f_shutdown_helper(); } /* Reply to a received CRCX with an OK (or the reply configured in cpars), using the given parameters. @@ -1147,6 +1157,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assignment), t_pars(3)); vc_conn.done; + + f_shutdown_helper(); } friend function f_tc_rab_assign_fail(charstring id, TestHdlrParams pars) runs on ConnHdlr { @@ -1183,6 +1195,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_fail), t_pars(4)); vc_conn.done; + + f_shutdown_helper(); } friend function f_tc_rab_release(charstring id, TestHdlrParams pars) runs on ConnHdlr { @@ -1223,6 +1237,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_rab_release), t_pars(5)); vc_conn.done; + + f_shutdown_helper(); } friend function f_tc_rab_assign_mgcp_to(charstring id, TestHdlrParams pars) runs on ConnHdlr { @@ -1272,6 +1288,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_mgcp_to), t_pars(6)); vc_conn.done; + + f_shutdown_helper(); } /* Create an Iuh connection; send InitialUE; transceive data both directions */ @@ -1297,6 +1315,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_ranap_bidir), t_pars(3)); vc_conn.done; + + f_shutdown_helper(); } testcase TC_ranap_ps_bidir() runs on test_CT { var ConnHdlr vc_conn; @@ -1306,6 +1326,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_ranap_bidir), t_pars(4, true)); vc_conn.done; + + f_shutdown_helper(); } @@ -1331,6 +1353,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_ranap_mo_disconnect), t_pars(5)); vc_conn.done; + + f_shutdown_helper(); } testcase TC_ranap_ps_mo_disconnect() runs on test_CT { var ConnHdlr vc_conn; @@ -1340,6 +1364,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_ranap_mo_disconnect), t_pars(6)); vc_conn.done; + + f_shutdown_helper(); } type record FTeid { @@ -1508,6 +1534,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment_with_pfcp), t_pars(7, ps_domain := true)); vc_conn.done; + + f_shutdown_helper(); } altstep as_disallow_pfcp() runs on ConnHdlr { @@ -1570,6 +1598,8 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment_without_pfcp), t_pars(7, ps_domain := true)); vc_conn.done; + + f_shutdown_helper(); } control { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie2088bc8786742a1dffb0132f4b162fb2649fb9b Gerrit-Change-Number: 33407 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: give RAN startup some time
by neels 23 Jun '23

23 Jun '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33408 ) Change subject: hnbgw: give RAN startup some time ...................................................................... hnbgw: give RAN startup some time We have sporadic test failure, because the test starts to send RUA messages before the CN link was able to perform a RANAP RESET + ACK procedure. Since recently, osmo-hnbgw is stricter on RANAP RESET: it will only start passing RUA connections to the CN when the CN link has seen a RANAP RESET ACK (from either side). So now, when the test is too quick, its first RUA message is dropped on the floor, and the test fails, since the RANAP never turns up on SCCP. This is a quick hack, better would be to wait for some signal from the RAN_Emulation when we are ready. This jenkins trace shows that the RUA InitialUE happens about 200 ms before RESET ACK is complete: Time Protocol Info 04:02:17.088852 RANAP Reset 04:02:17.105820 RANAP Reset 04:02:17.899887 RANAP (RUA) InitialUE-Message (DTAP) (Unknown) 04:02:17.905122 RANAP Reset 04:02:17.906043 RANAP SACK (Ack=2, Arwnd=106496) ResetAcknowledge 04:02:17.906056 RANAP SACK (Ack=5, Arwnd=106436) ResetAcknowledge 04:02:18.081522 RANAP Reset ResetAcknowledge 04:02:18.082829 RANAP SACK (Ack=4, Arwnd=106496) ResetAcknowledge https://jenkins.osmocom.org/jenkins/job/ttcn3-hnbgw-test/512/artifact/logs/… Change-Id: Icbe7220112fbfe4ff5a5e1b9b65eeec428e51530 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 39 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index c3dbecd..e5f227e 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -465,6 +465,8 @@ f_vty_transceive(HNBGWVTY, "enable"); /* TODO: CTRL? */ + + f_sleep(1.0); } /* global altstep for global guard timer; */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icbe7220112fbfe4ff5a5e1b9b65eeec428e51530 Gerrit-Change-Number: 33408 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0