June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: gitignore: add arm-poky-linux-gnueabi-libtool

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33412 ) Change subject: gitignore: add arm-poky-linux-gnueabi-libtool ...................................................................... gitignore: add arm-poky-linux-gnueabi-libtool This file gets copied into the tree when building with the SDK. Change-Id: I0fe4f96175ee94eb0a131c425bbeb110f1d55402 --- M .gitignore 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/33412/1 diff --git a/.gitignore b/.gitignore index a18b040..bf0f844 100644 --- a/.gitignore +++ b/.gitignore @@ -107,3 +107,5 @@ contrib/osmo-bts.spec contrib/ber/rtp_ber contrib/ber/rtp_gen_map + +arm-poky-linux-gnueabi-libtool -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0fe4f96175ee94eb0a131c425bbeb110f1d55402 Gerrit-Change-Number: 33412 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

[S] Change in libosmocore[master]: Fix various uninitialized value errors

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors ...................................................................... Patch Set 1: (1 comment) File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/267b4a3f_c3b8519a PS1, Line 490: struct osmo_nri_range add_range = {}; > Coverity is basically unhappy because at line 497 we're copying a struct with partly-initialized fie […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f Gerrit-Change-Number: 33400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:50:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmocore[master]: Fix various uninitialized value errors

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors ...................................................................... Patch Set 1: (1 comment) File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/2cd7f9b9_034e2aca PS1, Line 490: struct osmo_nri_range add_range = {}; > Then I see no problem? everything is as expected? Coverity is basically unhappy because at line 497 we're copying a struct with partly-initialized fields. This can be easily solved by moving it below the check at line 499, as you suggested. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f Gerrit-Change-Number: 33400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:47:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmocore[master]: Fix various uninitialized value errors

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors ...................................................................... Patch Set 1: (1 comment) File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/d6613dbd_7d6e5340 PS1, Line 490: struct osmo_nri_range add_range = {}; > It's not required to be zero-initialized. […] Then I see no problem? everything is as expected? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f Gerrit-Change-Number: 33400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:39:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33394 ) Change subject: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str ...................................................................... gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str Fixes: CID#321280 Change-Id: Id372d2d844446d6667a00dae22bdf8ed36c599ba --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 1d99421..5664f4c 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -1110,6 +1110,7 @@ struct gsm_mncc *alerting = arg; struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 CC ALERT"); struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh)); + int rc; gh->msg_type = GSM48_MT_CC_ALERTING; @@ -1128,7 +1129,11 @@ if (alerting->sdp[0]) { struct call_leg *cl = trans->msc_a->cc.call_leg; struct rtp_stream *rtp_cn = cl ? cl->rtp[RTP_TO_CN] : NULL; - sdp_msg_from_sdp_str(&trans->cc.remote, alerting->sdp); + + rc = sdp_msg_from_sdp_str(&trans->cc.remote, alerting->sdp); + if (rc < 0) + return rc; + trans_cc_filter_run(trans); LOG_TRANS(trans, LOGL_DEBUG, "msg_type=%s\n", get_mncc_name(alerting->msg_type)); if (rtp_cn) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id372d2d844446d6667a00dae22bdf8ed36c599ba Gerrit-Change-Number: 33394 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[M] Change in libosmocore[master]: logging: add log level cache

by fixeria

Attention is currently required from: Hoernchen, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633 ) Change subject: logging: add log level cache ...................................................................... Patch Set 12: (1 comment) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/0e3fe6b6_67164345 PS12, Line 1557: talloc_free(osmo_log_info); do `osmo_log_info = NULL` like below? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 23 Jun 2023 10:50:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33394 ) Change subject: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id372d2d844446d6667a00dae22bdf8ed36c599ba Gerrit-Change-Number: 33394 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 10:40:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33394 ) Change subject: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/33394/comment/b9d2b457_12202866 PS1, Line 1113: int rc; could be moved to the scope of use, but not critical -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id372d2d844446d6667a00dae22bdf8ed36c599ba Gerrit-Change-Number: 33394 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 10:40:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-msc[master]: csd_bs_list_to_gsm0808_channel_type: fix rc check

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33393 ) Change subject: csd_bs_list_to_gsm0808_channel_type: fix rc check ...................................................................... csd_bs_list_to_gsm0808_channel_type: fix rc check Check the return code before writing it to unsigned ct->data_rate, as "ct->data_rate < 0" is never true. Fixes: CID#321277 Fixes: 106321 ("Add initial CSD support with external MNCC") Change-Id: I5d77da71b60748818ba631229126c1bf061a9c7d --- M src/libmsc/csd_bs.c 1 file changed, 19 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libmsc/csd_bs.c b/src/libmsc/csd_bs.c index adb9293..2322f20 100644 --- a/src/libmsc/csd_bs.c +++ b/src/libmsc/csd_bs.c @@ -375,14 +375,16 @@ if (csd_bs_is_transp(list->bs[0])) { ct->data_transparent = true; - ct->data_rate = csd_bs_to_gsm0808_data_rate_transp(list->bs[0]); + rc = csd_bs_to_gsm0808_data_rate_transp(list->bs[0]); } else { - ct->data_rate = csd_bs_to_gsm0808_data_rate_non_transp(list->bs[0]); + rc = csd_bs_to_gsm0808_data_rate_non_transp(list->bs[0]); } - if (ct->data_rate < 0) + if (rc < 0) return -EINVAL; + ct->data_rate = rc; + /* Other possible data rates allowed (3GPP TS 48.008 § 3.2.2.11, 5a) */ if (!ct->data_transparent && list->count > 1) { for (i = 1; i < list->count; i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5d77da71b60748818ba631229126c1bf061a9c7d Gerrit-Change-Number: 33393 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in osmo-msc[master]: csd_bs_list_to_gsm0808_channel_type: fix rc check

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33393 ) Change subject: csd_bs_list_to_gsm0808_channel_type: fix rc check ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5d77da71b60748818ba631229126c1bf061a9c7d Gerrit-Change-Number: 33393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 10:38:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2023