neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33408 )
Change subject: hnbgw: give RAN startup some time
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icbe7220112fbfe4ff5a5e1b9b65eeec428e51530
Gerrit-Change-Number: 33408
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jun 2023 03:08:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33408
to look at the new patch set (#2).
Change subject: hnbgw: give RAN startup some time
......................................................................
hnbgw: give RAN startup some time
We have sporadic test failure, because the test starts to send RUA
messages before the CN link was able to perform a RANAP RESET + ACK
procedure.
Since recently, osmo-hnbgw is stricter on RANAP RESET: it will only
start passing RUA connections to the CN when the CN link has seen a
RANAP RESET ACK (from either side). So now, when the test is too quick,
its first RUA message is dropped on the floor, and the test fails, since
the RANAP never turns up on SCCP.
This is a quick hack, better would be to wait for some signal from the
RAN_Emulation when we are ready.
This jenkins trace shows that the RUA InitialUE happens about 200 ms
before RESET ACK is complete:
Time Protocol Info
04:02:17.088852 RANAP Reset
04:02:17.105820 RANAP Reset
04:02:17.899887 RANAP (RUA) InitialUE-Message (DTAP) (Unknown)
04:02:17.905122 RANAP Reset
04:02:17.906043 RANAP SACK (Ack=2, Arwnd=106496) ResetAcknowledge
04:02:17.906056 RANAP SACK (Ack=5, Arwnd=106436) ResetAcknowledge
04:02:18.081522 RANAP Reset ResetAcknowledge
04:02:18.082829 RANAP SACK (Ack=4, Arwnd=106496) ResetAcknowledge
https://jenkins.osmocom.org/jenkins/job/ttcn3-hnbgw-test/512/artifact/logs/…
Change-Id: Icbe7220112fbfe4ff5a5e1b9b65eeec428e51530
---
M hnbgw/HNBGW_Tests.ttcn
1 file changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/33408/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icbe7220112fbfe4ff5a5e1b9b65eeec428e51530
Gerrit-Change-Number: 33408
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33408 )
Change subject: hnbgw: give RAN startup some time
......................................................................
hnbgw: give RAN startup some time
We have sporadic test failure, because the test starts to send RUA
messages before the CN link was able to perform a RANAP RESET + ACK
procedure.
Since recently, osmo-hnbgw is stricter on RANAP RESET: it will only
start passing RUA connections to the CN when the CN link has seen a
RANAP RESET ACK (from either side). So now, when the test is too quick,
its first RUA message is dropped on the floor, and the test fails, since
the RANAP never turns up on SCCP.
This is a quick hack, better would be to wait for some signal from the
RAN_Emulation when we are ready.
This jenkins trace shows that the RUA InitialUE happens about 200 ms
before RESET ACK is complete:
https://jenkins.osmocom.org/jenkins/job/ttcn3-hnbgw-test/512/artifact/logs/…
No. Time src dst Protocol Info
118 04:02:17.088852 172.18.124.200,2905,189 172.18.124.203,23905,188 RANAP Reset
167 04:02:17.105820 172.18.124.200,2905,189 172.18.124.203,23906,185 RANAP Reset
193 04:02:17.899887 172.18.124.203,9999 172.18.124.20,29169 RANAP (RUA) InitialUE-Message (DTAP) (Unknown)
210 04:02:17.905122 172.18.124.203,23906,185 172.18.124.200,2905,189 RANAP Reset
258 04:02:17.906043 172.18.124.200,2905,189 172.18.124.203,23906,185 RANAP SACK (Ack=2, Arwnd=106496) ResetAcknowledge
259 04:02:17.906056 172.18.124.203,23906,185 172.18.124.200,2905,189 RANAP SACK (Ack=5, Arwnd=106436) ResetAcknowledge
288 04:02:18.081522 172.18.124.203,23905,188,188 172.18.124.200,2905,189,189 RANAP Reset ResetAcknowledge
363 04:02:18.082829 172.18.124.200,2905,189 172.18.124.203,23905,188 RANAP SACK (Ack=4, Arwnd=106496) ResetAcknowledge
Change-Id: Icbe7220112fbfe4ff5a5e1b9b65eeec428e51530
---
M hnbgw/HNBGW_Tests.ttcn
1 file changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/33408/1
diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index c3dbecd..e5f227e 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -465,6 +465,8 @@
f_vty_transceive(HNBGWVTY, "enable");
/* TODO: CTRL? */
+
+ f_sleep(1.0);
}
/* global altstep for global guard timer; */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icbe7220112fbfe4ff5a5e1b9b65eeec428e51530
Gerrit-Change-Number: 33408
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newchange
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33406 )
Change subject: fix hnbgw: RAN_Emu: ranap_unitdata_cb: call only when present
......................................................................
fix hnbgw: RAN_Emu: ranap_unitdata_cb: call only when present
osmo-hnbgw since recently sends own RANAP RESET out to the CN links. So
HNBGW_Tests.ttcn now receives a lot more UnitData messages.
Turns out that tests crash when no UnitData callback is provided.
Currently only osmo-hnbgw and RANAP, i.e. ranap_unitdata_cb, needs this
fix, but also apply the same safeguard to the BSSAP unitdata_cb.
Change-Id: I699a42de88b15f6f47b8feece7639e0dfaf31955
---
M library/RAN_Emulation.ttcnpp
1 file changed, 23 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
neels: Looks good to me, approved
diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp
index 543df2b..6a1f784 100644
--- a/library/RAN_Emulation.ttcnpp
+++ b/library/RAN_Emulation.ttcnpp
@@ -515,6 +515,9 @@
log("CommonBssmapUnitdataCallback: Not a paging message");
}
/* ELSE: handle in user callback */
+ if (not ispresent(g_ran_ops.unitdata_cb)) {
+ return omit;
+ }
return g_ran_ops.unitdata_cb.apply(bssap);
}
@@ -675,6 +678,9 @@
}
/* ELSE: handle in user callback */
+ if (not ispresent(g_ran_ops.ranap_unitdata_cb)) {
+ return omit;
+ }
return g_ran_ops.ranap_unitdata_cb.apply(ranap);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33406
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I699a42de88b15f6f47b8feece7639e0dfaf31955
Gerrit-Change-Number: 33406
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: merged
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33406 )
Change subject: fix hnbgw: RAN_Emu: ranap_unitdata_cb: call only when present
......................................................................
fix hnbgw: RAN_Emu: ranap_unitdata_cb: call only when present
osmo-hnbgw since recently sends own RANAP RESET out to the CN links. So
HNBGW_Tests.ttcn now receives a lot more UnitData messages.
Turns out that tests crash when no UnitData callback is provided.
Currently only osmo-hnbgw and RANAP, i.e. ranap_unitdata_cb, needs this
fix, but also apply the same safeguard to the BSSAP unitdata_cb.
Change-Id: I699a42de88b15f6f47b8feece7639e0dfaf31955
---
M library/RAN_Emulation.ttcnpp
1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/33406/1
diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp
index 543df2b..6a1f784 100644
--- a/library/RAN_Emulation.ttcnpp
+++ b/library/RAN_Emulation.ttcnpp
@@ -515,6 +515,9 @@
log("CommonBssmapUnitdataCallback: Not a paging message");
}
/* ELSE: handle in user callback */
+ if (not ispresent(g_ran_ops.unitdata_cb)) {
+ return omit;
+ }
return g_ran_ops.unitdata_cb.apply(bssap);
}
@@ -675,6 +678,9 @@
}
/* ELSE: handle in user callback */
+ if (not ispresent(g_ran_ops.ranap_unitdata_cb)) {
+ return omit;
+ }
return g_ran_ops.ranap_unitdata_cb.apply(ranap);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33406
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I699a42de88b15f6f47b8feece7639e0dfaf31955
Gerrit-Change-Number: 33406
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: falconia.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29973 )
Change subject: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Cool, I never considered / tried Call Waiting before.
It would be great to see some ladder diagram or somesuch for the scenario that this patch fixes, if you can spare the time.
We also have this script that makes ladder diagrams from reading an osmo-msc log. Unfortunately it seems I forgot to document the logging configuration that this needs, I'm guessing:
log file /tmp/osmo-msc.log
logging filter all 1
logging color 0
logging print level 1
logging print category 1
logging print category-hex 0
logging print file basename last
logging print extended-timestamp 1
logging level set-all debug
and then run your call-waiting scenario. After that, get a ladder diagram from the log file with these two lines:
~/src/osmo-msc/doc/sequence_charts/msc_log_to_ladder.py -i /tmp/osmo-msc.log -o /tmp/foo.msc
mscgen -T png -o foo.png /tmp/foo.msc
You could add that foo.msc diagram, as part of this patch, to osmo-msc/doc/sequence_charts, next to the other ones that illustrating the order of things in various kinds of voice calls.
All this is optional, but it would help me a lot to understand the context.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29973
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ibb62cb3c154b99769b2dfe708f73c20e8b632f5d
Gerrit-Change-Number: 29973
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Thu, 22 Jun 2023 21:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: arehbein, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 )
Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
@arehbein you have CR+2 now, the only thing needed is a V+1. We don't have a gerrit job doing that for this repository, so we need a V+1 vote from someone who ran this code and has seen that it works. Hint, hint, that someone could be you =)
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664
Gerrit-Change-Number: 30980
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Jun 2023 21:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
