June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fix compilation warnings (template restrictions)
by fixeria 27 Jun '23

27 Jun '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33520 to look at the new patch set (#2). Change subject: SGSN_Tests: fix compilation warnings (template restrictions) ...................................................................... SGSN_Tests: fix compilation warnings (template restrictions) This patch fixes multiple compilation warnings like this one: Inadequate restriction on the referenced template variable `attach_req', this may cause a dynamic test case error at runtime Change-Id: Iee7760d3dcf2a35d7fe612ed80dc13c1d11e0897 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 27 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/33520/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iee7760d3dcf2a35d7fe612ed80dc13c1d11e0897 Gerrit-Change-Number: 33520 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fix TC_attach_timeout_after_pdp_act
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: fixeria. fixeria has uploaded a new patch set (#4) to the change originally created by arehbein. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 ) Change subject: SGSN_Tests: fix TC_attach_timeout_after_pdp_act ...................................................................... SGSN_Tests: fix TC_attach_timeout_after_pdp_act This patch fixes several problems: * missing "vc_conn.done": the actual testsuite logic, which can be found in f_TC_attach_timeout_after_pdp_act(), was never executed fully because we did not wait for the BSSGP_ConnHdlr to complete; * too short Tguard value: the testsuite logic takes slightly more time to complete than the default timeout of 30.0 seconds; * osmo-sgsn does not require authentication for the second ATTACH.req: the testsuite logic gets stuck in f_gmm_auth() after sending the second ATTACH.req because: ** osmo-sgsn is waiting for a response to GMM IDENTITY REQUEST, ** osmo-sgsn does not send GSUP SendAuthInfo.req again. As can be seen from the test execution artifacts on Jenkins, this testcase never passed: either failing due to an error, or declaring no verdict at all. The average execution time is 650 ms. Change-Id: Ibaf2134247153471bd45d7a7f91155294c6c6de5 Fixes: 3ede9e32b "sgsn: Add TC_attach_timeout_after_pdp_act" Closes: OS#4221 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 46 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/33465/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibaf2134247153471bd45d7a7f91155294c6c6de5 Gerrit-Change-Number: 33465 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fix compilation warnings (template restrictions)
by fixeria 27 Jun '23

27 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33520 ) Change subject: SGSN_Tests: fix compilation warnings (template restrictions) ...................................................................... SGSN_Tests: fix compilation warnings (template restrictions) This patch fixes multiple compilation warnings like this one: Inadequate restriction on the referenced template variable `attach_req', this may cause a dynamic test case error at runtime Change-Id: Iee7760d3dcf2a35d7fe612ed80dc13c1d11e0897 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 27 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/33520/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 88cbbb1..ac25caa 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -757,7 +757,7 @@ auth_ciph_req.msgs.gprs_mm.authenticationAndCipheringRequest.authenticationParameterAUTN := autn; l3_mt := f_receive_l3(auth_ciph_req, ran_index); var BIT4 ac_ref := l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.acReferenceNumber.valueField; - var template PDU_L3_MS_SGSN auth_ciph_resp := ts_GMM_AUTH_RESP_2G(ac_ref, g_pars.vec.sres); + var template (value) PDU_L3_MS_SGSN auth_ciph_resp := ts_GMM_AUTH_RESP_2G(ac_ref, g_pars.vec.sres); if (umts_aka_challenge and not force_gsm_sres) { /* set UMTS response instead */ @@ -885,7 +885,7 @@ friend function f_gmm_attach(boolean umts_aka_challenge, boolean force_gsm_sres, integer ran_index := 0, template (omit) RoutingAreaIdentificationV old_ra := omit) runs on BSSGP_ConnHdlr { var RoutingAreaIdentificationV old_ra_val; - var template PDU_L3_MS_SGSN attach_req; + var template (value) PDU_L3_MS_SGSN attach_req; var PDU_L3_SGSN_MS l3_mt; if (istemplatekind(old_ra, "omit")) { @@ -1027,7 +1027,7 @@ const integer gmm_attach_repeats := 5; /* See TS 24.008 Rel. 16 Table 11.4 */ const float T3350 := 6.0; - var template PDU_L3_MS_SGSN attach_req; + var template (value) PDU_L3_MS_SGSN attach_req; timer t_receive_GMM_ATTACH_ACCEPT; var RoutingAreaIdentificationV rai := f_random_RAI(); timer T; @@ -2630,7 +2630,7 @@ friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer ran_index := 0) runs on BSSGP_ConnHdlr { var PDU_L3_SGSN_MS l3_mt; var PDU_DTAP_PS_MT mt; - var template OCT4 p_tmsi := omit; + var template (omit) OCT4 p_tmsi := omit; if (is_iu(ran_index)) { p_tmsi := g_pars.p_tmsi; @@ -2807,7 +2807,7 @@ private function f_TC_attach_usim_resync(charstring id) runs on BSSGP_ConnHdlr { var RoutingAreaIdentificationV old_ra := f_random_RAI(); - var template PDU_L3_MS_SGSN attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit); + var template (value) PDU_L3_MS_SGSN attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit); /* send Attach Request */ /* indicate R99 capability of the MS to enable UMTS AKA in presence of @@ -2879,7 +2879,7 @@ auth_ciph_req.msgs.gprs_mm.authenticationAndCipheringRequest.authenticationParameterAUTN := autn; BSSGP[0].receive(auth_ciph_req) -> value l3_mt; var BIT4 ac_ref := l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.acReferenceNumber.valueField; - var template PDU_L3_MS_SGSN auth_ciph_resp := ts_GMM_AUTH_RESP_2G(ac_ref, g_pars.vec.sres); + var template (value) PDU_L3_MS_SGSN auth_ciph_resp := ts_GMM_AUTH_RESP_2G(ac_ref, g_pars.vec.sres); auth_ciph_resp := ts_GMM_AUTH_RESP_2G(ac_ref, g_pars.vec.sres); auth_ciph_resp.msgs.gprs_mm.authenticationAndCipheringResponse.authenticationParResp := { valueField := substr(g_pars.vec.res, 0, 4) @@ -2936,7 +2936,7 @@ private function f_TC_attach_usim_crypt(OCT1 netcap_a2345, BIT3 auth_req_ciph) runs on BSSGP_ConnHdlr { var RoutingAreaIdentificationV old_ra := f_random_RAI(); - var template PDU_L3_MS_SGSN attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit); + var template (value) PDU_L3_MS_SGSN attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit); attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.spare_octets := netcap_a2345; /* GEA2345... */ /* send Attach Request */ @@ -3192,7 +3192,7 @@ var RoutingAreaIdentificationV old_ra := f_random_RAI(); var RoutingAreaIdentificationV new_ra := f_random_RAI(); while (old_ra == new_ra) { new_ra := f_random_RAI(); }; - var template PDU_L3_MS_SGSN attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit); + var template (value) PDU_L3_MS_SGSN attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit); var PDU_L3_SGSN_MS l3_mt; f_send_l3(attach_req, 0); @@ -3392,9 +3392,9 @@ var template RIM_Routing_Address dst_addr; var template RIM_Routing_Address src_addr; - var template RAN_Information_Request_RIM_Container req_cont; - var template RAN_Information_RIM_Container res_cont; - var template PDU_BSSGP bssgp_rim_pdu; + var template (value) RAN_Information_Request_RIM_Container req_cont; + var template (value) RAN_Information_RIM_Container res_cont; + var template (value) PDU_BSSGP bssgp_rim_pdu; var template PDU_BSSGP bssgp_rim_pdu_expect; dst_addr := t_RIM_Routing_Address_cid(g_gb[1].cfg.bvc[0].cell_id); @@ -3520,8 +3520,8 @@ /* Now also emulate also the response as well and send it back on GB interface #1. Expect the result on * GTPC */ - var template RAN_Information_RIM_Container res_cont; - var template PDU_BSSGP bssgp_rim_pdu; + var template (value) RAN_Information_RIM_Container res_cont; + var template (value) PDU_BSSGP bssgp_rim_pdu; res_cont := ts_RAN_Information_RIM_Container(ts_RIM_Application_Identity(RIM_APP_ID_NACC), ts_RIM_Sequence_Number(2), ts_RIM_PDU_Indications(false, RIM_PDU_TYPE_SING_REP), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iee7760d3dcf2a35d7fe612ed80dc13c1d11e0897 Gerrit-Change-Number: 33520 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fix TC_attach_timeout_after_pdp_act
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: fixeria. fixeria has uploaded a new patch set (#3) to the change originally created by arehbein. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 ) Change subject: SGSN_Tests: fix TC_attach_timeout_after_pdp_act ...................................................................... SGSN_Tests: fix TC_attach_timeout_after_pdp_act This patch fixes several problems: * missing "vc_conn.done": the actual testsuite logic, which can be found in f_TC_attach_timeout_after_pdp_act(), was never executed fully because we did not wait for the BSSGP_ConnHdlr to complete; * too short Tguard value: the testsuite logic takes slightly more time to complete than the default timeout of 30.0 seconds; * osmo-sgsn does not require authentication for the second ATTACH.req: the testsuite logic gets stuck in f_gmm_auth() after sending the second ATTACH.req because: ** osmo-sgsn is waiting for a response to GMM IDENTITY REQUEST, ** osmo-sgsn does not send GSUP SendAuthInfo.req again. As can be seen from the test execution artifacts on Jenkins, this testcase never passed: either failing due to an error, or declaring no verdict at all. The average execution time is 650 ms. Change-Id: Ibaf2134247153471bd45d7a7f91155294c6c6de5 Fixes: 3ede9e32b "sgsn: Add TC_attach_timeout_after_pdp_act" Closes: OS#4221 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 46 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/33465/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibaf2134247153471bd45d7a7f91155294c6c6de5 Gerrit-Change-Number: 33465 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: turn f_gmm_gsup_lu_isd() into an altstep
by fixeria 27 Jun '23

27 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33519 ) Change subject: SGSN_Tests: turn f_gmm_gsup_lu_isd() into an altstep ...................................................................... SGSN_Tests: turn f_gmm_gsup_lu_isd() into an altstep This way it can be used in the alt statements. Change-Id: I1baaf6ed66cfaa75237b0abdce82ffdc7e672b96 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 23 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/33519/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 7cdf72c..0e5b43a 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -872,15 +872,14 @@ } } -private function f_gmm_gsup_lu_isd() runs on BSSGP_ConnHdlr { - var GSUP_PDU gsup; - /* Expect MSC to perform LU with HLR */ - GSUP.receive(tr_GSUP_UL_REQ(g_pars.imsi)); - gsup := valueof(ts_GSUP_ISD_REQ(g_pars.imsi, g_pars.msisdn)); - gsup.ies := gsup.ies & { valueof(ts_GSUP_IE_PdpInfo(char2oct("*"), '0121'O, ''O)) }; - GSUP.send(gsup); - GSUP.receive(tr_GSUP_ISD_RES(g_pars.imsi)); - GSUP.send(ts_GSUP_UL_RES(g_pars.imsi)); +private altstep as_gmm_gsup_lu_isd() runs on BSSGP_ConnHdlr { + [] GSUP.receive(tr_GSUP_UL_REQ(g_pars.imsi)) { + var GSUP_PDU gsup := valueof(ts_GSUP_ISD_REQ(g_pars.imsi, g_pars.msisdn)); + gsup.ies := gsup.ies & { valueof(ts_GSUP_IE_PdpInfo(char2oct("*"), '0121'O, ''O)) }; + GSUP.send(gsup); + GSUP.receive(tr_GSUP_ISD_RES(g_pars.imsi)); + GSUP.send(ts_GSUP_UL_RES(g_pars.imsi)); + } } friend function f_gmm_attach(boolean umts_aka_challenge, boolean force_gsm_sres, integer ran_index := 0, @@ -906,7 +905,7 @@ f_send_l3(attach_req, ran_index); f_gmm_auth(umts_aka_challenge, force_gsm_sres, ran_index); /* Expect SGSN to perform LU with HLR */ - f_gmm_gsup_lu_isd(); + as_gmm_gsup_lu_isd(); l3_mt := f_receive_l3(tr_GMM_ATTACH_ACCEPT('001'B, ?, ?), ran_index); f_process_attach_accept(l3_mt.msgs.gprs_mm.attachAccept, ran_index); @@ -1216,7 +1215,7 @@ f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, true, false, omit, omit)); f_gmm_auth(); /* Expect MSC to perform LU with HLR */ - f_gmm_gsup_lu_isd(); + as_gmm_gsup_lu_isd(); BSSGP[0].receive(tr_GMM_ATTACH_ACCEPT('001'B, ?, ?)) -> value l3_mt { f_process_attach_accept(l3_mt.msgs.gprs_mm.attachAccept); @@ -2579,7 +2578,7 @@ f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), f_random_RAI(), true, false, omit, omit)); f_gmm_auth(); /* Expect SGSN to perform LU with HLR */ - f_gmm_gsup_lu_isd(); + as_gmm_gsup_lu_isd(); timer T := 10.0; T.start; @@ -2887,7 +2886,7 @@ deactivate(di); /* Expect SGSN to perform LU with HLR */ - f_gmm_gsup_lu_isd(); + as_gmm_gsup_lu_isd(); BSSGP[0].receive(tr_GMM_ATTACH_ACCEPT('001'B, ?, ?)) -> value l3_mt { f_process_attach_accept(l3_mt.msgs.gprs_mm.attachAccept); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1baaf6ed66cfaa75237b0abdce82ffdc7e672b96 Gerrit-Change-Number: 33519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-sccp[master]: vty: Improve output of show cs7 instance <0-15> asp
by osmith 27 Jun '23

27 Jun '23

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33518 ) Change subject: vty: Improve output of show cs7 instance <0-15> asp ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/33518/comment/6b3ff3c9_1a614d90 PS2, Line 8: Noting that Role and SCTP Role are now printed would be useful here File src/osmo_ss7_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/33518/comment/a39864d2_475ca2e9 PS2, Line 828: Remote IP Addr:Rmt Port it might be useful to shorten this while at it, to "Remote IP:Port"? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Id22bd4e74fb6f79950adba58862d379203d36760 Gerrit-Change-Number: 33518 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:37:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Wait for USF before start using UL TBF
by osmith 27 Jun '23

27 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33466 ) Change subject: pcu: Wait for USF before start using UL TBF ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33466/comment/42cea031_e60f… PS3, Line 995: receiveing receiving -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe8f8c24b239715c0a43d52e59475011e78cb4eb Gerrit-Change-Number: 33466 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:29:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: fix record PCUIF_pch_dt
by dexter 27 Jun '23

27 Jun '23

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 ) Change subject: PCUIF_Types: fix record PCUIF_pch_dt ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417/comment/12600845_0498… PS1, Line 10: it would pad the data with zeros if it does not fit the : specified length. This is unwanted > AFAIR, the `ALIGN` attribute tells where to put the payload if it's less than the buffer size: eithe […] My observation here is that when ALIGN(left) is used, the buffer is padded with zeros at the beginning. The "ALIGN" behaves more like a "PAD". With ALIGN(left) the buffer looks like this: 0000000000000000313233343539393837 Without ALIGN(left) (or with ALIGN(right)) the buffer looks like: 3132333435393938370000000000000000 (correct) Unfortunately I do not fully understand this either. Maybe align in this context is more about padding - I am not sure. Patchset: PS1: I have re-tested this, everything seems to be fine but I also didn't fully understand how the ALIGN attribute works (see comment). Since everything works as expected I would say that we can merge this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I011eb2496b1422c49736b227dfa1e2a2d6096d67 Gerrit-Change-Number: 33417 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:25:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by osmith 27 Jun '23

27 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 8: (2 comments) File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/0d303118_06367600 PS7, Line 1271: oml_mo_rf_lock_chg(&trx->mo, fl1h->last_rf_mute, 0); > I meant call to the oml_mo_rf_lock_chg() function, which also happens in the success case. […] I've verified that it sends a Change Administrative State Ack/Nack. Updated the patch to send it only after opstart_success, and verified that it behaves as expected. File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/846a6fe7_23ffd135 PS8, Line 1342: int trx_rf_lock(struct gsm_bts_trx *trx, int locked, l1if_compl_cb *cb); Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by osmith 27 Jun '23

27 Jun '23

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 to look at the new patch set (#9). Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... osmo-bts-sysmo: mute PHY until OML is ready Connecting to OML and PHY is done in parallel. The PHY connection will always be done first, mute PHY until OML is also ready. As Pau suggested, move dispatch of NM_EV_SW_ACT to a callback of trx_rf_lock to have the events serialized and therefore deterministic. Fixes: SYS#6496 Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 --- M src/osmo-bts-sysmo/l1_if.c M src/osmo-bts-sysmo/oml.c 2 files changed, 42 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/57/33457/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 9 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0