June 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by osmith 27 Jun '23

27 Jun '23

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 to look at the new patch set (#10). Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... osmo-bts-sysmo: mute PHY until OML is ready Connecting to OML and PHY is done in parallel. The PHY connection will always be done first, mute PHY until OML is also ready. As Pau suggested, move dispatch of NM_EV_SW_ACT to a callback of trx_rf_lock to have the events serialized and therefore deterministic. Fixes: SYS#6496 Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 --- M src/osmo-bts-sysmo/l1_if.c M src/osmo-bts-sysmo/oml.c 2 files changed, 42 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/57/33457/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 10 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: pcu_sock: use PCUIF version 11 (direct TLLI)
by dexter 27 Jun '23

27 Jun '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33522 ) Change subject: pcu_sock: use PCUIF version 11 (direct TLLI) ...................................................................... pcu_sock: use PCUIF version 11 (direct TLLI) OsmoBTS still uses the deprecated version 10 of the PCUIF protocol. OsmoPCU is still compatible to version 10, but to maintain a clean interface it is planned to drop the support for version 10 in the near future. Moving to PCUIF v.11 essentially means using the "Direct TLLI" method to convey IMMEDIATE ASSIGNMENT and also PAGING COMMAND messages through the PCU socket. This means in particular that we use a TLLI as an identifier to confirm IMMEDIATE ASSIGNMENT messages towards the PCU (PAGING COMMAND is not confirmed at all). Also we now use struct gsm_pcu_if_pch_dt to parse the incoming PCU_IF_SAPI_PCH_DT, which is much cleaner than using offsets in a buffer. Change-Id: I25816ac12e63cc6b641eb414e6bc7eaa9c85fc25 Depends: osmo-ttcn3-hacks.git I08de02e951e10bc8b4381cc2ad32e63f2747e3c4 Depends: docker-playground.git Ia28bc0d6d3cbfe63be19443db86631fb67bb80fb Related: OS#5927 --- M include/osmo-bts/paging.h M include/osmo-bts/pcu_if.h M include/osmo-bts/pcuif_proto.h M src/common/paging.c M src/common/pcu_sock.c 5 files changed, 67 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/22/33522/1 diff --git a/include/osmo-bts/paging.h b/include/osmo-bts/paging.h index 9a30abb..d604536 100644 --- a/include/osmo-bts/paging.h +++ b/include/osmo-bts/paging.h @@ -37,7 +37,7 @@ /* Add a ready formatted MAC block message to the paging queue, this can be an IMMEDIATE ASSIGNMENT, or a * PAGING COMMAND (from the PCU) */ -int paging_add_macblock(struct paging_state *ps, const char *imsi, bool confirm, const uint8_t *macblock); +int paging_add_macblock(struct paging_state *ps, uint32_t tlli, const char *imsi, bool confirm, const uint8_t *macblock); /* generate paging message for given gsm time */ int paging_gen_msg(struct paging_state *ps, uint8_t *out_buf, struct gsm_time *gt, diff --git a/include/osmo-bts/pcu_if.h b/include/osmo-bts/pcu_if.h index 8e3b3ba..b8ce9c4 100644 --- a/include/osmo-bts/pcu_if.h +++ b/include/osmo-bts/pcu_if.h @@ -23,7 +23,7 @@ int pcu_tx_time_ind(uint32_t fn); int pcu_tx_interf_ind(const struct gsm_bts_trx *trx, uint32_t fn); int pcu_tx_pag_req(const uint8_t *identity_lv, uint8_t chan_needed); -int pcu_tx_pch_data_cnf(uint32_t fn, uint8_t *data, uint8_t len); +int pcu_tx_pch_data_cnf(uint32_t fn, uint32_t tlli); int pcu_tx_susp_req(struct gsm_lchan *lchan, uint32_t tlli, const uint8_t *ra_id, uint8_t cause); int pcu_sock_send(struct msgb *msg); diff --git a/include/osmo-bts/pcuif_proto.h b/include/osmo-bts/pcuif_proto.h index 0fece48..bae6cda 100644 --- a/include/osmo-bts/pcuif_proto.h +++ b/include/osmo-bts/pcuif_proto.h @@ -3,10 +3,11 @@ #include <osmocom/gsm/l1sap.h> #include <arpa/inet.h> +#include <osmocom/gsm/protocol/gsm_23_003.h> #define PCU_SOCK_DEFAULT "/tmp/pcu_bts" -#define PCU_IF_VERSION 0x0a +#define PCU_IF_VERSION 0x0b #define TXT_MAX_LEN 128 /* msg_type */ @@ -34,7 +35,7 @@ #define PCU_IF_SAPI_PDTCH 0x05 /* packet data/control/ccch block */ #define PCU_IF_SAPI_PRACH 0x06 /* packet random access channel */ #define PCU_IF_SAPI_PTCCH 0x07 /* packet TA control channel */ -#define PCU_IF_SAPI_AGCH_DT 0x08 /* assignment on AGCH but with additional TLLI */ +#define PCU_IF_SAPI_PCH_DT 0x08 /* assignment on PCH (confirmed using TLLI) */ /* flags */ #define PCU_IF_FLAG_ACTIVE (1 << 0)/* BTS is active */ @@ -229,6 +230,17 @@ uint8_t data[0]; } __attribute__ ((packed)); +/* Struct to send a (confirmed) IMMEDIATE ASSIGNMENT message via PCH. The struct is sent as a data request + * (data_req) under SAPI PCU_IF_SAPI_PCH_DT. */ +struct gsm_pcu_if_pch_dt { + /* TLLI as reference for confirmation */ + uint32_t tlli; + /* IMSI (to derive paging group) */ + char imsi[OSMO_IMSI_BUF_SIZE]; + /* GSM mac-block (with immediate assignment message) */ + uint8_t data[GSM_MACBLOCK_LEN]; +} __attribute__((packed)); + struct gsm_pcu_if { /* context based information */ uint8_t msg_type; /* message type */ diff --git a/src/common/paging.c b/src/common/paging.c index 55f85f6..0ea7de7 100644 --- a/src/common/paging.c +++ b/src/common/paging.c @@ -64,6 +64,7 @@ struct { uint8_t msg[GSM_MACBLOCK_LEN]; bool confirm; + uint32_t tlli; /* used as identifier for confirmation */ } macblock; } u; }; @@ -270,7 +271,7 @@ /* Add a ready formatted MAC block message to the paging queue, this can be an IMMEDIATE ASSIGNMENT, or a * PAGING COMMAND (from the PCU) */ -int paging_add_macblock(struct paging_state *ps, const char *imsi, bool confirm, const uint8_t *macblock) +int paging_add_macblock(struct paging_state *ps, uint32_t tlli, const char *imsi, bool confirm, const uint8_t *macblock) { struct llist_head *group_q; struct paging_record *pr; @@ -308,6 +309,7 @@ paging_group); memcpy(pr->u.macblock.msg, macblock, GSM_MACBLOCK_LEN); pr->u.macblock.confirm = confirm; + pr->u.macblock.tlli = tlli; /* enqueue the new message to the HEAD of the queue */ llist_add(&pr->list, group_q); @@ -627,7 +629,7 @@ num_imsi++; } - /* if we have a MAC block (from the PCU), we send a conformation back */ + /* Handle MAC block (from the PCU) */ if (macblock) { /* re-add normal paging records */ for (i = 0; i < num_pr; i++) @@ -636,10 +638,9 @@ /* get MAC block message and free record */ memcpy(out_buf, pr[num_pr]->u.macblock.msg, GSM_MACBLOCK_LEN); - if (pr[num_pr]->u.macblock.confirm) { - pcu_tx_pch_data_cnf(gt->fn, pr[num_pr]->u.macblock.msg, - GSM_MACBLOCK_LEN); - } + /* send a confirmation back (if required) */ + if (pr[num_pr]->u.macblock.confirm) + pcu_tx_pch_data_cnf(gt->fn, pr[num_pr]->u.macblock.tlli); talloc_free(pr[num_pr]); return GSM_MACBLOCK_LEN; } diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 16048e2..d409cc9 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -58,6 +58,7 @@ [PCU_IF_SAPI_PDTCH] = "PDTCH", [PCU_IF_SAPI_PRACH] = "PRACH", [PCU_IF_SAPI_PTCCH] = "PTCCH", + [PCU_IF_SAPI_PCH_DT] = "PCH_DT", }; /* @@ -616,28 +617,26 @@ return pcu_sock_send(msg); } -int pcu_tx_pch_data_cnf(uint32_t fn, uint8_t *data, uint8_t len) +int pcu_tx_pch_data_cnf(uint32_t fn, uint32_t tlli) { struct gsm_bts *bts; struct msgb *msg; struct gsm_pcu_if *pcu_prim; - struct gsm_pcu_if_data *data_cnf; /* FIXME: allow multiple BTS */ bts = llist_entry(g_bts_sm->bts_list.next, struct gsm_bts, list); LOGP(DPCU, LOGL_DEBUG, "Sending PCH confirm\n"); - msg = pcu_msgb_alloc(PCU_IF_MSG_DATA_CNF, bts->nr); + msg = pcu_msgb_alloc(PCU_IF_MSG_DATA_CNF_DT, bts->nr); if (!msg) return -ENOMEM; pcu_prim = (struct gsm_pcu_if *) msg->data; - data_cnf = &pcu_prim->u.data_cnf; - - data_cnf->sapi = PCU_IF_SAPI_PCH; - data_cnf->fn = fn; - memcpy(data_cnf->data, data, len); - data_cnf->len = len; + pcu_prim->u.data_cnf_dt = (struct gsm_pcu_if_data_cnf_dt) { + .sapi = PCU_IF_SAPI_PCH_DT, + .tlli = tlli, + .fn = fn, + }; return pcu_sock_send(msg); } @@ -674,21 +673,23 @@ osmo_hexdump(data_req->data, data_req->len)); switch (data_req->sapi) { - case PCU_IF_SAPI_PCH: + case PCU_IF_SAPI_PCH_DT: { + const struct gsm_pcu_if_pch_dt *gsm_pcu_if_pch_dt; const struct gsm48_imm_ass *gsm48_imm_ass; bool confirm; - char imsi[4]; - OSMO_STRLCPY_ARRAY(imsi, (char *)data_req->data); - if (data_req->len-3 != GSM_MACBLOCK_LEN) { - LOGP(DPCU, LOGL_ERROR, "MAC block with invalid length %d (expecting GSM_MACBLOCK_LEN = %d)\n", - data_req->len-3, GSM_MACBLOCK_LEN); - rc = -ENOMEM; + + if (OSMO_UNLIKELY(data_req->len != sizeof(*gsm_pcu_if_pch_dt))) { + LOGP(DPCU, LOGL_ERROR, "Rx malformed DATA.req for PCH\n"); + rc = -EINVAL; break; } - gsm48_imm_ass = (struct gsm48_imm_ass *)(data_req->data + 3); + + gsm_pcu_if_pch_dt = (struct gsm_pcu_if_pch_dt *)data_req->data; + gsm48_imm_ass = (struct gsm48_imm_ass *)gsm_pcu_if_pch_dt->data; confirm = (gsm48_imm_ass->msg_type == GSM48_MT_RR_IMM_ASS); - paging_add_macblock(bts->paging_state, imsi, confirm, data_req->data + 3); + rc = paging_add_macblock(bts->paging_state, gsm_pcu_if_pch_dt->tlli, + gsm_pcu_if_pch_dt->imsi, confirm, gsm_pcu_if_pch_dt->data); break; } case PCU_IF_SAPI_AGCH: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I25816ac12e63cc6b641eb414e6bc7eaa9c85fc25 Gerrit-Change-Number: 33522 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: set mp_pcuif_version
by dexter 27 Jun '23

27 Jun '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33521 ) Change subject: ttcn3-bts-test/jenkins.sh: set mp_pcuif_version ...................................................................... ttcn3-bts-test/jenkins.sh: set mp_pcuif_version OsmoBTS currently uses PCUIF v.10 but will move to v.11 soon. (see Depends). Unfortuantely this means that we have to execute the TTCN3 testsuite in master with PCUIF v.11 and in latest with PCUIF v.10. This will be the case until the current master becomes the new latest on the next release. Depends: osmo-bts.git I25816ac12e63cc6b641eb414e6bc7eaa9c85fc25 Depends: osmo-ttcn3-hacks.git I08de02e951e10bc8b4381cc2ad32e63f2747e3c4 Change-Id: Ia28bc0d6d3cbfe63be19443db86631fb67bb80fb Related: OS#5927 --- M ttcn3-bts-test/generic/BTS_Tests.cfg M ttcn3-bts-test/jenkins.sh M ttcn3-bts-test/oml/BTS_Tests.cfg M ttcn3-bts-test/virtphy/BTS_Tests.cfg 4 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/21/33521/1 diff --git a/ttcn3-bts-test/generic/BTS_Tests.cfg b/ttcn3-bts-test/generic/BTS_Tests.cfg index f6a0552..7015111 100644 --- a/ttcn3-bts-test/generic/BTS_Tests.cfg +++ b/ttcn3-bts-test/generic/BTS_Tests.cfg @@ -18,6 +18,7 @@ BTS_Tests.mp_rtpem_bind_ip := "172.18.9.10" BTS_Tests.mp_osmuxem_bind_ip := "172.18.9.10" BTS_Tests.mp_l1_supports_gprs := true +PCUIF_Types.mp_pcuif_version := 10; [MAIN_CONTROLLER] diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index ed1e095..edf7e6a 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -121,17 +121,34 @@ $REPO_USER/ttcn3-bts-test } +set_pcuif_version() { + # This changes the PCUIF module parameter of the TTCN3 testsuite when the testsuite is + # executed for current master. For latest the PCUIF module parameter must stay at v.10 + # since in osmo-btw-latest PCUIF v.11 is not yet supported. After the next release PCUIF + # v.11 will be supported in osmo-bts-latest as well and this function, including the + # PCUIF_Types.mp_pcuif_version setting in the configuration files can be removed. + image_suffix_is_master + if [ "$?" -eq 0 ] + then + echo $1 + sed -i 's/PCUIF_Types.mp_pcuif_version := 10/PCUIF_Types.mp_pcuif_version := 11/g' $1 + fi +} + network_create mkdir $VOL_BASE_DIR/bts-tester-generic cp generic/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-generic/ write_mp_osmo_repo "$VOL_BASE_DIR/bts-tester-generic/BTS_Tests.cfg" +set_pcuif_version "$VOL_BASE_DIR/bts-tester-generic/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-virtphy cp virtphy/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-virtphy/ write_mp_osmo_repo "$VOL_BASE_DIR/bts-tester-virtphy/BTS_Tests.cfg" +set_pcuif_version "$VOL_BASE_DIR/bts-tester-virtphy/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-oml cp oml/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-oml/ write_mp_osmo_repo "$VOL_BASE_DIR/bts-tester-oml/BTS_Tests.cfg" +set_pcuif_version "$VOL_BASE_DIR/bts-tester-oml/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-hopping cp fh/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-hopping/ write_mp_osmo_repo "$VOL_BASE_DIR/bts-tester-hopping/BTS_Tests.cfg" diff --git a/ttcn3-bts-test/oml/BTS_Tests.cfg b/ttcn3-bts-test/oml/BTS_Tests.cfg index ee2b4e0..bcecf28 100644 --- a/ttcn3-bts-test/oml/BTS_Tests.cfg +++ b/ttcn3-bts-test/oml/BTS_Tests.cfg @@ -19,6 +19,7 @@ BTS_Tests_OML.mp_oml_ip := "172.18.9.10" BTS_Tests_OML.mp_oml_port := 3002 BTS_Tests_OML.mp_pcu_socket := "/data/unix/pcu_sock" +PCUIF_Types.mp_pcuif_version := 10; [MAIN_CONTROLLER] diff --git a/ttcn3-bts-test/virtphy/BTS_Tests.cfg b/ttcn3-bts-test/virtphy/BTS_Tests.cfg index ee3455d..74d6f53 100644 --- a/ttcn3-bts-test/virtphy/BTS_Tests.cfg +++ b/ttcn3-bts-test/virtphy/BTS_Tests.cfg @@ -17,6 +17,7 @@ BTS_Tests.mp_ctrl_ip := "172.18.9.20" BTS_Tests.mp_l1_supports_gprs := true BTS_Tests.mp_bts_trxc_port := -1; +PCUIF_Types.mp_pcuif_version := 10; [MAIN_CONTROLLER] -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia28bc0d6d3cbfe63be19443db86631fb67bb80fb Gerrit-Change-Number: 33521 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: Add support for PCUIF protocol version 11
by dexter 27 Jun '23

27 Jun '23

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 ) Change subject: BTS_Tests: Add support for PCUIF protocol version 11 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: (re-added +2 since I only corrected cosmetic things) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08de02e951e10bc8b4381cc2ad32e63f2747e3c4 Gerrit-Change-Number: 33418 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:57:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: Add support for PCUIF protocol version 11
by dexter 27 Jun '23

27 Jun '23

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 ) Change subject: BTS_Tests: Add support for PCUIF protocol version 11 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08de02e951e10bc8b4381cc2ad32e63f2747e3c4 Gerrit-Change-Number: 33418 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:57:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: Add support for PCUIF protocol version 11
by dexter 27 Jun '23

27 Jun '23

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 ) Change subject: BTS_Tests: Add support for PCUIF protocol version 11 ...................................................................... Patch Set 2: (1 comment) File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418/comment/9e198a43_af2f… PS1, Line 376: enc_PCUIF_pch_dt > We usually declare enc/dec functions close to the record they operate on. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08de02e951e10bc8b4381cc2ad32e63f2747e3c4 Gerrit-Change-Number: 33418 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by pespin 27 Jun '23

27 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 9: Code-Review-1 (3 comments) File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/8abd503b_3dab697a PS7, Line 1271: oml_mo_rf_lock_chg(&trx->mo, fl1h->last_rf_mute, 0); > I've verified that it sends a Change Administrative State Ack/Nack. […] FYI you can also see what's done in osmo-bts-trx, something similar: """ static void st_open_poweroff_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct trx_l1h *l1h = (struct trx_l1h *)fi->priv; struct phy_instance *pinst = l1h->phy_inst; trx_provision_reset(l1h); if (pinst->trx == NULL) { trx_if_cmd_rfmute(l1h, true); return; } /* Apply initial RFMUTE state */ trx_if_cmd_rfmute(l1h, pinst->trx->mo.nm_state.administrative != NM_STATE_UNLOCKED); osmo_fsm_inst_dispatch(pinst->trx->mo.fi, NM_EV_SW_ACT, NULL); osmo_fsm_inst_dispatch(pinst->trx->bb_transc.mo.fi, NM_EV_SW_ACT, NULL); } """ File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/f9034480_1d0ce523 PS9, Line 1271: if (trx->mo.opstart_success) Better use this below, the opstart_success field is a flag used internally by the FSM. Idealyl we should send an event to the FSM and the FSM should take care of sending that message, but that's not implemented yet. if (trx->mo.fi->state != NM_RCARRIER_ST_OP_DISABLED_NOTINSTALLED) https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/f68d8cff_28d67261 PS9, Line 1279: if (trx->mo.opstart_success) if (trx->mo.fi->state != NM_RCARRIER_ST_OP_DISABLED_NOTINSTALLED) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 9 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:56:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: Add support for PCUIF protocol version 11
by dexter 27 Jun '23

27 Jun '23

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 ) Change subject: BTS_Tests: Add support for PCUIF protocol version 11 ...................................................................... Patch Set 2: (1 comment) File library/PCUIF_CodecPort.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418/comment/6f4ad5d0_8746… PS1, Line 173: > cosmetic: no need for another tab-level here Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08de02e951e10bc8b4381cc2ad32e63f2747e3c4 Gerrit-Change-Number: 33418 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:54:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: Add support for PCUIF protocol version 11
by dexter 27 Jun '23

27 Jun '23

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 to look at the new patch set (#2). Change subject: BTS_Tests: Add support for PCUIF protocol version 11 ...................................................................... BTS_Tests: Add support for PCUIF protocol version 11 The PCUIF protocol version 11 uses a more distinct (direct TLLI) way to signal PAGING COMMAND and IMMEDIATE ASSIGNMENT messages towards the PCU. Since OsmoBTS will soon fully support v.11 of the PCUIF protocol we need to add compatibility in the OsmoBTS TTCN3 testsuite early. We also have to stay compatible with older versions of OsmoBTS. The BTS_Tests.default config still sets up mp_pcuif_version to version 10, so this will be the default until we have full version 11 support in current master and latest. Related: OS#5927 Change-Id: I08de02e951e10bc8b4381cc2ad32e63f2747e3c4 --- M bts/BTS_Tests.ttcn M library/PCUIF_CodecPort.ttcn M library/PCUIF_Types.ttcn 3 files changed, 72 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/33418/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08de02e951e10bc8b4381cc2ad32e63f2747e3c4 Gerrit-Change-Number: 33418 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: turn f_gmm_gsup_lu_isd() into an altstep
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33519 to look at the new patch set (#2). Change subject: SGSN_Tests: turn f_gmm_gsup_lu_isd() into an altstep ...................................................................... SGSN_Tests: turn f_gmm_gsup_lu_isd() into an altstep This way it can be used in the alt statements. Change-Id: I1baaf6ed66cfaa75237b0abdce82ffdc7e672b96 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 24 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/33519/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1baaf6ed66cfaa75237b0abdce82ffdc7e672b96 Gerrit-Change-Number: 33519 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0