June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: f_verify_talloc_count: mtc.stop
by pespin 27 Jun '23

27 Jun '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33475 ) Change subject: f_verify_talloc_count: mtc.stop ...................................................................... Patch Set 1: (1 comment) File library/Osmocom_VTY_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33475/comment/e4d86795_4159… PS1, Line 290: setverdict(fail, "talloc count mismatch"); Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "talloc count mismatch"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id2b29beecf1c0652fb8d75e031e5c0dc9aa27975 Gerrit-Change-Number: 33475 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 09:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: CC: don't start guard timer on mid-call MNCC messages
by osmith 27 Jun '23

27 Jun '23

Attention is currently required from: falconia, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33472 ) Change subject: CC: don't start guard timer on mid-call MNCC messages ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Sorry to hear that. […] Sorry for the breakage, it's very likely that this comes from my patches. As fixeria wrote, I'm trying to reproduce and fix it. Falconia, do you have details on what doesn't work, an error message or something? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibe2dd53f8e9e06d175b64df67d2a2e3e2d4155aa Gerrit-Change-Number: 33472 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 09:31:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: osmo_io: Use bitfield for various boolean flags
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33495 ) Change subject: osmo_io: Use bitfield for various boolean flags ...................................................................... Patch Set 1: (5 comments) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/00f0ecf1_9532519a PS1, Line 39: iofd `(iofd)->flags`, just to be safe https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/894f5fdc_aa7899e1 PS1, Line 40: } while (0) Agreeing with the linter, do-while wrapper is not really needed here. https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/53c7ca3a_9c7146f7 PS1, Line 47: iofd->flags & flag same here: `(iofd)->flags & (flag)` https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/02433da4_e8289139 PS1, Line 58: TODO: Move to bitfield remove this TODO? File src/core/osmo_io_poll.c: https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/a6cc2654_bae1cdec PS1, Line 84: FLAG_ISSET missing `IOFD_` prefix -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic134e4c8d791c34778202fea98a70bc04007a113 Gerrit-Change-Number: 33495 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 09:27:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: ECU in UL path: move it from trx model to l1sap
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33471 ) Change subject: ECU in UL path: move it from trx model to l1sap ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/33471/comment/ed77ca9d_61ab07ca PS1, Line 1852: gsm_fn2gsmtime `l1sap_tch_ind()` does this calculation before calling this new helper function, so maybe accept a `const struct gsm_time` pointer instead of just `uint32_t fn`? FYI, the `struct gsm_time` does contain the `fn` field too. Not really critical, but we can save some CPU cycles, especially given that this calculation is needed for `DEBUG` logging only. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iac577975c9ab50cb8ebbc035c661c1880e7cecec Gerrit-Change-Number: 33471 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 27 Jun 2023 09:22:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: CC: don't start guard timer on mid-call MNCC messages
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33472 ) Change subject: CC: don't start guard timer on mid-call MNCC messages ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Please note: because current OsmoMSC master doesn't work for me at all (must be some breakage from t […] Sorry to hear that. I brought this problem up on the weekly review meeting today, @osmith will take a look. Next time feel free to report a ticket when you find something is broken, so it's more likely that it would be picked up quickly. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibe2dd53f8e9e06d175b64df67d2a2e3e2d4155aa Gerrit-Change-Number: 33472 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 27 Jun 2023 09:02:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: CC: don't start guard timer on mid-call MNCC messages
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33472 ) Change subject: CC: don't start guard timer on mid-call MNCC messages ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibe2dd53f8e9e06d175b64df67d2a2e3e2d4155aa Gerrit-Change-Number: 33472 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 27 Jun 2023 08:57:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: osmo_io: Use LOGPIO instead of LOGP
by laforge 27 Jun '23

27 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33494 ) Change subject: osmo_io: Use LOGPIO instead of LOGP ...................................................................... osmo_io: Use LOGPIO instead of LOGP Change-Id: I4ee256b18544f7ca6bff6b7c6ebcce15546bb1f2 --- M src/core/osmo_io_poll.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/core/osmo_io_poll.c b/src/core/osmo_io_poll.c index c4819fa..571f2bb 100644 --- a/src/core/osmo_io_poll.c +++ b/src/core/osmo_io_poll.c @@ -51,7 +51,7 @@ struct iofd_msghdr hdr; msg = iofd_msgb_pending_or_alloc(iofd); if (!msg) { - LOGP(DLIO, LOGL_ERROR, "iofd(%s): Could not get msgb for reading\n", iofd->name); + LOGPIO(iofd, LOGL_ERROR, "Could not allocate msgb for reading\n"); OSMO_ASSERT(0); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4ee256b18544f7ca6bff6b7c6ebcce15546bb1f2 Gerrit-Change-Number: 33494 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: osmo_io: Return early on error in osmo_iofd_register()
by laforge 27 Jun '23

27 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33493 ) Change subject: osmo_io: Return early on error in osmo_iofd_register() ...................................................................... osmo_io: Return early on error in osmo_iofd_register() Change-Id: I2561c82e6bf7e2bb5fd699c899238f9c43ea4d9c --- M src/core/osmo_io.c 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index c9b0b29..b00da63 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -421,11 +421,13 @@ if (fd >= 0) iofd->fd = fd; - iofd->closed = false; if (osmo_iofd_ops.register_fd) rc = osmo_iofd_ops.register_fd(iofd); + if (rc) + return rc; + iofd->closed = false; osmo_iofd_ops.read_enable(iofd); osmo_iofd_ops.write_enable(iofd); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2561c82e6bf7e2bb5fd699c899238f9c43ea4d9c Gerrit-Change-Number: 33493 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: osmo_io: Return early on error in osmo_iofd_register()
by laforge 27 Jun '23

27 Jun '23

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33493 ) Change subject: osmo_io: Return early on error in osmo_iofd_register() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2561c82e6bf7e2bb5fd699c899238f9c43ea4d9c Gerrit-Change-Number: 33493 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 08:39:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: osmo_io: Use LOGPIO instead of LOGP
by laforge 27 Jun '23

27 Jun '23

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33494 ) Change subject: osmo_io: Use LOGPIO instead of LOGP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4ee256b18544f7ca6bff6b7c6ebcce15546bb1f2 Gerrit-Change-Number: 33494 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 08:38:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0