Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 ) Change subject: PCUIF_Types: fix record PCUIF_pch_dt ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417/comment/12600845_0498c... PS1, Line 10: it would pad the data with zeros if it does not fit the : specified length. This is unwanted

AFAIR, the `ALIGN` attribute tells where to put the payload if it's less than the buffer size: eithe […] My observation here is that when ALIGN(left) is used, the buffer is padded with zeros at the beginning. The "ALIGN" behaves more like a "PAD".

With ALIGN(left) the buffer looks like this: 0000000000000000313233343539393837 Without ALIGN(left) (or with ALIGN(right)) the buffer looks like: 3132333435393938370000000000000000 (correct) Unfortunately I do not fully understand this either. Maybe align in this context is more about padding - I am not sure. Patchset: PS1: I have re-tested this, everything seems to be fine but I also didn't fully understand how the ALIGN attribute works (see comment). Since everything works as expected I would say that we can merge this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I011eb2496b1422c49736b227dfa1e2a2d6096d67 Gerrit-Change-Number: 33417 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 12:25:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment