June 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: Added BSC tests for terminating voice group calls
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 ) Change subject: Added BSC tests for terminating voice group calls ...................................................................... Patch Set 3: (2 comments) File bsc/BSC_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/bb9d26ba_a89f… PS3, Line 46: type component RSL_DchanHdlr This component type is already defined in `library/RSL_Emulation.ttcn`, which is imported by this module. Why duplicating it here? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/2315fa37_9098… PS3, Line 59: integer cr, integer sf, integer af, integer prio, integer ci Why not defining template parameters as `BITn`? ``` template (value) DescriptiveGroupOrBroadcastCallReference_V ts_BSSMAP_IE_GroupCallRef(integer cr, BIT1 sf := '1'B, BIT1 af := '0'B, BIT3 prio := '000'B, BIT4 ci := '0000'B) := { ... } ``` I understand the problem with `cr`: there is no `BIT27` and passing long bitstrings might be inconvenient, but other params can be `BITn` and have default values assigned. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe Gerrit-Change-Number: 33150 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:20:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in dahdi-linux[master]: Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
by laforge 06 Jun '23

06 Jun '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33184 ) Change subject: Support kernel >= 6.3.0 (bus_type.uevent() const struct device) ...................................................................... Patch Set 1: Verified+1 Code-Review+2 (1 comment) Patchset: PS1: master fails due to other API changes fixed later in this series -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239 Gerrit-Change-Number: 33184 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:19:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in dahdi-linux[master]: kernel 6.4 API change in DEFINE_SEMAPHORE
by laforge 06 Jun '23

06 Jun '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33181 ) Change subject: kernel 6.4 API change in DEFINE_SEMAPHORE ...................................................................... Patch Set 2: Verified+1 Code-Review+2 (1 comment) Patchset: PS2: master fails due to other errors fixed in other patches of this series -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I752c903c8a0345af6e51a996d064c9d629578ab4 Gerrit-Change-Number: 33181 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:18:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: parse PCUIF data indication outside of paging.c
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32733 ) Change subject: paging: parse PCUIF data indication outside of paging.c ...................................................................... Patch Set 8: (2 comments) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/d97c32a3_0a628124 PS8, Line 679: osmo_strlcpy(&imsi[0], (char *)data_req->data, sizeof(imsi)); > OSMO_STRLCPY_ARRAY Ack, I forgot about this macro... https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/7aa29322_2c15b7e6 PS8, Line 682: confirm = true; > I believe this is going to fail, I don't see confirm being defined. Looks like it's something from a follow-up patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9f3799916e8102bf1ce0f21891f2d24f43091f01 Gerrit-Change-Number: 32733 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:11:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in dahdi-linux[master]: compatibility with class_create API change in 6.4-rc1
by laforge 06 Jun '23

06 Jun '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33185 ) Change subject: compatibility with class_create API change in 6.4-rc1 ...................................................................... compatibility with class_create API change in 6.4-rc1 Linux kernel 6.4-rc1 has an API change for the class_create() function. See upstream kernel git commit 1aaba11da9aa7d7d6b52a74d45b31cac118295a1 Change-Id: I5f7d25aa7516c470b943b9e8dfba20ca4206e378 --- M drivers/dahdi/dahdi-sysfs-chan.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/85/33185/1 diff --git a/drivers/dahdi/dahdi-sysfs-chan.c b/drivers/dahdi/dahdi-sysfs-chan.c index 8682ea3..5692c05 100644 --- a/drivers/dahdi/dahdi-sysfs-chan.c +++ b/drivers/dahdi/dahdi-sysfs-chan.c @@ -483,7 +483,12 @@ } should_cleanup.channel_driver = 1; +/* see linux kernel commit 1aaba11da9aa7d7d6b52a74d45b31cac118295a1 */ +#if LINUX_VERSION_CODE > KERNEL_VERSION(6, 3, 0) + dahdi_class = class_create("dahdi"); +#else dahdi_class = class_create(THIS_MODULE, "dahdi"); +#endif if (IS_ERR(dahdi_class)) { res = PTR_ERR(dahdi_class); dahdi_err("%s: class_create(dahi_chan) failed. Error: %d\n", -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I5f7d25aa7516c470b943b9e8dfba20ca4206e378 Gerrit-Change-Number: 33185 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in dahdi-linux[master]: Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
by laforge 06 Jun '23

06 Jun '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33184 ) Change subject: Support kernel >= 6.3.0 (bus_type.uevent() const struct device) ...................................................................... Support kernel >= 6.3.0 (bus_type.uevent() const struct device) linux kernel commit 2a81ada32f0e584fc0c943e0d3a8c9f4fae411d6 modifies the struct bus_type.uevent() argument from 'struct device *' to 'const struct device *'. Let's adjust our code to support that. Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239 --- M drivers/dahdi/dahdi-sysfs.c M drivers/dahdi/xpp/xbus-sysfs.c M include/dahdi/kernel.h 3 files changed, 25 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/84/33184/1 diff --git a/drivers/dahdi/dahdi-sysfs.c b/drivers/dahdi/dahdi-sysfs.c index ca29ddb..0e0a993 100644 --- a/drivers/dahdi/dahdi-sysfs.c +++ b/drivers/dahdi/dahdi-sysfs.c @@ -68,7 +68,7 @@ return err; \ } while (0) -static int span_uevent(struct device *dev, struct kobj_uevent_env *kenv) +static int span_uevent(UEVENT_CONST struct device *dev, struct kobj_uevent_env *kenv) { struct dahdi_span *span; @@ -438,7 +438,7 @@ return err; \ } while (0) -static int device_uevent(struct device *dev, struct kobj_uevent_env *kenv) +static int device_uevent(UEVENT_CONST struct device *dev, struct kobj_uevent_env *kenv) { struct dahdi_device *ddev; diff --git a/drivers/dahdi/xpp/xbus-sysfs.c b/drivers/dahdi/xpp/xbus-sysfs.c index d8c11dc..34cab65 100644 --- a/drivers/dahdi/xpp/xbus-sysfs.c +++ b/drivers/dahdi/xpp/xbus-sysfs.c @@ -418,7 +418,7 @@ return err; \ } while (0) -static int astribank_uevent(struct device *dev, struct kobj_uevent_env *kenv) +static int astribank_uevent(UEVENT_CONST struct device *dev, struct kobj_uevent_env *kenv) { xbus_t *xbus; extern char *initdir; diff --git a/include/dahdi/kernel.h b/include/dahdi/kernel.h index 778c2b2..f04f324 100644 --- a/include/dahdi/kernel.h +++ b/include/dahdi/kernel.h @@ -1683,4 +1683,13 @@ #endif /* DAHDI_PRINK_MACROS_USE_debug */ + +/* work-around kernel API change from "struct device *dev" to "const struct device *dev" + * as implemented in 2a81ada32f0e584fc0c943e0d3a8c9f4fae411d6 */ +#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 3, 0) +#define UEVENT_CONST const +#else +#define UEVENT_CONST +#endif + #endif /* _DAHDI_KERNEL_H */ -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239 Gerrit-Change-Number: 33184 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: paging: do not confirm PAGING COMMAND messages
by pespin 06 Jun '23

06 Jun '23

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32734 ) Change subject: paging: do not confirm PAGING COMMAND messages ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8b8264d28b1b1deb08774cdba58dd4c6dafe115d Gerrit-Change-Number: 32734 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:09:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: parse PCUIF data indication outside of paging.c
by pespin 06 Jun '23

06 Jun '23

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32733 ) Change subject: paging: parse PCUIF data indication outside of paging.c ...................................................................... Patch Set 8: (1 comment) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/02b01667_5e25f937 PS8, Line 682: confirm = true; I believe this is going to fail, I don't see confirm being defined. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9f3799916e8102bf1ce0f21891f2d24f43091f01 Gerrit-Change-Number: 32733 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:09:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: parse PCUIF data indication outside of paging.c
by pespin 06 Jun '23

06 Jun '23

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32733 ) Change subject: paging: parse PCUIF data indication outside of paging.c ...................................................................... Patch Set 8: (1 comment) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/4cfc614f_3da59bde PS8, Line 679: osmo_strlcpy(&imsi[0], (char *)data_req->data, sizeof(imsi)); OSMO_STRLCPY_ARRAY -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9f3799916e8102bf1ce0f21891f2d24f43091f01 Gerrit-Change-Number: 32733 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:08:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: paging: do not confirm PAGING COMMAND messages
by dexter 06 Jun '23

06 Jun '23

Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32734 ) Change subject: paging: do not confirm PAGING COMMAND messages ...................................................................... Patch Set 9: (1 comment) Patchset: PS6: > In osmo-bsc we also distinguish between PAGING COMMAND and IMMEDIATE ASSIGNMENT. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8b8264d28b1b1deb08774cdba58dd4c6dafe115d Gerrit-Change-Number: 32734 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0