June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33186 ) Change subject: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/host/layer23/src/modem/grr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33186/comment/76b103aa_5e3b6b09 PS1, Line 50: static uint32_t _gsm48_req_ref2fn(const struct gsm48_req_ref *ref) > ugh yes this is totally unrelated I didn't even remember I had it. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife91ad87fed78daf86e9f28ceed981d61799758e Gerrit-Change-Number: 33186 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 14:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: Submit UL block to lower layers before freeing TBF
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33187 ) Change subject: rlcmac: Submit UL block to lower layers before freeing TBF ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Looks good to me. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I236a5fd0e97b0b323153a4b6cf95b785348cf7df Gerrit-Change-Number: 33187 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 14:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add template to receive ChannelType IE
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33145 ) Change subject: BSSMAP_Templates: Add template to receive ChannelType IE ...................................................................... Patch Set 3: (1 comment) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33145/comment/b4ca7b86_ee04… PS3, Line 570: template BIT4 speech_data_ind All fields in `record BSSMAP_IE_ChannelType` are mandatory (not optional), so all template params should be `(present)` too. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6f283c17a1687ee65f8997bbeba0b09d1a462cf Gerrit-Change-Number: 33145 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 06 Jun 2023 14:15:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: DAHDI master build diversification
by laforge 06 Jun '23

06 Jun '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/33190 to look at the new patch set (#2). Change subject: DAHDI master build diversification ...................................................................... DAHDI master build diversification * we never really wanted to build against fixed tags but branches, i.e. "the latest tag within a given stable series", so switch from a fixed tag like "v5.10" in torvalds/linux.git to "linux-5.10.y" in stable/linux.git * we also want to build against 6.1.y, as that is what upcoming debian bookwork will ship Change-Id: Ibc0527a6f7d11c4f99c19e73c948b9baacd4e5a2 --- M jobs/master-builds-dahdi.yml 1 file changed, 33 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/33190/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibc0527a6f7d11c4f99c19e73c948b9baacd4e5a2 Gerrit-Change-Number: 33190 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: DAHDI master build diversification
by laforge 06 Jun '23

06 Jun '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/33190 ) Change subject: DAHDI master build diversification ...................................................................... DAHDI master build diversification * we never really wanted to build against fixed tags but branches, i.e. "the latest tag within a given stable series", so switch from a fixed tag like "v5.10" in torvalds/linux.git to "linux-5.10.y" in stable/linux.git * we also want to build against 6.1.y, as that is what upcoming debian bookwork will ship Change-Id: Ibc0527a6f7d11c4f99c19e73c948b9baacd4e5a2 --- M jobs/master-builds-dahdi.yml 1 file changed, 33 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/33190/1 diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index 37d48b7..7134f05 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -1,14 +1,25 @@ - project: - name: master-builds-dahdi-linux + name: master-builds-dahdi-linux-stable + type: stable + repo: 'https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git' linux-ver: - - "v4.19" - - "v5.10" + - "linux-4.19.y" + - "linux-5.10.y" + - "linux-6.1.y" + jobs: + - 'master-dahdi-linux-{type}-{linux-ver}' + +- project: + name: master-builds-dahdi-linux-torvalrds + type: torvalds + repo: 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git' + linux-ver: - "master" jobs: - - 'master-dahdi-linux-{linux-ver}' + - 'master-dahdi-linux-{type}-{linux-ver}' - job-template: - name: 'master-dahdi-linux-{linux-ver}' + name: 'master-dahdi-linux-{type}-{linux-ver}' project-type: freestyle node: osmocom-master concurrent: true @@ -31,7 +42,7 @@ # the shell part below. - git: basedir: 'linux' - url: 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git' + url: '{repo}' branches: - '{linux-ver}' refspec: '{linux-ver}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibc0527a6f7d11c4f99c19e73c948b9baacd4e5a2 Gerrit-Change-Number: 33190 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add templates to receive CellID IE
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144 ) Change subject: BSSMAP_Templates: Add templates to receive CellID IE ...................................................................... Patch Set 3: Code-Review-1 (2 comments) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144/comment/d1d59a71_dac2… PS3, Line 371: present There's still something wrong with this template. The `present` means that either a value or a template `?` can be passed. Passing a `?` would result in a DTE, because `valueof(?)` cannot be evaluated. Given the limitations of `t[rs]_BSSMAP_CI_CGI`, in particular having to call `f_enc_mcc_mnc()`, both parameters `mcc` and `mnc` should be defined as regular values, not templates. Other params *can* be templates because functions `f_tr_LAC` and `f_tr_CI` should be capable of handling them. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144/comment/bc987b3b_7abd… PS3, Line 1467: GsmMcc mcc, GsmMnc mnc Here I suggest keeping both `mcc` and `mnc` as they are, i.e. value parameters. The remaining `lac` and `ci` should be `template (present)`. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42d52d871c8011db7e0897dfe752afeefa6d9662 Gerrit-Change-Number: 33144 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 06 Jun 2023 14:09:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM
by pespin 06 Jun '23

06 Jun '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/33186 to look at the new patch set (#2). Change subject: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM ...................................................................... layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM Change-Id: Ife91ad87fed78daf86e9f28ceed981d61799758e --- M src/host/layer23/src/modem/rlcmac.c 1 file changed, 23 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/86/33186/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife91ad87fed78daf86e9f28ceed981d61799758e Gerrit-Change-Number: 33186 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: layer23: modem: Add helper function to get FN from gsm48_req_ref
by pespin 06 Jun '23

06 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33189 ) Change subject: layer23: modem: Add helper function to get FN from gsm48_req_ref ...................................................................... layer23: modem: Add helper function to get FN from gsm48_req_ref Change-Id: I1265a580f55473f52e77af6c5f53c1573f8f3e70 --- M src/host/layer23/src/modem/grr.c 1 file changed, 25 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/89/33189/1 diff --git a/src/host/layer23/src/modem/grr.c b/src/host/layer23/src/modem/grr.c index c4e8537..b290c8b 100644 --- a/src/host/layer23/src/modem/grr.c +++ b/src/host/layer23/src/modem/grr.c @@ -47,6 +47,16 @@ #include <l1ctl_proto.h> +static uint32_t _gsm48_req_ref2fn(const struct gsm48_req_ref *ref) +{ + const struct gsm_time time = { + .t3 = ref->t3_high << 3 | ref->t3_low, + .t2 = ref->t2, + .t1 = ref->t1, + }; + return gsm_gsmtime2fn(&time); +} + /* Generate an 8-bit CHANNEL REQUEST message as per 3GPP TS 44.018, 9.1.8 */ uint8_t modem_grr_gen_chan_req(bool single_block) { @@ -254,9 +264,10 @@ return 0; } if (!grr_match_req_ref(ms, &ia->req_ref)) { - LOGP(DRR, LOGL_INFO, "%s(): req_ref mismatch (RA=0x%02x, T1=%u, T3=%u, T2=%u)\n", + LOGP(DRR, LOGL_INFO, "%s(): req_ref mismatch (RA=0x%02x, T1=%u, T3=%u, T2=%u, FN=%u)\n", __func__, ia->req_ref.ra, ia->req_ref.t1, - ia->req_ref.t3_high << 3 | ia->req_ref.t3_low, ia->req_ref.t2); + ia->req_ref.t3_high << 3 | ia->req_ref.t3_low, ia->req_ref.t2, + _gsm48_req_ref2fn(&ia->req_ref)); return 0; } @@ -460,8 +471,9 @@ if (rr->state == GSM48_RR_ST_CONN_PEND) { const struct gsm48_req_ref *ref = (void *)&ch->data[1]; LOGP(DRSL, LOGL_NOTICE, - "Rx RACH.conf (RA=0x%02x, T1=%u, T3=%u, T2=%u)\n", - rr->cr_ra, ref->t1, ref->t3_high << 3 | ref->t3_low, ref->t2); + "Rx RACH.conf (RA=0x%02x, T1=%u, T3=%u, T2=%u, FN=%u)\n", + rr->cr_ra, ref->t1, ref->t3_high << 3 | ref->t3_low, ref->t2, + _gsm48_req_ref2fn(ref)); /* shift the CHANNEL REQUEST history buffer */ memmove(&rr->cr_hist[1], &rr->cr_hist[0], ARRAY_SIZE(rr->cr_hist) - 1); /* store the new entry */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1265a580f55473f52e77af6c5f53c1573f8f3e70 Gerrit-Change-Number: 33189 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM
by pespin 06 Jun '23

06 Jun '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33186 ) Change subject: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/modem/grr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33186/comment/08f1c299_9aa72380 PS1, Line 50: static uint32_t _gsm48_req_ref2fn(const struct gsm48_req_ref *ref) > I like this change, but it looks unrelated and deserves a separate commit? ugh yes this is totally unrelated I didn't even remember I had it. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife91ad87fed78daf86e9f28ceed981d61799758e Gerrit-Change-Number: 33186 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 13:54:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: osmo_io: Fix sending msgb structures
by daniel 06 Jun '23

06 Jun '23

Attention is currently required from: arehbein, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33084 ) Change subject: osmo_io: Fix sending msgb structures ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Agreeing with laforge. Ok then I'll prepare a patch removing osmo_iofd_write_{en,dis}able Those were only ever intended as public API for the user. Internally the txqueue will take care of dis-/enabling the writes. That then leaves us with the special case of checking whether the fd is writable for async connect(). The next question then is whether read_{en,dis}able is actually needed in osmo_io. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2a9c93f820fa372a1d527c805fd0fe2cff0eb49 Gerrit-Change-Number: 33084 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 13:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0