lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

June 2023

  • 1 participants
  • 2480 discussions
[S] Change in dahdi-linux[master]: Fix jenkins.sh failure for kernels >= 6.3.0
by laforge 06 Jun '23

06 Jun '23
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33188 ) Change subject: Fix jenkins.sh failure for kernels >= 6.3.0 ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7206f1daed8ff1e7fcd4894bc24e5ef4d4590358 Gerrit-Change-Number: 33188 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:56:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in dahdi-linux[master]: Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
by laforge 06 Jun '23

06 Jun '23
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33184 ) Change subject: Support kernel >= 6.3.0 (bus_type.uevent() const struct device) ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239 Gerrit-Change-Number: 33184 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteVote
1 0
0 0
[M] Change in dahdi-linux[master]: Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
by laforge 06 Jun '23

06 Jun '23
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33184 ) Change subject: Support kernel >= 6.3.0 (bus_type.uevent() const struct device) ...................................................................... Patch Set 3: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239 Gerrit-Change-Number: 33184 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:55:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in osmocom-bb[master]: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM
by fixeria 06 Jun '23

06 Jun '23
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33186 ) Change subject: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/modem/grr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33186/comment/dd1dcc8d_eeca6373 PS1, Line 50: static uint32_t _gsm48_req_ref2fn(const struct gsm48_req_ref *ref) I like this change, but it looks unrelated and deserves a separate commit? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife91ad87fed78daf86e9f28ceed981d61799758e Gerrit-Change-Number: 33186 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:52:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[S] Change in dahdi-linux[master]: Fix jenkins.sh failure for kernels >= 6.3.0
by laforge 06 Jun '23

06 Jun '23
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33188 ) Change subject: Fix jenkins.sh failure for kernels >= 6.3.0 ...................................................................... Fix jenkins.sh failure for kernels >= 6.3.0 In >= 6.3.0 the default for how modules are built in absence of vmlinux.o or Module.symvers due to a change of the modpost execution. See linux kernel git commit 5573b4daa26a0cf15aa0fecd7f1be16e0b6157bc As our build verification *just* builds the dahdi modules without building the entire kernel, we need to enforce the legacy behaviour by adding KBUILD_MODPOST_WARN=1 to the command line. Change-Id: I7206f1daed8ff1e7fcd4894bc24e5ef4d4590358 --- M contrib/jenkins.sh 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/88/33188/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index eeb3fbc..6a39daf 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -29,4 +29,4 @@ git log -1 --pretty="%t - %s" make -j "$JOBS" modules_prepare -make -j "$JOBS" -C "$TOPDIR" KSRC="$KSRC" +make -j "$JOBS" -C "$TOPDIR" KSRC="$KSRC" KBUILD_MODPOST_WARN=1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7206f1daed8ff1e7fcd4894bc24e5ef4d4590358 Gerrit-Change-Number: 33188 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in libosmo-gprs[master]: rlcmac: Submit UL block to lower layers before freeing TBF
by pespin 06 Jun '23

06 Jun '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33187 ) Change subject: rlcmac: Submit UL block to lower layers before freeing TBF ...................................................................... rlcmac: Submit UL block to lower layers before freeing TBF Change-Id: I236a5fd0e97b0b323153a4b6cf95b785348cf7df --- M src/rlcmac/sched.c M tests/rlcmac/rlcmac_prim_test.err M tests/rlcmac/rlcmac_prim_test.ok 3 files changed, 27 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/87/33187/1 diff --git a/src/rlcmac/sched.c b/src/rlcmac/sched.c index 25ee6da..8709f71 100644 --- a/src/rlcmac/sched.c +++ b/src/rlcmac/sched.c @@ -155,14 +155,22 @@ return NULL; } - +/*! Select a CTRL message to transmit, based on different messages priority. + * \param[in] bi RTS block indication information. + * \param[in] tbfs TBF candidates having CTRL messages to send, filled in by get_ctrl_msg_tbf_candidates() + * \param[out] tbf_to_free TBF to free after sending the generated message + */ static struct msgb *sched_select_ctrl_msg(const struct gprs_rlcmac_rts_block_ind *bi, - struct tbf_sched_ctrl_candidates *tbfs) + const struct tbf_sched_ctrl_candidates *tbfs, + struct gprs_rlcmac_tbf **tbf_to_free) { struct msgb *msg = NULL; struct gprs_rlcmac_entity *gre; int rc; + /* No TBF to be freed by default: */ + *tbf_to_free = NULL; + /* 8.1.2.2 1) (EGPRS) PACKET DOWNLINK ACK/NACK w/ FinalAckInd=1 */ if (tbfs->poll_dl_ack_final_ack) { LOGRLCMAC(LOGL_DEBUG, "(ts=%u,fn=%u,usf=%u) Tx DL ACK/NACK FinalAck=1\n", @@ -200,8 +208,8 @@ LOGRLCMAC(LOGL_DEBUG, "(ts=%u,fn=%u,usf=%u) Tx Pkt Control Ack (UL ACK/NACK poll)\n", bi->ts, bi->fn, bi->usf); msg = gprs_rlcmac_gre_create_pkt_ctrl_ack(ul_tbf_as_tbf(tbfs->poll_ul_ack)->gre); - /* Last UL message, freeing */ - gprs_rlcmac_ul_tbf_free(tbfs->poll_ul_ack); + /* Last UL message, freeing (after passing msg to lower layers) */ + *tbf_to_free = ul_tbf_as_tbf(tbfs->poll_ul_ack); return msg; } if (tbfs->poll_dl_ass) { @@ -280,6 +288,7 @@ { struct msgb *msg = NULL; struct tbf_sched_ctrl_candidates tbf_cand = {0}; + struct gprs_rlcmac_tbf *tbf_to_free; struct osmo_gprs_rlcmac_prim *rlcmac_prim_tx; int rc = 0; @@ -287,7 +296,7 @@ get_ctrl_msg_tbf_candidates(bi, &tbf_cand); - if ((msg = sched_select_ctrl_msg(bi, &tbf_cand))) + if ((msg = sched_select_ctrl_msg(bi, &tbf_cand, &tbf_to_free))) goto tx_msg; if ((msg = sched_select_ul_data_msg(bi))) @@ -305,6 +314,8 @@ rlcmac_prim_tx->l1ctl.pdch_data_req.data_len = msgb_length(msg); rc = gprs_rlcmac_prim_call_down_cb(rlcmac_prim_tx); msgb_free(msg); + if (tbf_to_free) + gprs_rlcmac_tbf_free(tbf_to_free); ret_rc: gprs_rlcmac_pdch_ulc_expire_fn(g_rlcmac_ctx->sched.ulc[bi->ts], bi->fn); diff --git a/tests/rlcmac/rlcmac_prim_test.err b/tests/rlcmac/rlcmac_prim_test.err index 120458a..24ee965 100644 --- a/tests/rlcmac/rlcmac_prim_test.err +++ b/tests/rlcmac/rlcmac_prim_test.err @@ -63,11 +63,11 @@ DLGLOBAL DEBUG Rx from lower layers: L1CTL-PDCH_RTS.indication DLGLOBAL DEBUG (ts=7,fn=21,usf=0) Tx Pkt Control Ack (UL ACK/NACK poll) DLGLOBAL DEBUG GRE(00002342) Tx Packet Control Ack +DLGLOBAL DEBUG Tx to lower layers: L1CTL-PDCH_DATA.request DLGLOBAL INFO UL_TBF_ASS{IDLE}: Deallocated DLGLOBAL INFO UL_TBF{RELEASING}: Send L1CTL-CFG_UL_TBF.req ul_tbf_nr=0 (release) DLGLOBAL DEBUG Tx to lower layers: L1CTL-CFG_UL_TBF.request DLGLOBAL INFO UL_TBF{RELEASING}: Deallocated -DLGLOBAL DEBUG Tx to lower layers: L1CTL-PDCH_DATA.request DLGLOBAL INFO DL_TBF_ASS{IDLE}: Deallocated DLGLOBAL INFO Rx from upper layers: GRR-UNITDATA.request DLGLOBAL INFO TLLI=0x00002342 not found, creating entity on the fly diff --git a/tests/rlcmac/rlcmac_prim_test.ok b/tests/rlcmac/rlcmac_prim_test.ok index b555cbe..34b82f1 100644 --- a/tests/rlcmac/rlcmac_prim_test.ok +++ b/tests/rlcmac/rlcmac_prim_test.ok @@ -5,8 +5,8 @@ test_rlcmac_prim_up_cb(): Rx GMMRR-LLC_TRANSMITTED.indication TLLI=0x00002342 test_rlcmac_prim_down_cb(): Rx L1CTL-PDCH_DATA.request fn=4 ts=7 data_len=34 data=[3c 01 01 00 00 23 42 01 c0 00 08 01 01 d5 71 00 00 08 29 26 24 00 00 00 00 71 62 f2 24 6c 84 44 04 00 ] test_rlcmac_prim_down_cb(): Rx L1CTL-PDCH_DATA.request fn=8 ts=7 data_len=34 data=[00 01 02 1d 00 00 23 42 11 e5 10 00 e2 18 f2 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 00 ] -test_rlcmac_prim_down_cb(): Rx L1CTL-CFG_UL_TBF.request ul_tbf_nr=0 ul_slotmask=0x00 test_rlcmac_prim_down_cb(): Rx L1CTL-PDCH_DATA.request fn=21 ts=7 data_len=23 data=[40 04 00 00 8d 08 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b ] +test_rlcmac_prim_down_cb(): Rx L1CTL-CFG_UL_TBF.request ul_tbf_nr=0 ul_slotmask=0x00 === test_ul_tbf_attach end === === test_ul_tbf_t3164_timeout start === sys={0.000000}, mono={0.000000}: clock_override_set -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I236a5fd0e97b0b323153a4b6cf95b785348cf7df Gerrit-Change-Number: 33187 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in osmocom-bb[master]: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM
by pespin 06 Jun '23

06 Jun '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33186 ) Change subject: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM ...................................................................... layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM Change-Id: Ife91ad87fed78daf86e9f28ceed981d61799758e --- M src/host/layer23/src/modem/grr.c M src/host/layer23/src/modem/rlcmac.c 2 files changed, 39 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/86/33186/1 diff --git a/src/host/layer23/src/modem/grr.c b/src/host/layer23/src/modem/grr.c index c4e8537..b290c8b 100644 --- a/src/host/layer23/src/modem/grr.c +++ b/src/host/layer23/src/modem/grr.c @@ -47,6 +47,16 @@ #include <l1ctl_proto.h> +static uint32_t _gsm48_req_ref2fn(const struct gsm48_req_ref *ref) +{ + const struct gsm_time time = { + .t3 = ref->t3_high << 3 | ref->t3_low, + .t2 = ref->t2, + .t1 = ref->t1, + }; + return gsm_gsmtime2fn(&time); +} + /* Generate an 8-bit CHANNEL REQUEST message as per 3GPP TS 44.018, 9.1.8 */ uint8_t modem_grr_gen_chan_req(bool single_block) { @@ -254,9 +264,10 @@ return 0; } if (!grr_match_req_ref(ms, &ia->req_ref)) { - LOGP(DRR, LOGL_INFO, "%s(): req_ref mismatch (RA=0x%02x, T1=%u, T3=%u, T2=%u)\n", + LOGP(DRR, LOGL_INFO, "%s(): req_ref mismatch (RA=0x%02x, T1=%u, T3=%u, T2=%u, FN=%u)\n", __func__, ia->req_ref.ra, ia->req_ref.t1, - ia->req_ref.t3_high << 3 | ia->req_ref.t3_low, ia->req_ref.t2); + ia->req_ref.t3_high << 3 | ia->req_ref.t3_low, ia->req_ref.t2, + _gsm48_req_ref2fn(&ia->req_ref)); return 0; } @@ -460,8 +471,9 @@ if (rr->state == GSM48_RR_ST_CONN_PEND) { const struct gsm48_req_ref *ref = (void *)&ch->data[1]; LOGP(DRSL, LOGL_NOTICE, - "Rx RACH.conf (RA=0x%02x, T1=%u, T3=%u, T2=%u)\n", - rr->cr_ra, ref->t1, ref->t3_high << 3 | ref->t3_low, ref->t2); + "Rx RACH.conf (RA=0x%02x, T1=%u, T3=%u, T2=%u, FN=%u)\n", + rr->cr_ra, ref->t1, ref->t3_high << 3 | ref->t3_low, ref->t2, + _gsm48_req_ref2fn(ref)); /* shift the CHANNEL REQUEST history buffer */ memmove(&rr->cr_hist[1], &rr->cr_hist[0], ARRAY_SIZE(rr->cr_hist) - 1); /* store the new entry */ diff --git a/src/host/layer23/src/modem/rlcmac.c b/src/host/layer23/src/modem/rlcmac.c index e030299..161effd 100644 --- a/src/host/layer23/src/modem/rlcmac.c +++ b/src/host/layer23/src/modem/rlcmac.c @@ -85,8 +85,8 @@ switch (rlcmac_prim->oph.primitive) { case OSMO_GPRS_RLCMAC_GMMRR_PAGE: /* Forward it to upper layers, pass ownership over to GMM: */ - /* Optimization: RLCMAC-GMMRR-ASSIGN-REQ is 1-to-1 ABI compatible with - GMM-GMMRR-ASSIGN-REQ, we just need to adapt the header. + /* Optimization: RLCMAC-GMMRR-PAGE-IND is 1-to-1 ABI compatible with + GMM-GMMRR-PAGE-IND, we just need to adapt the header. See osmo_static_assert(_gmmrr_prim_size) above. */ gmm_prim = (struct osmo_gprs_gmm_prim *)rlcmac_prim; @@ -95,6 +95,18 @@ osmo_gprs_gmm_prim_lower_up(gmm_prim); rc = 1; /* Tell RLCMAC that we take ownership of the prim. */ break; + case OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED: + /* Forward it to upper layers, pass ownership over to GMM: */ + /* Optimization: RLCMAC-GMMRR-LLC-TRANSMITTED-IND is 1-to-1 ABI compatible with + GMM-GMMRR-LLC-TRANSMITTED-IND, we just need to adapt the header. + See osmo_static_assert(_gmmrr_prim_size) above. + */ + gmm_prim = (struct osmo_gprs_gmm_prim *)rlcmac_prim; + gmm_prim->oph.sap = OSMO_GPRS_GMM_SAP_GMMRR; + gmm_prim->oph.primitive = OSMO_GPRS_GMM_GMMRR_LLC_TRANSMITTED; + osmo_gprs_gmm_prim_lower_up(gmm_prim); + rc = 1; /* Tell RLCMAC that we take ownership of the prim. */ + break; default: LOGP(DRLCMAC, LOGL_NOTICE, "%s(): Unexpected Rx RLCMAC GMMRR prim %u\n", __func__, rlcmac_prim->oph.primitive); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife91ad87fed78daf86e9f28ceed981d61799758e Gerrit-Change-Number: 33186 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[M] Change in dahdi-linux[master]: Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
by laforge 06 Jun '23

06 Jun '23
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184 to look at the new patch set (#3). Change subject: Support kernel >= 6.3.0 (bus_type.uevent() const struct device) ...................................................................... Support kernel >= 6.3.0 (bus_type.uevent() const struct device) linux kernel commit 2a81ada32f0e584fc0c943e0d3a8c9f4fae411d6 modifies the struct bus_type.uevent() argument from 'struct device *' to 'const struct device *'. Let's adjust our code to support that. Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239 --- M drivers/dahdi/dahdi-sysfs.c M drivers/dahdi/xpp/xbus-sysfs.c M include/dahdi/kernel.h 3 files changed, 39 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/84/33184/3 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239 Gerrit-Change-Number: 33184 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset
1 0
0 0
[S] Change in dahdi-linux[master]: Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
by laforge 06 Jun '23

06 Jun '23
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184 to look at the new patch set (#2). Change subject: Support kernel >= 6.3.0 (bus_type.uevent() const struct device) ...................................................................... Support kernel >= 6.3.0 (bus_type.uevent() const struct device) linux kernel commit 2a81ada32f0e584fc0c943e0d3a8c9f4fae411d6 modifies the struct bus_type.uevent() argument from 'struct device *' to 'const struct device *'. Let's adjust our code to support that. Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239 --- M drivers/dahdi/dahdi-sysfs.c M drivers/dahdi/xpp/xbus-sysfs.c M include/dahdi/kernel.h 3 files changed, 26 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/84/33184/2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239 Gerrit-Change-Number: 33184 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset
1 0
0 0
[S] Change in dahdi-linux[master]: compatibility with class_create API change in 6.4-rc1
by laforge 06 Jun '23

06 Jun '23
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/dahdi-linux/+/33185 to look at the new patch set (#2). Change subject: compatibility with class_create API change in 6.4-rc1 ...................................................................... compatibility with class_create API change in 6.4-rc1 Linux kernel 6.4-rc1 has an API change for the class_create() function. See upstream kernel git commit 1aaba11da9aa7d7d6b52a74d45b31cac118295a1 Change-Id: I5f7d25aa7516c470b943b9e8dfba20ca4206e378 --- M drivers/dahdi/dahdi-sysfs-chan.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/85/33185/2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I5f7d25aa7516c470b943b9e8dfba20ca4206e378 Gerrit-Change-Number: 33185 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 200
  • 201
  • 202
  • 203
  • 204
  • 205
  • 206
  • ...
  • 248
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.