Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33186 )
Change subject: layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM
......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/modem/grr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33186/comment/dd1dcc8d_eeca6373
PS1, Line 50: static uint32_t _gsm48_req_ref2fn(const struct gsm48_req_ref *ref)
I like this change, but it looks unrelated and deserves a separate commit?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33186
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ife91ad87fed78daf86e9f28ceed981d61799758e
Gerrit-Change-Number: 33186
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Jun 2023 12:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33188 )
Change subject: Fix jenkins.sh failure for kernels >= 6.3.0
......................................................................
Fix jenkins.sh failure for kernels >= 6.3.0
In >= 6.3.0 the default for how modules are built in absence of
vmlinux.o or Module.symvers due to a change of the modpost execution.
See linux kernel git commit 5573b4daa26a0cf15aa0fecd7f1be16e0b6157bc
As our build verification *just* builds the dahdi modules without
building the entire kernel, we need to enforce the legacy behaviour
by adding KBUILD_MODPOST_WARN=1 to the command line.
Change-Id: I7206f1daed8ff1e7fcd4894bc24e5ef4d4590358
---
M contrib/jenkins.sh
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/88/33188/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index eeb3fbc..6a39daf 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -29,4 +29,4 @@
git log -1 --pretty="%t - %s"
make -j "$JOBS" modules_prepare
-make -j "$JOBS" -C "$TOPDIR" KSRC="$KSRC"
+make -j "$JOBS" -C "$TOPDIR" KSRC="$KSRC" KBUILD_MODPOST_WARN=1
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33188
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I7206f1daed8ff1e7fcd4894bc24e5ef4d4590358
Gerrit-Change-Number: 33188
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/dahdi-linux/+/33184
to look at the new patch set (#3).
Change subject: Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
......................................................................
Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
linux kernel commit 2a81ada32f0e584fc0c943e0d3a8c9f4fae411d6 modifies
the struct bus_type.uevent() argument from 'struct device *' to
'const struct device *'. Let's adjust our code to support that.
Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239
---
M drivers/dahdi/dahdi-sysfs.c
M drivers/dahdi/xpp/xbus-sysfs.c
M include/dahdi/kernel.h
3 files changed, 39 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/84/33184/3
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239
Gerrit-Change-Number: 33184
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/dahdi-linux/+/33184
to look at the new patch set (#2).
Change subject: Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
......................................................................
Support kernel >= 6.3.0 (bus_type.uevent() const struct device)
linux kernel commit 2a81ada32f0e584fc0c943e0d3a8c9f4fae411d6 modifies
the struct bus_type.uevent() argument from 'struct device *' to
'const struct device *'. Let's adjust our code to support that.
Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239
---
M drivers/dahdi/dahdi-sysfs.c
M drivers/dahdi/xpp/xbus-sysfs.c
M include/dahdi/kernel.h
3 files changed, 26 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/84/33184/2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I0c416d8fa8d7d0081fdfec6325971d6de9f8d239
Gerrit-Change-Number: 33184
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/dahdi-linux/+/33185
to look at the new patch set (#2).
Change subject: compatibility with class_create API change in 6.4-rc1
......................................................................
compatibility with class_create API change in 6.4-rc1
Linux kernel 6.4-rc1 has an API change for the class_create() function.
See upstream kernel git commit 1aaba11da9aa7d7d6b52a74d45b31cac118295a1
Change-Id: I5f7d25aa7516c470b943b9e8dfba20ca4206e378
---
M drivers/dahdi/dahdi-sysfs-chan.c
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/85/33185/2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I5f7d25aa7516c470b943b9e8dfba20ca4206e378
Gerrit-Change-Number: 33185
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset