April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: trxcon: l1sched: fix copy-paste in LOGP_SCHEDD macro
by fixeria 14 Apr '23

14 Apr '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32300 ) Change subject: trxcon: l1sched: fix copy-paste in LOGP_SCHEDD macro ...................................................................... trxcon: l1sched: fix copy-paste in LOGP_SCHEDD macro Change-Id: I256578ae23e2f2d29a2751169c63d7a3df6d6f56 Related: OS#5500 --- M src/host/trxcon/include/osmocom/bb/l1sched/logging.h 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/trxcon/include/osmocom/bb/l1sched/logging.h b/src/host/trxcon/include/osmocom/bb/l1sched/logging.h index f88fe4c..21be995 100644 --- a/src/host/trxcon/include/osmocom/bb/l1sched/logging.h +++ b/src/host/trxcon/include/osmocom/bb/l1sched/logging.h @@ -16,7 +16,7 @@ /* Data messages using l1sched_state as the context */ #define LOGP_SCHEDD(sched, level, fmt, args...) \ - LOGP_SCHED_CAT(sched, common, level, fmt, ## args) + LOGP_SCHED_CAT(sched, data, level, fmt, ## args) #define LOGP_LCHAN_NAME_FMT "TS%u-%s" -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I256578ae23e2f2d29a2751169c63d7a3df6d6f56 Gerrit-Change-Number: 32300 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: cosmetic: rename l1sched_find_lchan()
by fixeria 14 Apr '23

14 Apr '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32302 ) Change subject: trxcon/l1sched: cosmetic: rename l1sched_find_lchan() ...................................................................... trxcon/l1sched: cosmetic: rename l1sched_find_lchan() An upcoming patch will add a similar function taking chan_nr/link_id as the search criteria, so let's clarify the existing API first. Change-Id: Ib9f733c22d7fc6bd933219906ca680f246b07f4b Related: OS#5500 --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/src/sched_trx.c 2 files changed, 23 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h index f9894a1..7f7e96d 100644 --- a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h +++ b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h @@ -436,8 +436,8 @@ uint8_t codecs_bitmask, uint8_t start_codec); int l1sched_activate_lchan(struct l1sched_ts *ts, enum l1sched_lchan_type chan); int l1sched_deactivate_lchan(struct l1sched_ts *ts, enum l1sched_lchan_type chan); -struct l1sched_lchan_state *l1sched_find_lchan(struct l1sched_ts *ts, - enum l1sched_lchan_type chan); +struct l1sched_lchan_state *l1sched_find_lchan_by_type(struct l1sched_ts *ts, + enum l1sched_lchan_type type); /* Primitive management functions */ struct l1sched_ts_prim *l1sched_prim_push(struct l1sched_state *sched, diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c index be4331b..49dadd2 100644 --- a/src/host/trxcon/src/sched_trx.c +++ b/src/host/trxcon/src/sched_trx.c @@ -115,7 +115,7 @@ return; /* Make sure that lchan is allocated and active */ - lchan = l1sched_find_lchan(ts, chan); + lchan = l1sched_find_lchan_by_type(ts, chan); if (lchan == NULL || !lchan->active) return; @@ -413,13 +413,13 @@ return 0; } -struct l1sched_lchan_state *l1sched_find_lchan(struct l1sched_ts *ts, - enum l1sched_lchan_type chan) +struct l1sched_lchan_state *l1sched_find_lchan_by_type(struct l1sched_ts *ts, + enum l1sched_lchan_type type) { struct l1sched_lchan_state *lchan; llist_for_each_entry(lchan, &ts->lchans, list) - if (lchan->type == chan) + if (lchan->type == type) return lchan; return NULL; @@ -485,7 +485,7 @@ struct l1sched_lchan_state *lchan; /* Try to find requested logical channel */ - lchan = l1sched_find_lchan(ts, chan); + lchan = l1sched_find_lchan_by_type(ts, chan); if (lchan == NULL) return -EINVAL; @@ -572,7 +572,7 @@ struct l1sched_lchan_state *lchan; /* Try to find requested logical channel */ - lchan = l1sched_find_lchan(ts, chan); + lchan = l1sched_find_lchan_by_type(ts, chan); if (lchan == NULL) return -EINVAL; @@ -794,7 +794,7 @@ return -ENODEV; /* Find required channel state */ - lchan = l1sched_find_lchan(ts, chan); + lchan = l1sched_find_lchan_by_type(ts, chan); if (lchan == NULL) return -ENODEV; @@ -851,7 +851,7 @@ return -ENODEV; /* Find the appropriate logical channel */ - lchan = l1sched_find_lchan(ts, frame->dl_chan); + lchan = l1sched_find_lchan_by_type(ts, frame->dl_chan); if (lchan == NULL) return -ENODEV; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib9f733c22d7fc6bd933219906ca680f246b07f4b Gerrit-Change-Number: 32302 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: rename l1sched[_lchan]_prim_drop()
by fixeria 14 Apr '23

14 Apr '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32301 ) Change subject: trxcon/l1sched: rename l1sched[_lchan]_prim_drop() ...................................................................... trxcon/l1sched: rename l1sched[_lchan]_prim_drop() Make it clear that this function operates on a logical channel. Also take a chance to remove redundant comments and ws. Change-Id: I0517bba2be5403d437d3879b2332196d872e11f2 Related: OS#5500 --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/src/sched_lchan_pdtch.c M src/host/trxcon/src/sched_lchan_rach.c M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c M src/host/trxcon/src/sched_lchan_xcch.c M src/host/trxcon/src/sched_prim.c M src/host/trxcon/src/sched_trx.c 8 files changed, 34 insertions(+), 41 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h index 350294d..f9894a1 100644 --- a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h +++ b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h @@ -480,7 +480,7 @@ struct l1sched_ts_prim *l1sched_prim_dequeue(struct llist_head *queue, uint32_t fn, struct l1sched_lchan_state *lchan); int l1sched_prim_dummy(struct l1sched_lchan_state *lchan); -void l1sched_prim_drop(struct l1sched_lchan_state *lchan); +void l1sched_lchan_prim_drop(struct l1sched_lchan_state *lchan); void l1sched_prim_flush_queue(struct llist_head *list); int l1sched_handle_rx_burst(struct l1sched_state *sched, diff --git a/src/host/trxcon/src/sched_lchan_pdtch.c b/src/host/trxcon/src/sched_lchan_pdtch.c index a518d72..722800f 100644 --- a/src/host/trxcon/src/sched_lchan_pdtch.c +++ b/src/host/trxcon/src/sched_lchan_pdtch.c @@ -129,10 +129,7 @@ LOGP_LCHAND(lchan, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n", lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload, lchan->prim->payload_len)); - - /* Forget this primitive */ - l1sched_prim_drop(lchan); - + l1sched_lchan_prim_drop(lchan); return -EINVAL; } @@ -162,7 +159,7 @@ l1sched_handle_data_cnf(lchan, br->fn, L1SCHED_DT_PACKET_DATA); /* Forget processed primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); /* Reset mask */ *mask = 0x00; diff --git a/src/host/trxcon/src/sched_lchan_rach.c b/src/host/trxcon/src/sched_lchan_rach.c index e59c97d..7448d83 100644 --- a/src/host/trxcon/src/sched_lchan_rach.c +++ b/src/host/trxcon/src/sched_lchan_rach.c @@ -90,9 +90,7 @@ LOGP_LCHAND(lchan, LOGL_ERROR, "Unknown RACH synch. sequence=0x%02x\n", rach->synch_seq); - - /* Forget this primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return -ENOTSUP; } @@ -102,9 +100,7 @@ LOGP_LCHAND(lchan, LOGL_ERROR, "Could not encode 11-bit RACH burst (ra=%u bsic=%u)\n", rach->ra, bsic); - - /* Forget this primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return rc; } } else if (L1SCHED_PRIM_IS_RACH8(lchan->prim)) { @@ -116,16 +112,14 @@ LOGP_LCHAND(lchan, LOGL_ERROR, "Could not encode RACH burst (ra=%u bsic=%u)\n", rach->ra, bsic); - - /* Forget this primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return rc; } } else { LOGP_LCHAND(lchan, LOGL_ERROR, "Primitive has unexpected type=0x%02x\n", lchan->prim->type); - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return -EINVAL; } @@ -154,7 +148,7 @@ l1sched_handle_data_cnf(lchan, br->fn, L1SCHED_DT_OTHER); /* Forget processed primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return 0; } diff --git a/src/host/trxcon/src/sched_lchan_tchf.c b/src/host/trxcon/src/sched_lchan_tchf.c index af7695b..8cb996b 100644 --- a/src/host/trxcon/src/sched_lchan_tchf.c +++ b/src/host/trxcon/src/sched_lchan_tchf.c @@ -309,16 +309,14 @@ LOGP_LCHAND(lchan, LOGL_ERROR, "Invalid TCH mode: %u, dropping frame...\n", lchan->tch_mode); - /* Forget this primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return -EINVAL; } if (lchan->prim->payload_len != l2_len) { LOGP_LCHAND(lchan, LOGL_ERROR, "Primitive has odd length %zu " "(expected %zu for TCH or %u for FACCH), so dropping...\n", lchan->prim->payload_len, l2_len, GSM_MACBLOCK_LEN); - - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return -EINVAL; } rc = gsm0503_tch_fr_encode(buffer, lchan->prim->payload, l2_len, 1); @@ -329,8 +327,7 @@ lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload, lchan->prim->payload_len)); free_bad_msg: - /* Forget this primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return -EINVAL; } @@ -362,7 +359,7 @@ l1sched_handle_data_cnf(lchan, br->fn, dt); /* Forget processed primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); /* Reset mask */ *mask = 0x00; diff --git a/src/host/trxcon/src/sched_lchan_tchh.c b/src/host/trxcon/src/sched_lchan_tchh.c index bebd6e3..7302351 100644 --- a/src/host/trxcon/src/sched_lchan_tchh.c +++ b/src/host/trxcon/src/sched_lchan_tchh.c @@ -529,16 +529,14 @@ LOGP_LCHAND(lchan, LOGL_ERROR, "Invalid TCH mode: %u, dropping frame...\n", lchan->tch_mode); - /* Forget this primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return -EINVAL; } if (lchan->prim->payload_len != l2_len) { LOGP_LCHAND(lchan, LOGL_ERROR, "Primitive has odd length %zu " "(expected %zu for TCH or %u for FACCH), so dropping...\n", lchan->prim->payload_len, l2_len, GSM_MACBLOCK_LEN); - /* Forget this primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return -EINVAL; } rc = gsm0503_tch_hr_encode(buffer, lchan->prim->payload, l2_len); @@ -549,8 +547,7 @@ lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload, lchan->prim->payload_len)); free_bad_msg: - /* Forget this primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return -EINVAL; } @@ -590,7 +587,7 @@ } /* Forget processed primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); } return 0; diff --git a/src/host/trxcon/src/sched_lchan_xcch.c b/src/host/trxcon/src/sched_lchan_xcch.c index 0f47ffe..936a899 100644 --- a/src/host/trxcon/src/sched_lchan_xcch.c +++ b/src/host/trxcon/src/sched_lchan_xcch.c @@ -124,8 +124,7 @@ LOGP_LCHAND(lchan, LOGL_ERROR, "Primitive has odd length %zu (expected %u), so dropping...\n", lchan->prim->payload_len, GSM_MACBLOCK_LEN); - - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); return -EINVAL; } @@ -135,10 +134,7 @@ LOGP_LCHAND(lchan, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n", lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload, lchan->prim->payload_len)); - - /* Forget this primitive */ - l1sched_prim_drop(lchan); - + l1sched_lchan_prim_drop(lchan); return -EINVAL; } @@ -168,7 +164,7 @@ l1sched_handle_data_cnf(lchan, br->fn, L1SCHED_DT_SIGNALING); /* Forget processed primitive */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); /* Reset mask */ *mask = 0x00; diff --git a/src/host/trxcon/src/sched_prim.c b/src/host/trxcon/src/sched_prim.c index 99c4d82..b7ebdeb 100644 --- a/src/host/trxcon/src/sched_prim.c +++ b/src/host/trxcon/src/sched_prim.c @@ -466,9 +466,8 @@ * * @param lchan a logical channel to drop prim from */ -void l1sched_prim_drop(struct l1sched_lchan_state *lchan) +void l1sched_lchan_prim_drop(struct l1sched_lchan_state *lchan) { - /* Forget this primitive */ talloc_free(lchan->prim); lchan->prim = NULL; } diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c index ac55f92..be4331b 100644 --- a/src/host/trxcon/src/sched_trx.c +++ b/src/host/trxcon/src/sched_trx.c @@ -544,7 +544,7 @@ lchan->tx_bursts = NULL; /* Forget the current prim */ - l1sched_prim_drop(lchan); + l1sched_lchan_prim_drop(lchan); /* Channel specific stuff */ if (L1SCHED_CHAN_IS_TCH(lchan->type)) { -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0517bba2be5403d437d3879b2332196d872e11f2 Gerrit-Change-Number: 32301 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcap[master]: contrib/jenkins.sh: build with --enable-external-tests
by fixeria 14 Apr '23

14 Apr '23

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32127 ) Change subject: contrib/jenkins.sh: build with --enable-external-tests ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Interesting, where do we test with travis? We don't, I guess Holger initially had it hosted on GitHub: ``` commit 9646754e1f82d3b846304dc5803d520641064ba4 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Wed Aug 3 21:13:15 2016 +0200 ci: Add travis.yml for the github account ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ic9d37b231510e592198a9de707dfe8f5f2703dce Gerrit-Change-Number: 32127 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 11:30:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-msc
by fixeria 14 Apr '23

14 Apr '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32120 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-msc ...................................................................... tests: $(BUILT_SOURCES) is not defined, depend on osmo-msc Change-Id: I3676a744bbe13d5d17caa94e9bd9e21c5c53de87 --- M tests/Makefile.am 1 file changed, 15 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/Makefile.am b/tests/Makefile.am index d25fe16..5b77250 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -48,7 +48,7 @@ if ENABLE_EXT_TESTS # don't run multiple tests concurrently so that the ports don't conflict -python-tests: $(BUILT_SOURCES) +python-tests: $(MAKE) vty-test $(MAKE) ctrl-test if BUILD_SMPP @@ -56,11 +56,11 @@ endif else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif -vty-python-test: $(BUILT_SOURCES) +vty-python-test: $(top_builddir)/src/osmo-msc/osmo-msc if BUILD_IU IU=1 osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v IU=1 osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v @@ -77,7 +77,7 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-transcript-test U=-u -vty-transcript-test: +vty-transcript-test: $(top_builddir)/src/osmo-msc/osmo-msc osmo_verify_transcript_vty.py -v \ -n OsmoMSC -p 4254 \ -r "$(top_builddir)/src/osmo-msc/osmo-msc -c $(top_srcdir)/doc/examples/osmo-msc/osmo-msc.cfg" \ @@ -89,7 +89,7 @@ $(MAKE) vty-python-test $(MAKE) vty-transcript-test -ctrl-python-test: $(BUILT_SOURCES) +ctrl-python-test: $(top_builddir)/src/osmo-msc/osmo-msc $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v rm -f $(top_builddir)/sms.db* @@ -104,7 +104,7 @@ $(MAKE) ctrl-python-test $(MAKE) ctrl-transcript-test -smpp-test: +smpp-test:$(top_builddir)/src/osmo-msc/osmo-msc $(srcdir)/smpp_test_runner.py -w $(abs_top_builddir) -v rm -f $(top_builddir)/sms.db* -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3676a744bbe13d5d17caa94e9bd9e21c5c53de87 Gerrit-Change-Number: 32120 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-msc
by fixeria 14 Apr '23

14 Apr '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32120 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-msc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3676a744bbe13d5d17caa94e9bd9e21c5c53de87 Gerrit-Change-Number: 32120 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 11:16:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-prog.py: fix SyntaxWarning: using is with a literal
by fixeria 14 Apr '23

14 Apr '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/32297 ) Change subject: pySim-prog.py: fix SyntaxWarning: using is with a literal ...................................................................... pySim-prog.py: fix SyntaxWarning: using is with a literal Change-Id: If9460bf827242a1dfc518213e3faa9137a21869a --- M pySim-prog.py 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/pySim-prog.py b/pySim-prog.py index b3919ee..448f2a0 100755 --- a/pySim-prog.py +++ b/pySim-prog.py @@ -599,9 +599,9 @@ # commandline options we can use that info, otherwise we guess that # the length is 2, which is also the most common case. if opts.mnclen != "auto": - if opts.mnclen is "2": + if opts.mnclen == "2": row['mnc'] = row.get('mnc', mnc_from_imsi(row.get('imsi'), False)) - elif opts.mnclen is "3": + elif opts.mnclen == "3": row['mnc'] = row.get('mnc', mnc_from_imsi(row.get('imsi'), True)) else: raise ValueError("invalid parameter --mnclen, must be 2 or 3 or auto") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If9460bf827242a1dfc518213e3faa9137a21869a Gerrit-Change-Number: 32297 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: pySim-prog.py: fix SyntaxWarning: using is with a literal
by fixeria 14 Apr '23

14 Apr '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32297 ) Change subject: pySim-prog.py: fix SyntaxWarning: using is with a literal ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If9460bf827242a1dfc518213e3faa9137a21869a Gerrit-Change-Number: 32297 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 11:14:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: add l1sched_find_lchan_by_chan_nr()
by pespin 14 Apr '23

14 Apr '23

Attention is currently required from: fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32303 ) Change subject: trxcon/l1sched: add l1sched_find_lchan_by_chan_nr() ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/src/sched_trx.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32303/comment/703337e3_166be2bb PS1, Line 440: if (lchan_desc->chan_nr != (chan_nr & 0xf8)) > Where those magic numbers come from? Ack. It is not clear for us what are you checking here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9917a932c9a4aeb4b3ef7053bd58066b3aa41edb Gerrit-Change-Number: 32303 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 09:57:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: cosmetic: rename l1sched_find_lchan()
by pespin 14 Apr '23

14 Apr '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32302 ) Change subject: trxcon/l1sched: cosmetic: rename l1sched_find_lchan() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib9f733c22d7fc6bd933219906ca680f246b07f4b Gerrit-Change-Number: 32302 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 09:55:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0