April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: pcu_l1_if: replace magic numbers with IMSI_DIGITS_FOR_PAGING
by pespin 14 Apr '23

14 Apr '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32307 ) Change subject: pcu_l1_if: replace magic numbers with IMSI_DIGITS_FOR_PAGING ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9a1b6ba4578e2a8875d8d1a9e56c36dc2b33fe0d Gerrit-Change-Number: 32307 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 12:54:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: cosmetic: reformat comment
by pespin 14 Apr '23

14 Apr '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32306 ) Change subject: pcu_l1_if: cosmetic: reformat comment ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib4ae65e1bc118572135fbec02e64dbec35f208b4 Gerrit-Change-Number: 32306 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 12:53:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: cosmetic: reformat comment
by dexter 14 Apr '23

14 Apr '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32306 ) Change subject: pcu_l1_if: cosmetic: reformat comment ...................................................................... pcu_l1_if: cosmetic: reformat comment Change-Id: Ib4ae65e1bc118572135fbec02e64dbec35f208b4 --- M src/pcu_l1_if.cpp 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/06/32306/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 577ba57..6d48d92 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -274,9 +274,7 @@ else memset(data, '0', IMSI_DIGITS_FOR_PAGING); - /* block provided by upper layer comes without first byte (plen), - * prepend it manually: - */ + /* block provided by upper layer comes without first byte (plen), prepend it manually: */ OSMO_ASSERT(sizeof(data) >= IMSI_DIGITS_FOR_PAGING + 1 + block->data_len); data[3] = (plen << 2) | 0x01; bitvec_pack(block, data + IMSI_DIGITS_FOR_PAGING + 1); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib4ae65e1bc118572135fbec02e64dbec35f208b4 Gerrit-Change-Number: 32306 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: replace magic numbers with IMSI_DIGITS_FOR_PAGING
by dexter 14 Apr '23

14 Apr '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32307 ) Change subject: pcu_l1_if: replace magic numbers with IMSI_DIGITS_FOR_PAGING ...................................................................... pcu_l1_if: replace magic numbers with IMSI_DIGITS_FOR_PAGING we have defined IMSI_DIGITS_FOR_PAGING but some parts of the code still use magic numbers (3), let's replace those as well. Change-Id: I9a1b6ba4578e2a8875d8d1a9e56c36dc2b33fe0d --- M src/pcu_l1_if.cpp 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/32307/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 6d48d92..ca3164b 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -276,11 +276,12 @@ /* block provided by upper layer comes without first byte (plen), prepend it manually: */ OSMO_ASSERT(sizeof(data) >= IMSI_DIGITS_FOR_PAGING + 1 + block->data_len); - data[3] = (plen << 2) | 0x01; + data[IMSI_DIGITS_FOR_PAGING] = (plen << 2) | 0x01; bitvec_pack(block, data + IMSI_DIGITS_FOR_PAGING + 1); if (the_pcu->gsmtap_categ_mask & (1 << PCU_GSMTAP_C_DL_PCH)) - gsmtap_send(the_pcu->gsmtap, 0, 0, GSMTAP_CHANNEL_PCH, 0, 0, 0, 0, data + 3, GSM_MACBLOCK_LEN); + gsmtap_send(the_pcu->gsmtap, 0, 0, GSMTAP_CHANNEL_PCH, 0, 0, 0, 0, + data + IMSI_DIGITS_FOR_PAGING, GSM_MACBLOCK_LEN); pcu_tx_data_req(bts, 0, 0, PCU_IF_SAPI_PCH, 0, 0, 0, data, sizeof(data)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9a1b6ba4578e2a8875d8d1a9e56c36dc2b33fe0d Gerrit-Change-Number: 32307 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-gprs[master]: sm: Start using SNSM SAP
by pespin 14 Apr '23

14 Apr '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32295 to look at the new patch set (#4). Change subject: sm: Start using SNSM SAP ...................................................................... sm: Start using SNSM SAP Related: OS#5501 Change-Id: Ic5525bfa92e2591757d999610c0d59849d022d8d --- M include/osmocom/gprs/sm/sm_ms_fsm.h M include/osmocom/gprs/sm/sm_prim.h M include/osmocom/gprs/sm/sm_private.h M libosmo-gprs-sm.pc.in M src/sm/Makefile.am M src/sm/sm.c M src/sm/sm_ms_fsm.c M src/sm/sm_prim.c M tests/sm/Makefile.am M tests/sm/sm_prim_test.c M tests/sm/sm_prim_test.err M tests/sm/sm_prim_test.ok 12 files changed, 216 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/95/32295/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic5525bfa92e2591757d999610c0d59849d022d8d Gerrit-Change-Number: 32295 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: add l1sched_find_lchan_by_chan_nr()
by pespin 14 Apr '23

14 Apr '23

Attention is currently required from: fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32303 ) Change subject: trxcon/l1sched: add l1sched_find_lchan_by_chan_nr() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9917a932c9a4aeb4b3ef7053bd58066b3aa41edb Gerrit-Change-Number: 32303 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 11:59:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: use RSL_CHAN_NR_MASK from libosmogsm
by pespin 14 Apr '23

14 Apr '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32305 ) Change subject: trxcon/l1sched: use RSL_CHAN_NR_MASK from libosmogsm ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibec43dcd4acc104ab5f1930112db6fe9aff917a1 Gerrit-Change-Number: 32305 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 11:59:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: add l1sched_find_lchan_by_chan_nr()
by fixeria 14 Apr '23

14 Apr '23

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32303 ) Change subject: trxcon/l1sched: add l1sched_find_lchan_by_chan_nr() ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/src/sched_trx.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32303/comment/4c7c9965_60917083 PS1, Line 440: if (lchan_desc->chan_nr != (chan_nr & 0xf8)) > Ack. It is not clear for us what are you checking here. Done, see also: https://gerrit.osmocom.org/c/osmocom-bb/+/32305. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9917a932c9a4aeb4b3ef7053bd58066b3aa41edb Gerrit-Change-Number: 32303 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 11:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: use RSL_CHAN_NR_MASK from libosmogsm
by fixeria 14 Apr '23

14 Apr '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32305 ) Change subject: trxcon/l1sched: use RSL_CHAN_NR_MASK from libosmogsm ...................................................................... trxcon/l1sched: use RSL_CHAN_NR_MASK from libosmogsm Change-Id: Ibec43dcd4acc104ab5f1930112db6fe9aff917a1 Related: OS#5500 --- M src/host/trxcon/src/sched_trx.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/05/32305/1 diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c index 49dadd2..12c6385 100644 --- a/src/host/trxcon/src/sched_trx.c +++ b/src/host/trxcon/src/sched_trx.c @@ -439,7 +439,7 @@ llist_for_each_entry(lchan, &ts->lchans, list) { lchan_desc = &l1sched_lchan_desc[lchan->type]; - if (lchan_desc->chan_nr == (chan_nr & 0xf8)) { + if (lchan_desc->chan_nr == (chan_nr & RSL_CHAN_NR_MASK)) { if (active) { rc |= l1sched_activate_lchan(ts, lchan->type); lchan->tch_mode = tch_mode; @@ -642,7 +642,7 @@ /* Iterate over all known lchan types */ for (i = 0; i < _L1SCHED_CHAN_MAX; i++) - if (l1sched_lchan_desc[i].chan_nr == (chan_nr & 0xf8)) + if (l1sched_lchan_desc[i].chan_nr == (chan_nr & RSL_CHAN_NR_MASK)) if (l1sched_lchan_desc[i].link_id == link_id) return i; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibec43dcd4acc104ab5f1930112db6fe9aff917a1 Gerrit-Change-Number: 32305 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: add l1sched_find_lchan_by_chan_nr()
by fixeria 14 Apr '23

14 Apr '23

Attention is currently required from: fixeria, msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32303 to look at the new patch set (#2). Change subject: trxcon/l1sched: add l1sched_find_lchan_by_chan_nr() ...................................................................... trxcon/l1sched: add l1sched_find_lchan_by_chan_nr() Change-Id: I9917a932c9a4aeb4b3ef7053bd58066b3aa41edb Related: OS#5500 --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/src/sched_trx.c 2 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/03/32303/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9917a932c9a4aeb4b3ef7053bd58066b3aa41edb Gerrit-Change-Number: 32303 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0