April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: abis_rsl: fix encoding RSL_IE_IPAC_RTP_CSD_FORMAT

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32366 ) Change subject: abis_rsl: fix encoding RSL_IE_IPAC_RTP_CSD_FORMAT ...................................................................... abis_rsl: fix encoding RSL_IE_IPAC_RTP_CSD_FORMAT The A-bis/IP RTP CSD Format IR Values need to be shifted by 4 bits instead of 5. See OsmoBTS Abis Protocol Specification § 5.8.14 RSL_IE_IPAC_RTP_CSD_FORMAT. Related: https://ftp.osmocom.org/docs/osmo-bts/master/osmobts-abis.pdf Related: OS#4393 Change-Id: I9ce0b2d9b77eef61a6d4dce417efe4e853217dc5 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/66/32366/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index dfe7da9..6370942 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2590,18 +2590,18 @@ switch (ch_mode_rate->data_rate.t) { case RSL_CMOD_CSD_T_32k0: case RSL_CMOD_CSD_T_29k0: - ret |= RSL_IPAC_RTP_CSD_IR_32k << 5; + ret |= RSL_IPAC_RTP_CSD_IR_32k << 4; break; case RSL_CMOD_CSD_T_14k4: case RSL_CMOD_CSD_T_9k6: - ret |= RSL_IPAC_RTP_CSD_IR_16k << 5; + ret |= RSL_IPAC_RTP_CSD_IR_16k << 4; break; case RSL_CMOD_CSD_T_4k8: case RSL_CMOD_CSD_T_2k4: case RSL_CMOD_CSD_T_1k2: case RSL_CMOD_CSD_T_600: case RSL_CMOD_CSD_T_1200_75: - ret |= RSL_IPAC_RTP_CSD_IR_8k << 5; + ret |= RSL_IPAC_RTP_CSD_IR_8k << 4; break; default: return -EINVAL; @@ -2622,19 +2622,19 @@ case RSL_CMOD_CSD_NTA_14k5_43k5: case RSL_CMOD_CSD_NTA_29k0_43k5: case RSL_CMOD_CSD_NT_43k5: - ret |= RSL_IPAC_RTP_CSD_IR_64k << 5; + ret |= RSL_IPAC_RTP_CSD_IR_64k << 4; break; case RSL_CMOD_CSD_NTA_29k0_14k5: case RSL_CMOD_CSD_NTA_14k5_29k0: case RSL_CMOD_CSD_NT_28k8: - ret |= RSL_IPAC_RTP_CSD_IR_32k << 5; + ret |= RSL_IPAC_RTP_CSD_IR_32k << 4; break; case RSL_CMOD_CSD_NT_14k5: case RSL_CMOD_CSD_NT_12k0: - ret |= RSL_IPAC_RTP_CSD_IR_16k << 5; + ret |= RSL_IPAC_RTP_CSD_IR_16k << 4; break; case RSL_CMOD_CSD_NT_6k0: - ret |= RSL_IPAC_RTP_CSD_IR_8k << 5; + ret |= RSL_IPAC_RTP_CSD_IR_8k << 4; break; default: return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ce0b2d9b77eef61a6d4dce417efe4e853217dc5 Gerrit-Change-Number: 32366 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-bsc[master]: CSD: support 29k0, 32k0 transp data

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32367 ) Change subject: CSD: support 29k0, 32k0 transp data ...................................................................... CSD: support 29k0, 32k0 transp data Related: OS#4393 Change-Id: I03fd3ca19b08d5cff8748ba9cf2f21d4befaf338 --- M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/assignment_fsm.c M src/osmo-bsc/data_rate_pref.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/lchan_rtp_fsm.c M src/osmo-bsc/lchan_select.c 6 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/67/32367/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 6370942..37f0e81 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -456,6 +456,8 @@ case GSM48_CMODE_SPEECH_AMR: cm->chan_rate = RSL_CMOD_SP_GSM3; break; + case GSM48_CMODE_DATA_32k0: + case GSM48_CMODE_DATA_29k0: case GSM48_CMODE_DATA_14k5: case GSM48_CMODE_DATA_12k0: case GSM48_CMODE_DATA_6k0: @@ -2695,6 +2697,8 @@ int ipacc_payload_type(enum gsm48_chan_mode tch_mode, enum gsm_chan_t type) { switch (gsm48_chan_mode_to_non_vamos(tch_mode)) { + case GSM48_CMODE_DATA_32k0: + case GSM48_CMODE_DATA_29k0: case GSM48_CMODE_DATA_14k5: case GSM48_CMODE_DATA_12k0: case GSM48_CMODE_DATA_6k0: diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index 02ca29c..b631767 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -361,6 +361,8 @@ case GSM48_CMODE_DATA_12k0: case GSM48_CMODE_DATA_14k5: + case GSM48_CMODE_DATA_29k0: + case GSM48_CMODE_DATA_32k0: case GSM48_CMODE_SPEECH_EFR: /* these services all explicitly require a TCH/F */ return type == GSM_LCHAN_TCH_F; @@ -378,6 +380,8 @@ static int chan_mode_to_ch_indctr(enum gsm48_chan_mode chan_mode) { switch (gsm48_chan_mode_to_non_vamos(chan_mode)) { + case GSM48_CMODE_DATA_32k0: + case GSM48_CMODE_DATA_29k0: case GSM48_CMODE_DATA_14k5: case GSM48_CMODE_DATA_12k0: case GSM48_CMODE_DATA_6k0: diff --git a/src/osmo-bsc/data_rate_pref.c b/src/osmo-bsc/data_rate_pref.c index 443fea7..2c98169 100644 --- a/src/osmo-bsc/data_rate_pref.c +++ b/src/osmo-bsc/data_rate_pref.c @@ -55,6 +55,10 @@ static int gsm0808_data_rate_transp_to_gsm0408(enum gsm0808_data_rate_transp rate) { switch (rate) { + case GSM0808_DATA_RATE_TRANSP_32k0: + return GSM48_CMODE_DATA_32k0; + case GSM0808_DATA_RATE_TRANSP_28k8: + return GSM48_CMODE_DATA_29k0; case GSM0808_DATA_RATE_TRANSP_14k4: return GSM48_CMODE_DATA_14k5; case GSM0808_DATA_RATE_TRANSP_9k6: diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 012149a..1e132f4 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -1034,6 +1034,8 @@ case GSM48_CMODE_SPEECH_EFR: case GSM48_CMODE_SPEECH_AMR: return RSL_CMOD_SPD_SPEECH; + case GSM48_CMODE_DATA_32k0: + case GSM48_CMODE_DATA_29k0: case GSM48_CMODE_DATA_14k5: case GSM48_CMODE_DATA_12k0: case GSM48_CMODE_DATA_6k0: diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c index 7e9c31f..8b6faad 100644 --- a/src/osmo-bsc/lchan_rtp_fsm.c +++ b/src/osmo-bsc/lchan_rtp_fsm.c @@ -871,6 +871,8 @@ static enum mgcp_codecs chan_mode_to_mgcp_codec(enum gsm48_chan_mode chan_mode, bool full_rate) { switch (gsm48_chan_mode_to_non_vamos(chan_mode)) { + case GSM48_CMODE_DATA_32k0: + case GSM48_CMODE_DATA_29k0: case GSM48_CMODE_DATA_14k5: case GSM48_CMODE_DATA_12k0: case GSM48_CMODE_DATA_6k0: diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c index 1e12d96..9e0da86 100644 --- a/src/osmo-bsc/lchan_select.c +++ b/src/osmo-bsc/lchan_select.c @@ -184,6 +184,8 @@ /* fall through */ case GSM48_CMODE_SPEECH_V1: case GSM48_CMODE_SPEECH_AMR: + case GSM48_CMODE_DATA_32k0: + case GSM48_CMODE_DATA_29k0: case GSM48_CMODE_DATA_14k5: case GSM48_CMODE_DATA_12k0: case GSM48_CMODE_DATA_6k0: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I03fd3ca19b08d5cff8748ba9cf2f21d4befaf338 Gerrit-Change-Number: 32367 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: bsc: TC_assignment_csd: test all transp data rates

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32365 ) Change subject: bsc: TC_assignment_csd: test all transp data rates ...................................................................... bsc: TC_assignment_csd: test all transp data rates Related: OS#4393 Change-Id: I9a5f0e630fefcafb1b26eabba73de7e76d9e7e5d --- M bsc/BSC_Tests.ttcn M bsc/MSC_ConnectionHandler.ttcn 2 files changed, 50 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/32365/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index e60c342..edd54bc 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1869,7 +1869,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelTypeCSD); ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecCSData})); - ass_cmd.pdu.bssmap.assignmentRequest.channelType.speechId_DataIndicator := GSM0808_DATA_RATE_TRANSP_4k8; + ass_cmd.pdu.bssmap.assignmentRequest.channelType.speechId_DataIndicator := g_pars.speech_data_ind; f_establish_fully(ass_cmd, exp_compl); @@ -1879,10 +1879,11 @@ f_perform_clear(); } -testcase TC_assignment_csd_t_4k8() runs on test_CT { +private function f_tc_assignment_csd_test_CT(OCT1 speech_data_ind) runs on test_CT { var MSC_ConnHdlr vc_conn; var TestHdlrParams pars := f_gen_test_hdlr_pars(); pars.encr := valueof(t_EncrParams('01'O, f_rnd_octstring(8))); + pars.speech_data_ind := speech_data_ind; f_init(1, true); f_sleep(1.0); @@ -1890,6 +1891,33 @@ vc_conn.done; f_shutdown_helper(); } +testcase TC_assignment_csd_t_32k0() runs on test_CT { + f_tc_assignment_csd_test_CT(GSM0808_DATA_RATE_TRANSP_32k0); +} +testcase TC_assignment_csd_t_28k8() runs on test_CT { + f_tc_assignment_csd_test_CT(GSM0808_DATA_RATE_TRANSP_28k8); +} +testcase TC_assignment_csd_t_14k4() runs on test_CT { + f_tc_assignment_csd_test_CT(GSM0808_DATA_RATE_TRANSP_14k4); +} +testcase TC_assignment_csd_t_9k6() runs on test_CT { + f_tc_assignment_csd_test_CT(GSM0808_DATA_RATE_TRANSP_9k6); +} +testcase TC_assignment_csd_t_4k8() runs on test_CT { + f_tc_assignment_csd_test_CT(GSM0808_DATA_RATE_TRANSP_4k8); +} +testcase TC_assignment_csd_t_2k4() runs on test_CT { + f_tc_assignment_csd_test_CT(GSM0808_DATA_RATE_TRANSP_2k4); +} +testcase TC_assignment_csd_t_1k2() runs on test_CT { + f_tc_assignment_csd_test_CT(GSM0808_DATA_RATE_TRANSP_1k2); +} +testcase TC_assignment_csd_t_600() runs on test_CT { + f_tc_assignment_csd_test_CT(GSM0808_DATA_RATE_TRANSP_600); +} +testcase TC_assignment_csd_t_1200_75() runs on test_CT { + f_tc_assignment_csd_test_CT(GSM0808_DATA_RATE_TRANSP_1200_75); +} testcase TC_assignment_ctm() runs on test_CT { var template PDU_BSSAP exp_fail := tr_BSSMAP_AssignmentFail; @@ -12362,7 +12390,15 @@ /* Assignment related */ execute( TC_assignment_cic_only() ); if (Misc_Helpers.f_osmo_repo_is("nightly")) { /* osmo-bsc > 1.10.0 */ + execute( TC_assignment_csd_t_32k0() ); + execute( TC_assignment_csd_t_28k8() ); + execute( TC_assignment_csd_t_14k4() ); + execute( TC_assignment_csd_t_9k6() ); execute( TC_assignment_csd_t_4k8() ); + execute( TC_assignment_csd_t_2k4() ); + execute( TC_assignment_csd_t_1k2() ); + execute( TC_assignment_csd_t_600() ); + execute( TC_assignment_csd_t_1200_75() ); } else { execute( TC_assignment_csd() ); } diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index fa7cd84..9e32ed3 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -785,7 +785,8 @@ boolean inter_bsc_ho_in__ho_req_in_initial_sccp_cr, boolean ignore_mgw_mdcx, boolean fail_on_dlcx, - boolean ignore_ipa_media + boolean ignore_ipa_media, + OCT1 speech_data_ind }; /* Note: Do not use valueof() to get a value of this template, use -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a5f0e630fefcafb1b26eabba73de7e76d9e7e5d Gerrit-Change-Number: 32365 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: bsc: TC_assignment_csd: split into two tests

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32364 ) Change subject: bsc: TC_assignment_csd: split into two tests ...................................................................... bsc: TC_assignment_csd: split into two tests Prepare to test multiple data rates by splitting the test for the old behavior (CSD not implemented) from the code that tests a specific data rate. Related: OS#4393 Change-Id: I052685d36d9fc794502b6fe2c444b95ebac8dfc4 --- M bsc/BSC_Tests.ttcn 1 file changed, 39 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/32364/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index aa627b7..e60c342 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1849,6 +1849,18 @@ return dt; } +/* Test for CSD assignment failure as it is not implemented, drop after + * osmo-bsc > 1.10.0 in favor of TC_assignment_csd_t_4k8 etc. below. */ +testcase TC_assignment_csd() runs on test_CT { + var template PDU_BSSAP exp_fail := tr_BSSMAP_AssignmentFail; + var PDU_BSSAP ass_cmd := f_gen_ass_req(); + ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelTypeCSD); + //exp_fail.pdu.bssmap.assignmentFailure.cause.causeValue := int2bit(enum2int(GSM0808_CAUSE_REQ_CODEC_TYPE_OR_CONFIG_UNAVAIL), 7); + var DchanTuple dt := f_assignment_exp(ass_cmd, exp_fail, "BSC accepted Assignment for CSD"); + f_perform_clear_test_ct(dt); + f_shutdown_helper(); +} + private function f_tc_assignment_csd(charstring id) runs on MSC_ConnHdlr { var template PDU_BSSAP exp_compl := f_gen_exp_compl(); var PDU_BSSAP ass_cmd := f_gen_ass_req(); @@ -1867,24 +1879,15 @@ f_perform_clear(); } -testcase TC_assignment_csd() runs on test_CT { - if (Misc_Helpers.f_osmo_repo_is("nightly")) { /* osmo-bsc > 1.10.0 */ - var MSC_ConnHdlr vc_conn; - var TestHdlrParams pars := f_gen_test_hdlr_pars(); - pars.encr := valueof(t_EncrParams('01'O, f_rnd_octstring(8))); +testcase TC_assignment_csd_t_4k8() runs on test_CT { + var MSC_ConnHdlr vc_conn; + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + pars.encr := valueof(t_EncrParams('01'O, f_rnd_octstring(8))); - f_init(1, true); - f_sleep(1.0); - vc_conn := f_start_handler(refers(f_tc_assignment_csd), pars); - vc_conn.done; - } else { - var template PDU_BSSAP exp_fail := tr_BSSMAP_AssignmentFail; - var PDU_BSSAP ass_cmd := f_gen_ass_req(); - ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelTypeCSD); - //exp_fail.pdu.bssmap.assignmentFailure.cause.causeValue := int2bit(enum2int(GSM0808_CAUSE_REQ_CODEC_TYPE_OR_CONFIG_UNAVAIL), 7); - var DchanTuple dt := f_assignment_exp(ass_cmd, exp_fail, "BSC accepted Assignment for CSD"); - f_perform_clear_test_ct(dt); - } + f_init(1, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_assignment_csd), pars); + vc_conn.done; f_shutdown_helper(); } @@ -12358,7 +12361,11 @@ /* Assignment related */ execute( TC_assignment_cic_only() ); - execute( TC_assignment_csd() ); + if (Misc_Helpers.f_osmo_repo_is("nightly")) { /* osmo-bsc > 1.10.0 */ + execute( TC_assignment_csd_t_4k8() ); + } else { + execute( TC_assignment_csd() ); + } execute( TC_assignment_ctm() ); execute( TC_assignment_sign() ); if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_AoIP) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I052685d36d9fc794502b6fe2c444b95ebac8dfc4 Gerrit-Change-Number: 32364 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in libosmo-pfcp[master]: coverity: fix null deref

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/32363 ) Change subject: coverity: fix null deref ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/32363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I347a813b31c839eae6b752982952367b2e664dc4 Gerrit-Change-Number: 32363 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Apr 2023 01:07:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bts[master]: gsm_objclass2obj(): Change signature/set NACK cause

by fixeria

Attention is currently required from: arehbein, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32354 ) Change subject: gsm_objclass2obj(): Change signature/set NACK cause ...................................................................... Patch Set 2: (1 comment) File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/5816d636_fde453c6 PS2, Line 1106: gsm_objclass2obj This call may overwrite the cause previously set by `gsm_objclass2mo()`. We may want two checks here instead of a combined one, i.e. ``` if ((mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst, &c)) == NULL) return oml_fom_ack_nack(msg, c); if ((obj = gsm_objclass2obj(bts, foh->obj_class, &foh->obj_inst, &c)) == NULL) return oml_fom_ack_nack(msg, c); ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If734ea2c8cae4c1f99b02520dffa4e3862a67745 Gerrit-Change-Number: 32354 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Apr 2023 01:06:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bts[master]: gsm_objclass2mo(): Change signature/set NACK cause

by fixeria

Attention is currently required from: arehbein. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32075 ) Change subject: gsm_objclass2mo(): Change signature/set NACK cause ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37e6b23ed95260a8188910cf9754faffcba519c5 Gerrit-Change-Number: 32075 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Apr 2023 01:02:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-bts[master]: common: Remove redundant checks

by fixeria

Attention is currently required from: arehbein, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32073 ) Change subject: common: Remove redundant checks ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9f21f1a0a9dab897d4fd89ab6b7341ca4aec8b22 Gerrit-Change-Number: 32073 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Apr 2023 00:59:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-pfcp[master]: coverity: fix null deref

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/32363 ) Change subject: coverity: fix null deref ...................................................................... coverity: fix null deref fixup for "pfcp_msg: refactor LOG_PFCP_MSG e6ff99d7acbe270ed8f271daeaafc99e03a48176 Change-Id Ic84090c9b1a34185577cfb2ea1efa9c07542df34 Related: CID#313611 Change-Id: I347a813b31c839eae6b752982952367b2e664dc4 --- M src/libosmo-pfcp/pfcp_msg.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/63/32363/1 diff --git a/src/libosmo-pfcp/pfcp_msg.c b/src/libosmo-pfcp/pfcp_msg.c index 74335fe..abcee18 100644 --- a/src/libosmo-pfcp/pfcp_msg.c +++ b/src/libosmo-pfcp/pfcp_msg.c @@ -555,7 +555,7 @@ { struct osmo_strbuf sb = { .buf = buf, .len = buflen }; struct osmo_fsm_inst *fi = m ? (m->ctx.session_fi ?: m->ctx.peer_fi) : NULL; - enum osmo_pfcp_cause *cause = osmo_pfcp_msg_cause(m); + enum osmo_pfcp_cause *cause = m ? osmo_pfcp_msg_cause(m) : NULL; if (fi) OSMO_STRBUF_PRINTF(sb, "%s{%s}: ", -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/32363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I347a813b31c839eae6b752982952367b2e664dc4 Gerrit-Change-Number: 32363 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[M] Change in libosmo-sccp[master]: sccp_scoc.c: fix infinite loop on conn ID exhaustion

by neels

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32320 ) Change subject: sccp_scoc.c: fix infinite loop on conn ID exhaustion ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/55004c17_3a0e5a67 PS1, Line 17: entire SCCP conn id number space before exiting in failure. > I don't think it should be configurable. […] In some programs we have sanity counters to limit iterations to find an unused ID, I think like 1000 or 10000 or some such, so I thought it might be a good idea. AFAICT not for SCCP though, more the other protocols... I've been hitting this issue of finding an unused ID a lot, and it is in theory a pretty hard problem to make this always O(1). But I've been thinking on-and-off about a general API that will in "all" practical situations be O(1), completely avoiding a lookup whether an ID is used. So yes, ok, if the way to find an unused ID changes and does not require a max_iterations argument at all, then you're probably right and we shouldn't put that parameter there at all. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ib64e0cb1ae0cc8b7bebcb2a352d4068b496b304a Gerrit-Change-Number: 32320 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Apr 2023 00:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023