pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32357 )
Change subject: ms: Make sure tbf!=NULL in ms_attach_{ul,dl}_tbf()
......................................................................
ms: Make sure tbf!=NULL in ms_attach_{ul,dl}_tbf()
It makes no sense to pass "NULL" to attach function. There's a detach
function to be used if a given TBF has to be detached.
Change-Id: I0c5df195c080b21e5516aebfb46db22bdc55f2a2
---
M src/gprs_ms.c
1 file changed, 17 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/57/32357/1
diff --git a/src/gprs_ms.c b/src/gprs_ms.c
index f65ffb8..357470b 100644
--- a/src/gprs_ms.c
+++ b/src/gprs_ms.c
@@ -362,8 +362,7 @@
ms->ul_tbf = tbf;
- if (tbf)
- ms_release_timer_stop(ms);
+ ms_release_timer_stop(ms);
ms_unref(ms, __func__);
}
@@ -382,14 +381,16 @@
ms->dl_tbf = tbf;
- if (tbf)
- ms_release_timer_stop(ms);
+ ms_release_timer_stop(ms);
ms_unref(ms, __func__);
}
void ms_attach_tbf(struct GprsMs *ms, struct gprs_rlcmac_tbf *tbf)
{
+ OSMO_ASSERT(ms);
+ OSMO_ASSERT(tbf);
+
if (tbf_direction(tbf) == GPRS_RLCMAC_DL_TBF)
ms_attach_dl_tbf(ms, tbf_as_dl_tbf(tbf));
else
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32357
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0c5df195c080b21e5516aebfb46db22bdc55f2a2
Gerrit-Change-Number: 32357
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: falconia.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/32347
to look at the new patch set (#2).
Change subject: osmo_rtp2trau() for FR & EFR UL: set C13 & C14 correctly
......................................................................
osmo_rtp2trau() for FR & EFR UL: set C13 & C14 correctly
Control bits C13 & C14 in TRAU-UL frames indicate SID classification
per section 6.1.1 of GSM 06.31 for FR or GSM 06.81 for EFR.
Previous commit 08d0c0990275 implements correct setting of C16 in
TRAU-DL, but the case of generating TRAU-UL was left as a FIXME.
Now that we have osmo_{fr,efr}_sid_classify() functions in
libosmocodec, we can set C13 & C14 in TRAU-UL too. Do it.
Change-Id: Ifcfc28ad7d77e561d456be546689995abfd8a6f5
---
M TODO-RELEASE
M src/trau/trau_rtp_conv.c
2 files changed, 39 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/47/32347/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32347
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ifcfc28ad7d77e561d456be546689995abfd8a6f5
Gerrit-Change-Number: 32347
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32184 )
Change subject: codec: add SID preening functions for FR & EFR
......................................................................
Patch Set 5:
(3 comments)
File src/codec/gsm610.c:
https://gerrit.osmocom.org/c/libosmocore/+/32184/comment/66608f22_2ddface9
PS3, Line 428: /* should never be reached */
: return false;
> I agree with OSMO_ASSERT() approach, and I shall implement it in the next iteration.
Done
File src/codec/gsm610.c:
https://gerrit.osmocom.org/c/libosmocore/+/32184/comment/e6cb48b9_72cea721
PS4, Line 432: return false;
> Looking closer, I see that you are right - the macro definition of OSMO_ASSERT() and the declaration […]
Done
File src/codec/gsm660.c:
https://gerrit.osmocom.org/c/libosmocore/+/32184/comment/2e1d955c_b968c31a
PS3, Line 391:
> likewise here.
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iec5c1f2619a82499f61cb3e5a7cd03ff0f020ad8
Gerrit-Change-Number: 32184
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Apr 2023 14:32:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32356 )
Change subject: Cosmetic: mgcp_client: fix typo
......................................................................
Cosmetic: mgcp_client: fix typo
Change-Id: I8e44b4bb853ebac881cb51b9546505874cf8fa45
---
M src/libosmo-mgcp-client/mgcp_client.c
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/56/32356/1
diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c
index 3df9ccf..3208192 100644
--- a/src/libosmo-mgcp-client/mgcp_client.c
+++ b/src/libosmo-mgcp-client/mgcp_client.c
@@ -1373,7 +1373,7 @@
MSGB_PRINTF_OR_RET("I: %s\r\n", mgcp_msg->conn_id);
}
- /* Using SDP makes sense when a valid IP/Port combination is specifiec,
+ /* Using SDP makes sense when a valid IP/Port combination is specified,
* if we do not know this information yet, we fall back to LCO */
if (mgcp_msg->presence & MGCP_MSG_PRESENCE_AUDIO_IP
&& mgcp_msg->presence & MGCP_MSG_PRESENCE_AUDIO_PORT)
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32356
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I8e44b4bb853ebac881cb51b9546505874cf8fa45
Gerrit-Change-Number: 32356
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32341 )
Change subject: ms: Drop setting (egprs_)ms_class during bts_alloc_ms()
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/tbf_dl.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/32341/comment/e637a2a2_8658bcb2
PS2, Line 220: ms = bts_alloc_ms(bts);
> Not really, because it is set below in lines 224-229. […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32341
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I36f07dc389f7abe205fc4bcddbde93735f5d5cfc
Gerrit-Change-Number: 32341
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Apr 2023 12:49:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment