April 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-pcu[master]: ms: Make ms_{attach,detach}_tbf expectancies more robust

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32358 to look at the new patch set (#3). Change subject: ms: Make ms_{attach,detach}_tbf expectancies more robust ...................................................................... ms: Make ms_{attach,detach}_tbf expectancies more robust * Make sure that the tbf being attached has already the MS assigned. * Check no re-attaching of alredy attached TBF ever happens. * Document and early skip case where a non-attached TBF detach is attempted. * Avoid recursive call mess to tbf_set_ms(tbf, NULL); during detach. * MsTest needs to be modified since it uses fake TBF objects which use different set of calls than the regular TBFs in osmo-pcu. Since the ul_tbf object is reused, it needs to be assigned ul_tbf->ms again before re-assigning it, as per what happens usually in tbf_set_ms() in osmo-pcu. Change-Id: Ia18fe2de1fb3bf72f530157e5f30de64f2b11e12 --- M src/gprs_ms.c M tests/ms/MsTest.cpp M tests/ms/MsTest.err 3 files changed, 60 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/58/32358/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia18fe2de1fb3bf72f530157e5f30de64f2b11e12 Gerrit-Change-Number: 32358 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: ms: Log detaching tbf log line in proper place

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32359 to look at the new patch set (#3). Change subject: ms: Log detaching tbf log line in proper place ...................................................................... ms: Log detaching tbf log line in proper place It is interesting to log that a tbf is being detached *before* it actually happens, so that the reader can see which TBF is being detached. Change-Id: I2008beb9ab8f97f7ea5ed7b45cfb3f23dfe7b27f --- M src/gprs_ms.c M tests/app_info/AppInfoTest.err M tests/ms/MsTest.err M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.err 5 files changed, 145 insertions(+), 132 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/59/32359/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2008beb9ab8f97f7ea5ed7b45cfb3f23dfe7b27f Gerrit-Change-Number: 32359 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf: Move m_ctrs alloc to constructor

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32377 to look at the new patch set (#6). Change subject: tbf: Move m_ctrs alloc to constructor ...................................................................... tbf: Move m_ctrs alloc to constructor Move rate_ctr allocation to the constructor since it its expected not to fail. This simplifies further tbf::setup() function. Change-Id: If64443c38624d159e68eec3a07d8e8caf369467b --- M src/tbf.cpp M src/tbf_ul.cpp 2 files changed, 16 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/32377/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If64443c38624d159e68eec3a07d8e8caf369467b Gerrit-Change-Number: 32377 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf: Store initial timestamp during constructor

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32376 to look at the new patch set (#6). Change subject: tbf: Store initial timestamp during constructor ...................................................................... tbf: Store initial timestamp during constructor Like already done for other timestamps. This helps in simplifying the setup() call. Change-Id: Ia0c2d0f5456b211169fb6c71f5f3c2e2b8760a28 --- M src/tbf.cpp 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/32376/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia0c2d0f5456b211169fb6c71f5f3c2e2b8760a28 Gerrit-Change-Number: 32376 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf: Move enable_egprs() to constructor

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32379 to look at the new patch set (#6). Change subject: tbf: Move enable_egprs() to constructor ...................................................................... tbf: Move enable_egprs() to constructor Whether the TBF is GPRS or EGPRS is known at allocation time since it comes from the information known in the MS object used to create it. Hence, no need to delay calling it to later steps such as setup(). So far it was probably elft in setup() due to the constrains about requiring the subclass to be constructed (use of window() virtual API). Change-Id: I2e9d2a98c666a930333d52fb6c0463d7593c2615 --- M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_ul.cpp M tests/tbf/TbfTest.err 5 files changed, 36 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/79/32379/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2e9d2a98c666a930333d52fb6c0463d7593c2615 Gerrit-Change-Number: 32379 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: ms: Rewrite MS release lifecycle

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360 to look at the new patch set (#5). Change subject: ms: Rewrite MS release lifecycle ...................................................................... ms: Rewrite MS release lifecycle This commit changes lots of stuff in the MS release lifecycle, but there's no really good way to split this into patches which make sense, since all the chaos is intensively entangled. Get rid of the ms_callback complex mess, it is not needed at all. Previous MS release was strange due to the existance of previous ms_callback.idle concept and MS storage: the MS signalled when it went idle (no TBFs attached) and waited for somebody outside to free it, while then arming itself the release timer to release itself if it was not released by whoever. The new lifecycle follows an easier (expected) approach: Whenever all TBFs become detached from the MS and it becomes idle (use_count becomes 0), then it frees its reserved resources (TFI, etc.) and either: * frees itself immediatelly under certain conditions (release timeout configured = 0 or MS garbage with TLLI=GSM_RESERVED_TMSI) * Arms release_timer and frees itself when it triggers. If during release_timer the MS is required again (for instance because a new TBF with TLLI/IMSI of the MS is observed), then a TBF is attached to the MS and it is considered to become active again, hence the release_timer is stopped. OS#6002 Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839 --- M src/bts.cpp M src/gprs_ms.c M src/gprs_ms.h M tests/alloc/AllocTest.err M tests/alloc/AllocTest.ok M tests/app_info/AppInfoTest.err M tests/ms/MsTest.cpp M tests/ms/MsTest.err M tests/ms/MsTest.ok M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.err 11 files changed, 388 insertions(+), 551 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/32360/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839 Gerrit-Change-Number: 32360 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul: Move rate_ctr allocation to constructor

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32378 to look at the new patch set (#6). Change subject: tbf_ul: Move rate_ctr allocation to constructor ...................................................................... tbf_ul: Move rate_ctr allocation to constructor Change-Id: I818eb05fe062e0610e86cb34273bde99b379aa3f --- M src/tbf_ul.cpp 1 file changed, 14 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/32378/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I818eb05fe062e0610e86cb34273bde99b379aa3f Gerrit-Change-Number: 32378 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: cosmetic: Fix indentation in comment

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32380 to look at the new patch set (#5). Change subject: cosmetic: Fix indentation in comment ...................................................................... cosmetic: Fix indentation in comment Change-Id: I15063346e4ff0367c0bf04f6b48ac62b9bdf2929 --- M src/gprs_ms.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/32380/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32380 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I15063346e4ff0367c0bf04f6b48ac62b9bdf2929 Gerrit-Change-Number: 32380 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: ms: Hold a reference during ms_alloc

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32375 to look at the new patch set (#7). Change subject: ms: Hold a reference during ms_alloc ...................................................................... ms: Hold a reference during ms_alloc Make the caller hold a reference to the MS object just allocated, so that it hs to explicitly unref it and, in turn, if no new references were added during its use, trigger release of the MS object. This is useful to avoid leaking MS object if it was allocated and then no TBF is attached to it because allocation of TBF failed. Related: OS#6002 Change-Id: I2088a7ddd76fe9157b6626ef96ae4315e88779ea --- M src/bts.cpp M src/gprs_ms.c M src/gprs_ms.h M src/pdch.cpp M src/tbf_dl.cpp M tests/alloc/AllocTest.cpp M tests/app_info/AppInfoTest.cpp M tests/llc/LlcTest.cpp M tests/ms/MsTest.cpp M tests/ms/MsTest.err M tests/tbf/TbfTest.cpp M tests/tbf/TbfTest.err M tests/types/TypesTest.cpp M tests/ulc/PdchUlcTest.cpp 14 files changed, 274 insertions(+), 114 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/32375/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2088a7ddd76fe9157b6626ef96ae4315e88779ea Gerrit-Change-Number: 32375 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: Add new log category 'ms'

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32383 to look at the new patch set (#6). Change subject: Add new log category 'ms' ...................................................................... Add new log category 'ms' This is useful to track the lifecycle of MS objects. The RLCMAC cateogry used so far in those log messages is too broad. Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd --- M src/gprs_debug.c M src/gprs_debug.h M src/gprs_ms.c M tests/app_info/AppInfoTest.cpp M tests/ms/MsTest.cpp M tests/tbf/TbfTest.cpp M tests/ulc/PdchUlcTest.cpp 7 files changed, 50 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/32383/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd Gerrit-Change-Number: 32383 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023