April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: ms: Increase log level when scheduling release timer

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32384 to look at the new patch set (#4). Change subject: ms: Increase log level when scheduling release timer ...................................................................... ms: Increase log level when scheduling release timer Change-Id: Ie470b5b0c7b01d91f4ad693e52afd51860d6da2d --- M src/gprs_ms.c M tests/ms/MsTest.err 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/84/32384/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie470b5b0c7b01d91f4ad693e52afd51860d6da2d Gerrit-Change-Number: 32384 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: dl_tbf: Set BandWidth timestamps to current time directly

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32382 to look at the new patch set (#5). Change subject: dl_tbf: Set BandWidth timestamps to current time directly ...................................................................... dl_tbf: Set BandWidth timestamps to current time directly Change-Id: I01654534aef5255c6d1c3ba0c553190a0319e8e1 --- M src/tbf_dl.cpp 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/32382/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I01654534aef5255c6d1c3ba0c553190a0319e8e1 Gerrit-Change-Number: 32382 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: meas: Improve logging formatting

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32389 to look at the new patch set (#3). Change subject: meas: Improve logging formatting ...................................................................... meas: Improve logging formatting Change-Id: I15d66da3f41a9f14a542b96436d65a0581bbb45a --- M src/gprs_rlcmac_meas.cpp 1 file changed, 15 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/89/32389/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I15d66da3f41a9f14a542b96436d65a0581bbb45a Gerrit-Change-Number: 32389 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: ms: Get rid of ms->delay field

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32390 to look at the new patch set (#2). Change subject: ms: Get rid of ms->delay field ...................................................................... ms: Get rid of ms->delay field Simply apply the content of the configured timer when the MS goes idle. Having that field is convenient to do tricky stuff in unit tests, but makes the main osmo-pcu app more complex for no good enough reason. Change-Id: I8d44318b37b6605afd84db8ccec0d75e6db293b9 --- M src/bts.cpp M src/gprs_ms.c M src/gprs_ms.h M tests/alloc/AllocTest.cpp M tests/ms/MsTest.cpp M tests/tbf/TbfTest.cpp M tests/ulc/PdchUlcTest.cpp 7 files changed, 30 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/90/32390/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8d44318b37b6605afd84db8ccec0d75e6db293b9 Gerrit-Change-Number: 32390 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: ms: Log MS active/idle state in 'show ms' VTY commands

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32394 to look at the new patch set (#2). Change subject: ms: Log MS active/idle state in 'show ms' VTY commands ...................................................................... ms: Log MS active/idle state in 'show ms' VTY commands Change-Id: Ibcd34055c9ae390510c5c3ba26621fd96d2368fd --- M src/gprs_ms.c M src/gprs_ms.h M src/pcu_vty_functions.cpp 3 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/94/32394/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibcd34055c9ae390510c5c3ba26621fd96d2368fd Gerrit-Change-Number: 32394 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: ms: Rename field timer -> release_timer

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32391 to look at the new patch set (#2). Change subject: ms: Rename field timer -> release_timer ...................................................................... ms: Rename field timer -> release_timer Rename it so that it becomes clear what the timer is used for. Change-Id: Id4738ea196b232858e1ec9cdc439f9b81839058f --- M src/gprs_ms.c M src/gprs_ms.h M tests/ms/MsTest.cpp 3 files changed, 18 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/91/32391/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id4738ea196b232858e1ec9cdc439f9b81839058f Gerrit-Change-Number: 32391 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: vty: Several improvements to 'show ms' output format

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32396 to look at the new patch set (#2). Change subject: vty: Several improvements to 'show ms' output format ...................................................................... vty: Several improvements to 'show ms' output format * Use UL/DL acronyms to decrease output verbosity * Keep more stable MS properties at the top, move link quality changing entries to the bottom putting them together. Change-Id: If9f4c6ba1a4a6f9060222cc04254054ad03d7a96 --- M src/pcu_vty_functions.cpp 1 file changed, 29 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/96/32396/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If9f4c6ba1a4a6f9060222cc04254054ad03d7a96 Gerrit-Change-Number: 32396 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: alloc_algo: Pass a struct containing all req params

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32397 to look at the new patch set (#3). Change subject: alloc_algo: Pass a struct containing all req params ...................................................................... alloc_algo: Pass a struct containing all req params This is a first step towards isolating the allocation algorithm from applying changes on PCU state. In next steps the tbf pointer will be dropped and the allocation algorithm will only result a "result" struct which then the caller can apply to whatever TBF object it requires. Change-Id: Ie4d9ace526ad012d97738bc55bdb5cc1472c632d --- M src/alloc_algo.cpp M src/alloc_algo.h M src/gprs_pcu.h M src/pcu_vty_functions.cpp M src/tbf.cpp M src/tbf_dl.cpp M tests/emu/pcu_emu.cpp M tests/ulc/PdchUlcTest.cpp 8 files changed, 165 insertions(+), 132 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/97/32397/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie4d9ace526ad012d97738bc55bdb5cc1472c632d Gerrit-Change-Number: 32397 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: WIP: Apply alloc_algo results in the caller

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 ) Change subject: WIP: Apply alloc_algo results in the caller ...................................................................... WIP: Apply alloc_algo results in the caller TODO: cleanup helper functions, move to better place?: * attach_tbf_to_pdch * assign_ul_tbf_slots * assign_dl_tbf_slots TODO: Have a second look at gprs_rlcmac_tbf::alloc_algorithm() to see if it can be simplified or made more robust. Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20 --- M src/alloc_algo.cpp M src/alloc_algo.h M src/gprs_pcu.h M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.cpp 8 files changed, 400 insertions(+), 374 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/99/32399/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20 Gerrit-Change-Number: 32399 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: alloc_algo: Move printing outside of update_ms_reserved_slots()

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/32398 ) Change subject: alloc_algo: Move printing outside of update_ms_reserved_slots() ...................................................................... alloc_algo: Move printing outside of update_ms_reserved_slots() Change-Id: I0d8838829c519bb6da8a68d62947b98bab35a39f --- M src/alloc_algo.cpp M tests/tbf/TbfTest.err 2 files changed, 22 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/98/32398/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0d8838829c519bb6da8a68d62947b98bab35a39f Gerrit-Change-Number: 32398 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023