Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 )
Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case
......................................................................
Patch Set 2:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32128/comment/bd1f4032_f0bf924a
PS1, Line 1661: send_ul_rtp_packet(lchan, fn, bfi, 0);
> well if len = 0, then it makes no sense to access to buffer, so it shouldn't expect it to be non-nul […]
I just double-checked to be absolutely sure: when OsMux is used, the call boils down to osmo_rtp_build() in libosmo-netif, and in the non-OsMux case it boils down to rtp_session_create_packet() in the external-dependency ortp library. Both functions are explicitly OK with zero-length RTP payloads (length argument to the function equals 0), and in both functions the memcpy() call for payload bytes is explicitly skipped in the zero-length case, thus the data pointer argument is never used. So we all good.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
Gerrit-Change-Number: 32128
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 19:43:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/32129 )
Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-pcu
......................................................................
tests: $(BUILT_SOURCES) is not defined, depend on osmo-pcu
Change-Id: I6620a524b393a0db6201930a1e2795a439785824
---
M tests/Makefile.am
1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/29/32129/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32129
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6620a524b393a0db6201930a1e2795a439785824
Gerrit-Change-Number: 32129
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32121 )
Change subject: tests: $(BUILT_SOURCES) is not defined
......................................................................
Patch Set 1:
(1 comment)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/osmo-pcap/+/32121/comment/14083d0e_aa0a562a
PS1, Line 24: python-tests:
> you are missing the binary path here?
It's actually a good question what binary.
There are both -client and -server, perhaps both?
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32121
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf
Gerrit-Change-Number: 32121
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 19:03:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32117 )
Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bts-virtual
......................................................................
Patch Set 1:
(1 comment)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/osmo-bts/+/32117/comment/526fbd30_03156739
PS1, Line 35: python-tests:
> $(top_builddir)/src/osmo-bts-virtual/osmo-bts-virtual
I am intentionally not adding dependencies if they're not used directly.
This dependency is added to the `vty-test` target, where it's used explicityly.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32117
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4ace06e115a2689bde9afd9f99ecee99d796360b
Gerrit-Change-Number: 32117
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 19:02:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 )
Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
Gerrit-Change-Number: 32128
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Wed, 29 Mar 2023 18:36:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 )
Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case
......................................................................
Patch Set 2:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32128/comment/43b3024e_795e31e3
PS1, Line 1661: send_ul_rtp_packet(lchan, fn, bfi, 0);
> I did not realize that passing a NULL pointer was allowed, for some reason I thought it had to be a […]
well if len = 0, then it makes no sense to access to buffer, so it shouldn't expect it to be non-null in that case.
The question is more whether it's fine to have len=0 on that path, but I think it ws the case before right?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
Gerrit-Change-Number: 32128
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Wed, 29 Mar 2023 18:36:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/32128
to look at the new patch set (#2).
Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case
......................................................................
rtp continuous-streaming: fix BFI in the quality-suppressed case
The check for (tch_ind->lqual_cb >= bts->min_qual_norm) in
l1sap_tch_ind() has the intent of suppressing valid-seeming
speech frame output from lower layers when the link quality is
too low; this check is particularly important for FR1 codec
where the intrinsic validity check is only a 3-bit CRC which has
1/8 probability of indicating "correct" when decoding radio noise
during DTXu silence.
However, this check is effectively defeated in the current
implementation of rtp continuous-streaming, at least when
themyscira-bfi extension is not used or when it doesn't apply
because the codec is not FR or EFR: the RTP packet being output
is the presumed-bogus speech frame from lower layers, rather than
the intended zero-length payload. Fix this bug.
Related: OS#5975
Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
---
M src/common/l1sap.c
1 file changed, 27 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/28/32128/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
Gerrit-Change-Number: 32128
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 )
Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case
......................................................................
Patch Set 1:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32128/comment/21db46c9_17b5bd58
PS1, Line 1661: send_ul_rtp_packet(lchan, fn, bfi, 0);
> bfi is actually not used here (len=0), so better pass NULL to make it clear.
I did not realize that passing a NULL pointer was allowed, for some reason I thought it had to be a pointer to some "real" memory location, like what happens with msg->data when msg->len equals 0. But if you say that NULL is acceptable, then of course it is philosophically more correct - I'll spin a revised patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
Gerrit-Change-Number: 32128
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 18:19:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 )
Change subject: common+trx: add rtp ecu-downstream vty option
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> So AFAIU you are saying that your ECU is located somewhere in the CN after osmo-msc, as in some sort of PBX/sip-connector.
Correct.
> So, you are actually tweaking the *uplink* RTP path of that BTS here, not the *downlink*. So not sure the "downstream" concept really fits here.
I think I see the source of confusion: the two words "downlink" and "downstream" both begin with the prefix "down", but they are two different English words, and in the present case have completely unrelated meanings. Think of upstream and downstream as in software developers, maintainers and distributors: the original developer's git repository is the ultimate upstream, tarball releases are downstream from that original repo, distro packages are further downstream, and so on. In the present case, I meant "downstream" as in "down the flow of this BTS-originated RTP stream", with the stream flowing through forwarders (OsmoMGW) and translators (themwi-mgw).
> Maybe "rtp uplink-external-eecu" or alike?
I am agnostic on most naming questions, including this one. Harald, you already gave us the name for "rtp continuous-streaming" - maybe you could name this one for us too?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e
Gerrit-Change-Number: 32110
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 18:06:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 )
Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case
......................................................................
Patch Set 1:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32128/comment/a2c3b65a_bc44115a
PS1, Line 1661: send_ul_rtp_packet(lchan, fn, bfi, 0);
bfi is actually not used here (len=0), so better pass NULL to make it clear.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
Gerrit-Change-Number: 32128
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Wed, 29 Mar 2023 18:00:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 )
Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case
......................................................................
rtp continuous-streaming: fix BFI in the quality-suppressed case
The check for (tch_ind->lqual_cb >= bts->min_qual_norm) in
l1sap_tch_ind() has the intent of suppressing valid-seeming
speech frame output from lower layers when the link quality is
too low; this check is particularly important for FR1 codec
where the intrinsic validity check is only a 3-bit CRC which has
1/8 probability of indicating "correct" when decoding radio noise
during DTXu silence.
However, this check is effectively defeated in the current
implementation of rtp continuous-streaming, at least when
themyscira-bfi extension is not used or when it doesn't apply
because the codec is not FR or EFR: the RTP packet being output
is the presumed-bogus speech frame from lower layers, rather than
the intended zero-length payload. Fix this bug.
Related: OS#5975
Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
---
M src/common/l1sap.c
1 file changed, 27 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/28/32128/1
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index bb19524..0664816 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1645,7 +1645,7 @@
return 1;
}
} else {
- /* Are we in rtp continuous-stream special mode? If so, send
+ /* Are we in rtp continuous-streaming special mode? If so, send
* out a BFI packet as zero-length RTP payload, or in Themyscira
* BFI format if that option is also enabled and the codec is
* FR or EFR. */
@@ -1658,7 +1658,7 @@
bfi[1] = (fn % 104 == 52); /* TAF */
send_ul_rtp_packet(lchan, fn, bfi, 2);
} else
- send_ul_rtp_packet(lchan, fn, msg->data, msg->len);
+ send_ul_rtp_packet(lchan, fn, bfi, 0);
} else {
DEBUGPGT(DRTP, &g_time, "Skipping RTP frame with lost payload (chan_nr=0x%02x)\n",
chan_nr);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
Gerrit-Change-Number: 32128
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-MessageType: newchange
Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 )
Change subject: common+trx: add rtp ecu-downstream vty option
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> No, "downstream" here means down the RTP stream from the BTS: after the RTP stream is emitted from t […]
Ok as I expected I am still confused with the naming then.
So AFAIU you are saying that your ECU is located somewhere in the CN after osmo-msc, as in some sort of PBX/sip-connector.
So, you are actually tweaking the *uplink* RTP path of that BTS here, not the *downlink*. So not sure the "downstream" concept really fits here.
Maybe "rtp uplink-external-eecu" or alike?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e
Gerrit-Change-Number: 32110
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Wed, 29 Mar 2023 17:37:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/32123
to look at the new patch set (#2).
Change subject: rlcmac: Release UL_TBF L1CTL resources upon free
......................................................................
rlcmac: Release UL_TBF L1CTL resources upon free
Change-Id: I4c98d5431a8409a6d428e96f9bfbb442bd75b24f
---
M src/rlcmac/tbf_ul_fsm.c
M tests/rlcmac/rlcmac_prim_test.err
M tests/rlcmac/rlcmac_prim_test.ok
3 files changed, 71 insertions(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/23/32123/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32123
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I4c98d5431a8409a6d428e96f9bfbb442bd75b24f
Gerrit-Change-Number: 32123
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32123 )
Change subject: rlcmac: Release UL_TBF L1CTL resources upon free
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
@fixeria, after this we still need to somehow signal to L1CTL that this MS should return to idle mode camping in BCCH.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32123
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I4c98d5431a8409a6d428e96f9bfbb442bd75b24f
Gerrit-Change-Number: 32123
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 15:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32105 )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: lc15: fix compiler warning about unused variable cell_size
......................................................................
lc15: fix compiler warning about unused variable cell_size
oml.c: In function ‘bts_model_apply_oml’:
oml.c:1814:17: error: variable ‘cell_size’ set but not used [-Werror=unused-but-set-variable]
1814 | uint8_t cell_size;
| ^~~~~~~~~
Change-Id: I0bf1542f613f613d03609d50836137ff440401af
---
M src/osmo-bts-lc15/oml.c
1 file changed, 18 insertions(+), 3 deletions(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bts-lc15/oml.c b/src/osmo-bts-lc15/oml.c
index 4847c17..3709d8c 100644
--- a/src/osmo-bts-lc15/oml.c
+++ b/src/osmo-bts-lc15/oml.c
@@ -1844,7 +1844,6 @@
int rc;
struct gsm_bts_trx *trx;
struct lc15l1_hdl *fl1h;
- uint8_t cell_size;
/* TODO: NM Object without FSM: */
switch (foh->obj_class) {
@@ -1858,10 +1857,11 @@
case NM_MT_SET_RADIO_ATTR:
trx = obj;
fl1h = trx_lc15l1_hdl(trx);
- /* convert max TA to max cell size in qbits */
- cell_size = bts->max_ta << 2;
#if LITECELL15_API_VERSION >= LITECELL15_API(2,1,7)
+ {
+ /* convert max TA to max cell size in qbits */
+ uint8_t cell_size = bts->max_ta << 2;
/* We do not need to check for L1 handle
* because the max cell size parameter can receive before MphInit */
if (fl1h->phy_inst->u.lc15.max_cell_size != cell_size) {
@@ -1870,6 +1870,7 @@
/* update current max cell size */
fl1h->phy_inst->u.lc15.max_cell_size = cell_size;
}
+ }
#endif
/* Did we go through MphInit yet? If yes fire and forget */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0bf1542f613f613d03609d50836137ff440401af
Gerrit-Change-Number: 32105
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32121 )
Change subject: tests: $(BUILT_SOURCES) is not defined
......................................................................
Patch Set 1:
(1 comment)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/osmo-pcap/+/32121/comment/b7d267f3_30d53457
PS1, Line 24: python-tests:
you are missing the binary path here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32121
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf
Gerrit-Change-Number: 32121
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 13:50:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32119 )
Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-mgw
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I951ce2410614993a855336e6bb408cae1823ef9a
Gerrit-Change-Number: 32119
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 12:45:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32117 )
Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bts-virtual
......................................................................
Patch Set 1:
(1 comment)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/osmo-bts/+/32117/comment/cb843508_295fd2b4
PS1, Line 35: python-tests:
$(top_builddir)/src/osmo-bts-virtual/osmo-bts-virtual
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32117
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4ace06e115a2689bde9afd9f99ecee99d796360b
Gerrit-Change-Number: 32117
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 12:44:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32116 )
Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bsc
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32116
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I640dd2cd599707ad6bc661e7bea08372d85b47df
Gerrit-Change-Number: 32116
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 12:44:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32117 )
Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bts-virtual
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32117
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4ace06e115a2689bde9afd9f99ecee99d796360b
Gerrit-Change-Number: 32117
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 12:43:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32115 )
Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-stp
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32115
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I4864f4d78095187f566bcde772b71665fa6e4729
Gerrit-Change-Number: 32115
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 12:41:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32116
to look at the new patch set (#2).
Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bsc
......................................................................
tests: $(BUILT_SOURCES) is not defined, depend on osmo-bsc
Change-Id: I640dd2cd599707ad6bc661e7bea08372d85b47df
---
M tests/Makefile.am
1 file changed, 12 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/16/32116/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32116
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I640dd2cd599707ad6bc661e7bea08372d85b47df
Gerrit-Change-Number: 32116
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 )
Change subject: common+trx: add rtp ecu-downstream vty option
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm not sure what you mean with "downstream" here. […]
No, "downstream" here means down the RTP stream from the BTS: after the RTP stream is emitted from the BTS and passes through two OsmoMGW instances (BSC, then MSC), it goes to an external software component (themwi-mgw in my case) that applies the full Rx DTX handler of GSM 06.31 or 06.81. That full Rx DTX handler includes an ECU function that is more sophisticated than the one in libosmocore, and intertied with other (not strictly ECU) Rx DTX functions - this type of use scenario is when having OsmoBTS apply the libosmocodec ECU becomes undesirable.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e
Gerrit-Change-Number: 32110
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Mar 2023 12:18:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment