March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: Clarify configuration of TSC on each timeslot
by pespin 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32165 ) Change subject: Clarify configuration of TSC on each timeslot ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: Tested this patch on top of current osmo-bts master in 201705-nightly, with BSIC=0x0a and pSetChanAttr with TSC=0x02, it works fine as expected. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ief21daf63ba76725de9117cbe14ada8b75f147df Gerrit-Change-Number: 32165 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Fri, 31 Mar 2023 14:46:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gm_12_21.h: Add cross-component parameter defaults (NSE timing)
by arehbein 31 Mar '23

31 Mar '23

Attention is currently required from: osmith, laforge. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31877 ) Change subject: gm_12_21.h: Add cross-component parameter defaults (NSE timing) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > what's the status here? no updates since March 14 on something presumably simple which prevents all […] The issue has been stuck, because I was waiting for some more input on PCU IF changes. I had sent a mail to dexter concerning the PCU IF change I wanted to make; I didn't get a direct reply (which led me to work on other issues). There was some discussion here https://gerrit.osmocom.org/c/osmo-bts/+/31885 about what could be done, but it didn't seem very conclusive to me concerning next steps with my patch. Seems like dexter is still working on the version bump to v11 of PCU IF (I suppose here https://gerrit.osmocom.org/c/osmo-bts/+/31600 ), I've just written a comment asking for clarification on further steps here https://gerrit.osmocom.org/c/osmo-bts/+/31885/comments/0c79b1ee_06b6b60e and will contact dexter regarding this. Thank you for the heads up, I'll think more of following up on issues that need input. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I51d1fd8b596523ae2ac8fb6a186ce7a702334c27 Gerrit-Change-Number: 31877 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 31 Mar 2023 14:46:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: MGCP_Test: move template RtpFlowData up
by dexter 31 Mar '23

31 Mar '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32178 ) Change subject: MGCP_Test: move template RtpFlowData up ...................................................................... MGCP_Test: move template RtpFlowData up The template RtpFlowData is defined in the middle of the code, lets move it up below the related record definition Change-Id: If854f708e4da8b3a7b02d1ace2eb7caa3e2f2bfb --- M mgw/MGCP_Test.ttcn 1 file changed, 35 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/32178/1 diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 2755199..73d7be2 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -355,6 +355,29 @@ RtpOsmuxFlowData osmux } + template RtpFlowData t_RtpFlow(charstring host_a, charstring host_b, uint7_t pt, + charstring codec, template charstring fmtp := omit) := { + em := { + hostname := host_a, + portnr := omit + }, + mgw := { + hostname := host_b, + portnr := omit + }, + codec_descr := {{ + pt := pt, + codec := codec, + fmtp := fmtp + }}, + osmux:= { + local_cid_sent := false, + local_cid := omit, + remote_cid := omit, + cfg := omit + } + } + /* To be used with f_flow_create/modify... functions */ function f_gen_sdp(RtpFlowData flow) runs on dummy_CT return SDP_Message { var template SDP_Message sdp; @@ -1795,29 +1818,6 @@ setverdict(pass); } - template RtpFlowData t_RtpFlow(charstring host_a, charstring host_b, uint7_t pt, - charstring codec, template charstring fmtp := omit) := { - em := { - hostname := host_a, - portnr := omit - }, - mgw := { - hostname := host_b, - portnr := omit - }, - codec_descr := {{ - pt := pt, - codec := codec, - fmtp := fmtp - }}, - osmux:= { - local_cid_sent := false, - local_cid := omit, - remote_cid := omit, - cfg := omit - } - } - /* transmit RTP streams between two RTP Emulations back-to-back; expect no loss */ testcase TC_rtpem_selftest() runs on dummy_CT { var RtpemStats stats[2]; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If854f708e4da8b3a7b02d1ace2eb7caa3e2f2bfb Gerrit-Change-Number: 32178 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Test: add fmtp to template t_RtpFlow
by dexter 31 Mar '23

31 Mar '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32177 ) Change subject: MGCP_Test: add fmtp to template t_RtpFlow ...................................................................... MGCP_Test: add fmtp to template t_RtpFlow When creating a flow with fmtp parameters we must always add them in a second step. Lets update t_RtpFlow, so that it supports fmtp as an optional parameter. Change-Id: I04b17c0d233c1db4b9ba1306a4e0555914519bf8 --- M mgw/MGCP_Test.ttcn 1 file changed, 22 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/32177/1 diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 512278c..2755199 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1397,13 +1397,12 @@ }; /* from us to MGW */ - flow[0] := valueof(t_RtpFlow(local_ip_rtp, remote_ip_rtp, 112, "AMR/8000")); + flow[0] := valueof(t_RtpFlow(local_ip_rtp, remote_ip_rtp, 112, "AMR/8000", fmtp)); flow[0].rtp_cfg := c_RtpemDefaultCfg flow[0].rtp_cfg.rx_payloads[0].payload_type := flow[0].codec_descr[0].pt; flow[0].rtp_cfg.rx_payloads[0].fixed_payload := amr_payload; flow[0].rtp_cfg.tx_payloads[0].payload_type := flow[0].codec_descr[0].pt; flow[0].rtp_cfg.tx_payloads[0].fixed_payload := amr_payload; - flow[0].codec_descr[0].fmtp := fmtp; /* bind local RTP emulation sockets */ flow[0].em.portnr := 10000; f_flow_create(RTPEM[0], ep, call_id, "sendrecv", flow[0]); @@ -1796,8 +1795,8 @@ setverdict(pass); } - template (value) RtpFlowData t_RtpFlow(charstring host_a, charstring host_b, uint7_t pt, - charstring codec) := { + template RtpFlowData t_RtpFlow(charstring host_a, charstring host_b, uint7_t pt, + charstring codec, template charstring fmtp := omit) := { em := { hostname := host_a, portnr := omit @@ -1808,7 +1807,8 @@ }, codec_descr := {{ pt := pt, - codec := codec + codec := codec, + fmtp := fmtp }}, osmux:= { local_cid_sent := false, @@ -2283,7 +2283,7 @@ f_vty_transceive(MGWVTY, "rtp-patch rfc5993hr"); /* Connection #0 (Bidirectional) */ - flow[0] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 111, "GSM-HR-08/8000")); + flow[0] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 111, "GSM-HR-08/8000", fmtp0)); /* bind local RTP emulation sockets */ flow[0].em.portnr := 10000; flow[0].rtp_cfg := c_RtpemDefaultCfg; @@ -2291,18 +2291,16 @@ flow[0].rtp_cfg.tx_payloads[0].payload_type := flow[0].codec_descr[0].pt; flow[0].rtp_cfg.rx_payloads[0].fixed_payload := pl0; flow[0].rtp_cfg.tx_payloads[0].fixed_payload := pl0; - flow[0].codec_descr[0].fmtp := fmtp0; f_flow_create(RTPEM[0], ep, call_id, "sendrecv", flow[0]); /* Connection #1 (Bidirectional) */ - flow[1] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 111, "GSM-HR-08/8000")); + flow[1] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 111, "GSM-HR-08/8000", fmtp1)); flow[1].em.portnr := 20000; flow[1].rtp_cfg := c_RtpemDefaultCfg; flow[1].rtp_cfg.rx_payloads[0].payload_type := flow[1].codec_descr[0].pt; flow[1].rtp_cfg.tx_payloads[0].payload_type := flow[1].codec_descr[0].pt; flow[1].rtp_cfg.rx_payloads[0].fixed_payload := pl1; flow[1].rtp_cfg.tx_payloads[0].fixed_payload := pl1; - flow[1].codec_descr[0].fmtp := fmtp1; f_flow_create(RTPEM[1], ep, call_id, "sendrecv", flow[1]); /* Send RTP packets to connection #0, receive on connection #1 */ @@ -2363,7 +2361,7 @@ f_init(ep); /* Connection #0 (Bidirectional) */ - flow[0] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 96, "AMR/8000")); + flow[0] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 96, "AMR/8000", fmtp0)); /* bind local RTP emulation sockets */ flow[0].em.portnr := 10000; flow[0].rtp_cfg := c_RtpemDefaultCfg; @@ -2371,18 +2369,16 @@ flow[0].rtp_cfg.tx_payloads[0].payload_type := flow[0].codec_descr[0].pt; flow[0].rtp_cfg.rx_payloads[0].fixed_payload := pl0; flow[0].rtp_cfg.tx_payloads[0].fixed_payload := pl0; - flow[0].codec_descr[0].fmtp := fmtp0; f_flow_create(RTPEM[0], ep, call_id, "sendrecv", flow[0]); /* Connection #1 (Bidirectional) */ - flow[1] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 112, "AMR/8000")); + flow[1] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 112, "AMR/8000", fmtp1)); flow[1].em.portnr := 20000; flow[1].rtp_cfg := c_RtpemDefaultCfg; flow[1].rtp_cfg.rx_payloads[0].payload_type := flow[1].codec_descr[0].pt; flow[1].rtp_cfg.tx_payloads[0].payload_type := flow[1].codec_descr[0].pt; flow[1].rtp_cfg.rx_payloads[0].fixed_payload := pl1; flow[1].rtp_cfg.tx_payloads[0].fixed_payload := pl1; - flow[1].codec_descr[0].fmtp := fmtp1; f_flow_create(RTPEM[1], ep, call_id, "sendrecv", flow[1]); /* Send RTP packets to connection #0, receive on connection #1 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04b17c0d233c1db4b9ba1306a4e0555914519bf8 Gerrit-Change-Number: 32177 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: Clarify configuration of TSC on each timeslot
by pespin 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria, pespin, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32165 ) Change subject: Clarify configuration of TSC on each timeslot ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ief21daf63ba76725de9117cbe14ada8b75f147df Gerrit-Change-Number: 32165 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Fri, 31 Mar 2023 14:41:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: gprs: fix has_valid_nsvc(): permit local udp port 0
by fixeria 31 Mar '23

31 Mar '23

Attention is currently required from: pespin, daniel, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32176 ) Change subject: gprs: fix has_valid_nsvc(): permit local udp port 0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > (Copy-pasting from previous Change-Id:) What previous Change-Id? It's a new patch. I am guessing you meant: https://gerrit.osmocom.org/c/osmo-bsc/+/32169. > The question here is more: does it make sense from network architecture point of view that PCU binds to a randomly available port for Gb? You have to use a different bind port anyway when running everything on the same host. I have 23023 in my config file, which does not clash with 23000 used by osmo-sgsn by default. I see random bind port selection as a useful option, removing the need to pick and configure it manually. > AFAIU it makes no sense, since it needs to bind to a specific port also known by the SGSN so that it knows where to send packets to. Or is the SGSN available to learn dynamically of the PCU by listening() on its port? AFAIU, osmo-sgsn "learns" the PCU's bind port during the initial NS handshake, yes. So it needs not to be known by the SGSN in advance. There is no config options in osmo-sgsn to specify the bind addresses of PCUs. I also confirmed in the leaked ip.access A-bis document that 0 is a valid special value, which tells the PCU to bind() at a random port number. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0afd83e77f3daeeb082e7db911610428b5bc587c Gerrit-Change-Number: 32176 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 31 Mar 2023 14:40:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: PCU IF: Update NSE timer field
by arehbein 31 Mar '23

31 Mar '23

Attention is currently required from: pespin, fixeria, dexter. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31885 ) Change subject: PCU IF: Update NSE timer field ...................................................................... Patch Set 1: (1 comment) File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/26da5482_d4f29348 PS1, Line 156: PCU_IF_NUM_NSE_TIMERS > Extending the timer at the end of the struct would change the message size and hence would break the […] So, how exactly do I go about updating the PCU IF now/ how does Osmocom go about these version bumps? It's also not clear to me right now what change is preferred... pespin's last comment > I wouldn't really care for now about that, I don't expect the size of this array to change lots of times. I'd leave it as/where it is, update the size now like you did. sounded like this patch would be alright (?) and I should just add a version bump for osmo-bts, osmo-bsc and osmo-pcu? Last but not least, since that was also mentioned: Should we add this PCU IF change to the version bump in https://gerrit.osmocom.org/c/osmo-bts/+/31600/1/include/osmo-bts/pcuif_prot… ? This concerns two other patches of mine as well: https://gerrit.osmocom.org/c/osmo-pcu/+/31886 and https://gerrit.osmocom.org/c/osmo-bsc/+/31880 (which I will probably have to change so as to separate out the PCU_IF change) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb Gerrit-Change-Number: 31885 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 14:33:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: tests: rename and extend gprs_{bvci_default->params}.vty
by pespin 31 Mar '23

31 Mar '23

Attention is currently required from: laforge, fixeria, daniel, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32169 ) Change subject: tests: rename and extend gprs_{bvci_default->params}.vty ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I am not following you. […] My bad, I was the one which I confused the patches and wrote the comment initially in here instead of the other one. I copy-pasted my comment to the one which I aimed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia02e9a97137eb7724f22526fc3768331b35ac55d Gerrit-Change-Number: 32169 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 31 Mar 2023 14:31:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: tests: add more tests for GPRS NSVC parameters
by pespin 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32171 ) Change subject: tests: add more tests for GPRS NSVC parameters ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Neither I do. But we have what we have. I am not changing the logic. […] Yeah, just sharing my view in case all this needs to be developed further. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I13d6ac887ddb1c9bc5d1e4122f20405a28f135d4 Gerrit-Change-Number: 32171 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 14:29:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: tests: rename and extend gprs_{bvci_default->params}.vty
by fixeria 31 Mar '23

31 Mar '23

Attention is currently required from: laforge, pespin, daniel, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32169 ) Change subject: tests: rename and extend gprs_{bvci_default->params}.vty ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Ok, this is a totally new commit after latest version submit, and the discussion doesn't apply anymo […] I am not following you. This is exactly the same commit with exactly the same change ID, I simply removed the statements about the local port being 0 is wrong and about sane defaults... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia02e9a97137eb7724f22526fc3768331b35ac55d Gerrit-Change-Number: 32169 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 31 Mar 2023 14:29:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0