March 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-gprs[master]: rlcmac: Release UL_TBF L1CTL resources upon free
by fixeria 31 Mar '23

31 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32123 ) Change subject: rlcmac: Release UL_TBF L1CTL resources upon free ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > @fixeria, after this we still need to somehow signal to L1CTL that this MS should return to idle mod […] I guess this can be done by the modem app itself based on some timer? i.e. if no TBF CFGs were requested during the last N seconds and there are no active ones, the modem app automatically switches back to BCCH. What do you think? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4c98d5431a8409a6d428e96f9bfbb442bd75b24f Gerrit-Change-Number: 32123 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 15:31:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: gprs: fix has_valid_nsvc(): permit local udp port 0
by pespin 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria, daniel, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32176 ) Change subject: gprs: fix has_valid_nsvc(): permit local udp port 0 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0afd83e77f3daeeb082e7db911610428b5bc587c Gerrit-Change-Number: 32176 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 31 Mar 2023 15:30:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-gprs[master]: rlcmac: Fix DL_ASS polls removed when UL TBF released
by pespin 31 Mar '23

31 Mar '23

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32118 ) Change subject: rlcmac: Fix DL_ASS polls removed when UL TBF released ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icdaa30e9ff942fb53cc4bbd801e4542b8885b32a Gerrit-Change-Number: 32118 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 15:30:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: gprs_rlcmac_tbf_free():Call proper free function for DL TBF
by fixeria 31 Mar '23

31 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32122 ) Change subject: rlcmac: gprs_rlcmac_tbf_free():Call proper free function for DL TBF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I65c37dd4ea20f039680e0927722b332d1140e62e Gerrit-Change-Number: 32122 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 15:27:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-gprs[master]: rlcmac: Fix DL_ASS polls removed when UL TBF released
by fixeria 31 Mar '23

31 Mar '23

Attention is currently required from: pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32118 ) Change subject: rlcmac: Fix DL_ASS polls removed when UL TBF released ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icdaa30e9ff942fb53cc4bbd801e4542b8885b32a Gerrit-Change-Number: 32118 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 15:26:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: gprs: fix has_valid_nsvc(): permit local udp port 0
by fixeria 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria, daniel, lynxis lazus. Hello Jenkins Builder, pespin, daniel, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32176 to look at the new patch set (#2). Change subject: gprs: fix has_valid_nsvc(): permit local udp port 0 ...................................................................... gprs: fix has_valid_nsvc(): permit local udp port 0 NSVC local port 0 is actually a valid value, which tells the PCU to pick a random port for bind()ing. It was supported before 315af2f9e, but now osmo-bsc would simply ignore NSVCs with 'local udp port 0' and leave the respective MOs unconfigured in the BTS. Change-Id: I0afd83e77f3daeeb082e7db911610428b5bc587c Fixes: 315af2f9e "bts: ipa/osmo-bts/sysmobts: MO: add support for the second NSVC" Related: OS#5979 --- M src/osmo-bsc/nm_gprs_nsvc_fsm.c 1 file changed, 23 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/32176/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0afd83e77f3daeeb082e7db911610428b5bc587c Gerrit-Change-Number: 32176 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[XL] Change in libosmo-gprs[master]: Introduce libosmo-gprs-sm
by fixeria 31 Mar '23

31 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32154 ) Change subject: Introduce libosmo-gprs-sm ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Patchset: PS3: LGTM! File include/osmocom/gprs/sm/sm_private.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/32154/comment/47f344ef_cf456745 PS3, Line 58: struct_endianness This script does weird things here, making the code hard to read :/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9b4a9a6364f7799540475e7e1d10ab2310768281 Gerrit-Change-Number: 32154 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 15:20:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-abis[master]: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case
by falconia 31 Mar '23

31 Mar '23

Attention is currently required from: neels, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/32078 to look at the new patch set (#2). Change subject: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case ...................................................................... osmo_rtp2trau() for FR & EFR: correctly handle the no-data case 3GPP TS 48.060 sections 6.5.2 and 6.5.3 prescribe the behavior of TRAU frame emitters under conditions of not having any speech or SID frame to send. In the case of osmo_rtp2trau() this no-data condition is indicated with a zero rtp_len argument to the function, but this case was not handled correctly: a garbage speech frame (previous buffer content for the D bits in struct osmo_trau_frame) was being generated. The present change implements the rules of TS 48.060 sections 6.5.2 and 6.5.3: standard FR/EFR speech frame with BFI=1 for DL, special idle speech frame pattern for UL. Change-Id: I7f21e2210bba9ef87f1af515a001a0cfc1c0a1d8 --- M src/trau/trau_rtp_conv.c 1 file changed, 60 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/78/32078/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7f21e2210bba9ef87f1af515a001a0cfc1c0a1d8 Gerrit-Change-Number: 32078 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Add missing tests in expected-results.xml
by pespin 31 Mar '23

31 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32175 ) Change subject: bts: Add missing tests in expected-results.xml ...................................................................... bts: Add missing tests in expected-results.xml Change-Id: Ie751804c0557846224f6159fb1a02eb3444f84a4 --- M bts/expected-results.xml 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bts/expected-results.xml b/bts/expected-results.xml index 4eb1fd3..f559132 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -92,6 +92,12 @@ <testcase classname='BTS_Tests' name='TC_pcu_ver_si1' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_ver_si3' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_ver_si13' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_data_req_pdtch' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_data_req_ptcch' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_data_req_wrong_bts' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_data_req_wrong_trx' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_data_req_wrong_ts' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_data_req_ts_inactive' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_ptcch' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_data_req_agch' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_data_req_pch' time='MASKED'/> @@ -172,6 +178,8 @@ <testcase classname='BTS_Tests' name='TC_speech_no_rtp_tchh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_speech_rtp_tchf' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_speech_rtp_tchh' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_speech_osmux_tchf' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_speech_osmux_tchh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_early_immediate_assignment' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_acch_overpower_rxqual_thresh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_acch_overpower_rxqual_thresh_dtx' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie751804c0557846224f6159fb1a02eb3444f84a4 Gerrit-Change-Number: 32175 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: PCU IF: Update NSE timer field
by pespin 31 Mar '23

31 Mar '23

Attention is currently required from: arehbein, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31885 ) Change subject: PCU IF: Update NSE timer field ...................................................................... Patch Set 1: (2 comments) File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/9d1a0729_95f7d9ae PS1, Line 156: PCU_IF_NUM_NSE_TIMERS > So, how exactly do I go about updating the PCU IF now/ how does Osmocom go about these version bumps […] First of all and before going onto next matters: Why did you change the array size 7->8 here? I see no detailed reason for that change explained in the commit message. Can you add some more reference to this "tsns-prov" you mention in the commit description? Is it being used in the PCU? I wanted to ping you on irc/jabber to ask directly now but I couldn't find you, feel free to ping me if you need assistance. File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/21213116_fadaf4f5 PS1, Line 274: imer memcpy(info_ind->nse_timer, bts->gprs.nse.timer, PCU_IF_NUM_NSE_TIMERS); PCU_IF_NUM_NSE_TIMERS is 8, but: include/osmo-bts/bts.h:230: uint8_t timer[7]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb Gerrit-Change-Number: 31885 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 15:14:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0