Attention is currently required from: neels, laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/32078
to look at the new patch set (#2).
Change subject: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case
......................................................................
osmo_rtp2trau() for FR & EFR: correctly handle the no-data case
3GPP TS 48.060 sections 6.5.2 and 6.5.3 prescribe the behavior of
TRAU frame emitters under conditions of not having any speech or SID
frame to send. In the case of osmo_rtp2trau() this no-data condition
is indicated with a zero rtp_len argument to the function, but this
case was not handled correctly: a garbage speech frame (previous
buffer content for the D bits in struct osmo_trau_frame) was being
generated. The present change implements the rules of TS 48.060
sections 6.5.2 and 6.5.3: standard FR/EFR speech frame with BFI=1
for DL, special idle speech frame pattern for UL.
Change-Id: I7f21e2210bba9ef87f1af515a001a0cfc1c0a1d8
---
M src/trau/trau_rtp_conv.c
1 file changed, 60 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/78/32078/2
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/32078
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7f21e2210bba9ef87f1af515a001a0cfc1c0a1d8
Gerrit-Change-Number: 32078
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset