Attention is currently required from: arehbein, fixeria, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31885
)
Change subject: PCU IF: Update NSE timer field
......................................................................
Patch Set 1:
(2 comments)
File include/osmo-bts/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/9d1a0729_95f7d9ae
PS1, Line 156: PCU_IF_NUM_NSE_TIMERS
So, how exactly do I go about updating the PCU IF now/
how does Osmocom go about these version bumps […]
First of all and before going onto
next matters:
Why did you change the array size 7->8 here? I see no detailed reason for that change
explained in the commit message. Can you add some more reference to this
"tsns-prov" you mention in the commit description? Is it being used in the PCU?
I wanted to ping you on irc/jabber to ask directly now but I couldn't find you, feel
free to ping me if you need assistance.
File src/common/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/21213116_fadaf4f5
PS1, Line 274: imer
memcpy(info_ind->nse_timer, bts->gprs.nse.timer, PCU_IF_NUM_NSE_TIMERS);
PCU_IF_NUM_NSE_TIMERS is 8, but:
include/osmo-bts/bts.h:230: uint8_t timer[7];
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31885
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb
Gerrit-Change-Number: 31885
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 31 Mar 2023 15:14:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment