Attention is currently required from: fixeria, daniel, lynxis lazus.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/32176
)
Change subject: gprs: fix has_valid_nsvc(): permit local udp port 0
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
yes sorry, I got confused.
You have to use a different bind port anyway when
running everything on the same host
Not really, you can use also another IP address.
I see random bind port selection as a useful option,
removing the need to pick and configure it manually.
ACK.
AFAIU, osmo-sgsn "learns" the PCU's bind
port during the initial NS handshake, yes. So it needs not to be known by the SGSN in
advance. There is no config options in osmo-sgsn to specify the bind addresses of PCUs.
Fine then!
PS1:
I'd welcome review from daniel and lynxis here.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32176
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0afd83e77f3daeeb082e7db911610428b5bc587c
Gerrit-Change-Number: 32176
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 31 Mar 2023 14:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment