Attention is currently required from: osmith, arehbein, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31877 )
Change subject: gm_12_21.h: Add cross-component parameter defaults (NSE timing)
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File include/osmocom/gsm/protocol/gsm_12_21.h:
https://gerrit.osmocom.org/c/libosmocore/+/31877/comment/c9681c15_3731b5c3
PS2, Line 294: enum abis_nm_par_defaults {
it makes no sense to have this as enums, because they are not different types of the same
thing nor need to have different values (as you can see below, values are repeated).
Please use defines here.
BTW, I guess all these default values come from specs (TS 12.21?) because if they
don't come from some spec reference, they have no place here, since it would actually
be some implementation specific value of each app that we chose.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31877
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I51d1fd8b596523ae2ac8fb6a186ce7a702334c27
Gerrit-Change-Number: 31877
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 31 Mar 2023 15:04:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment